178322 2017-10-15 15:08:03 -0700 ASSERTION FAILED: m_truncation != cFullTruncation in InlineTextBox::clampedOffset() 2017-10-17 10:15:16 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 178032 178395 1 dbates dbates bfulgham darin simon.fraser webkit-bug-importer zalan oldest_to_newest 1360599 0 dbates 2017-10-15 15:08:03 -0700 Following <https://trac.webkit.org/changeset/223259> (bug #178032), clicking on the ellipsis in a truncated text run causes ASSERT(m_truncation != cFullTruncation) to fail in InlineTextBox::clampedOffset(). ASSERTION FAILED: m_truncation != cFullTruncation /Users/.../Source/WebCore/rendering/InlineTextBox.cpp(594) : unsigned int WebCore::InlineTextBox::clampedOffset(unsigned int) const 1 0x104404a6d WTFCrash 2 0x10d52e701 WebCore::InlineTextBox::clampedOffset(unsigned int) const 3 0x10d5353d2 WebCore::InlineTextBox::positionForOffset(unsigned int) const 4 0x10eb8b1bb WebCore::RenderText::localCaretRect(WebCore::InlineBox*, unsigned int, WebCore::LayoutUnit*) 5 0x10f306aef WebCore::VisiblePosition::localCaretRect(WebCore::RenderObject*&) const 6 0x10cdf8f04 WebCore::localCaretRectInRendererForCaretPainting(WebCore::VisiblePosition const&, WebCore::RenderBlock*&) 7 0x10d07b06e WebCore::CaretBase::updateCaretRect(WebCore::Document*, WebCore::VisiblePosition const&) 8 0x10d08343b WebCore::FrameSelection::recomputeCaretRect() 9 0x10d07c99f WebCore::FrameSelection::updateAppearance() 10 0x10d07c734 WebCore::FrameSelection::updateAndRevealSelection(WebCore::AXTextStateChangeIntent const&) 11 0x10d07a6e1 WebCore::FrameSelection::setSelection(WebCore::VisibleSelection const&, unsigned int, WebCore::AXTextStateChangeIntent, WebCore::FrameSelection::CursorAlignOnScroll, WebCore::TextGranularity) 12 0x10d07b53c WebCore::FrameSelection::setSelectionByMouseIfDifferent(WebCore::VisibleSelection const&, WebCore::TextGranularity, WebCore::FrameSelection::EndPointsAdjustmentMode) 13 0x10ce70940 WebCore::EventHandler::updateSelectionForMouseDownDispatchingSelectStart(WebCore::Node*, WebCore::VisibleSelection const&, WebCore::TextGranularity) 14 0x10ce71c4f WebCore::EventHandler::handleMousePressEventSingleClick(WebCore::MouseEventWithHitTestResults const&) 15 0x10ce723b2 WebCore::EventHandler::handleMousePressEvent(WebCore::MouseEventWithHitTestResults const&) 16 0x10ce776ce WebCore::EventHandler::handleMousePressEvent(WebCore::PlatformMouseEvent const&) 17 0x10ce890d5 WebCore::EventHandler::mouseDown(NSEvent*, NSEvent*) 18 0x102493349 -[WebHTMLView mouseDown:] 19 0x101ace500 -[EventSendingController mouseDown:withModifiers:] 20 0x7fffbabbe0cc __invoking___ 21 0x7fffbabbdf51 -[NSInvocation invoke] 22 0x10e6e2d65 JSC::Bindings::ObjcInstance::invokeObjcMethod(JSC::ExecState*, JSC::Bindings::ObjcMethod*) 23 0x10e6e24aa JSC::Bindings::ObjcInstance::invokeMethod(JSC::ExecState*, JSC::RuntimeMethod*) 24 0x10ec82786 JSC::callRuntimeMethod(JSC::ExecState*) 25 0x103d5f6ea JSC::LLInt::handleHostCall(JSC::ExecState*, JSC::Instruction*, JSC::JSValue, JSC::CodeSpecializationKind) 26 0x103d5aa1d JSC::LLInt::setUpCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind, JSC::JSValue, JSC::LLIntCallLinkInfo*) 27 0x103d59ce4 JSC::LLInt::genericCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind) 28 0x103d59bd3 llint_slow_path_call 29 0x102fd6a7f llint_entry 30 0x102fd6a91 llint_entry 31 0x102fcee57 vmEntryToJavaScript 1360602 1 323851 dbates 2017-10-15 15:30:20 -0700 Created attachment 323851 Patch and layout test 1361283 2 323851 dbates 2017-10-17 10:14:00 -0700 Comment on attachment 323851 Patch and layout test Clearing flags on attachment: 323851 Committed r223553: <https://trac.webkit.org/changeset/223553> 1361284 3 dbates 2017-10-17 10:14:02 -0700 All reviewed patches have been landed. Closing bug. 1361285 4 webkit-bug-importer 2017-10-17 10:15:05 -0700 <rdar://problem/35031674> 323851 2017-10-15 15:30:20 -0700 2017-10-17 10:14:00 -0700 Patch and layout test Bug178322.patch text/plain 4266 dbates SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMzMzMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTEwLTE1ICBEYW5pZWwg QmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiBt X3RydW5jYXRpb24gIT0gY0Z1bGxUcnVuY2F0aW9uIGluIElubGluZVRleHRCb3g6OmNsYW1wZWRP ZmZzZXQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc4MzIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SXQgaXMgYWNjZXB0YWJsZSBmb3IgSW5saW5lVGV4dEJveDo6Y2xhbXBlZE9mZnNldCgpIHRvIGJl IGNhbGxlZCBmb3IgYSBmdWxseSB0cnVuY2F0ZWQgYm94LAorICAgICAgICBzYXkgYSBwZXJzb24g Y2xpY2tzIG9uIHRoZSBlbGxpcHNpcyBpbiBhIHRydW5jYXRlZCB0ZXh0IHJ1bi4gUmVzdG9yZSB0 aGUgYmVoYXZpb3IgcHJpb3IgdG8KKyAgICAgICAgcjIyMzI1OSBhbmQgcmV0dXJuIHRoZSBjbGFt cGVkIG9mZnNldC4KKworICAgICAgICBUZXN0OiBmYXN0L3RleHQvY2xpY2stZWxsaXBzaXMtYXNz ZXJ0aW9uLWZhaWx1cmUuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL0lubGluZVRleHRCb3gu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5saW5lVGV4dEJveDo6Y2xhbXBlZE9mZnNldCBjb25z dCk6CisKIDIwMTctMTAtMTUgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAg ICAgICBET01Ub2tlbkxpc3Qgc2hvdWxkbid0IGFkZCBlbXB0eSBhdHRyaWJ1dGVzCkluZGV4OiBT b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0lubGluZVRleHRCb3guY3BwCShyZXZpc2lvbiAyMjMy NzkpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSW5saW5lVGV4dEJveC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTU4OSw4ICs1ODksOSBAQCB2b2lkIElubGluZVRleHRCb3g6OnBhaW50KFBh aW50SW5mbyYgcGFpCiAKIHVuc2lnbmVkIElubGluZVRleHRCb3g6OmNsYW1wZWRPZmZzZXQodW5z aWduZWQgeCkgY29uc3QKIHsKLSAgICBBU1NFUlQobV90cnVuY2F0aW9uICE9IGNGdWxsVHJ1bmNh dGlvbik7CiAgICAgdW5zaWduZWQgb2Zmc2V0ID0gc3RkOjptYXgoc3RkOjptaW4oeCwgbV9zdGFy dCArIG1fbGVuKSwgbV9zdGFydCkgLSBtX3N0YXJ0OworICAgIGlmIChtX3RydW5jYXRpb24gPT0g Y0Z1bGxUcnVuY2F0aW9uKQorICAgICAgICByZXR1cm4gb2Zmc2V0OwogICAgIGlmIChtX3RydW5j YXRpb24gIT0gY05vVHJ1bmNhdGlvbikKICAgICAgICAgb2Zmc2V0ID0gc3RkOjptaW48dW5zaWdu ZWQ+KG9mZnNldCwgbV90cnVuY2F0aW9uKTsKICAgICBlbHNlIGlmIChvZmZzZXQgPT0gbV9sZW4p IHsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMzI3OSkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwko d29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEwLTE1ICBEYW5pZWwgQmF0ZXMg IDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlRJT04gRkFJTEVEOiBtX3RydW5j YXRpb24gIT0gY0Z1bGxUcnVuY2F0aW9uIGluIElubGluZVRleHRCb3g6OmNsYW1wZWRPZmZzZXQo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MzIy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEg dGVzdCB0byBlbnN1cmUgdGhhdCBjbGlja2luZyBvbiB0aGUgZWxsaXBzaXMgaW4gYSB0cnVuY2F0 ZWQgdGV4dCBydW4gZG9lcyBub3QKKyAgICAgICAgY2F1c2UgYW4gYXNzZXJ0aW9uIGZhaWx1cmUg aW4gYSBkZWJ1ZyBidWlsZC4KKworICAgICAgICAqIGZhc3QvdGV4dC9jbGljay1lbGxpcHNpcy1h c3NlcnRpb24tZmFpbHVyZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvdGV4 dC9jbGljay1lbGxpcHNpcy1hc3NlcnRpb24tZmFpbHVyZS5odG1sOiBBZGRlZC4KKwogMjAxNy0x MC0xMyAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICAi dGV4dC9odG1sIiBkYXRhIGlzIG5vdCBleHBvc2VkIHdoZW4gZHJhZ2dpbmcgYW5kIGRyb3BwaW5n IGFjcm9zcyBvcmlnaW5zCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L3RleHQvY2xpY2stZWxsaXBz aXMtYXNzZXJ0aW9uLWZhaWx1cmUtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2Zhc3QvdGV4dC9jbGljay1lbGxpcHNpcy1hc3NlcnRpb24tZmFpbHVyZS1leHBlY3RlZC50 eHQJKG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2NsaWNrLWVsbGlwc2lz LWFzc2VydGlvbi1mYWlsdXJlLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsx LDQgQEAKK1Rlc3RzIHRoYXQgY29tcHV0aW5nIHRoZSBjYXJldCByZWN0YW5nbGUgd2l0aCByZXNw ZWN0IHRvIGEgZnVsbHkgdHJ1bmNhdGVkIGlubGluZSB0ZXh0IGJveCBkb2VzIG5vdCBjYXVzZSBh biBhc3NlcnRpb24gZmFpbHVyZSBpbiBhIGRlYnVnIGJ1aWxkLiBUbyBydW4gYnkgaGFuZCwgY2xp Y2sgdGhlICcuLi4nIChiZWxvdykuIFRoZSB0ZXN0IFBBU1NFRCBpZiB3ZSBkbyBub3QgY3Jhc2gu CisKK2FiYworUEFTUyBkaWQgbm90IGNyYXNoLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC90ZXh0 L2NsaWNrLWVsbGlwc2lzLWFzc2VydGlvbi1mYWlsdXJlLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC90ZXh0L2NsaWNrLWVsbGlwc2lzLWFzc2VydGlvbi1mYWlsdXJlLmh0bWwJ KG5vbmV4aXN0ZW50KQorKysgTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2NsaWNrLWVsbGlwc2lzLWFz c2VydGlvbi1mYWlsdXJlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyOSBAQAorPCFE T0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNl cy91aS1oZWxwZXIuanMiPjwvc2NyaXB0PgorPHN0eWxlPgorI2VsbGlwc2l6ZWRUZXh0IHsKKyAg ICBmb250LXNpemU6IDMwMCU7CisgICAgZGlzcGxheTogaW5saW5lLWJsb2NrOworICAgIHRleHQt b3ZlcmZsb3c6IGVsbGlwc2lzOworICAgIG92ZXJmbG93OiBoaWRkZW47CisgICAgd2hpdGUtc3Bh Y2U6IG5vd3JhcDsKKyAgICB3aWR0aDogNTBweDsKK30KKzwvc3R5bGU+Cis8L2hlYWQ+Cis8Ym9k eT4KKzxwPlRlc3RzIHRoYXQgY29tcHV0aW5nIHRoZSBjYXJldCByZWN0YW5nbGUgd2l0aCByZXNw ZWN0IHRvIGEgZnVsbHkgdHJ1bmNhdGVkIGlubGluZSB0ZXh0IGJveCBkb2VzIG5vdCBjYXVzZSBh biBhc3NlcnRpb24gZmFpbHVyZSBpbiBhIGRlYnVnIGJ1aWxkLiBUbyBydW4gYnkgaGFuZCwgY2xp Y2sgdGhlICcuLi4nIChiZWxvdykuIFRoZSB0ZXN0IFBBU1NFRCBpZiB3ZSBkbyBub3QgY3Jhc2gu PC9wPgorPGRpdiBpZD0iZWxsaXBzaXplZFRleHQiPmFiYzwvZGl2PgorPHByZSBpZD0icmVzdWx0 Ij5QQVNTIGRpZCBub3QgY3Jhc2guPC9wcmU+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy50ZXN0UnVu bmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisKKyAgICB2YXIgZWxsaXBzaXpl ZFRleHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiZWxsaXBzaXplZFRleHQiKTsKKyAgICBV SUhlbHBlci5hY3RpdmF0ZUF0KGVsbGlwc2l6ZWRUZXh0Lm9mZnNldExlZnQsIGVsbGlwc2l6ZWRU ZXh0Lm9mZnNldFRvcCk7Cit9Cis8L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K