178283 2017-10-13 13:37:34 -0700 [WPE] Fontconfig fails build in JHBuild with “error: conflicting types for ‘FcObjectTypeHash’” 2017-10-13 15:04:20 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez cgarcia clopez commit-queue lforschler mcatanzaro webkit-bug-importer zan oldest_to_newest 1360201 0 aperez 2017-10-13 13:37:34 -0700 Full error: In file included from ../../../Source/fontconfig-2.12.4/src/fcobjs.c:33:0: fcobjshash.gperf:28:1: error: conflicting types for ‘FcObjectTypeHash’ "aspect",FC_ASPECT_OBJECT ^~~~~~~~~~~~~~~~ ../../../Source/fontconfig-2.12.4/src/fcobjs.c:28:1: note: previous declaration of ‘FcObjectTypeHash’ was here FcObjectTypeHash (register const char *str, register FC_GPERF_SIZE_T len); ^~~~~~~~~~~~~~~~ In file included from ../../../Source/fontconfig-2.12.4/src/fcobjs.c:33:0: fcobjshash.gperf:172:1: error: conflicting types for ‘FcObjectTypeLookup’ ../../../Source/fontconfig-2.12.4/src/fcobjs.c:31:1: note: previous declaration of ‘FcObjectTypeLookup’ was here FcObjectTypeLookup (register const char *str, register FC_GPERF_SIZE_T len); ^~~~~~~~~~~~~~~~~~ 1360202 1 aperez 2017-10-13 13:38:05 -0700 Interestingly enough, the JHBuild for the GTK+ port uses exactly the same version of Fontconfig, but there it builds. 1360205 2 323738 aperez 2017-10-13 13:45:21 -0700 Created attachment 323738 Patch 1360212 3 zan 2017-10-13 13:54:19 -0700 Could this be a ccache issue? What's the target architecture? Is it an issue with how FC_GPERF_SIZE_T is deduced? 1360226 4 aperez 2017-10-13 14:15:48 -0700 (In reply to Zan Dobersek from comment #3) > Could this be a ccache issue? > > What's the target architecture? Is it an issue with how FC_GPERF_SIZE_T is > deduced? The target architecture is x86-64 (my work laptop). I added the ‘supports-non-srcdir-builds="no"’ because I noticed that the JHBuild module set for the GTK+ port has that, and that made Fontconfig build successfully. 1360228 5 aperez 2017-10-13 14:20:19 -0700 (In reply to Adrian Perez from comment #4) > (In reply to Zan Dobersek from comment #3) > > Could this be a ccache issue? > > > > What's the target architecture? Is it an issue with how FC_GPERF_SIZE_T is > > deduced? > > The target architecture is x86-64 (my work laptop). I added the > ‘supports-non-srcdir-builds="no"’ because I noticed that the JHBuild > module set for the GTK+ port has that, and that made Fontconfig build > successfully. Surprise! It was me who disabled non-srcdir builds for Fontconfig in the GTK+ JHBuild module set back in May: http://trac.webkit.org/changeset/216184 The commit log message still applies: “[...] building the module with srcdir!=builddir prevents "fcobjshash.gperf" being regenerated (which is needed) so this is disabled for the Fontconfig module.” TL;DR: The Fontconfig code includes a pregenerated “fcobjhash.gperf” which is out of date and the build rules for it don't work with srcdir!=builddir. 1360248 6 323738 commit-queue 2017-10-13 15:03:46 -0700 Comment on attachment 323738 Patch Clearing flags on attachment: 323738 Committed r223301: <https://trac.webkit.org/changeset/223301> 1360249 7 commit-queue 2017-10-13 15:03:47 -0700 All reviewed patches have been landed. Closing bug. 1360250 8 webkit-bug-importer 2017-10-13 15:04:20 -0700 <rdar://problem/34986650> 323738 2017-10-13 13:45:21 -0700 2017-10-13 15:03:46 -0700 Patch bug-178283-20171013234519.patch text/plain 1446 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMjk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGU4MTBhYjhkM2ZmMzUzNDhkMmE0NTZmYzBmMzRhNDBj YzIyNTkwZC4uYzMzNmVhNzI3YjczOTY2NWZhYTMyMTRhMjM4ZGNlZjEyODEwYjk0MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE3LTEwLTEzICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5j b20+CisKKyAgICAgICAgW1dQRV0gRm9udGNvbmZpZyBmYWlscyBidWlsZCBpbiBKSEJ1aWxkIHdp dGgg4oCcZXJyb3I6IGNvbmZsaWN0aW5nIHR5cGVzIGZvciDigJhGY09iamVjdFR5cGVIYXNo4oCZ 4oCdCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzgy ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdw ZS9qaGJ1aWxkLm1vZHVsZXM6IEZsYWcgRm9udGNvbmZpZyB0byBiZSBidWlsdCBpbnNpZGUgdGhl IHNvdXJjZSBkaXJlY3RvcnksIG90aGVyd2lzZQorICAgICAgICBjb21waWxhdGlvbiBmYWlscy4g V2hpbGUgYXQgaXQsIHBhc3MgIi0tZGlzYWJsZS1kb2NzIiB0byBjdXQgYSBiaXQgb24gYnVpbGQg dGltZS4KKwogMjAxNy0xMC0xMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAK ICAgICAgICAgSW1wbGVtZW50IGxpc3Rpbmcgb3JpZ2lucyBmb3Igd2hpY2ggQ2FjaGVTdG9yYWdl IGlzIHN0b3JpbmcgZGF0YQpkaWZmIC0tZ2l0IGEvVG9vbHMvd3BlL2poYnVpbGQubW9kdWxlcyBi L1Rvb2xzL3dwZS9qaGJ1aWxkLm1vZHVsZXMKaW5kZXggMWNkM2Q1NWJmNGViOWUxYmVmZmU4Yzdj YjM1ODU2NjcwZDlkZmMwYS4uYTEyMmViN2E5NGM3ODI5YWIwZjAyY2NkNjZlZjE5MWNmMzZhZTNj YiAxMDA2NDQKLS0tIGEvVG9vbHMvd3BlL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy93cGUv amhidWlsZC5tb2R1bGVzCkBAIC0xMDcsNyArMTA3LDkgQEAKICAgICAgICAgICAgIGhhc2g9InNo YTI1NjphM2M2MDNlZDg0YzNjMjQ5NWY5YzkzMzFmZTZiYmEzYmIwZWU2NWUwNmVjMzMxZTBhMGZi NTIxNTgyOTFiNDBiIi8+CiAgIDwvYXV0b3Rvb2xzPgogCi0gIDxhdXRvdG9vbHMgaWQ9ImZvbnRj b25maWciIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSI+CisgIDxhdXRvdG9vbHMgaWQ9ImZvbnRjb25m aWciIGF1dG9nZW4tc2g9ImNvbmZpZ3VyZSIKKyAgICAgICAgICAgICBhdXRvZ2VuYXJncz0iLS1k aXNhYmxlLWRvY3MiCisgICAgICAgICAgICAgc3VwcG9ydHMtbm9uLXNyY2Rpci1idWlsZHM9Im5v Ij4KICAgICA8ZGVwZW5kZW5jaWVzPgogICAgICAgPGRlcCBwYWNrYWdlPSJmcmVldHlwZTYiLz4K ICAgICA8L2RlcGVuZGVuY2llcz4K