178259 2017-10-13 05:31:24 -0700 Replace some ScrollingTreeNode::nodeType() calls with is*Node() 2017-10-16 00:05:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 fred.wang fred.wang buildbot cmarcelo darin jamesr luiz simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1359981 0 fred.wang 2017-10-13 05:31:24 -0700 Replace some ScrollingTreeNode::nodeType() calls with is*Node() 1359982 1 323661 fred.wang 2017-10-13 05:32:33 -0700 Created attachment 323661 Patch 1359983 2 fred.wang 2017-10-13 05:34:54 -0700 Note: I'm not sure yet, but this might be useful for bug 173833 if we introduce some new kind of FrameScrollingNode to handle non-main frames. 1360685 3 fred.wang 2017-10-16 00:04:55 -0700 Committed r223337: <https://trac.webkit.org/changeset/223337> 1360686 4 webkit-bug-importer 2017-10-16 00:05:47 -0700 <rdar://problem/35002387> 323661 2017-10-13 05:32:33 -0700 2017-10-15 18:23:27 -0700 Patch bug-178259-20171013143232.patch text/plain 5321 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMjQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmNhYzg4YTIyOTkyMmIz ZDgzNzVlODUyZWY4YTQ0MGY3ZTIwMDBhNC4uMGM4NzNlYzFhYmJmZjE5MmI2ZjJiN2QwMjJjZTNm NDUwNTJjNDZmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTEwLTEzICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBSZXBsYWNlIHNvbWUgU2Ny b2xsaW5nVHJlZU5vZGU6Om5vZGVUeXBlKCkgY2FsbHMgd2l0aCBpcypOb2RlKCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODI1OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYmVo YXZpb3IgdW5jaGFuZ2VkLgorCisgICAgICAgICogcGFnZS9zY3JvbGxpbmcvQXN5bmNTY3JvbGxp bmdDb29yZGluYXRvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBc3luY1Njcm9sbGluZ0Nvb3Jk aW5hdG9yOjpmcmFtZVZpZXdGb3JTY3JvbGxpbmdOb2RlIGNvbnN0KToKKyAgICAgICAgKiBwYWdl L3Njcm9sbGluZy9TY3JvbGxpbmdTdGF0ZU5vZGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9s bGluZ1N0YXRlTm9kZTo6aXNTY3JvbGxpbmdOb2RlIGNvbnN0KToKKyAgICAgICAgKiBwYWdlL3Nj cm9sbGluZy9TY3JvbGxpbmdUcmVlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGluZ1Ry ZWU6OnVwZGF0ZVRyZWVGcm9tU3RhdGVOb2RlKToKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdUcmVlTm9kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JvbGxpbmdUcmVlTm9k ZTo6ZW5jbG9zaW5nRnJhbWVOb2RlIGNvbnN0KToKKyAgICAgICAgKiBwYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdUcmVlTm9kZS5oOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsaW5nVHJlZU5vZGU6 OmlzU2Nyb2xsaW5nTm9kZSBjb25zdCk6CisKIDIwMTctMTAtMTIgIEZyZWRlcmljIFdhbmcgIDxm d2FuZ0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFVzZSBsZXNzIHNwZWNpZmljIGNhc3QgaW4gU2Ny b2xsaW5nVHJlZTo6c2Nyb2xsUG9zaXRpb25DaGFuZ2VkVmlhRGVsZWdhdGVkU2Nyb2xsaW5nCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nv b3JkaW5hdG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xs aW5nQ29vcmRpbmF0b3IuY3BwCmluZGV4IDQ1YzljN2U1YzVhYzQ1YmE0NGJkNWRhNzUzODZhYmRi NDQzY2I3MzMuLjQ3NzMzZTdmZThmYzRlY2UyZmYzYTkwMTkxN2I5ZGZjY2VhYWViNDEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRp bmF0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xs aW5nQ29vcmRpbmF0b3IuY3BwCkBAIC0zMDcsNyArMzA3LDcgQEAgRnJhbWVWaWV3KiBBc3luY1Nj cm9sbGluZ0Nvb3JkaW5hdG9yOjpmcmFtZVZpZXdGb3JTY3JvbGxpbmdOb2RlKFNjcm9sbGluZ05v ZGVJRAogCiAgICAgLy8gRmluZCB0aGUgZW5jbG9zaW5nIGZyYW1lIHNjcm9sbGluZyBub2RlLgog ICAgIFNjcm9sbGluZ1N0YXRlTm9kZSogcGFyZW50Tm9kZSA9IHN0YXRlTm9kZTsKLSAgICB3aGls ZSAocGFyZW50Tm9kZSAmJiBwYXJlbnROb2RlLT5ub2RlVHlwZSgpICE9IEZyYW1lU2Nyb2xsaW5n Tm9kZSkKKyAgICB3aGlsZSAocGFyZW50Tm9kZSAmJiAhcGFyZW50Tm9kZS0+aXNGcmFtZVNjcm9s bGluZ05vZGUoKSkKICAgICAgICAgcGFyZW50Tm9kZSA9IHBhcmVudE5vZGUtPnBhcmVudCgpOwog ICAgIAogICAgIGlmICghcGFyZW50Tm9kZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1N0YXRlTm9kZS5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9z Y3JvbGxpbmcvU2Nyb2xsaW5nU3RhdGVOb2RlLmgKaW5kZXggNWQ3MTJkYmVkZTQxMDMwOWZjY2Nh ODVjY2E1YjY2MDdlYzNhOTM4MC4uNTgxYTFhZTExMjcwMzZlZTczZjFhY2YzYWU1ZjNlMjdjNzY4 YzhjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n U3RhdGVOb2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5n U3RhdGVOb2RlLmgKQEAgLTE5Niw3ICsxOTYsNyBAQCBwdWJsaWM6CiAKICAgICBib29sIGlzRml4 ZWROb2RlKCkgY29uc3QgeyByZXR1cm4gbV9ub2RlVHlwZSA9PSBGaXhlZE5vZGU7IH0KICAgICBi b29sIGlzU3RpY2t5Tm9kZSgpIGNvbnN0IHsgcmV0dXJuIG1fbm9kZVR5cGUgPT0gU3RpY2t5Tm9k ZTsgfQotICAgIGJvb2wgaXNTY3JvbGxpbmdOb2RlKCkgY29uc3QgeyByZXR1cm4gbV9ub2RlVHlw ZSA9PSBGcmFtZVNjcm9sbGluZ05vZGUgfHwgbV9ub2RlVHlwZSA9PSBPdmVyZmxvd1Njcm9sbGlu Z05vZGU7IH0KKyAgICBib29sIGlzU2Nyb2xsaW5nTm9kZSgpIGNvbnN0IHsgcmV0dXJuIGlzRnJh bWVTY3JvbGxpbmdOb2RlKCkgfHwgaXNPdmVyZmxvd1Njcm9sbGluZ05vZGUoKTsgfQogICAgIGJv b2wgaXNGcmFtZVNjcm9sbGluZ05vZGUoKSBjb25zdCB7IHJldHVybiBtX25vZGVUeXBlID09IEZy YW1lU2Nyb2xsaW5nTm9kZTsgfQogICAgIGJvb2wgaXNPdmVyZmxvd1Njcm9sbGluZ05vZGUoKSBj b25zdCB7IHJldHVybiBtX25vZGVUeXBlID09IE92ZXJmbG93U2Nyb2xsaW5nTm9kZTsgfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuY3BwCmluZGV4 IDZlNjhhMDA3MmJiMjU1ZmY5YjgyYzc4ZTAzNjVhNGE5ODFhYThlZWEuLjI1NWZmYjkzZDU5MDgx MmFiNzk1NDc2NmJjZWVlOWFiZWZlYmZkZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv c2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWUuY3BwCkBAIC0xNjcsNyArMTY3LDcgQEAgdm9pZCBTY3Jv bGxpbmdUcmVlOjp1cGRhdGVUcmVlRnJvbVN0YXRlTm9kZShjb25zdCBTY3JvbGxpbmdTdGF0ZU5v ZGUqIHN0YXRlTm9kZSwKICAgICAgICAgbm9kZSA9IGNyZWF0ZVNjcm9sbGluZ1RyZWVOb2RlKHN0 YXRlTm9kZS0+bm9kZVR5cGUoKSwgbm9kZUlEKTsKICAgICAgICAgaWYgKCFwYXJlbnROb2RlSUQp IHsKICAgICAgICAgICAgIC8vIFRoaXMgaXMgdGhlIHJvb3Qgbm9kZS4gQ2xlYXIgdGhlIG5vZGUg bWFwLgotICAgICAgICAgICAgQVNTRVJUKHN0YXRlTm9kZS0+bm9kZVR5cGUoKSA9PSBGcmFtZVNj cm9sbGluZ05vZGUpOworICAgICAgICAgICAgQVNTRVJUKHN0YXRlTm9kZS0+aXNGcmFtZVNjcm9s bGluZ05vZGUoKSk7CiAgICAgICAgICAgICBtX3Jvb3ROb2RlID0gbm9kZTsKICAgICAgICAgICAg IG1fbm9kZU1hcC5jbGVhcigpOwogICAgICAgICB9IApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZU5vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZU5vZGUuY3BwCmluZGV4IGU1Y2Q1YWU0MWVmNzNm N2QzM2VkZjVlMGIzNDliMjdmYWQ1ZWVkMDEuLmNlNzgzNWEwMWI5YjE5ZDFkOWEyODA5ZjMxZGY4 ZDNkNmY0NDUzZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Nj cm9sbGluZ1RyZWVOb2RlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9T Y3JvbGxpbmdUcmVlTm9kZS5jcHAKQEAgLTgyLDcgKzgyLDcgQEAgdm9pZCBTY3JvbGxpbmdUcmVl Tm9kZTo6ZHVtcFByb3BlcnRpZXMoVGV4dFN0cmVhbSYgdHMsIFNjcm9sbGluZ1N0YXRlVHJlZUFz VGV4dEIKIFNjcm9sbGluZ1RyZWVGcmFtZVNjcm9sbGluZ05vZGUqIFNjcm9sbGluZ1RyZWVOb2Rl OjplbmNsb3NpbmdGcmFtZU5vZGUoKSBjb25zdAogewogICAgIFNjcm9sbGluZ1RyZWVOb2RlKiBu b2RlID0gcGFyZW50KCk7Ci0gICAgd2hpbGUgKG5vZGUgJiYgbm9kZS0+bm9kZVR5cGUoKSAhPSBG cmFtZVNjcm9sbGluZ05vZGUpCisgICAgd2hpbGUgKG5vZGUgJiYgIW5vZGUtPmlzRnJhbWVTY3Jv bGxpbmdOb2RlKCkpCiAgICAgICAgIG5vZGUgPSBub2RlLT5wYXJlbnQoKTsKIAogICAgIHJldHVy biBkb3duY2FzdDxTY3JvbGxpbmdUcmVlRnJhbWVTY3JvbGxpbmdOb2RlPihub2RlKTsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWVOb2RlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9TY3JvbGxpbmdUcmVlTm9kZS5oCmluZGV4 IGQwZmI4OTIzMDAxYWM3OTgwZDkxNWU1YzY2NTMzZjgxNjI4NzZiY2UuLjlmZTVhYjE3MTM1NGJj MjI0MWEwNTkyMmFjMDc5MjIyNjM5ZDM4YWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2Uvc2Nyb2xsaW5nL1Njcm9sbGluZ1RyZWVOb2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9zY3JvbGxpbmcvU2Nyb2xsaW5nVHJlZU5vZGUuaApAQCAtNDksNyArNDksNyBAQCBwdWJsaWM6 CiAgICAgCiAgICAgYm9vbCBpc0ZpeGVkTm9kZSgpIGNvbnN0IHsgcmV0dXJuIG5vZGVUeXBlKCkg PT0gRml4ZWROb2RlOyB9CiAgICAgYm9vbCBpc1N0aWNreU5vZGUoKSBjb25zdCB7IHJldHVybiBu b2RlVHlwZSgpID09IFN0aWNreU5vZGU7IH0KLSAgICBib29sIGlzU2Nyb2xsaW5nTm9kZSgpIGNv bnN0IHsgcmV0dXJuIG5vZGVUeXBlKCkgPT0gRnJhbWVTY3JvbGxpbmdOb2RlIHx8IG5vZGVUeXBl KCkgPT0gT3ZlcmZsb3dTY3JvbGxpbmdOb2RlOyB9CisgICAgYm9vbCBpc1Njcm9sbGluZ05vZGUo KSBjb25zdCB7IHJldHVybiBpc0ZyYW1lU2Nyb2xsaW5nTm9kZSgpIHx8IGlzT3ZlcmZsb3dTY3Jv bGxpbmdOb2RlKCk7IH0KICAgICBib29sIGlzRnJhbWVTY3JvbGxpbmdOb2RlKCkgY29uc3QgeyBy ZXR1cm4gbm9kZVR5cGUoKSA9PSBGcmFtZVNjcm9sbGluZ05vZGU7IH0KICAgICBib29sIGlzT3Zl cmZsb3dTY3JvbGxpbmdOb2RlKCkgY29uc3QgeyByZXR1cm4gbm9kZVR5cGUoKSA9PSBPdmVyZmxv d1Njcm9sbGluZ05vZGU7IH0KIAo=