<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>178223</bug_id>
          
          <creation_ts>2017-10-12 12:09:53 -0700</creation_ts>
          <short_desc>WebGL clamps drawingBufferWidth to 4096 pixels on a 5120 monitor/canvas</short_desc>
          <delta_ts>2017-10-18 10:15:38 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebGL</component>
          <version>Safari 11</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>macOS 10.12</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alec Miller">alecazam123</reporter>
          <assigned_to name="Dean Jackson">dino</assigned_to>
          <cc>buildbot</cc>
    
    <cc>cdumez</cc>
    
    <cc>dino</cc>
    
    <cc>esprehn+autocc</cc>
    
    <cc>graouts</cc>
    
    <cc>graouts</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>jonlee</cc>
    
    <cc>kondapallykalyan</cc>
    
    <cc>michael.herzog</cc>
    
    <cc>ryanhaddad</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1359663</commentid>
    <comment_count>0</comment_count>
      <attachid>323543</attachid>
    <who name="Alec Miller">alecazam123</who>
    <bug_when>2017-10-12 12:09:53 -0700</bug_when>
    <thetext>Created attachment 323543
Example showing clamping of WebGL renderBuffer

Safari currently clamps the WebGL context to 4096 pixels horizontally and vertically.  This is what Chrome/Firefox used to do, but they made the clamp on total pixels (4k x 4k) instead of per side.  It looks like the WebKit implementation is using the old behavior.  This is problematic on both 5K displays including the 5K iMac.

Enclosed is a simple WebGL sample.  Expand the window on a 5K display, and at a canvas size of 4097 pixels, you&apos;ll see a jump in the color and then aliasing bands.  The drawingBufferWidth is clamped to 4096 pixels, and the checkerboard pattern is non-uniformly scaled up to 5120 pixels if you expand the browser fully or go fullscreen.

This is problematic for design tools like ours, where we rely on pixel precision.  Now the experience on a 5K display will be letterboxed bars around the interactive canvas when the UI is hidden.  You can see this in figma.com rendering on 5K monitor with &quot;Show UI&quot; disabled.  

We would prefer to not have to wait for a long update cycle (another OSX release) on WebKit to see this corrected.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361134</commentid>
    <comment_count>1</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2017-10-16 22:42:40 -0700</bug_when>
    <thetext>&lt;rdar://problem/34597567&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361136</commentid>
    <comment_count>2</comment_count>
      <attachid>323996</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2017-10-16 22:45:28 -0700</bug_when>
    <thetext>Created attachment 323996
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361144</commentid>
    <comment_count>3</comment_count>
      <attachid>323996</attachid>
    <who name="Antoine Quint">graouts</who>
    <bug_when>2017-10-16 23:05:44 -0700</bug_when>
    <thetext>Comment on attachment 323996
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323996&amp;action=review

&gt; LayoutTests/fast/canvas/webgl/large-drawing-buffer-resize.html:56
&gt; +}, false);

You can drop this parameter.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361145</commentid>
    <comment_count>4</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2017-10-16 23:22:50 -0700</bug_when>
    <thetext>Committed r223459: &lt;https://trac.webkit.org/changeset/223459&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361266</commentid>
    <comment_count>5</comment_count>
      <attachid>323996</attachid>
    <who name="Jon Lee">jonlee</who>
    <bug_when>2017-10-17 09:38:46 -0700</bug_when>
    <thetext>Comment on attachment 323996
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323996&amp;action=review

&gt; Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:-851
&gt; -    maxSize = std::min(maxSize, sizeUpperLimit);

Why was this limit here in the first place? Should we restrict the size based on the device?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361327</commentid>
    <comment_count>6</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-10-17 11:21:56 -0700</bug_when>
    <thetext>LayoutTest webgl/1.0.2/conformance/canvas/drawingbuffer-static-canvas-test.html is failing after this change:

https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/r223462%20(5490)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&amp;tests=webgl%2F1.0.2%2Fconformance%2Fcanvas%2Fdrawingbuffer-static-canvas-test.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361331</commentid>
    <comment_count>7</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-10-17 11:39:41 -0700</bug_when>
    <thetext>The test for this change is timing out on iOS 11 Release bots, failing on iOS 11 Debug:

Release:
https://build.webkit.org/results/Apple%20iOS%2011%20Simulator%20Release%20WK2%20(Tests)/r223553%20(595)/results.html

Debug:
https://build.webkit.org/builders/Apple%20iOS%2011%20Simulator%20Debug%20WK2%20(Tests)/builds/425
--- /Volumes/Data/slave/ios-simulator-11-debug-tests-wk2/build/layout-test-results/fast/canvas/webgl/large-drawing-buffer-resize-expected.txt
+++ /Volumes/Data/slave/ios-simulator-11-debug-tests-wk2/build/layout-test-results/fast/canvas/webgl/large-drawing-buffer-resize-actual.txt
@@ -1,5 +1,5 @@
-Original drawing buffer: 5000 x 5000
+Original drawing buffer: 4096 x 4096
 
-Resized drawing buffer: 5001 x 5001
+Resized drawing buffer: 4096 x 4096</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361343</commentid>
    <comment_count>8</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-10-17 11:49:17 -0700</bug_when>
    <thetext>Reverted r223459 for reason:

This change introduced LayoutTest failures.

Committed r223563: &lt;https://trac.webkit.org/changeset/223563&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361356</commentid>
    <comment_count>9</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2017-10-17 12:18:02 -0700</bug_when>
    <thetext>Committed r223567: &lt;https://trac.webkit.org/changeset/223567&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361367</commentid>
    <comment_count>10</comment_count>
    <who name="Ryan Haddad">ryanhaddad</who>
    <bug_when>2017-10-17 12:46:36 -0700</bug_when>
    <thetext>(In reply to Dean Jackson from comment #9)
&gt; Committed r223567: &lt;https://trac.webkit.org/changeset/223567&gt;
Thanks for updating the TestExpectations for iOS. Was anything done to address the webgl/1.0.2/conformance/canvas/drawingbuffer-static-canvas-test.html failure on macOS?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361383</commentid>
    <comment_count>11</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2017-10-17 13:17:00 -0700</bug_when>
    <thetext>(In reply to Ryan Haddad from comment #10)
&gt; (In reply to Dean Jackson from comment #9)
&gt; &gt; Committed r223567: &lt;https://trac.webkit.org/changeset/223567&gt;
&gt; Thanks for updating the TestExpectations for iOS. Was anything done to
&gt; address the
&gt; webgl/1.0.2/conformance/canvas/drawingbuffer-static-canvas-test.html failure
&gt; on macOS?

No, I didn&apos;t see that one. I&apos;ll fix it now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361384</commentid>
    <comment_count>12</comment_count>
    <who name="Dean Jackson">dino</who>
    <bug_when>2017-10-17 13:18:45 -0700</bug_when>
    <thetext>(In reply to Jon Lee from comment #5)
&gt; Comment on attachment 323996 [details]
&gt; Patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=323996&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp:-851
&gt; &gt; -    maxSize = std::min(maxSize, sizeUpperLimit);
&gt; 
&gt; Why was this limit here in the first place? Should we restrict the size
&gt; based on the device?

I think this was mostly there because older hardware had problems with large buffers, but we still identify that hardware in another place.

Note that this was only being applied on resize, so it was still possible to create such large buffers. i.e. we were not protecting it properly anyway</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1361759</commentid>
    <comment_count>13</comment_count>
    <who name="Michael Herzog">michael.herzog</who>
    <bug_when>2017-10-18 10:15:38 -0700</bug_when>
    <thetext>*** Bug 162604 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>323543</attachid>
            <date>2017-10-12 12:09:53 -0700</date>
            <delta_ts>2017-10-12 12:09:53 -0700</delta_ts>
            <desc>Example showing clamping of WebGL renderBuffer</desc>
            <filename>checkerboard.html</filename>
            <type>text/html</type>
            <size>2410</size>
            <attacher name="Alec Miller">alecazam123</attacher>
            
              <data encoding="base64">PGJvZHkgc3R5bGU9Im92ZXJmbG93OmhpZGRlbjsiPjwvYm9keT4KPHNjcmlwdD4KKGZ1bmN0aW9u
KCkgewogIGZ1bmN0aW9uIG1haW4oKSB7CiAgICAvLyBBbiBleGFtcGxlIHRoYXQgc2hvd3MgU2Fm
YXJpL1dlYktpdCBjbGFtcGluZyB0byA0MDk2cHggb24gYSA1MTIwcHggZGlzcGxheS4gIEV4cGFu
ZCB0aGUgY2FudmFzIHVudGlsCiAgICAvLyBhbmQgdGhlIGNvbG9yIHNoaWZ0IGFuZCBhbGlhc2Vk
IGJhbmRpbmcgb2Ygbm9uLXVuaWZvcm0gc2NhbGluZyBhcmUgZXZpZGVudCBhdCA0MDk3IHB4IG9y
IGJpZ2dlci4KICAgIC8vIFRoaXMgZG9lcyBub3QgaGFwcGVuIGluIENocm9tZS9GaXJlZm94LCBz
aW5jZSB0aG9zZSBjbGFtcCB0byA0MDk2eDQwOTYgcGl4ZWxzID0gNjRNQi4gIEV2ZW4gd2l0aCB0
aGF0CiAgICAvLyBsaW1pdCwgdGhhdCBpcyBhbiBpbnNpZ25pZmljYW50IGFtb3VudCBvZiBWUkFN
IGZvciBtb2Rlcm4gY2FyZHMgYW5kIHNwYW5uaW5nIGRpc3BsYXlzLgogICAgLy8gVGhlc2UgbGlt
aXRzIG5lZWQgdG8gYWxsIGJlIHJlbW92ZWQgb3IgaW5jcmVhc2VkIHRvIEdMX01BWF9SRU5ERVJC
VUZGRVJfU0laRSBvbiBkZXNrdG9wLgoKICAgIHZhciB3aWR0aCA9IGlubmVyV2lkdGg7CiAgICB2
YXIgaGVpZ2h0ID0gaW5uZXJIZWlnaHQ7CiAgICB2YXIgZG9jID0gZG9jdW1lbnQ7CiAgICB2YXIg
Y2FudmFzID0gZG9jLmNyZWF0ZUVsZW1lbnQoJ2NhbnZhcycpOwogICAgY2FudmFzLnN0eWxlLnBv
c2l0aW9uID0gJ2Fic29sdXRlJzsKICAgIGNhbnZhcy5zdHlsZS5sZWZ0ID0gMDsKICAgIGNhbnZh
cy5zdHlsZS50b3AgPSAwOwogICAgdmFyIGdsID0gY2FudmFzLmdldENvbnRleHQoJ2V4cGVyaW1l
bnRhbC13ZWJnbCcpOwogICAgdmFyIHByb2dyYW0gPSBnbC5jcmVhdGVQcm9ncmFtKCk7CiAgICB2
YXIgYnVmZmVyID0gZ2wuY3JlYXRlQnVmZmVyKCk7CiAgICB2YXIgdmVydGljZXMgPSBuZXcgRmxv
YXQzMkFycmF5KFstMSwgLTEsIDMsIC0xLCAtMSwgM10pOwogICAgdmFyIHRpY2sgPSBmdW5jdGlv
bigpIHsKICAgICAgZ2wuY2FudmFzLndpZHRoID0gTWF0aC5yb3VuZChpbm5lcldpZHRoICogZGV2
aWNlUGl4ZWxSYXRpbyk7CiAgICAgIGdsLmNhbnZhcy5oZWlnaHQgPSBNYXRoLnJvdW5kKGlubmVy
SGVpZ2h0ICogZGV2aWNlUGl4ZWxSYXRpbyk7CiAgICAgIGdsLmNhbnZhcy5zdHlsZS53aWR0aCA9
IGlubmVyV2lkdGggKyAncHgnOwogICAgICBnbC5jYW52YXMuc3R5bGUuaGVpZ2h0ID0gaW5uZXJI
ZWlnaHQgKyAncHgnOwogICAgICBnbC52aWV3cG9ydCgwLCAwLCBnbC5jYW52YXMud2lkdGgsIGds
LmNhbnZhcy5oZWlnaHQpOwogICAgICBnbC51bmlmb3JtMWYoZ2wuZ2V0VW5pZm9ybUxvY2F0aW9u
KHByb2dyYW0sICd0JyksIHBlcmZvcm1hbmNlLm5vdygpIC8gMTAwMCk7CiAgICAgIGdsLmRyYXdB
cnJheXMoZ2wuVFJJQU5HTEVTLCAwLCAzKTsKICAgICAgcmVxdWVzdEFuaW1hdGlvbkZyYW1lKHRp
Y2spOwogICAgfTsKICAgIHZhciBjb21waWxlU2hhZGVyID0gZnVuY3Rpb24oa2luZCwgc291cmNl
KSB7CiAgICAgIHZhciBzaGFkZXIgPSBnbC5jcmVhdGVTaGFkZXIoa2luZCk7CiAgICAgIGdsLnNo
YWRlclNvdXJjZShzaGFkZXIsIHNvdXJjZSk7CiAgICAgIGdsLmNvbXBpbGVTaGFkZXIoc2hhZGVy
KTsKICAgICAgZ2wuYXR0YWNoU2hhZGVyKHByb2dyYW0sIHNoYWRlcik7CiAgICB9OwogICAgY29t
cGlsZVNoYWRlcihnbC5WRVJURVhfU0hBREVSLCAnXG4gICAgYXR0cmlidXRlIHZlYzQgdjtcbiAg
ICB2b2lkIG1haW4oKSB7XG4gICAgICBnbF9Qb3NpdGlvbiA9IHY7XG4gICAgfVxuICAnKTsKCiAg
ICBjb21waWxlU2hhZGVyKGdsLkZSQUdNRU5UX1NIQURFUiwgYFxuICAgIHByZWNpc2lvbiBtZWRp
dW1wIGZsb2F0O1xuCiAgICAgIHZvaWQgbWFpbigpIHsKICAgICAgICB2ZWMyIHYgPSBnbF9GcmFn
Q29vcmQueHk7CiAgICAgICAgdiA9IGZyYWN0KHYqMC41KTsKICAgICAgICBnbF9GcmFnQ29sb3Ig
PSB2ZWM0KHYsMCwxKTsKICAgICAgfVxuICBgKTsKICAgIGdsLmxpbmtQcm9ncmFtKHByb2dyYW0p
OwogICAgZ2wudXNlUHJvZ3JhbShwcm9ncmFtKTsKICAgIGdsLmJpbmRCdWZmZXIoZ2wuQVJSQVlf
QlVGRkVSLCBidWZmZXIpOwogICAgZ2wuYnVmZmVyRGF0YShnbC5BUlJBWV9CVUZGRVIsIHZlcnRp
Y2VzLCBnbC5TVEFUSUNfRFJBVyk7CiAgICBnbC52ZXJ0ZXhBdHRyaWJQb2ludGVyKDAsIDIsIGds
LkZMT0FULCBmYWxzZSwgMCwgMCk7CiAgICBnbC5lbmFibGVWZXJ0ZXhBdHRyaWJBcnJheSgwKTsK
ICAgIGRvYy5ib2R5LmFwcGVuZENoaWxkKGNhbnZhcyk7CiAgICBjYW52YXMud2lkdGggPSB3aWR0
aDsKICAgIGNhbnZhcy5oZWlnaHQgPSBoZWlnaHQ7CiAgICB0aWNrKCk7CiAgfQoKICBtYWluKCk7
Cn0pKCk7Cjwvc2NyaXB0Pg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>323996</attachid>
            <date>2017-10-16 22:45:28 -0700</date>
            <delta_ts>2017-10-16 23:05:44 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-178223-20171017164525.patch</filename>
            <type>text/plain</type>
            <size>5648</size>
            <attacher name="Dean Jackson">dino</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTUyZTZlNjQ2OWRmMzJk
NGFjNDAwN2M5ZDk4NWRjZmM0MWZjYTZiMy4uNzNhYTI0NTZmYTU4ZTczOGQxMmIxODJkNjBhMzdk
OGFlZjBiMWQ1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEwLTE2ICBEZWFu
IEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJHTCBjbGFtcHMgZHJhd2lu
Z0J1ZmZlcldpZHRoIHRvIDQwOTYgcGl4ZWxzIG9uIGEgNTEyMCBtb25pdG9yL2NhbnZhcworICAg
ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MjIzCisgICAg
ICAgIDxyZGFyOi8vcHJvYmxlbS8zNDU5NzU2Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP
RFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhlIGxpbWl0IG9mIDRrIG9uIHRoZSB3aWR0
aC9oZWlnaHQgb2YgdGhlIHJlbmRlcmJ1ZmZlci4KKworICAgICAgICBUZXN0OiBmYXN0L2NhbnZh
cy93ZWJnbC9sYXJnZS1kcmF3aW5nLWJ1ZmZlci1yZXNpemUuaHRtbAorCisgICAgICAgICogaHRt
bC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHA6CisgICAgICAgIChXZWJDb3Jl
OjpXZWJHTFJlbmRlcmluZ0NvbnRleHRCYXNlOjpyZXNoYXBlKToKKwogMjAxNy0xMC0xMiAgQ2hy
aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIEFkZCBzdXBwb3J0
IGZvciBNb3VzZUV2ZW50LmJ1dHRvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwv
Y2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRt
bC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAKaW5kZXggYzFkMDQ0OWI0ZDNm
YzMxOTgwNGFlNWZjNGMyMGY2NWFlOTAxZmFiNC4uZjg1YWQxMjI3N2U2MDI1YTVlZGI1YTcwNTI2
MzY4NjRiNjc1ODYwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvV2Vi
R0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52
YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0QmFzZS5jcHAKQEAgLTg0Niw5ICs4NDYsNiBAQCB2b2lk
IFdlYkdMUmVuZGVyaW5nQ29udGV4dEJhc2U6OnJlc2hhcGUoaW50IHdpZHRoLCBpbnQgaGVpZ2h0
KQogICAgIC8vIFRoaXMgaXMgYW4gYXBwcm94aW1hdGlvbiBiZWNhdXNlIGF0IFdlYkdMUmVuZGVy
aW5nQ29udGV4dCBsZXZlbCB3ZSBkb24ndAogICAgIC8vIGtub3cgaWYgdGhlIHVuZGVybHlpbmcg
RkJPIHVzZXMgdGV4dHVyZXMgb3IgcmVuZGVyYnVmZmVycy4KICAgICBHQzNEaW50IG1heFNpemUg
PSBzdGQ6Om1pbihtX21heFRleHR1cmVTaXplLCBtX21heFJlbmRlcmJ1ZmZlclNpemUpOwotICAg
IC8vIExpbWl0IGRyYXdpbmcgYnVmZmVyIHNpemUgdG8gNGsgdG8gYXZvaWQgbWVtb3J5IGV4aGF1
c3Rpb24uCi0gICAgY29uc3QgaW50IHNpemVVcHBlckxpbWl0ID0gNDA5NjsKLSAgICBtYXhTaXpl
ID0gc3RkOjptaW4obWF4U2l6ZSwgc2l6ZVVwcGVyTGltaXQpOwogICAgIEdDM0RpbnQgbWF4V2lk
dGggPSBzdGQ6Om1pbihtYXhTaXplLCBtX21heFZpZXdwb3J0RGltc1swXSk7CiAgICAgR0MzRGlu
dCBtYXhIZWlnaHQgPSBzdGQ6Om1pbihtYXhTaXplLCBtX21heFZpZXdwb3J0RGltc1sxXSk7CiAg
ICAgd2lkdGggPSBjbGFtcCh3aWR0aCwgMSwgbWF4V2lkdGgpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGE5YmQyMGQxZmY1
Y2E5ODVhOTM5OWZmZjNlZTMzZTlmMTFmNmVkYTkuLjVlNmU3MTUyMDI3MjM0OWI2YmNjMWViZDNk
MGVlYzJmZTZhZTczMmQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9M
YXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNy0xMC0xNiAgRGVhbiBK
YWNrc29uICA8ZGlub0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViR0wgY2xhbXBzIGRyYXdpbmdC
dWZmZXJXaWR0aCB0byA0MDk2IHBpeGVscyBvbiBhIDUxMjAgbW9uaXRvci9jYW52YXMKKyAgICAg
ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODIyMworICAgICAg
ICA8cmRhcjovL3Byb2JsZW0vMzQ1OTc1Njc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgVGVzdCB0aGF0IHJlc2l6ZXMgYW4gYWxyZWFkeSBsYXJnZSBi
dWZmZXIgdG8gbWFrZSBzdXJlIGl0CisgICAgICAgIGRvZXNuJ3QgZ2V0IGNsYW1wZWQgdG8gNGsu
CisKKyAgICAgICAgKiBmYXN0L2NhbnZhcy93ZWJnbC9sYXJnZS1kcmF3aW5nLWJ1ZmZlci1yZXNp
emUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2NhbnZhcy93ZWJnbC9sYXJn
ZS1kcmF3aW5nLWJ1ZmZlci1yZXNpemUuaHRtbDogQWRkZWQuCisKIDIwMTctMTAtMTIgIFlvdWVu
biBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIExheW91dCBUZXN0IGh0dHAv
dGVzdHMvY2FjaGUtc3RvcmFnZS9jYWNoZS1jbGVhcmluZy5odHRwcy5odG1sIGlzIGZhaWxpbmcK
ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2xhcmdlLWRyYXdpbmct
YnVmZmVyLXJlc2l6ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJn
bC9sYXJnZS1kcmF3aW5nLWJ1ZmZlci1yZXNpemUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUg
MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE2
NzM0N2UxNzVhZjVjMWRlMjQ1YWY2ZmJmYzEzZTU3NzFjOTRlZjgKLS0tIC9kZXYvbnVsbAorKysg
Yi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9sYXJnZS1kcmF3aW5nLWJ1ZmZlci1yZXNp
emUtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNSBAQAorT3JpZ2luYWwgZHJhd2luZyBidWZmZXI6
IDUwMDAgeCA1MDAwCisKK1Jlc2l6ZWQgZHJhd2luZyBidWZmZXI6IDUwMDEgeCA1MDAxCisKKwpk
aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvbGFyZ2UtZHJhd2luZy1i
dWZmZXItcmVzaXplLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9sYXJnZS1k
cmF3aW5nLWJ1ZmZlci1yZXNpemUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43NzliNDA4Yzg3MjljYzczYjQz
NDFhMGMzNWQzOTc4NWJhMjllMGJjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFz
dC9jYW52YXMvd2ViZ2wvbGFyZ2UtZHJhd2luZy1idWZmZXItcmVzaXplLmh0bWwKQEAgLTAsMCAr
MSw2MCBAQAorPHNjcmlwdD4KKworaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgIHdpbmRvdy50
ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKword2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQi
LCBmdW5jdGlvbiAoKSB7CisgICAgbGV0IHdpZHRoID0gNTAwMDsKKyAgICBsZXQgaGVpZ2h0ID0g
NTAwMDsKKyAgICBsZXQgY2FudmFzID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigiY2FudmFzIik7
CisgICAgY2FudmFzLndpZHRoID0gd2lkdGg7CisgICAgY2FudmFzLmhlaWdodCA9IGhlaWdodDsK
KyAgICBjYW52YXMuc3R5bGUud2lkdGggPSB3aWR0aCArICdweCc7CisgICAgY2FudmFzLnN0eWxl
LmhlaWdodCA9IGhlaWdodCArICdweCc7CisgICAgbGV0IGdsID0gY2FudmFzLmdldENvbnRleHQo
IndlYmdsIik7CisgICAgbGV0IHByb2dyYW0gPSBnbC5jcmVhdGVQcm9ncmFtKCk7CisgICAgbGV0
IGJ1ZmZlciA9IGdsLmNyZWF0ZUJ1ZmZlcigpOworICAgIGxldCB2ZXJ0aWNlcyA9IG5ldyBGbG9h
dDMyQXJyYXkoWy0xLCAtMSwgMSwgLTEsIC0xLCAxLCAxLCAtMSwgMSwgMSwgLTEsIDFdKTsKKyAg
ICBsZXQgZHJhdyA9IGZ1bmN0aW9uKCkgeworICAgICAgICBnbC52aWV3cG9ydCgwLCAwLCB3aWR0
aCwgaGVpZ2h0KTsKKyAgICAgICAgZ2wuZHJhd0FycmF5cyhnbC5UUklBTkdMRVMsIDAsIDYpOwor
ICAgIH07CisgICAgbGV0IGNvbXBpbGVTaGFkZXIgPSBmdW5jdGlvbihraW5kLCBzb3VyY2UpIHsK
KyAgICAgICAgbGV0IHNoYWRlciA9IGdsLmNyZWF0ZVNoYWRlcihraW5kKTsKKyAgICAgICAgZ2wu
c2hhZGVyU291cmNlKHNoYWRlciwgc291cmNlKTsKKyAgICAgICAgZ2wuY29tcGlsZVNoYWRlcihz
aGFkZXIpOworICAgICAgICBnbC5hdHRhY2hTaGFkZXIocHJvZ3JhbSwgc2hhZGVyKTsKKyAgICB9
OworICAgIGNvbXBpbGVTaGFkZXIoZ2wuVkVSVEVYX1NIQURFUiwgImF0dHJpYnV0ZSB2ZWM0IHY7
IHZvaWQgbWFpbigpIHsgZ2xfUG9zaXRpb24gPSB2OyB9Iik7CisgICAgY29tcGlsZVNoYWRlcihn
bC5GUkFHTUVOVF9TSEFERVIsIGBwcmVjaXNpb24gbWVkaXVtcCBmbG9hdDsKKyAgICAgIHZvaWQg
bWFpbigpIHsKKyAgICAgICAgdmVjMiB2ID0gZ2xfRnJhZ0Nvb3JkLnh5OworICAgICAgICB2ID0g
ZnJhY3QodiowLjUpOworICAgICAgICBnbF9GcmFnQ29sb3IgPSB2ZWM0KHYsMCwxKTsKKyAgICAg
IH1gKTsKKyAgICBnbC5saW5rUHJvZ3JhbShwcm9ncmFtKTsKKyAgICBnbC51c2VQcm9ncmFtKHBy
b2dyYW0pOworICAgIGdsLmJpbmRCdWZmZXIoZ2wuQVJSQVlfQlVGRkVSLCBidWZmZXIpOworICAg
IGdsLmJ1ZmZlckRhdGEoZ2wuQVJSQVlfQlVGRkVSLCB2ZXJ0aWNlcywgZ2wuU1RBVElDX0RSQVcp
OworICAgIGdsLnZlcnRleEF0dHJpYlBvaW50ZXIoMCwgMiwgZ2wuRkxPQVQsIGZhbHNlLCAwLCAw
KTsKKyAgICBnbC5lbmFibGVWZXJ0ZXhBdHRyaWJBcnJheSgwKTsKKyAgICBkcmF3KCk7CisKKyAg
ICBsZXQgb3JpZ2luYWwgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgib3JpZ2luYWwiKTsKKyAg
ICBvcmlnaW5hbC50ZXh0Q29udGVudCA9IGAke2dsLmRyYXdpbmdCdWZmZXJXaWR0aH0geCAke2ds
LmRyYXdpbmdCdWZmZXJIZWlnaHR9YDsKKworICAgIHdpZHRoID0gNTAwMTsKKyAgICBoZWlnaHQg
PSA1MDAxOworICAgIGNhbnZhcy53aWR0aCA9IHdpZHRoOworICAgIGNhbnZhcy5oZWlnaHQgPSBo
ZWlnaHQ7CisgICAgY2FudmFzLnN0eWxlLndpZHRoID0gd2lkdGggKyAncHgnOworICAgIGNhbnZh
cy5zdHlsZS5oZWlnaHQgPSBoZWlnaHQgKyAncHgnOworICAgIGRyYXcoKTsKKworICAgIGxldCBy
ZXNpemVkID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc2l6ZWQiKTsKKyAgICByZXNpemVk
LnRleHRDb250ZW50ID0gYCR7Z2wuZHJhd2luZ0J1ZmZlcldpZHRofSB4ICR7Z2wuZHJhd2luZ0J1
ZmZlckhlaWdodH1gOworfSwgZmFsc2UpOworPC9zY3JpcHQ+Cis8cD5PcmlnaW5hbCBkcmF3aW5n
IGJ1ZmZlcjogPHNwYW4gaWQ9Im9yaWdpbmFsIj48L3NwYW4+PC9wPgorPHA+UmVzaXplZCBkcmF3
aW5nIGJ1ZmZlcjogPHNwYW4gaWQ9InJlc2l6ZWQiPjwvc3Bhbj48L3A+Cis8Y2FudmFzPjwvY2Fu
dmFzPgo=
</data>
<flag name="review"
          id="343644"
          type_id="1"
          status="+"
          setter="graouts"
    />
          </attachment>
      

    </bug>

</bugzilla>