178209 2017-10-12 05:53:58 -0700 DataTransfer.cpp triggers -Wunused-but-set-variable 2018-12-03 23:33:56 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tpopela tpopela achristensen buildbot cdumez dbates esprehn+autocc kangil.han webkit-bug-importer wenson_hsieh oldest_to_newest 1359587 0 tpopela 2017-10-12 05:53:58 -0700 ../../Source/WebCore/dom/DataTransfer.cpp: In member function ‘WTF::Vector<WTF::Ref<WebCore::File> > WebCore::DataTransfer::filesFromPasteboardAndItemList() const’: ../../Source/WebCore/dom/DataTransfer.cpp:289:10: warning: variable ‘addedFilesFromPasteboard’ set but not used [-Wunused-but-set-variable] bool addedFilesFromPasteboard = false; ^~~~~~~~~~~~~~~~~~~~~~~~ ../../Source/WebCore/dom/DataTransfer.cpp:298:10: warning: variable ‘itemListContainsItems’ set but not used [-Wunused-but-set-variable] bool itemListContainsItems = false; ^~~~~~~~~~~~~~~~~~~~~ 1359588 1 323523 tpopela 2017-10-12 05:56:31 -0700 Created attachment 323523 Patch 1359702 2 323523 achristensen 2017-10-12 13:29:27 -0700 Comment on attachment 323523 Patch We could also solve this with ASSERT_DISABLED or ASSERT_UNUSED 1359908 3 tpopela 2017-10-12 21:14:33 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 323523 [details] > Patch > > We could also solve this with ASSERT_DISABLED or ASSERT_UNUSED I knew there was a better way.. ASSERT_UNUSED is more cleaner solution. 1359938 4 323643 tpopela 2017-10-13 00:07:55 -0700 Created attachment 323643 Patch 1360009 5 323643 wenson_hsieh 2017-10-13 08:30:50 -0700 Comment on attachment 323643 Patch I don't think processedFiles is a great name for this local variable...perhaps make this something like: bool containsItemsAndFiles = itemListContainsItems && addedFilesFromPasteboard; ...and then ASSERT_UNUSED(containsItemsAndFiles, !containsItemsAndFiles);? 1360666 6 tpopela 2017-10-15 21:17:06 -0700 Committed r223334: <https://trac.webkit.org/changeset/223334> 1360668 7 webkit-bug-importer 2017-10-15 21:18:24 -0700 <rdar://problem/35001133> 323523 2017-10-12 05:56:31 -0700 2017-10-13 00:07:50 -0700 Patch bug-178209-20171012145629.patch text/plain 1827 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTczMzc4NzAzZDQ3NzU5 NzUzNTcxMzc2ZWNmYTU4MTRlYzJmYjk4Ni4uYWJiYjdlMTVmZDk4MmUxNmRkNDgxYTYxNGQ3M2Qw NjQwYjkyYjEyNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEwLTEyICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgRGF0YVRyYW5zZmVyLmNw cCB0cmlnZ2VycyAtV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzgyMDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUdXJuIG9mZiB0aGUgd2FybmluZyB3aXRoIHBy YWdtYS4KKworICAgICAgICAqIGRvbS9EYXRhVHJhbnNmZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RGF0YVRyYW5zZmVyOjpmaWxlc0Zyb21QYXN0ZWJvYXJkQW5kSXRlbUxpc3QgY29uc3QpOgor CiAyMDE3LTEwLTEyICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgZml4IGNvbXBpbGF0aW9uIHdhcm5pbmcKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9EYXRhVHJhbnNmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0RhdGFU cmFuc2Zlci5jcHAKaW5kZXggNDU2NzA4NGI4MDU2ZGRkOGE2YzA1MDBjN2Y5MDU2ZmQwZmY2NzQ2 NS4uMTA0NTdmM2M4ZDI5ZWU5MTg5MDgxMzI2NzI0N2NkMjRlMjU5OWZjYyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL0RhdGFUcmFuc2Zlci5jcHAKQEAgLTI4Niw3ICsyODYsOSBAQCBWZWN0b3I8U3RyaW5nPiBE YXRhVHJhbnNmZXI6OnR5cGVzKEFkZEZpbGVzVHlwZSBhZGRGaWxlc1R5cGUpIGNvbnN0CiAKIFZl Y3RvcjxSZWY8RmlsZT4+IERhdGFUcmFuc2Zlcjo6ZmlsZXNGcm9tUGFzdGVib2FyZEFuZEl0ZW1M aXN0KCkgY29uc3QKIHsKKyNwcmFnbWEgR0NDIGRpYWdub3N0aWMgaWdub3JlZCAiLVd1bnVzZWQt YnV0LXNldC12YXJpYWJsZSIKICAgICBib29sIGFkZGVkRmlsZXNGcm9tUGFzdGVib2FyZCA9IGZh bHNlOworI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyBwb3AKICAgICBWZWN0b3I8UmVmPEZpbGU+PiBm aWxlczsKICAgICBpZiAoIWZvckRyYWcoKSB8fCBmb3JGaWxlRHJhZygpKSB7CiAgICAgICAgIFdl YkNvcmVQYXN0ZWJvYXJkRmlsZVJlYWRlciByZWFkZXI7CkBAIC0yOTUsNyArMjk3LDkgQEAgVmVj dG9yPFJlZjxGaWxlPj4gRGF0YVRyYW5zZmVyOjpmaWxlc0Zyb21QYXN0ZWJvYXJkQW5kSXRlbUxp c3QoKSBjb25zdAogICAgICAgICBhZGRlZEZpbGVzRnJvbVBhc3RlYm9hcmQgPSAhZmlsZXMuaXNF bXB0eSgpOwogICAgIH0KIAorI3ByYWdtYSBHQ0MgZGlhZ25vc3RpYyBpZ25vcmVkICItV3VudXNl ZC1idXQtc2V0LXZhcmlhYmxlIgogICAgIGJvb2wgaXRlbUxpc3RDb250YWluc0l0ZW1zID0gZmFs c2U7CisjcHJhZ21hIEdDQyBkaWFnbm9zdGljIHBvcAogICAgIGlmIChtX2l0ZW1MaXN0ICYmIG1f aXRlbUxpc3QtPmhhc0l0ZW1zKCkpIHsKICAgICAgICAgZm9yIChhdXRvJiBpdGVtIDogbV9pdGVt TGlzdC0+aXRlbXMoKSkgewogICAgICAgICAgICAgaWYgKGF1dG8gZmlsZSA9IGl0ZW0tPmZpbGUo KSkK 323643 2017-10-13 00:07:55 -0700 2018-12-03 23:33:56 -0800 Patch bug-178209-20171013090754.patch text/plain 1354 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTczMzc4NzAzZDQ3NzU5 NzUzNTcxMzc2ZWNmYTU4MTRlYzJmYjk4Ni4uZmU5OTYwNmJhYzZiZmMxNmY3NDk2N2I0MGFmMDdl ZDA3YTIzMTA5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEwLTEzICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgRGF0YVRyYW5zZmVyLmNw cCB0cmlnZ2VycyAtV3VudXNlZC1idXQtc2V0LXZhcmlhYmxlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzgyMDkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgdGhlIEFTU0VSVF9VTlVTRUQgdG8gc2ls ZW5jZSBpdC4KKworICAgICAgICAqIGRvbS9EYXRhVHJhbnNmZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RGF0YVRyYW5zZmVyOjpmaWxlc0Zyb21QYXN0ZWJvYXJkQW5kSXRlbUxpc3QgY29uc3Qp OgorCiAyMDE3LTEwLTEyICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgZml4IGNvbXBpbGF0aW9uIHdhcm5pbmcKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2RvbS9EYXRhVHJhbnNmZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0Rh dGFUcmFuc2Zlci5jcHAKaW5kZXggNDU2NzA4NGI4MDU2ZGRkOGE2YzA1MDBjN2Y5MDU2ZmQwZmY2 NzQ2NS4uZjhhM2JhZjU5YjIwMjYwZWQwZjBhYmM5ODZhZTFmMGRmNmNjZTlhMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvZG9tL0RhdGFUcmFuc2Zlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvZG9tL0RhdGFUcmFuc2Zlci5jcHAKQEAgLTMwNCw3ICszMDQsOCBAQCBWZWN0b3I8UmVmPEZp bGU+PiBEYXRhVHJhbnNmZXI6OmZpbGVzRnJvbVBhc3RlYm9hcmRBbmRJdGVtTGlzdCgpIGNvbnN0 CiAgICAgICAgIGl0ZW1MaXN0Q29udGFpbnNJdGVtcyA9IHRydWU7CiAgICAgfQogCi0gICAgQVNT RVJUKCFpdGVtTGlzdENvbnRhaW5zSXRlbXMgfHwgIWFkZGVkRmlsZXNGcm9tUGFzdGVib2FyZCk7 CisgICAgYm9vbCBwcm9jZXNzZWRGaWxlcyA9ICFpdGVtTGlzdENvbnRhaW5zSXRlbXMgfHwgIWFk ZGVkRmlsZXNGcm9tUGFzdGVib2FyZDsKKyAgICBBU1NFUlRfVU5VU0VEKHByb2Nlc3NlZEZpbGVz LCBwcm9jZXNzZWRGaWxlcyk7CiAgICAgcmV0dXJuIGZpbGVzOwogfQogCg==