178170 2017-10-11 08:02:08 -0700 Remove some obsolete layout assertions 2017-10-11 11:34:32 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1359183 0 koivisto 2017-10-11 08:02:08 -0700 We have stronger assertions in place. 1359184 1 323417 koivisto 2017-10-11 08:07:22 -0700 Created attachment 323417 patch 1359220 2 323417 commit-queue 2017-10-11 09:38:10 -0700 Comment on attachment 323417 patch Rejecting attachment 323417 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 323417, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 223179 = c95e2018aa84a0b50651512bf0154704882a5a3d r223188 = 071ccb302ae248db041cd57670b910c4417666c6 r223189 = 6ae6ff940d015ccf34d4071e51a84ba1fadd5399 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/4825056 1359275 3 323417 commit-queue 2017-10-11 11:33:01 -0700 Comment on attachment 323417 patch Clearing flags on attachment: 323417 Committed r223194: <https://trac.webkit.org/changeset/223194> 1359276 4 commit-queue 2017-10-11 11:33:03 -0700 All reviewed patches have been landed. Closing bug. 1359277 5 webkit-bug-importer 2017-10-11 11:34:32 -0700 <rdar://problem/34937746> 323417 2017-10-11 08:07:22 -0700 2017-10-11 11:33:01 -0700 patch layout-assertion-cleanup.patch text/plain 4859 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMzE3OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTExICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgc29tZSBvYnNvbGV0 ZSBsYXlvdXQgYXNzZXJ0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc4MTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2UgaGF2ZSBzdHJvbmcgYXNzZXJ0aW9ucyBhZ2FpbnN0IHJlbmRlciB0cmVl IG11dGF0aW9uIGZ1bmN0aW9ucyBiZWluZyBjYWxsZWQgaW4gbGF5b3V0LiBUaGVzZSBhcmUgdW5u ZWNlc3NhcnkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6Om1vdmVDaGlsZFRvKToK KyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpSZW5kZXJFbGVtZW50Ojp0YWtlQ2hpbGRJbnRlcm5hbCk6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlckVsZW1lbnQuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGlzdEl0ZW06OmxheW91dCk6CisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckxpc3RJdGVtLmg6CisKIDIwMTctMTAtMTEgIFl1c3VrZSBTdXp1a2kg IDx1dGF0YW5lLnRlYUBnbWFpbC5jb20+CiAKICAgICAgICAgW0pTQ10gRHJvcCBJbnN0YW50aWF0 ZSBob29rIGluIEVTNiBtb2R1bGUgbG9hZGVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAJKHJldmlzaW9uIDIyMzE2OCkKKysr IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTI1ODUsOSArMjU4NSw2IEBAIHZvaWQgUmVuZGVyQm94TW9kZWxPYmplY3Q6 Om1hcEFic29sdXRlVG8KIAogdm9pZCBSZW5kZXJCb3hNb2RlbE9iamVjdDo6bW92ZUNoaWxkVG8o UmVuZGVyQm94TW9kZWxPYmplY3QqIHRvQm94TW9kZWxPYmplY3QsIFJlbmRlck9iamVjdCogY2hp bGQsIFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQsIGJvb2wgZnVsbFJlbW92ZUluc2VydCkKIHsK LSNpZiAhQVNTRVJUX0RJU0FCTEVECi0gICAgU2V0Rm9yU2NvcGU8Ym9vbD4gcmVwYXJlbnRpbmdD aGlsZChtX3JlcGFyZW50aW5nQ2hpbGQsIHRydWUpOwotI2VuZGlmCiAgICAgLy8gV2UgYXNzdW1l IHRoYXQgY2FsbGVycyBoYXZlIGNsZWFyZWQgdGhlaXIgcG9zaXRpb25lZCBvYmplY3RzIGxpc3Qg Zm9yIGNoaWxkIG1vdmVzICghZnVsbFJlbW92ZUluc2VydCkgc28gdGhlCiAgICAgLy8gcG9zaXRp b25lZCByZW5kZXJlciBtYXBzIGRvbid0IGJlY29tZSBzdGFsZS4gSXQgd291bGQgYmUgdG9vIHNs b3cgdG8gZG8gdGhlIG1hcCBsb29rdXAgb24gZWFjaCBjYWxsLgogICAgIEFTU0VSVCghZnVsbFJl bW92ZUluc2VydCB8fCAhaXM8UmVuZGVyQmxvY2s+KCp0aGlzKSB8fCAhZG93bmNhc3Q8UmVuZGVy QmxvY2s+KCp0aGlzKS5oYXNQb3NpdGlvbmVkT2JqZWN0cygpKTsKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAJKHJldmlzaW9uIDIyMzE2OCkKKysrIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcAkod29ya2luZyBjb3B5KQpA QCAtODUsOSArODUsNiBAQCBzdHJ1Y3QgU2FtZVNpemVBc1JlbmRlckVsZW1lbnQgOiBwdWJsaWMg CiAgICAgdm9pZCogZmlyc3RDaGlsZDsKICAgICB2b2lkKiBsYXN0Q2hpbGQ7CiAgICAgUmVuZGVy U3R5bGUgc3R5bGU7Ci0jaWYgIUFTU0VSVF9ESVNBQkxFRAotICAgIGJvb2wgcmVwYXJlbnRpbmdD aGlsZDsKLSNlbmRpZgogfTsKIAogc3RhdGljX2Fzc2VydChzaXplb2YoUmVuZGVyRWxlbWVudCkg PT0gc2l6ZW9mKFNhbWVTaXplQXNSZW5kZXJFbGVtZW50KSwgIlJlbmRlckVsZW1lbnQgc2hvdWxk IHN0YXkgc21hbGwiKTsKQEAgLTYzNCwxMSArNjMxLDYgQEAgUmVuZGVyUHRyPFJlbmRlck9iamVj dD4gUmVuZGVyRWxlbWVudDo6dAogCiAgICAgaWYgKEFYT2JqZWN0Q2FjaGUqIGNhY2hlID0gZG9j dW1lbnQoKS5leGlzdGluZ0FYT2JqZWN0Q2FjaGUoKSkKICAgICAgICAgY2FjaGUtPmNoaWxkcmVu Q2hhbmdlZCh0aGlzKTsKLSNpZiAhQVNTRVJUX0RJU0FCTEVECi0gICAgLy8gQ2hlY2sgaWYgdGhl IG1hcmtlciBnZXRzIGRldGFjaGVkIHdoaWxlIGxheWluZyBvdXQgdGhlIGxpc3QgaXRlbS4KLSAg ICBpZiAoaXM8UmVuZGVyTGlzdE1hcmtlcj4ob2xkQ2hpbGQpKQotICAgICAgICBBU1NFUlQobV9y ZXBhcmVudGluZ0NoaWxkIHx8ICFkb3duY2FzdDxSZW5kZXJMaXN0TWFya2VyPihvbGRDaGlsZCku bGlzdEl0ZW0oKS5pbkxheW91dCgpKTsKLSNlbmRpZgogCiAgICAgcmV0dXJuIFJlbmRlclB0cjxS ZW5kZXJPYmplY3Q+KCZvbGRDaGlsZCk7CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyRWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJFbGVtZW50LmgJKHJldmlzaW9uIDIyMzE2OCkKKysrIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJFbGVtZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTM1OCwxMSArMzU4LDYg QEAgcHJpdmF0ZToKICAgICAvLyBTdG9yZSBzdGF0ZSBiZXR3ZWVuIHN0eWxlV2lsbENoYW5nZSBh bmQgc3R5bGVEaWRDaGFuZ2UKICAgICBzdGF0aWMgYm9vbCBzX2FmZmVjdHNQYXJlbnRCbG9jazsK ICAgICBzdGF0aWMgYm9vbCBzX25vTG9uZ2VyQWZmZWN0c1BhcmVudEJsb2NrOwotCi1wcm90ZWN0 ZWQ6Ci0jaWYgIUFTU0VSVF9ESVNBQkxFRAotICAgIGJvb2wgbV9yZXBhcmVudGluZ0NoaWxkIHsg ZmFsc2UgfTsKLSNlbmRpZgogfTsKIAogaW5saW5lIHZvaWQgUmVuZGVyRWxlbWVudDo6c2V0QW5j ZXN0b3JMaW5lQm94RGlydHkoYm9vbCBmKQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxpc3RJdGVtLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyTGlzdEl0ZW0uY3BwCShyZXZpc2lvbiAyMjMxNjgpCisrKyBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGlzdEl0ZW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMzQsOSAr MjM0LDYgQEAgdm9pZCBSZW5kZXJMaXN0SXRlbTo6bGF5b3V0KCkKICAgICBTdGFja1N0YXRzOjpM YXlvdXRDaGVja1BvaW50IGxheW91dENoZWNrUG9pbnQ7CiAgICAgQVNTRVJUKG5lZWRzTGF5b3V0 KCkpOwogCi0jaWYgIUFTU0VSVF9ESVNBQkxFRAotICAgIFNldEZvclNjb3BlPGJvb2w+IGluTGlz dEl0ZW1MYXlvdXQobV9pbkxheW91dCwgdHJ1ZSk7Ci0jZW5kaWYKICAgICBSZW5kZXJCbG9ja0Zs b3c6OmxheW91dCgpOwogfQogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGlzdEl0ZW0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGlzdEl0ZW0uaAkocmV2aXNpb24gMjIzMTY4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckxpc3RJdGVtLmgJKHdvcmtpbmcgY29weSkKQEAgLTU5LDEwICs1OSw2IEBAIHB1Ymxp YzoKICAgICBSZW5kZXJMaXN0TWFya2VyKiBtYXJrZXJSZW5kZXJlcigpIGNvbnN0IHsgcmV0dXJu IG1fbWFya2VyLmdldCgpOyB9CiAgICAgdm9pZCBzZXRNYXJrZXJSZW5kZXJlcihSZW5kZXJMaXN0 TWFya2VyJiBtYXJrZXIpIHsgbV9tYXJrZXIgPSBtYWtlV2Vha1B0cihtYXJrZXIpOyB9CiAKLSNp ZiAhQVNTRVJUX0RJU0FCTEVECi0gICAgYm9vbCBpbkxheW91dCgpIGNvbnN0IHsgcmV0dXJuIG1f aW5MYXlvdXQ7IH0KLSNlbmRpZgotCiBwcml2YXRlOgogICAgIHZvaWQgd2lsbEJlRGVzdHJveWVk KCkgb3ZlcnJpZGU7CiAKQEAgLTkwLDkgKzg2LDYgQEAgcHJpdmF0ZToKICAgICBpbnQgbV9leHBs aWNpdFZhbHVlOwogICAgIFdlYWtQdHI8UmVuZGVyTGlzdE1hcmtlcj4gbV9tYXJrZXI7CiAgICAg bXV0YWJsZSBpbnQgbV92YWx1ZTsKLSNpZiAhQVNTRVJUX0RJU0FCTEVECi0gICAgYm9vbCBtX2lu TGF5b3V0IHsgZmFsc2UgfTsKLSNlbmRpZgogICAgIGJvb2wgbV9oYXNFeHBsaWNpdFZhbHVlIDog MTsKICAgICBtdXRhYmxlIGJvb2wgbV9pc1ZhbHVlVXBUb0RhdGUgOiAxOwogICAgIGJvb2wgbV9u b3RJbkxpc3QgOiAxOwo=