178143 2017-10-10 13:49:12 -0700 Web Inspector: Avoid "100.00ms" vs "100.0ms" jitter in TimelineRuler labels 2017-10-11 01:01:47 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1358882 0 joepeck 2017-10-10 13:49:12 -0700 Avoid "100.00ms" vs "100.0ms" jitter in TimelineRuler labels Sometimes the ms calculated ends up being values like: 100.0 => "100.0ms" 100.0000000000001 => "100.00ms" Account for this tiny jitter by checking against values like 100.0001. 1358885 1 323346 joepeck 2017-10-10 13:50:39 -0700 Created attachment 323346 [PATCH] Proposed Fix 1358898 2 323346 bburg 2017-10-10 14:09:46 -0700 Comment on attachment 323346 [PATCH] Proposed Fix r=me. Can you extract out the slop factor into a variable? 1359086 3 joepeck 2017-10-11 01:00:41 -0700 <https://trac.webkit.org/changeset/223171/webkit> 1359087 4 webkit-bug-importer 2017-10-11 01:01:47 -0700 <rdar://problem/34928802> 323346 2017-10-10 13:50:39 -0700 2017-10-11 01:00:47 -0700 [PATCH] Proposed Fix slop-1.patch text/plain 2100 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDYyMTgzZjViNzVlLi5lMDFkMThlYTE3ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTctMTAtMTAgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBBdm9pZCAiMTAwLjAwbXMiIHZzICIxMDAuMG1zIiBqaXR0ZXIgaW4gVGltZWxpbmVSdWxlciBs YWJlbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 ODE0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGllcy5qczoKKyAgICAgICAgQWxsb3cgYSBzbWFsbCBz bG9wIGZhY3RvciB0aGF0IHdvdWxkbid0IGhhdmUgY2hhbmdlZCB0aGUgZGlzcGxheSB2YWx1ZSdz CisgICAgICAgIHNpZ25pZmljYW50IGZpZ3VyZXMgYW55d2F5cy4gVGhpcyBhZGRyZXNzZXMgY2Fz ZXMgd2hlcmUgMTAwLjAwMDAwMDAwMDAwMDEKKyAgICAgICAgd2VyZSBiZWluZyB0cmVhdGVkIHNs aWdodGx5IGRpZmZlcmVudGx5IGZyb20gMTAwLjAuCisKKzIwMTctMTAtMTAgIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZXR3 b3JrIFRhYiAtIFNldCBjb2x1bW4gaW5pdGlhbCB3aWR0aHMgdG8gdHJ5IGFsbG93IHdhdGVyZmFs bCBjb2x1bW4gdG8gZXhwYW5kIG1vcmUgYnkgZGVmYXVsdAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MTQyCiAgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8zNDkxODIzMz4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0Jhc2UvVXRpbGl0aWVzLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQmFzZS9VdGlsaXRpZXMuanMKaW5kZXggOTI3YWYxYmZjNzIuLjVkZjVhMjMzYTdiIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1V0aWxpdGll cy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1V0aWxp dGllcy5qcwpAQCAtMTA4OSwxOSArMTA4OSwxOSBAQCBPYmplY3QuZGVmaW5lUHJvcGVydHkoTnVt YmVyLCAic2Vjb25kc1RvU3RyaW5nIiwKICAgICAgICAgaWYgKCFtcykKICAgICAgICAgICAgIHJl dHVybiBXSS5VSVN0cmluZygiJS4wZm1zIikuZm9ybWF0KDApOwogCi0gICAgICAgIGlmIChNYXRo LmFicyhtcykgPCAxMCkgeworICAgICAgICBpZiAoTWF0aC5hYnMobXMpIDwgMTAuMDAwMSkgewog ICAgICAgICAgICAgaWYgKGhpZ2hlclJlc29sdXRpb24pCiAgICAgICAgICAgICAgICAgcmV0dXJu IFdJLlVJU3RyaW5nKCIlLjNmbXMiKS5mb3JtYXQobXMpOwogICAgICAgICAgICAgcmV0dXJuIFdJ LlVJU3RyaW5nKCIlLjJmbXMiKS5mb3JtYXQobXMpOwogICAgICAgICB9CiAKLSAgICAgICAgaWYg KE1hdGguYWJzKG1zKSA8IDEwMCkgeworICAgICAgICBpZiAoTWF0aC5hYnMobXMpIDwgMTAwLjAw MDEpIHsKICAgICAgICAgICAgIGlmIChoaWdoZXJSZXNvbHV0aW9uKQogICAgICAgICAgICAgICAg IHJldHVybiBXSS5VSVN0cmluZygiJS4yZm1zIikuZm9ybWF0KG1zKTsKICAgICAgICAgICAgIHJl dHVybiBXSS5VSVN0cmluZygiJS4xZm1zIikuZm9ybWF0KG1zKTsKICAgICAgICAgfQogCi0gICAg ICAgIGlmIChNYXRoLmFicyhtcykgPCAxMDAwKSB7CisgICAgICAgIGlmIChNYXRoLmFicyhtcykg PCAxMDAwLjAwMDEpIHsKICAgICAgICAgICAgIGlmIChoaWdoZXJSZXNvbHV0aW9uKQogICAgICAg ICAgICAgICAgIHJldHVybiBXSS5VSVN0cmluZygiJS4xZm1zIikuZm9ybWF0KG1zKTsKICAgICAg ICAgICAgIHJldHVybiBXSS5VSVN0cmluZygiJS4wZm1zIikuZm9ybWF0KG1zKTsK