178139 2017-10-10 11:51:41 -0700 Layers should be destroyed by RenderLayerModelObject 2017-10-10 13:37:54 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1358824 0 koivisto 2017-10-10 11:51:41 -0700 ...instead of RenderObject. 1358825 1 323328 koivisto 2017-10-10 11:52:55 -0700 Created attachment 323328 patch 1358850 2 323328 simon.fraser 2017-10-10 12:53:09 -0700 Comment on attachment 323328 patch View in context: https://bugs.webkit.org/attachment.cgi?id=323328&action=review > Source/WebCore/rendering/RenderObject.cpp:-1444 > - // FIXME: Would like to do this in RenderBoxModelObject, but the timing is so complicated that this can't easily > - // be moved into RenderLayerModelObject::willBeDestroyed(). > - // FIXME: Is this still true? > - if (hasLayer()) { > - setHasLayer(false); > - downcast<RenderLayerModelObject>(*this).destroyLayer(); > - } > - Should RenderObject have ASSERT(!hasLayer()) somewhere late in its destruction to ensure that we didn't re-assign a layer after RenderLayerModelObject::destroyLayer() ran? 1358861 3 koivisto 2017-10-10 13:09:41 -0700 There isn't really much between willBeDestroyed() and the destructor. 1358869 4 323328 commit-queue 2017-10-10 13:36:51 -0700 Comment on attachment 323328 patch Clearing flags on attachment: 323328 Committed r223139: <http://trac.webkit.org/changeset/223139> 1358870 5 commit-queue 2017-10-10 13:36:53 -0700 All reviewed patches have been landed. Closing bug. 1358873 6 webkit-bug-importer 2017-10-10 13:37:54 -0700 <rdar://problem/34918241> 323328 2017-10-10 11:52:55 -0700 2017-10-10 13:36:51 -0700 patch destroylayer.patch text/plain 3169 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMzEzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTEwLTEwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBMYXllcnMgc2hvdWxkIGJlIGRl c3Ryb3llZCBieSBSZW5kZXJMYXllck1vZGVsT2JqZWN0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzgxMzkKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhbiB1cCBzb21lIEZJWE1Fcy4KKworICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJMYXllck1vZGVsT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckxheWVyTW9kZWxPYmplY3Q6OndpbGxCZURlc3Ryb3llZCk6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJMYXllck1vZGVsT2JqZWN0OjpkZXN0cm95TGF5ZXIpOgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJMYXllck1vZGVsT2JqZWN0Lmg6CisgICAgICAgICogcmVuZGVyaW5n L1JlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OndpbGxC ZURlc3Ryb3llZCk6CisKIDIwMTctMTAtMTAgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBFbnRyaWVzIEFQSSBzaG91bGQgcmVjb2duaXplIHBhdGggc3RhcnRpbmcg d2l0aCAyIHNsYXNoZXMgYXMgdmFsaWQgYWJzb2x1dGUgcGF0aApJbmRleDogU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyTW9kZWxPYmplY3QuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllck1vZGVsT2JqZWN0LmNwcAkocmV2aXNp b24gMjIzMTMyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyTW9kZWxP YmplY3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OSwxOCArNjksMTkgQEAgdm9pZCBSZW5kZXJM YXllck1vZGVsT2JqZWN0Ojp3aWxsQmVEZXN0cgogICAgICAgICAgICAgdmlldygpLmZyYW1lVmll dygpLnJlbW92ZVZpZXdwb3J0Q29uc3RyYWluZWRPYmplY3QodGhpcyk7CiAgICAgfQogCisgICAg aWYgKGhhc0xheWVyKCkpIHsKKyAgICAgICAgc2V0SGFzTGF5ZXIoZmFsc2UpOworICAgICAgICBk ZXN0cm95TGF5ZXIoKTsKKyAgICB9CisKICAgICBSZW5kZXJFbGVtZW50Ojp3aWxsQmVEZXN0cm95 ZWQoKTsKICAgICAKICAgICBjbGVhclJlcGFpbnRMYXlvdXRSZWN0cygpOwotICAgIAotICAgIC8v IE91ciBsYXllciBzaG91bGQgaGF2ZSBiZWVuIGRlc3Ryb3llZCBhbmQgY2xlYXJlZCBieSBub3cK LSAgICBBU1NFUlQoIWhhc0xheWVyKCkpOwotICAgIEFTU0VSVCghbV9sYXllcik7CiB9CiAKIHZv aWQgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdDo6ZGVzdHJveUxheWVyKCkKIHsKLSAgICBBU1NFUlQo IWhhc0xheWVyKCkpOyAvLyBDYWxsZXJzIHNob3VsZCBoYXZlIGFscmVhZHkgY2FsbGVkIHNldEhh c0xheWVyKGZhbHNlKQorICAgIEFTU0VSVCghaGFzTGF5ZXIoKSk7CiAgICAgQVNTRVJUKG1fbGF5 ZXIpOwogICAgIGlmIChtX2xheWVyLT5pc1NlbGZQYWludGluZ0xheWVyKCkpCiAgICAgICAgIGNs ZWFyUmVwYWludExheW91dFJlY3RzKCk7CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyTGF5ZXJNb2RlbE9iamVjdC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJMYXllck1vZGVsT2JqZWN0LmgJKHJldmlzaW9uIDIyMzEzMikKKysrIFNv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllck1vZGVsT2JqZWN0LmgJKHdvcmtpbmcg Y29weSkKQEAgLTQwLDcgKzQwLDYgQEAgY2xhc3MgUmVuZGVyTGF5ZXJNb2RlbE9iamVjdCA6IHB1 YmxpYyBSZQogcHVibGljOgogICAgIHZpcnR1YWwgflJlbmRlckxheWVyTW9kZWxPYmplY3QoKTsK IAotICAgIC8vIENhbGxlZCBieSBSZW5kZXJPYmplY3Q6OndpbGxCZURlc3Ryb3llZCgpIGFuZCBp cyB0aGUgb25seSB3YXkgbGF5ZXJzIHNob3VsZCBldmVyIGJlIGRlc3Ryb3llZAogICAgIHZvaWQg ZGVzdHJveUxheWVyKCk7CiAKICAgICBib29sIGhhc1NlbGZQYWludGluZ0xheWVyKCkgY29uc3Q7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmNwcAkocmV2aXNp b24gMjIzMTMyKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTE0MzQsMTQgKzE0MzQsNiBAQCB2b2lkIFJlbmRlck9iamVjdDo6 d2lsbEJlRGVzdHJveWVkKCkKICAgICBpZiAoQVhPYmplY3RDYWNoZSogY2FjaGUgPSBkb2N1bWVu dCgpLmV4aXN0aW5nQVhPYmplY3RDYWNoZSgpKQogICAgICAgICBjYWNoZS0+cmVtb3ZlKHRoaXMp OwogCi0gICAgLy8gRklYTUU6IFdvdWxkIGxpa2UgdG8gZG8gdGhpcyBpbiBSZW5kZXJCb3hNb2Rl bE9iamVjdCwgYnV0IHRoZSB0aW1pbmcgaXMgc28gY29tcGxpY2F0ZWQgdGhhdCB0aGlzIGNhbid0 IGVhc2lseQotICAgIC8vIGJlIG1vdmVkIGludG8gUmVuZGVyTGF5ZXJNb2RlbE9iamVjdDo6d2ls bEJlRGVzdHJveWVkKCkuCi0gICAgLy8gRklYTUU6IElzIHRoaXMgc3RpbGwgdHJ1ZT8KLSAgICBp ZiAoaGFzTGF5ZXIoKSkgewotICAgICAgICBzZXRIYXNMYXllcihmYWxzZSk7Ci0gICAgICAgIGRv d25jYXN0PFJlbmRlckxheWVyTW9kZWxPYmplY3Q+KCp0aGlzKS5kZXN0cm95TGF5ZXIoKTsKLSAg ICB9Ci0KICAgICByZW1vdmVSYXJlRGF0YSgpOwogfQogCg==