178137 2017-10-10 10:58:07 -0700 AX: [ATK] ARIA form role should be mapped to ATK_ROLE_LANDMARK; not ATK_ROLE_FORM 2017-10-10 14:29:28 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All Linux RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall apinheiro buildbot cfleizach commit-queue dmazzoni jcraig samuel_white webkit-bug-importer oldest_to_newest 1358801 0 jdiggs 2017-10-10 10:58:07 -0700 Because the ARIA form role is a landmark, it should be mapped to ATK_ROLE_LANDMARK; not ATK_ROLE_FORM. https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#role-map-form 1358802 1 webkit-bug-importer 2017-10-10 10:58:28 -0700 <rdar://problem/34914168> 1358806 2 323323 jdiggs 2017-10-10 11:06:11 -0700 Created attachment 323323 Patch 1358915 3 323323 commit-queue 2017-10-10 14:29:27 -0700 Comment on attachment 323323 Patch Clearing flags on attachment: 323323 Committed r223145: <http://trac.webkit.org/changeset/223145> 1358916 4 commit-queue 2017-10-10 14:29:28 -0700 All reviewed patches have been landed. Closing bug. 323323 2017-10-10 11:06:11 -0700 2017-10-10 14:29:27 -0700 Patch bug-178137-20171010200610.patch text/plain 5160 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzNkMDZlMzYxNTM5OTZl YjJlMGM1NDg2YmZhNThhZmM4OWE0ZjU4Ni4uMjZlOWFlMTQ4YWNkMzk2Y2Y0M2UxNjUxYTA4MmRk YzdhMDI0MmZmMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEwLTEwICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogW0FUS10gQVJJ QSBmb3JtIHJvbGUgc2hvdWxkIGJlIG1hcHBlZCB0byBBVEtfUk9MRV9MQU5ETUFSSzsgbm90IEFU S19ST0xFX0ZPUk0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3ODEzNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEV4cG9zZSB0aGUgQVJJQSBmb3JtIHJvbGUgYXMgQVRLX1JPTEVfTEFORE1BUks7IGNvbnRp bnVlIHRvIGV4cG9zZSB0aGUgSFRNTCBmb3JtCisgICAgICAgIGVsZW1lbnQgYXMgQVRLX1JPTEVf Rk9STS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkIGR1ZSB0byBleGlzdGluZyBjb3Zl cmFnZS4gVXBkYXRlIGV4cGVjdGF0aW9ucyBmb3Igcm9sZXMtZXhwb3NlZC5odG1sLgorCisgICAg ICAgICogYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwOgor ICAgICAgICAoYXRrUm9sZSk6CisKIDIwMTctMTAtMTAgIEpvYW5tYXJpZSBEaWdncyAgPGpkaWdn c0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEFYOiBbQVRLXSBTVEFURV9DSEVDS0FCTEUgc2hvdWxk IGJlIHJlbW92ZWQgZnJvbSByYWRpbyBidXR0b25zIGluIHJhZGlvZ3JvdXBzIHdpdGggYXJpYS1y ZWFkb25seT0idHJ1ZSIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv YXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vz c2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAppbmRleCBjNTM2ZGI2 OTExMzIwZjgyYzFmNGY2MGVkODc5NGFhNWE3ZGExNzVlLi5iZGM5MWMzOTY3NzBhODQ2YmQ3YWM2 ZDI5YjU0MGJjNmMxNjAyNjQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCkBAIC03 NzMsNiArNzczLDEwIEBAIHN0YXRpYyBBdGtSb2xlIGF0a1JvbGUoQWNjZXNzaWJpbGl0eU9iamVj dCogY29yZU9iamVjdCkKICAgICBjYXNlIEZvb3RlclJvbGU6CiAgICAgICAgIHJldHVybiBBVEtf Uk9MRV9GT09URVI7CiAgICAgY2FzZSBGb3JtUm9sZToKKyNpZiBBVEtfQ0hFQ0tfVkVSU0lPTigy LCAxMSwgMykKKyAgICAgICAgaWYgKGNvcmVPYmplY3QtPmFyaWFSb2xlQXR0cmlidXRlKCkgIT0g VW5rbm93blJvbGUpCisgICAgICAgICAgICByZXR1cm4gQVRLX1JPTEVfTEFORE1BUks7CisjZW5k aWYKICAgICAgICAgcmV0dXJuIEFUS19ST0xFX0ZPUk07CiAgICAgY2FzZSBDYW52YXNSb2xlOgog ICAgICAgICByZXR1cm4gQVRLX1JPTEVfQ0FOVkFTOwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDA2MjU5YjQwYTQwZmQ4OTdkMmMyODdjMDI3YTdk YTgwMTc0ZGQwN2UuLmExZDViYTljZDNkZDY5ODExM2NhY2JlYmYzZDdmOTllYmNhNWViYjcgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAxNy0xMC0xMCAgSm9hbm1hcmllIERpZ2dzICA8amRpZ2dzQGlnYWxpYS5jb20+ CisKKyAgICAgICAgQVg6IFtBVEtdIEFSSUEgZm9ybSByb2xlIHNob3VsZCBiZSBtYXBwZWQgdG8g QVRLX1JPTEVfTEFORE1BUks7IG5vdCBBVEtfUk9MRV9GT1JNCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzgxMzcKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgaGFuZGxpbmcgZm9yIEFUS19ST0xFX0xB TkRNQVJLIHJlc3VsdGluZyBmcm9tIHRoZSBBUklBIGZvcm0gcm9sZS4KKworICAgICAgICAqIFdl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRB dGsuY3BwOgorCiAyMDE3LTEwLTA5ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K IAogICAgICAgICBWZWN0b3Igc2hvdWxkIGJlIGFibGUgdG8gZWFzaWx5IGNyZWF0ZSBmcm9tIGEg bGlzdCBvZiBtb3ZhYmxlIG9ubHkgaXRlbXMKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RS dW5uZXIvSW5qZWN0ZWRCdW5kbGUvYXRrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRBdGsuY3BwIGIv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJ RWxlbWVudEF0ay5jcHAKaW5kZXggNDUwMmI4OTRlOTU0ZWFkM2IzYmMxOWZkNjMxYzM3Y2I2YmE0 ZDRhNi4uNDdiMmU2NzA0ZTMzZTg4ZWIzMjgyYWU4MmU1ZTU1ZGNjMzAyN2Q1MSAxMDA2NDQKLS0t IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9hdGsvQWNjZXNzaWJpbGl0 eVVJRWxlbWVudEF0ay5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9hdGsvQWNjZXNzaWJpbGl0eVVJRWxlbWVudEF0ay5jcHAKQEAgLTEyNSw2ICsxMjUsNyBA QCBjb25zdCBTdHJpbmcgYXR0cmlidXRlc01hcFtdWzJdID0gewogY29uc3QgY2hhciogbGFuZG1h cmtTdHJpbmdCYW5uZXIgPSAiQVhMYW5kbWFya0Jhbm5lciI7CiBjb25zdCBjaGFyKiBsYW5kbWFy a1N0cmluZ0NvbXBsZW1lbnRhcnkgPSAiQVhMYW5kbWFya0NvbXBsZW1lbnRhcnkiOwogY29uc3Qg Y2hhciogbGFuZG1hcmtTdHJpbmdDb250ZW50aW5mbyA9ICJBWExhbmRtYXJrQ29udGVudEluZm8i OworY29uc3QgY2hhciogbGFuZG1hcmtTdHJpbmdGb3JtID0gIkFYTGFuZG1hcmtGb3JtIjsKIGNv bnN0IGNoYXIqIGxhbmRtYXJrU3RyaW5nTWFpbiA9ICJBWExhbmRtYXJrTWFpbiI7CiBjb25zdCBj aGFyKiBsYW5kbWFya1N0cmluZ05hdmlnYXRpb24gPSAiQVhMYW5kbWFya05hdmlnYXRpb24iOwog Y29uc3QgY2hhciogbGFuZG1hcmtTdHJpbmdSZWdpb24gPSAiQVhMYW5kbWFya1JlZ2lvbiI7CkBA IC0zOTQsNiArMzk1LDggQEAgY29uc3QgZ2NoYXIqIHJvbGVUb1N0cmluZyhBdGtPYmplY3QqIG9i amVjdCkKICAgICAgICAgICAgIHJldHVybiBsYW5kbWFya1N0cmluZ1JlZ2lvbjsKICAgICAgICAg aWYgKGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKHhtbFJvbGVzVmFsdWUsICJkb2MtdG9j IikpCiAgICAgICAgICAgICByZXR1cm4gbGFuZG1hcmtTdHJpbmdSZWdpb247CisgICAgICAgIGlm IChlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZSh4bWxSb2xlc1ZhbHVlLCAiZm9ybSIpKQor ICAgICAgICAgICAgcmV0dXJuIGxhbmRtYXJrU3RyaW5nRm9ybTsKICAgICAgICAgaWYgKGVxdWFs TGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKHhtbFJvbGVzVmFsdWUsICJtYWluIikpCiAgICAgICAg ICAgICByZXR1cm4gbGFuZG1hcmtTdHJpbmdNYWluOwogICAgICAgICBpZiAoZXF1YWxMZXR0ZXJz SWdub3JpbmdBU0NJSUNhc2UoeG1sUm9sZXNWYWx1ZSwgIm5hdmlnYXRpb24iKSkKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAx NGFlN2E0ZTk4YmM4NWIzOGI5ZjA2MDdjYzA3ODQ1ODFlMmY0ZWZiLi4wNGNmMTYxZmM0YTY4NmI3 ODQzMGI4YTIwZWJjN2U5MzcwYTM5NTg2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMTAt MTAgIEpvYW5tYXJpZSBEaWdncyAgPGpkaWdnc0BpZ2FsaWEuY29tPgorCisgICAgICAgIEFYOiBb QVRLXSBBUklBIGZvcm0gcm9sZSBzaG91bGQgYmUgbWFwcGVkIHRvIEFUS19ST0xFX0xBTkRNQVJL OyBub3QgQVRLX1JPTEVfRk9STQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTc4MTM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9yb2xlcy1leHBvc2VkLWV4 cGVjdGVkLnR4dDogVXBkYXRlZCBleHBlY3RhdGlvbnMuCisKIDIwMTctMTAtMTAgIEpvYW5tYXJp ZSBEaWdncyAgPGpkaWdnc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEFYOiBbQVRLXSBTVEFURV9D SEVDS0FCTEUgc2hvdWxkIGJlIHJlbW92ZWQgZnJvbSByYWRpbyBidXR0b25zIGluIHJhZGlvZ3Jv dXBzIHdpdGggYXJpYS1yZWFkb25seT0idHJ1ZSIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL2d0ay9hY2Nlc3NpYmlsaXR5L3JvbGVzLWV4cG9zZWQtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvcm9sZXMtZXhwb3NlZC1leHBlY3Rl ZC50eHQKaW5kZXggMGYxNzM4ZDM1ZTQ5NTZjYWViZTVjNzhkODQ5OTFhZTljNTFhMzgzNi4uYmU5 M2ZlN2Q5MTdjZDhjOTI1MmU1NzE1MTE3MGNmYzJhMmE2YTYzMyAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvcm9sZXMtZXhwb3NlZC1leHBlY3RlZC50 eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvcm9sZXMtZXhw b3NlZC1leHBlY3RlZC50eHQKQEAgLTY0Nyw3ICs2NDcsNyBAQCBkaXZbcm9sZT1maWd1cmVdCiAg ICAgICBBWFJvbGU6IEFYR3JvdXAKICAgICAgIAogZGl2W3JvbGU9Zm9ybV0KLSAgICAgIEFYUm9s ZTogQVhGb3JtCisgICAgICBBWFJvbGU6IEFYTGFuZG1hcmtGb3JtCiAgICAgICAKIGRpdltyb2xl PWdyaWRdCiAgICAgICBBWFJvbGU6IEFYVGFibGUK