178122 2017-10-10 03:22:22 -0700 [GTK][WPE] Don't require brotli 2017-11-14 09:18:12 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=178158 P2 Normal --- 1 tpopela tpopela annulen aperez berto bugs-noreply clopez commit-queue fred.wang mcatanzaro zan oldest_to_newest 1358693 0 tpopela 2017-10-10 03:22:22 -0700 It is unnecessary to depend on brotli as it is only a dependency of woff2. Once there will be a new woff2 release with https://github.com/google/woff2/pull/95 included we should get rid off the brotli checks. 1358694 1 tpopela 2017-10-10 03:24:20 -0700 To be correct - it is not necessary to depend .. 1358695 2 323294 tpopela 2017-10-10 03:30:00 -0700 Created attachment 323294 Patch 1358708 3 323294 fred.wang 2017-10-10 04:08:41 -0700 Comment on attachment 323294 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323294&action=review > Source/cmake/OptionsGTK.cmake:386 > find_package(WOFF2Dec 1.0.1) I'm wondering whether we should wait a new release of WOFF2 before landing this, and then update the version number here. 1358710 4 tpopela 2017-10-10 04:19:02 -0700 (In reply to Frédéric Wang (:fredw) from comment #3) > I'm wondering whether we should wait a new release of WOFF2 before landing > this, and then update the version number here. Good point Fred! I will update the version once it will be released and I'll be landing this change. 1358720 5 annulen 2017-10-10 04:45:56 -0700 I think it would be better to avoid removing FindBrotliDec from the tree and instead do the following: 1. In FindWOFF2.cmake use check_cxx_symbol_exists(woff2::ConvertWOFF2ToTTF). This will create internal test file which is compiled and linked to WOFF2DEC_LIBRARIES. 2. If check_cxx_symbol_exists fails, e.g. because WOFF2DEC_LIBRARIES is incomplete (broken pkg-config file, or pkg-config was not used at all and WOFF2DEC_LIBRARIES was found by find_library()), invoke find_package(BrotliDec 1.0.1) and append its variables to WOFF2 variables. 1358721 6 annulen 2017-10-10 04:47:18 -0700 >and append its variables to WOFF2 variables. Looks like just set(WOFF2DEC_LIBRARIES ${WOFF2DEC_LIBRARIES} {BROTLIDEC_LIBRARIES}) 1358900 7 323294 mcatanzaro 2017-10-10 14:13:10 -0700 Comment on attachment 323294 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323294&action=review Good catch, Tom! >> Source/cmake/OptionsGTK.cmake:386 >> find_package(WOFF2Dec 1.0.1) > > I'm wondering whether we should wait a new release of WOFF2 before landing this, and then update the version number here. Yes. Perhaps Rick would be willing to make another release for us? 1358903 8 mcatanzaro 2017-10-10 14:14:35 -0700 Ah, I forgot to read the last few comments before I wrote my reply. :) (In reply to Konstantin Tokarev from comment #5) > I think it would be better to avoid removing FindBrotliDec from the tree and > instead do the following: > > 1. In FindWOFF2.cmake use check_cxx_symbol_exists(woff2::ConvertWOFF2ToTTF). > This will create internal test file which is compiled and linked to > WOFF2DEC_LIBRARIES. > > 2. If check_cxx_symbol_exists fails, e.g. because WOFF2DEC_LIBRARIES is > incomplete (broken pkg-config file, or pkg-config was not used at all and > WOFF2DEC_LIBRARIES was found by find_library()), invoke > find_package(BrotliDec 1.0.1) and append its variables to WOFF2 variables. This is really unnecessarily complicated. The WOFF2 library is brand new and not packaged by distros yet; there's no need for such a compatibility check. 1359077 9 tpopela 2017-10-11 00:38:25 -0700 Actually I realized that this is change is not needed at all, because we will require brotli at some point when we will the add support for brotli encoding as Dan doesn't want to include it in libsoup - https://bugzilla.gnome.org/show_bug.cgi?id=788418. Žan should we leave the brotli check in WebKit? 1359079 10 fred.wang 2017-10-11 00:43:39 -0700 (In reply to Tomas Popela from comment #9) > Actually I realized that this is change is not needed at all, because we > will require brotli at some point when we will the add support for brotli > encoding as Dan doesn't want to include it in libsoup - > https://bugzilla.gnome.org/show_bug.cgi?id=788418. Žan should we leave the > brotli check in WebKit? OK. Anyway, I think this change is not too urgent. We would still need the change in Source/WebCore/CMakeLists.txt and the modification of the release version when a new version of WOFF2 is released. 1359093 11 annulen 2017-10-11 02:14:58 -0700 (In reply to Tomas Popela from comment #9) > Actually I realized that this is change is not needed at all, because we > will require brotli at some point when we will the add support for brotli > encoding as Dan doesn't want to include it in libsoup - > https://bugzilla.gnome.org/show_bug.cgi?id=788418. Žan should we leave the > brotli check in WebKit? IMO it would be a better idea to support zstd encoding[1], unlike brotli it's clearly superior to zlib on both client and server side[2] [1] https://tools.ietf.org/id/draft-kucherawy-dispatch-zstd-00.html [2] http://zstd.net/ 1359146 12 mcatanzaro 2017-10-11 05:45:59 -0700 (In reply to Tomas Popela from comment #9) > Actually I realized that this is change is not needed at all, because we > will require brotli at some point when we will the add support for brotli > encoding as Dan doesn't want to include it in libsoup - > https://bugzilla.gnome.org/show_bug.cgi?id=788418. Žan should we leave the > brotli check in WebKit? I don't think we should support brotli decoding unless it's supported by libsoup (which we might still decide to do), so let's still remove this unnecessary brotli check. 1359182 13 clopez 2017-10-11 08:00:14 -0700 (In reply to Konstantin Tokarev from comment #11) > (In reply to Tomas Popela from comment #9) > > Actually I realized that this is change is not needed at all, because we > > will require brotli at some point when we will the add support for brotli > > encoding as Dan doesn't want to include it in libsoup - > > https://bugzilla.gnome.org/show_bug.cgi?id=788418. Žan should we leave the > > brotli check in WebKit? > > IMO it would be a better idea to support zstd encoding[1], unlike brotli > it's clearly superior to zlib on both client and server side[2] > > [1] https://tools.ietf.org/id/draft-kucherawy-dispatch-zstd-00.html > [2] http://zstd.net/ There is nowadays an egg-chicken problem with it, and I think the Linux WebKit ports doesn't have enough market share to change the status-quo. I have made a python script that checks Alexa top N sites to check how many support a given encoding: https://gist.github.com/clopez/dcae6ba605e7fa521b5e989ca323f522 And the numbers I get after a run of the script is that only 3 domains (which are all facebook owned) support zstd support of encoding zstd - Alexa top 100 : 1 domains (1%) - Alexa top 1000 : 3 domains (0.3%) support of encoding br (brotli) - Alexa top 100 : 24 domains (24%) - Alexa top 1000 : 91 domains (9.1%) support of encoding gzip - Alexa top 100 : 81 domains (81%) - Alexa top 1000 : 867 domains (86.7%) 1359185 14 clopez 2017-10-11 08:18:34 -0700 (In reply to Michael Catanzaro from comment #12) > (In reply to Tomas Popela from comment #9) > > Actually I realized that this is change is not needed at all, because we > > will require brotli at some point when we will the add support for brotli > > encoding as Dan doesn't want to include it in libsoup - > > https://bugzilla.gnome.org/show_bug.cgi?id=788418. Žan should we leave the > > brotli check in WebKit? > > I don't think we should support brotli decoding unless it's supported by > libsoup (which we might still decide to do), so let's still remove this > unnecessary brotli check. I think the current patch is right (no matter what we decide now), because there isn't currently any support in webkit for decoding brotli content (AFAIK)... so lets remove this dependency check from CMake. If in the future someone wants to propose any feature for WebKit that requires to interact directly with brotli encoded content they can bring this back. 1359242 15 mcatanzaro 2017-10-11 10:46:45 -0700 Note a similar change will be needed for WPE (again, after the next WOFF2 release), see bug #178158. 1360047 16 zan 2017-10-13 09:57:43 -0700 (In reply to Tomas Popela from comment #9) > Actually I realized that this is change is not needed at all, because we > will require brotli at some point when we will the add support for brotli > encoding as Dan doesn't want to include it in libsoup - > https://bugzilla.gnome.org/show_bug.cgi?id=788418. Žan should we leave the > brotli check in WebKit? No need, I can revert the removal once it's needed again. 1371356 17 323294 fred.wang 2017-11-14 04:34:56 -0800 Comment on attachment 323294 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323294&action=review > Source/WebCore/CMakeLists.txt:3663 > + list(APPEND WebCore_LIBRARIES "${WOFF2DEC_LIBRARIES}") Brotli dep was removed in bug 179630, however we forgot to take that part :-( @Tomas, Michael: can one of you please handle that? 1371386 18 mcatanzaro 2017-11-14 08:42:40 -0800 Thanks for pointing this out, Fred. I'll handle it. Had forgotten this bug. 1371387 19 326880 mcatanzaro 2017-11-14 08:44:10 -0800 Created attachment 326880 Patch 1371395 20 326880 commit-queue 2017-11-14 09:18:10 -0800 Comment on attachment 326880 Patch Clearing flags on attachment: 326880 Committed r224817: <https://trac.webkit.org/changeset/224817> 1371396 21 commit-queue 2017-11-14 09:18:12 -0800 All reviewed patches have been landed. Closing bug. 323294 2017-10-10 03:30:00 -0700 2017-11-14 08:44:08 -0800 Patch bug-178122-20171010122959.patch text/plain 4866 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmRiODAxNzBkOTllZjdk ZmVlZWI2N2U0OGU0NzNmNDJhY2EwNGI5ZS4uZjM1ZGViZDBmMDA1ZGVmMjNiYWI0MDk2MjdjNDg5 OTUzZmZmOTkzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEwLTEwICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBEb24n dCByZXF1aXJlIGJyb3RsaQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc4MTIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgSXQgaXMgbm90IG5lY2Vzc2FyeSB0byBkZXBlbmQgb24gYnJvdGxpIGFzIGl0IGlz IG9ubHkgYSBkZXBlbmRlbmN5IG9mCisgICAgICAgIHdvZmYyLgorCisgICAgICAgICogQ01ha2VM aXN0cy50eHQ6CisKIDIwMTctMTAtMDUgIEZyZWRlcmljIFdhbmcgIDxmd2FuZ0BpZ2FsaWEuY29t PgogCiAgICAgICAgIFJlbW92ZSBXT0ZGMiBmcm9tIFNvdXJjZS9UaGlyZFBhcnR5LgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9DTWFr ZUxpc3RzLnR4dAppbmRleCAyZDc4NGI3MmRiOTQ3ZmE0NTMxOWQ4NGI2Y2M5MDllOWRkMmE2YTky Li4yOWNhMDY2ZjRmODNmMzVjYzAyMDMzZjQzN2I2MDVmYzMwODQ1YTUyIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxp c3RzLnR4dApAQCAtMzY2MCw3ICszNjYwLDcgQEAgZW5kaWYgKCkKIAogaWYgKFVTRV9XT0ZGMikK ICAgbGlzdChBUFBFTkQgV2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVTICIke1dPRkYyREVDX0lO Q0xVREVfRElSU30iKQotICBsaXN0KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUyAiJHtCUk9UTElE RUNfTElCUkFSSUVTfSIgIiR7V09GRjJERUNfTElCUkFSSUVTfSIpCisgIGxpc3QoQVBQRU5EIFdl YkNvcmVfTElCUkFSSUVTICIke1dPRkYyREVDX0xJQlJBUklFU30iKQogZW5kaWYgKCkKIAogaWYg KFVTRV9YREdNSU1FKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL0ZpbmRCcm90bGlEZWMuY21h a2UgYi9Tb3VyY2UvY21ha2UvRmluZEJyb3RsaURlYy5jbWFrZQpkZWxldGVkIGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggM2E4Y2Y5MDM1N2YxODRhYTAwYmJjYjAxNDM0MTFmMGI1ZDYzZTJmNC4uMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9Tb3VyY2UvY21ha2Uv RmluZEJyb3RsaURlYy5jbWFrZQorKysgL2Rldi9udWxsCkBAIC0xLDUzICswLDAgQEAKLSMgLSBU cnkgdG8gZmluZCBCcm90bGlEZWMuCi0jIE9uY2UgZG9uZSwgdGhpcyB3aWxsIGRlZmluZQotIwot IyAgQlJPVExJREVDX0ZPVU5EIC0gc3lzdGVtIGhhcyBCcm90bGlEZWMuCi0jICBCUk9UTElERUNf SU5DTFVERV9ESVJTIC0gdGhlIEJyb3RsaURlYyBpbmNsdWRlIGRpcmVjdG9yaWVzCi0jICBCUk9U TElERUNfTElCUkFSSUVTIC0gbGluayB0aGVzZSB0byB1c2UgQnJvdGxpRGVjLgotIwotIyBDb3B5 cmlnaHQgKEMpIDIwMTcgSWdhbGlhIFMuTC4KLSMKLSMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBp biBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0Ci0jIG1vZGlmaWNhdGlv biwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwot IyBhcmUgbWV0OgotIyAxLiAgUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0 YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKLSMgICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRp dGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KLSMgMi4gIFJlZGlzdHJpYnV0aW9u cyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0Ci0jICAg ICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2Ns YWltZXIgaW4gdGhlCi0jICAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMg cHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgotIwotIyBUSElTIFNPRlRXQVJFIElTIFBS T1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMK LSMgSVMnJyBBTkQgQU5ZIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcs IEJVVCBOT1QgTElNSVRFRCBUTywKLSMgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFO VEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgotIyBQVVJQT1NFIEFSRSBESVND TEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUIEhPTERFUiBPUiBJVFMKLSMg Q09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5U QUwsIFNQRUNJQUwsCi0jIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNM VURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKLSMgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBH T09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7Ci0jIE9SIEJV U0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkgT0Yg TElBQklMSVRZLAotIyBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBU T1JUIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUgotIyBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5Z IFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGCi0jIEFEVklTRUQg T0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgotCi1maW5kX3BhY2thZ2UoUGtnQ29u ZmlnKQotcGtnX2NoZWNrX21vZHVsZXMoUENfQlJPVExJREVDIGxpYmJyb3RsaWRlYykKLQotZmlu ZF9wYXRoKEJST1RMSURFQ19JTkNMVURFX0RJUlMKLSAgICBOQU1FUyBicm90bGkvZGVjb2RlLmgK LSAgICBISU5UUyAke1BDX0JST1RMSURFQ19JTkNMVURFRElSfQotKQotCi1maW5kX2xpYnJhcnko QlJPVExJREVDX0xJQlJBUklFUwotICAgIE5BTUVTIGJyb3RsaWRlYwotICAgIEhJTlRTICR7UENf QlJPVExJREVDX0xJQkRJUn0KLSkKLQotaW5jbHVkZShGaW5kUGFja2FnZUhhbmRsZVN0YW5kYXJk QXJncykKLWZpbmRfcGFja2FnZV9oYW5kbGVfc3RhbmRhcmRfYXJncyhCcm90bGlEZWMKLSAgICBS RVFVSVJFRF9WQVJTIEJST1RMSURFQ19JTkNMVURFX0RJUlMgQlJPVExJREVDX0xJQlJBUklFUwot ICAgIEZPVU5EX1ZBUiBCUk9UTElERUNfRk9VTkQKLSAgICBWRVJTSU9OX1ZBUiBQQ19CUk9UTElE RUNfVkVSU0lPTikKLQotbWFya19hc19hZHZhbmNlZCgKLSAgICBCUk9UTElERUNfSU5DTFVERV9E SVJTCi0gICAgQlJPVExJREVDX0xJQlJBUklFUwotKQpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtl L09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQppbmRleCA0 ODExZGE5OGE1ODE4MzYwZTNmMmExNWM1OTMxNGZiN2NlM2M5MWFmLi4zM2EyOGVlMjk5Njg1Yjk5 NGRlYzQyOWI5MGRlZjczOGQ0YzZlNWY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9u c0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAtMzgzLDEw ICszODMsNiBAQCBpZiAoVVNFX1VQT1dFUikKIGVuZGlmICgpCiAKIGlmIChVU0VfV09GRjIpCi0g ICAgZmluZF9wYWNrYWdlKEJyb3RsaURlYyAxLjAuMSkKLSAgICBpZiAoTk9UIEJST1RMSURFQ19G T1VORCkKLSAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJsaWJyb3RsaWRlYyBpcyBuZWVkZWQg Zm9yIFVTRV9XT0ZGMi4iKQotICAgIGVuZGlmICgpCiAgICAgZmluZF9wYWNrYWdlKFdPRkYyRGVj IDEuMC4xKQogICAgIGlmIChOT1QgV09GRjJERUNfRk9VTkQpCiAgICAgICAgbWVzc2FnZShGQVRB TF9FUlJPUiAibGl3b2ZmMmRlYyBpcyBuZWVkZWQgZm9yIFVTRV9XT0ZGMi4iKQpkaWZmIC0tZ2l0 IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDMyNDBkZTlkYmE0Nzk1ZGRiZTFjYzQ3NzBj ZjVlZTZkYzEyODkwY2MuLjZiM2Y1NmQ5ZDIwYmVkNjc3MGU1MDNjNzQ2NDdkY2M2MDEyYTBhNmYg MTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAor MjAxNy0xMC0xMCAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgorCisgICAgICAg IFtHVEtdW1dQRV0gRG9uJ3QgcmVxdWlyZSBicm90bGkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODEyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGlzIG5vdCBuZWNlc3NhcnkgdG8gZGVwZW5kIG9u IGJyb3RsaSBhcyBpdCBpcyBvbmx5IGEgZGVwZW5kZW5jeSBvZgorICAgICAgICB3b2ZmMi4KKwor ICAgICAgICAqIFNvdXJjZS9jbWFrZS9GaW5kQnJvdGxpRGVjLmNtYWtlOiBSZW1vdmVkLgorICAg ICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOgorCiAyMDE3LTEwLTA1ICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZW1vdmUgV09GRjIgZnJv bSBTb3VyY2UvVGhpcmRQYXJ0eS4K 326880 2017-11-14 08:44:10 -0800 2017-11-14 09:18:10 -0800 Patch bug-178122-20171114104409.patch text/plain 1237 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjI0ODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGZmNDFhMTJjNDUxNWVi MzZlYjM1OTdiMjVkNjg1MGY4MmRiNTA0ZS4uZjQzZWY1YmQzNTI5NzVlZjY1YjA3ZjU4ODg5NGZi MjQ4MzJmMmI1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTExLTE0ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtX UEVdIERvbid0IHJlcXVpcmUgYnJvdGxpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzgxMjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZW1vdmUgc3RyYXkgcmVtYWluaW5nIHVzZSBvZiBicm90bGkgQ01h a2UgdmFyaWFibGUuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxNy0xMS0xNCAg WmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NhaXJvXSBN b3ZlIGRyYXdMaW5lc0ZvclRleHQgb3BlcmF0aW9uIGZyb20gR3JhcGhpY3NDb250ZXh0Q2Fpcm8g dG8gQ2Fpcm9PcGVyYXRpb25zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3Rz LnR4dCBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CmluZGV4IDE2NzJiZTljODcyMzk2 NzIzOGE2MzY1YjVhMjIyYTJmMDU4MjFhMmEuLmEzMmY4NWFiMzYxMWQwMzM2ZGY5YTNhOTg2NGRm ZWIzYmQzOTkwNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0Cisr KyBiL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0CkBAIC0xNDc3LDcgKzE0NzcsNyBAQCBl bmRpZiAoKQogCiBpZiAoVVNFX1dPRkYyKQogICBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xVREVf RElSRUNUT1JJRVMgIiR7V09GRjJERUNfSU5DTFVERV9ESVJTfSIpCi0gIGxpc3QoQVBQRU5EIFdl YkNvcmVfTElCUkFSSUVTICIke0JST1RMSURFQ19MSUJSQVJJRVN9IiAiJHtXT0ZGMkRFQ19MSUJS QVJJRVN9IikKKyAgbGlzdChBUFBFTkQgV2ViQ29yZV9MSUJSQVJJRVMgIiR7V09GRjJERUNfTElC UkFSSUVTfSIpCiBlbmRpZiAoKQogCiBpZiAoVVNFX1hER01JTUUpCg==