178100 2017-10-09 16:52:31 -0700 [WPE] Header cairo.h is used in GLib API headers but cannot be found 2017-10-11 05:42:34 -0700 1 1 1 Unclassified WebKit WPE WebKit Other Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=176475 https://bugs.webkit.org/show_bug.cgi?id=178104 P2 Normal --- 178125 1 aperez aperez berto bugs-noreply buildbot cgarcia commit-queue gustavo mcatanzaro webkit-bug-importer zan oldest_to_newest 1358506 0 aperez 2017-10-09 16:52:31 -0700 When a program tries to use the GLib-based API for WPE (see bug #178090 for a patch to make it installable), trying to use the <wpe/webkit.h> header will result in the compilation error shown below, due to “cairo.h” not being in the headers search path. --- In file included from /home/aperez/devel/wpe/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/wpe-0.1/WPE/wpe/webkit.h:46:0, from /home/aperez/devel/wpe/buildroot/output/build/dinghy-custom/dinghy.c:8: /home/aperez/devel/wpe/buildroot/output/host/arm-buildroot-linux-gnueabihf/sysroot/usr/include/wpe-0.1/WPE/wpe/WebKitFaviconDatabase.h:27:19: fatal error: cairo.h: No such file or directory #include <cairo.h> ^ 1358507 1 aperez 2017-10-09 16:54:01 -0700 I think we can fix this by adding “cairo” to the “Requires.private” field of the .pc generated to be used by pkg-config. I'll try that out and submit a patch. 1358513 2 323245 aperez 2017-10-09 17:00:14 -0700 Created attachment 323245 Patch 1358717 3 zan 2017-10-10 04:37:02 -0700 Can we instead just use a forward declaration of cairo_surface_t, and drop the cairo.h include? 1358722 4 aperez 2017-10-10 04:48:54 -0700 (In reply to Zan Dobersek from comment #3) > Can we instead just use a forward declaration of cairo_surface_t, and drop > the cairo.h include? Very likely! I'll give that a try and update the patch accordingly once I am sure it works. :-) 1358728 5 323299 aperez 2017-10-10 05:21:54 -0700 Created attachment 323299 Patch 1358729 6 aperez 2017-10-10 05:24:52 -0700 (In reply to Adrian Perez from comment #4) > (In reply to Zan Dobersek from comment #3) > > Can we instead just use a forward declaration of cairo_surface_t, and drop > > the cairo.h include? > > Very likely! I'll give that a try and update the patch accordingly > once I am sure it works. :-) Worked perfectly, the new version of the patch adds only the forward declaration and removes the #include \o/ 1358730 7 aperez 2017-10-10 05:26:26 -0700 Ouch, we'll have to add “#include <cairo.h>” to the .cpp files which make use of “WebKitFaviconDatabase.h”, as Good Guy EWS™ has found out. 1358814 8 323326 aperez 2017-10-10 11:34:17 -0700 Created attachment 323326 Patch 1358815 9 buildbot 2017-10-10 11:35:19 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1358817 10 323326 zan 2017-10-10 11:42:18 -0700 Comment on attachment 323326 Patch Thanks, I appreciate the change. 1358829 11 323326 commit-queue 2017-10-10 12:09:54 -0700 Comment on attachment 323326 Patch Clearing flags on attachment: 323326 Committed r223136: <http://trac.webkit.org/changeset/223136> 1358830 12 commit-queue 2017-10-10 12:09:56 -0700 All reviewed patches have been landed. Closing bug. 1358843 13 mcatanzaro 2017-10-10 12:39:08 -0700 But you need to update the GTK header as well. We have to keep these headers completely in sync. Only exception should be symbols that do not exist in one port or the other. 1358845 14 mcatanzaro 2017-10-10 12:41:10 -0700 Reverted r223136 for reason: Forgot to update GTK API header Committed r223138: <http://trac.webkit.org/changeset/223138> 1358847 15 mcatanzaro 2017-10-10 12:42:45 -0700 (This was probably overkill for a rollout, but it's easier for backporting to land one fixed patch instead of an incremental fixup.) 1358849 16 aperez 2017-10-10 12:52:38 -0700 (In reply to Michael Catanzaro from comment #13) > But you need to update the GTK header as well. We have to keep these headers > completely in sync. Only exception should be symbols that do not exist in > one port or the other. I'll prepare a new version of the patch that covers both WPE and GTK+. 1358860 17 323336 aperez 2017-10-10 13:08:37 -0700 Created attachment 323336 Patch 1358880 18 mcatanzaro 2017-10-10 13:48:22 -0700 You shouldn't have to #include a new header to use any types from our API. Zan's instincts to avoid unneeded forward declarations are good usually, but not in public headers IMO. Thanks to gtk-doc for catching this problem on the GTK EWS. :P 1358887 19 323347 aperez 2017-10-10 13:54:13 -0700 Created attachment 323347 Patch 1358913 20 323347 mcatanzaro 2017-10-10 14:26:44 -0700 Comment on attachment 323347 Patch Perfect! 1358921 21 323347 commit-queue 2017-10-10 14:32:56 -0700 Comment on attachment 323347 Patch Clearing flags on attachment: 323347 Committed r223146: <http://trac.webkit.org/changeset/223146> 1358922 22 commit-queue 2017-10-10 14:32:58 -0700 All reviewed patches have been landed. Closing bug. 1359144 23 mcatanzaro 2017-10-11 05:42:11 -0700 Reverted r223146 for reason: Better to not expose cairo in the WPE API Committed r223174: <http://trac.webkit.org/changeset/223174> 1359145 24 mcatanzaro 2017-10-11 05:42:34 -0700 We'll address this in bug #178157 instead. 323245 2017-10-09 17:00:14 -0700 2017-10-10 05:21:50 -0700 Patch bug-178100-20171010020013.patch text/plain 1430 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGQ3OTZmODk0YWYxMjBmYTIz Zjg3YmJjMjI4NGE0Yjc5YzVjYWRlZWEuLjM4ZTRhZWI2Y2FmNTFjNzMyZmVlMTAyYTQ5ZmNkNTA4 ZDE5OWZmYzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTAtMDkgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBIZWFk ZXIgY2Fpcm8uaCBpcyB1c2VkIGluIEdMaWIgQVBJIGhlYWRlcnMgYnV0IGNhbm5vdCBiZSBmb3Vu ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MTAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3cGUv d3BlLXdlYmtpdC5wYy5pbjogQWRkIENhaXJvIHRvIHRoZSAiUmVxdWlyZXMucHJpdmF0ZSIgZmll bGQsIHNvIGl0cyBmbGFncyBnZXQKKyAgICAgICAgcHVsbGVkIGluIGFuZCB0aGUgImNhaXJvLmgi LCB1c2VkIGluIHRoZSBXUEUgV2ViS2l0IEdMaWIgQVBJIGhlYWRlcnMsIGNhbiBiZSBmb3VuZC4K KwogMjAxNy0xMC0wOSAgU2FtIFdlaW5pZyAgPHNhbUB3ZWJraXQub3JnPgogCiAgICAgICAgIE1h a2UgSGFzaE1hcDo6a2V5cygpIGFuZCBIYXNoTWFwOjp2YWx1ZXMoKSB3b3JrIHdpdGggV1RGOjpt YXAvV1RGOjpjb3B5VG9WZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvd3BlL3dwZS13 ZWJraXQucGMuaW4gYi9Tb3VyY2UvV2ViS2l0L3dwZS93cGUtd2Via2l0LnBjLmluCmluZGV4IGU5 OWMwMjUxODE0N2Q3OWI2NTFhYThjZTU3NTIyYzMzMTdkZmVjNjYuLjlkNzk0NGJjZDgwMmE2MDQw YzA3NDY3YjY1YWQ5MTYxNjdhMWNiZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvd3BlL3dw ZS13ZWJraXQucGMuaW4KKysrIGIvU291cmNlL1dlYktpdC93cGUvd3BlLXdlYmtpdC5wYy5pbgpA QCAtNiw2ICs2LDYgQEAgaW5jbHVkZWRpcj0ke3ByZWZpeH0vaW5jbHVkZQogTmFtZTogV2ViS2l0 MgogRGVzY3JpcHRpb246IFdQRS1mbGF2b3JlZCBXZWIgZW5naW5lCiBWZXJzaW9uOiBAUFJPSkVD VF9WRVJTSU9OQAotUmVxdWlyZXMucHJpdmF0ZTogZ2xpYi0yLjAgbGlic291cC0yLjQKK1JlcXVp cmVzLnByaXZhdGU6IGdsaWItMi4wIGxpYnNvdXAtMi40IGNhaXJvID49IDEuMTQuNAogTGliczog LUwke2xpYmRpcn0gLWxXUEVXZWJLaXQgLWxXUEUKIENmbGFnczogLUkke2luY2x1ZGVkaXJ9L3dw ZS1AV1BFX0FQSV9WRVJTSU9OQCAtSSR7aW5jbHVkZWRpcn0vd3BlLUBXUEVfQVBJX1ZFUlNJT05A L1dQRQo= 323299 2017-10-10 05:21:54 -0700 2017-10-10 11:34:12 -0700 Patch bug-178100-20171010142152.patch text/plain 1877 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRlMGIyMzU3OGIwN2RmYTY1 NDkyMDBkZjBlODEyMTkwZjE3NmJlZmMuLjBjMjY3MmJhODYwYjY4OGNmZmM2ZDk3MTY4OTIxZTRl MjU5MDJkZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMTAtMTAgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBIZWFk ZXIgY2Fpcm8uaCBpcyB1c2VkIGluIEdMaWIgQVBJIGhlYWRlcnMgYnV0IGNhbm5vdCBiZSBmb3Vu ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MTAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVh ZCBvZiBpbmNsdWRpbmcgPGNhaXJvLmg+LCBpdCBpcyBiZXR0ZXIgdG8gZm9yd2FyZC1kZWNsYXJl IGNhaXJvX3N1cmZhY2VfdCwKKyAgICAgICAgd2hpY2ggaXMgdGhlIG9uZSBhbmQgb25seSBDYWly byBkZWNsYXJhdGlvbiBuZWVkZWQgYnkgdGhlIFdQRSBBUEkgaGVhZGVyLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS93cGUvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmg6IEFkZCBmb3J3YXJkIGRl Y2xhcmF0aW9uIG9mIGNhaXJvX3N1cmZhY2VfdC4KKwogMjAxNy0xMC0xMCAgQWRyaWFuIFBlcmV6 IGRlIENhc3RybyAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEdMaWIgQVBJ IGhlYWRlcnMgV2ViS2l0U2NyaXB0RGlhbG9nLmggYW5kIFdlYktpdEZpbGVDaG9vc2VyUmVxdWVz dC5oIGFyZSBub3QgaW5zdGFsbGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvd3BlL1dlYktpdEZhdmljb25EYXRhYmFzZS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL3dwZS9XZWJLaXRGYXZpY29uRGF0YWJhc2UuaAppbmRleCBiZWQ0MDE4MWQ4YjNmZjVj ZDM0ZmE2OTcyODY5ZmVjMWU3NmQyODcyLi41NzA4MDlhMzljODc2NDhjNDAyN2VmMDFiMmZmMDQy ZmQ5N2Q4MWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dl YktpdEZhdmljb25EYXRhYmFzZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93 cGUvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmgKQEAgLTI0LDEzICsyNCwxNCBAQAogI2lmbmRlZiBX ZWJLaXRGYXZpY29uRGF0YWJhc2VfaAogI2RlZmluZSBXZWJLaXRGYXZpY29uRGF0YWJhc2VfaAog Ci0jaW5jbHVkZSA8Y2Fpcm8uaD4KICNpbmNsdWRlIDxnaW8vZ2lvLmg+CiAjaW5jbHVkZSA8Z2xp Yi1vYmplY3QuaD4KICNpbmNsdWRlIDx3cGUvV2ViS2l0RGVmaW5lcy5oPgogCiBHX0JFR0lOX0RF Q0xTCiAKK3R5cGVkZWYgc3RydWN0IF9jYWlyb19zdXJmYWNlIGNhaXJvX3N1cmZhY2VfdDsKKwog I2RlZmluZSBXRUJLSVRfVFlQRV9GQVZJQ09OX0RBVEFCQVNFICAgICAgICAgICAgKHdlYmtpdF9m YXZpY29uX2RhdGFiYXNlX2dldF90eXBlKCkpCiAjZGVmaW5lIFdFQktJVF9GQVZJQ09OX0RBVEFC QVNFKG9iaikgICAgICAgICAgICAoR19UWVBFX0NIRUNLX0lOU1RBTkNFX0NBU1QoKG9iaiksIFdF QktJVF9UWVBFX0ZBVklDT05fREFUQUJBU0UsIFdlYktpdEZhdmljb25EYXRhYmFzZSkpCiAjZGVm aW5lIFdFQktJVF9JU19GQVZJQ09OX0RBVEFCQVNFKG9iaikgICAgICAgICAoR19UWVBFX0NIRUNL X0lOU1RBTkNFX1RZUEUoKG9iaiksIFdFQktJVF9UWVBFX0ZBVklDT05fREFUQUJBU0UpKQo= 323326 2017-10-10 11:34:17 -0700 2017-10-10 13:08:33 -0700 Patch bug-178100-20171010203416.patch text/plain 3068 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFiMGU0OTI1NzJiMjcxMDA1 MDQwZmU5OTRjN2JlOGFhZTNmZTU5YzUuLjNmOGE0OWUwNDFhZjBmZTRkZDU1ZDNhNDY3YWZjZmM0 ZTc2YTQ3MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTctMTAtMTAgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBIZWFk ZXIgY2Fpcm8uaCBpcyB1c2VkIGluIEdMaWIgQVBJIGhlYWRlcnMgYnV0IGNhbm5vdCBiZSBmb3Vu ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MTAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVh ZCBvZiBpbmNsdWRpbmcgPGNhaXJvLmg+LCBpdCBpcyBiZXR0ZXIgdG8gZm9yd2FyZC1kZWNsYXJl IGNhaXJvX3N1cmZhY2VfdCwKKyAgICAgICAgd2hpY2ggaXMgdGhlIG9uZSBhbmQgb25seSBDYWly byBkZWNsYXJhdGlvbiBuZWVkZWQgYnkgdGhlIFdQRSBBUEkgaGVhZGVyLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdEZhdmljb25EYXRhYmFzZS5jcHA6IEFkZCBpbmNsdXNp b24gb2YgPGNhaXJvLmg+LgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJW aWV3LmNwcDogQWRkIGluY2x1c2lvbiBvZiA8Y2Fpcm8uaD4uCisgICAgICAgICogVUlQcm9jZXNz L0FQSS93cGUvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmg6IEFkZCBmb3J3YXJkIGRlY2xhcmF0aW9u IG9mIGNhaXJvX3N1cmZhY2VfdC4KKwogMjAxNy0xMC0xMCAgQWRyaWFuIFBlcmV6IGRlIENhc3Ry byAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEJ1aWxkIGZhaWx1cmUgZHVl IHRvIGludmFsaWQgY2FzdCBvZiBFR0xOYXRpdmVXaW5kb3dUeXBlIHdoZW4gdGFyZ2V0dGluZyA2 NC1iaXQgQVJNCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9X ZWJLaXRGYXZpY29uRGF0YWJhc2UuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2ds aWIvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmNwcAppbmRleCAwNWQ2M2ZkNGM0YmQzMzkyOGNlNWE0 YWNhMGI4OWJlNzAzZWI2NTFmLi41YzU0YTAxY2I2NTc1NWNjMmVkODk1Yjc0NjcyYjdmYjczYjhj NDYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRG YXZpY29uRGF0YWJhc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGli L1dlYktpdEZhdmljb25EYXRhYmFzZS5jcHAKQEAgLTI3LDYgKzI3LDcgQEAKICNpbmNsdWRlIDxX ZWJDb3JlL0ltYWdlLmg+CiAjaW5jbHVkZSA8V2ViQ29yZS9JbnRTaXplLmg+CiAjaW5jbHVkZSA8 V2ViQ29yZS9SZWZQdHJDYWlyby5oPgorI2luY2x1ZGUgPGNhaXJvLmg+CiAjaW5jbHVkZSA8Z2xp Yi9naTE4bi1saWIuaD4KICNpbmNsdWRlIDx3dGYvUnVuTG9vcC5oPgogI2luY2x1ZGUgPHd0Zi9T ZXRGb3JTY29wZS5oPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2ds aWIvV2ViS2l0V2ViVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9X ZWJLaXRXZWJWaWV3LmNwcAppbmRleCAwYzE3OTgzYmVkNTkyNWJiNzY4ODY5OTE1NTA3MzNmNWY3 ZTdjNDBkLi42YmViNjRjYTBjY2UwYThmZTQ0ODhlMDg4MjdkZDEwYzQ0OTVhZjE0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRXZWJWaWV3LmNwcApA QCAtODUsNiArODUsOCBAQAogI2luY2x1ZGUgIldQRVZpZXcuaCIKICNlbmRpZgogCisjaW5jbHVk ZSA8Y2Fpcm8uaD4KKwogI2lmIFVTRShMSUJOT1RJRlkpCiAjaW5jbHVkZSA8bGlibm90aWZ5L25v dGlmeS5oPgogI2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv d3BlL1dlYktpdEZhdmljb25EYXRhYmFzZS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L3dwZS9XZWJLaXRGYXZpY29uRGF0YWJhc2UuaAppbmRleCBiZWQ0MDE4MWQ4YjNmZjVjZDM0ZmE2 OTcyODY5ZmVjMWU3NmQyODcyLi41NzA4MDlhMzljODc2NDhjNDAyN2VmMDFiMmZmMDQyZmQ5N2Q4 MWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdEZh dmljb25EYXRhYmFzZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvV2Vi S2l0RmF2aWNvbkRhdGFiYXNlLmgKQEAgLTI0LDEzICsyNCwxNCBAQAogI2lmbmRlZiBXZWJLaXRG YXZpY29uRGF0YWJhc2VfaAogI2RlZmluZSBXZWJLaXRGYXZpY29uRGF0YWJhc2VfaAogCi0jaW5j bHVkZSA8Y2Fpcm8uaD4KICNpbmNsdWRlIDxnaW8vZ2lvLmg+CiAjaW5jbHVkZSA8Z2xpYi1vYmpl Y3QuaD4KICNpbmNsdWRlIDx3cGUvV2ViS2l0RGVmaW5lcy5oPgogCiBHX0JFR0lOX0RFQ0xTCiAK K3R5cGVkZWYgc3RydWN0IF9jYWlyb19zdXJmYWNlIGNhaXJvX3N1cmZhY2VfdDsKKwogI2RlZmlu ZSBXRUJLSVRfVFlQRV9GQVZJQ09OX0RBVEFCQVNFICAgICAgICAgICAgKHdlYmtpdF9mYXZpY29u X2RhdGFiYXNlX2dldF90eXBlKCkpCiAjZGVmaW5lIFdFQktJVF9GQVZJQ09OX0RBVEFCQVNFKG9i aikgICAgICAgICAgICAoR19UWVBFX0NIRUNLX0lOU1RBTkNFX0NBU1QoKG9iaiksIFdFQktJVF9U WVBFX0ZBVklDT05fREFUQUJBU0UsIFdlYktpdEZhdmljb25EYXRhYmFzZSkpCiAjZGVmaW5lIFdF QktJVF9JU19GQVZJQ09OX0RBVEFCQVNFKG9iaikgICAgICAgICAoR19UWVBFX0NIRUNLX0lOU1RB TkNFX1RZUEUoKG9iaiksIFdFQktJVF9UWVBFX0ZBVklDT05fREFUQUJBU0UpKQo= 323336 2017-10-10 13:08:37 -0700 2017-10-10 13:54:10 -0700 Patch bug-178100-20171010220836.patch text/plain 4184 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFiMGU0OTI1NzJiMjcxMDA1 MDQwZmU5OTRjN2JlOGFhZTNmZTU5YzUuLjM4NjIwMzY0MTgzYmM1NTMxMWMyMjA5ZDUxYjczYjE0 NDQ4NzMzOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTctMTAtMTAgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBIZWFk ZXIgY2Fpcm8uaCBpcyB1c2VkIGluIEdMaWIgQVBJIGhlYWRlcnMgYnV0IGNhbm5vdCBiZSBmb3Vu ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MTAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW5zdGVh ZCBvZiBpbmNsdWRpbmcgPGNhaXJvLmg+LCBpdCBpcyBiZXR0ZXIgdG8gZm9yd2FyZC1kZWNsYXJl IGNhaXJvX3N1cmZhY2VfdCwKKyAgICAgICAgd2hpY2ggaXMgdGhlIG9uZSBhbmQgb25seSBDYWly byBkZWNsYXJhdGlvbiBuZWVkZWQgYnkgdGhlIFdQRSBBUEkgaGVhZGVyLiBUaGUgR1RLKworICAg ICAgICBwb3J0IGhlYWRlciBpcyB1cGRhdGVkIGFzIHdlbGwgdG8ga2VlcCBib3RoIGluIHN5bmMu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmNw cDogQWRkIGluY2x1c2lvbiBvZiA8Y2Fpcm8uaD4uCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n bGliL1dlYktpdFdlYlZpZXcuY3BwOiBBZGQgaW5jbHVzaW9uIG9mIDxjYWlyby5oPi4KKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRGYXZpY29uRGF0YWJhc2UuaDogQWRkIGZvcndh cmQgZGVjbGFyYXRpb24gb2YgY2Fpcm9fc3VyZmFjZV90LgorICAgICAgICAqIFVJUHJvY2Vzcy9B UEkvd3BlL1dlYktpdEZhdmljb25EYXRhYmFzZS5oOiBBZGQgZm9yd2FyZCBkZWNsYXJhdGlvbiBv ZiBjYWlyb19zdXJmYWNlX3QuCisKIDIwMTctMTAtMTAgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8g IDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbV1BFXSBCdWlsZCBmYWlsdXJlIGR1ZSB0 byBpbnZhbGlkIGNhc3Qgb2YgRUdMTmF0aXZlV2luZG93VHlwZSB3aGVuIHRhcmdldHRpbmcgNjQt Yml0IEFSTQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2Vi S2l0RmF2aWNvbkRhdGFiYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGli L1dlYktpdEZhdmljb25EYXRhYmFzZS5jcHAKaW5kZXggMDVkNjNmZDRjNGJkMzM5MjhjZTVhNGFj YTBiODliZTcwM2ViNjUxZi4uNWM1NGEwMWNiNjU3NTVjYzJlZDg5NWI3NDY3MmI3ZmI3M2I4YzQ2 MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0RmF2 aWNvbkRhdGFiYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9X ZWJLaXRGYXZpY29uRGF0YWJhc2UuY3BwCkBAIC0yNyw2ICsyNyw3IEBACiAjaW5jbHVkZSA8V2Vi Q29yZS9JbWFnZS5oPgogI2luY2x1ZGUgPFdlYkNvcmUvSW50U2l6ZS5oPgogI2luY2x1ZGUgPFdl YkNvcmUvUmVmUHRyQ2Fpcm8uaD4KKyNpbmNsdWRlIDxjYWlyby5oPgogI2luY2x1ZGUgPGdsaWIv Z2kxOG4tbGliLmg+CiAjaW5jbHVkZSA8d3RmL1J1bkxvb3AuaD4KICNpbmNsdWRlIDx3dGYvU2V0 Rm9yU2NvcGUuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGli L1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2Vi S2l0V2ViVmlldy5jcHAKaW5kZXggMGMxNzk4M2JlZDU5MjViYjc2ODg2OTkxNTUwNzMzZjVmN2U3 YzQwZC4uNmJlYjY0Y2EwY2NlMGE4ZmU0NDg4ZTA4ODI3ZGQxMGM0NDk1YWYxNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViVmlldy5jcHAKKysr IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0V2ViVmlldy5jcHAKQEAg LTg1LDYgKzg1LDggQEAKICNpbmNsdWRlICJXUEVWaWV3LmgiCiAjZW5kaWYKIAorI2luY2x1ZGUg PGNhaXJvLmg+CisKICNpZiBVU0UoTElCTk9USUZZKQogI2luY2x1ZGUgPGxpYm5vdGlmeS9ub3Rp ZnkuaD4KICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXRGYXZpY29uRGF0YWJhc2UuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmgKaW5kZXggNDVmYmI1ZDg4ZDljYjVkMWU4MDgyM2E3 Zjc2NDk3ZWE5OGE1OWVmZC4uZmZkYTM1M2NhY2M4ZDlhMTQxZTZlZTdkNmU0ZDU1NmYwYjc1YzU1 YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRGYXZp Y29uRGF0YWJhc2UuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dEZhdmljb25EYXRhYmFzZS5oCkBAIC0yNCwxMyArMjQsMTQgQEAKICNpZm5kZWYgV2ViS2l0RmF2 aWNvbkRhdGFiYXNlX2gKICNkZWZpbmUgV2ViS2l0RmF2aWNvbkRhdGFiYXNlX2gKIAotI2luY2x1 ZGUgPGNhaXJvLmg+CiAjaW5jbHVkZSA8Z2lvL2dpby5oPgogI2luY2x1ZGUgPGdsaWItb2JqZWN0 Lmg+CiAjaW5jbHVkZSA8d2Via2l0Mi9XZWJLaXREZWZpbmVzLmg+CiAKIEdfQkVHSU5fREVDTFMK IAordHlwZWRlZiBzdHJ1Y3QgX2NhaXJvX3N1cmZhY2UgY2Fpcm9fc3VyZmFjZV90OworCiAjZGVm aW5lIFdFQktJVF9UWVBFX0ZBVklDT05fREFUQUJBU0UgICAgICAgICAgICAod2Via2l0X2Zhdmlj b25fZGF0YWJhc2VfZ2V0X3R5cGUoKSkKICNkZWZpbmUgV0VCS0lUX0ZBVklDT05fREFUQUJBU0Uo b2JqKSAgICAgICAgICAgIChHX1RZUEVfQ0hFQ0tfSU5TVEFOQ0VfQ0FTVCgob2JqKSwgV0VCS0lU X1RZUEVfRkFWSUNPTl9EQVRBQkFTRSwgV2ViS2l0RmF2aWNvbkRhdGFiYXNlKSkKICNkZWZpbmUg V0VCS0lUX0lTX0ZBVklDT05fREFUQUJBU0Uob2JqKSAgICAgICAgIChHX1RZUEVfQ0hFQ0tfSU5T VEFOQ0VfVFlQRSgob2JqKSwgV0VCS0lUX1RZUEVfRkFWSUNPTl9EQVRBQkFTRSkpCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdEZhdmljb25EYXRhYmFz ZS5oIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9XZWJLaXRGYXZpY29uRGF0YWJh c2UuaAppbmRleCBiZWQ0MDE4MWQ4YjNmZjVjZDM0ZmE2OTcyODY5ZmVjMWU3NmQyODcyLi41NzA4 MDlhMzljODc2NDhjNDAyN2VmMDFiMmZmMDQyZmQ5N2Q4MWFmIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dlYktpdEZhdmljb25EYXRhYmFzZS5oCisrKyBiL1Nv dXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvV2ViS2l0RmF2aWNvbkRhdGFiYXNlLmgKQEAg LTI0LDEzICsyNCwxNCBAQAogI2lmbmRlZiBXZWJLaXRGYXZpY29uRGF0YWJhc2VfaAogI2RlZmlu ZSBXZWJLaXRGYXZpY29uRGF0YWJhc2VfaAogCi0jaW5jbHVkZSA8Y2Fpcm8uaD4KICNpbmNsdWRl IDxnaW8vZ2lvLmg+CiAjaW5jbHVkZSA8Z2xpYi1vYmplY3QuaD4KICNpbmNsdWRlIDx3cGUvV2Vi S2l0RGVmaW5lcy5oPgogCiBHX0JFR0lOX0RFQ0xTCiAKK3R5cGVkZWYgc3RydWN0IF9jYWlyb19z dXJmYWNlIGNhaXJvX3N1cmZhY2VfdDsKKwogI2RlZmluZSBXRUJLSVRfVFlQRV9GQVZJQ09OX0RB VEFCQVNFICAgICAgICAgICAgKHdlYmtpdF9mYXZpY29uX2RhdGFiYXNlX2dldF90eXBlKCkpCiAj ZGVmaW5lIFdFQktJVF9GQVZJQ09OX0RBVEFCQVNFKG9iaikgICAgICAgICAgICAoR19UWVBFX0NI RUNLX0lOU1RBTkNFX0NBU1QoKG9iaiksIFdFQktJVF9UWVBFX0ZBVklDT05fREFUQUJBU0UsIFdl YktpdEZhdmljb25EYXRhYmFzZSkpCiAjZGVmaW5lIFdFQktJVF9JU19GQVZJQ09OX0RBVEFCQVNF KG9iaikgICAgICAgICAoR19UWVBFX0NIRUNLX0lOU1RBTkNFX1RZUEUoKG9iaiksIFdFQktJVF9U WVBFX0ZBVklDT05fREFUQUJBU0UpKQo= 323347 2017-10-10 13:54:13 -0700 2017-10-10 14:32:56 -0700 Patch bug-178100-20171010225412.patch text/plain 1367 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGIzYjA5ZmEzNGE0NDJkYmM1 YTExMTU4NzZjMTM2NWY3OGRjNjFjMDUuLjVkOWM1OGQ4ZWZjMTA2NjUyYzQ5MjZjMjVjNGIwOTcy MTBiMDdkZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTAtMTAgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBIZWFk ZXIgY2Fpcm8uaCBpcyB1c2VkIGluIEdMaWIgQVBJIGhlYWRlcnMgYnV0IGNhbm5vdCBiZSBmb3Vu ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MTAw CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3cGUv d3BlLXdlYmtpdC5wYy5pbjogQWRkIENhaXJvIHRvIHRoZSAiUmVxdWlyZXMiIGZpZWxkLCBzbyBp dHMgZmxhZ3MgZ2V0IHB1bGxlZAorICAgICAgICBpbiBhbmQgdGhlICJjYWlyby5oIiwgdXNlZCBp biB0aGUgV1BFIFdlYktpdCBHTGliIEFQSSBoZWFkZXJzLCBjYW4gYmUgZm91bmQuCisKIDIwMTct MTAtMTAgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAg ICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMjMxMzYuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L3dwZS93cGUtd2Via2l0LnBjLmluIGIvU291cmNlL1dlYktpdC93cGUvd3BlLXdlYmtp dC5wYy5pbgppbmRleCA0ZWVlNzJlYTBmM2NlYTRhMWM3ZmNjNzhmNDc1MzFlNGFhODRhYTdkLi4z ZmYxNGE5M2FmNTU5ZjlmZTdkZDg0ZDNkYmE4NGViNTQ3OWFkODVhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L3dwZS93cGUtd2Via2l0LnBjLmluCisrKyBiL1NvdXJjZS9XZWJLaXQvd3BlL3dw ZS13ZWJraXQucGMuaW4KQEAgLTYsNiArNiw2IEBAIGluY2x1ZGVkaXI9JHtwcmVmaXh9L2luY2x1 ZGUKIE5hbWU6IFdlYktpdDIKIERlc2NyaXB0aW9uOiBXUEUtZmxhdm9yZWQgV2ViIGVuZ2luZQog VmVyc2lvbjogQFBST0pFQ1RfVkVSU0lPTkAKLVJlcXVpcmVzOiBnbGliLTIuMCBsaWJzb3VwLTIu NAorUmVxdWlyZXM6IGdsaWItMi4wIGxpYnNvdXAtMi40IGNhaXJvID49IDEuMTQuNAogTGliczog LUwke2xpYmRpcn0gLWxXUEVXZWJLaXQKIENmbGFnczogLUkke2luY2x1ZGVkaXJ9L3dwZS1AV1BF X0FQSV9WRVJTSU9OQCAtSSR7aW5jbHVkZWRpcn0vd3BlLUBXUEVfQVBJX1ZFUlNJT05AL1dQRQo=