178091 2017-10-09 12:54:34 -0700 Remove redundant RenderObject::virtualContinuation 2017-10-09 14:57:57 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1358352 0 zalan 2017-10-09 12:54:34 -0700 it sounds like it was some specific continuation behavior but it's simply just a function override. 1358353 1 webkit-bug-importer 2017-10-09 12:55:07 -0700 <rdar://problem/34892906> 1358373 2 323204 zalan 2017-10-09 13:11:11 -0700 Created attachment 323204 Patch 1358443 3 323204 commit-queue 2017-10-09 14:57:56 -0700 Comment on attachment 323204 Patch Clearing flags on attachment: 323204 Committed r223072: <http://trac.webkit.org/changeset/223072> 1358444 4 commit-queue 2017-10-09 14:57:57 -0700 All reviewed patches have been landed. Closing bug. 323204 2017-10-09 13:11:11 -0700 2017-10-09 14:57:56 -0700 Patch bug-178091-20171009131110.patch text/plain 5467 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzRlZGVkMDU3MjkyYzM2 Yjc1ZTZmYmE2MjdjNDhhMTNiYjI4OTA3OS4uMzZhODdjOTIyMTFmNTI3YTYzODJhNDJlM2ZjNDdi MTg0MmE0ZTgyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE3LTEwLTA5ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIHJlZHVuZGFudCBS ZW5kZXJPYmplY3Q6OnZpcnR1YWxDb250aW51YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODA5MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzQ4OTI5MDY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgCisgICAg ICAgIHZpcnR1YWxDb250aW51YXRpb24gc291bmRzIGxpa2UgYSBmZWF0dXJlIG9mIGNvbnRpbnVh dGlvbiwgd2hpbGUgaXQncyBqdXN0IGEgKG5vdCBzdXBlciB1c2VmdWwpaGVscGVyIG92ZXJyaWRl LgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNhbk1lcmdlQ29udGln dW91c0Fub255bW91c0Jsb2Nrcyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6dGFr ZUNoaWxkKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2suaDoKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVySW5saW5lLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVj dC5oOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyT2JqZWN0Ojppc0Jsb2NrRWxlbWVudENvbnRp bnVhdGlvbiBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJPYmplY3Q6OnZpcnR1YWxD b250aW51YXRpb24gY29uc3QpOiBEZWxldGVkLgorCiAyMDE3LTEwLTA2ICBEYW5pZWwgQmF0ZXMg IDxkYWJhdGVzQGFwcGxlLmNvbT4KIAogICAgICAgICBTcGVsbGluZyBlcnJvciBhbm5vdGF0aW9u IHNob3VsZCBlbmNvbXBhc3MgaHlwaGVuIGluIG1pc3NwZWxsZWQgd29yZCB0aGF0IHdyYXBzIGFj cm9zcyBtdWx0aXBsZSBsaW5lcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5j cHAKaW5kZXggYmFjNTU2OTgzNGU5MjliMjNjN2RjODlkZTliM2NlMmNiYzAwNWFmZi4uNmI3Y2M4 ZDAzNGFkZjFjYWIwY2MyZWJlMWM3ZjkxZWQzODIwNDRjNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQmxvY2suY3BwCkBAIC03ODgsNyArNzg4LDEyIEBAIHN0YXRpYyBib29sIGNh bkRyb3BBbm9ueW1vdXNCbG9jayhjb25zdCBSZW5kZXJCbG9jayYgYW5vbnltb3VzQmxvY2spCiAK IHN0YXRpYyBib29sIGNhbk1lcmdlQ29udGlndW91c0Fub255bW91c0Jsb2NrcyhSZW5kZXJPYmpl Y3QmIG9sZENoaWxkLCBSZW5kZXJPYmplY3QqIHByZXZpb3VzLCBSZW5kZXJPYmplY3QqIG5leHQp CiB7Ci0gICAgaWYgKG9sZENoaWxkLnJlbmRlclRyZWVCZWluZ0Rlc3Ryb3llZCgpIHx8IG9sZENo aWxkLmlzSW5saW5lKCkgfHwgb2xkQ2hpbGQudmlydHVhbENvbnRpbnVhdGlvbigpKQorICAgIEFT U0VSVCghb2xkQ2hpbGQucmVuZGVyVHJlZUJlaW5nRGVzdHJveWVkKCkpOworCisgICAgaWYgKG9s ZENoaWxkLmlzSW5saW5lKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmIChpczxS ZW5kZXJCb3hNb2RlbE9iamVjdD4ob2xkQ2hpbGQpICYmIGRvd25jYXN0PFJlbmRlckJveE1vZGVs T2JqZWN0PihvbGRDaGlsZCkuY29udGludWF0aW9uKCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK IAogICAgIGlmIChwcmV2aW91cykgewpAQCAtOTE1LDE5ICs5MjAsMTcgQEAgUmVuZGVyUHRyPFJl bmRlck9iamVjdD4gUmVuZGVyQmxvY2s6OnRha2VDaGlsZChSZW5kZXJPYmplY3QmIG9sZENoaWxk KQogICAgICAgICAgICAgd2hpbGUgKGNvbnRhaW5pbmdCbG9ja0lnbm9yaW5nQW5vbnltb3VzICYm IGNvbnRhaW5pbmdCbG9ja0lnbm9yaW5nQW5vbnltb3VzLT5pc0Fub255bW91c0Jsb2NrKCkpCiAg ICAgICAgICAgICAgICAgY29udGFpbmluZ0Jsb2NrSWdub3JpbmdBbm9ueW1vdXMgPSBjb250YWlu aW5nQmxvY2tJZ25vcmluZ0Fub255bW91cy0+Y29udGFpbmluZ0Jsb2NrKCk7CiAgICAgICAgICAg ICBmb3IgKFJlbmRlck9iamVjdCogY3VycmVudCA9IHRoaXM7IGN1cnJlbnQ7IGN1cnJlbnQgPSBj dXJyZW50LT5wcmV2aW91c0luUHJlT3JkZXIoY29udGFpbmluZ0Jsb2NrSWdub3JpbmdBbm9ueW1v dXMpKSB7Ci0gICAgICAgICAgICAgICAgaWYgKGN1cnJlbnQtPnZpcnR1YWxDb250aW51YXRpb24o KSAhPSB0aGlzKQorICAgICAgICAgICAgICAgIGlmICghaXM8UmVuZGVyQm94TW9kZWxPYmplY3Q+ KGN1cnJlbnQpIHx8IGRvd25jYXN0PFJlbmRlckJveE1vZGVsT2JqZWN0PigqY3VycmVudCkuY29u dGludWF0aW9uKCkgIT0gdGhpcykKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Ci0KICAg ICAgICAgICAgICAgICAvLyBGb3VuZCBvdXIgcHJldmlvdXMgY29udGludWF0aW9uLiBXZSBqdXN0 IG5lZWQgdG8gcG9pbnQgaXQgdG8KICAgICAgICAgICAgICAgICAvLyB8dGhpc3wncyBuZXh0IGNv bnRpbnVhdGlvbi4KLSAgICAgICAgICAgICAgICBSZW5kZXJCb3hNb2RlbE9iamVjdCogbmV4dENv bnRpbnVhdGlvbiA9IGNvbnRpbnVhdGlvbigpOworICAgICAgICAgICAgICAgIGF1dG8qIG5leHRD b250aW51YXRpb24gPSBjb250aW51YXRpb24oKTsKICAgICAgICAgICAgICAgICBpZiAoaXM8UmVu ZGVySW5saW5lPigqY3VycmVudCkpCiAgICAgICAgICAgICAgICAgICAgIGRvd25jYXN0PFJlbmRl cklubGluZT4oKmN1cnJlbnQpLnNldENvbnRpbnVhdGlvbihuZXh0Q29udGludWF0aW9uKTsKICAg ICAgICAgICAgICAgICBlbHNlIGlmIChpczxSZW5kZXJCbG9jaz4oKmN1cnJlbnQpKQogICAgICAg ICAgICAgICAgICAgICBkb3duY2FzdDxSZW5kZXJCbG9jaz4oKmN1cnJlbnQpLnNldENvbnRpbnVh dGlvbihuZXh0Q29udGludWF0aW9uKTsKICAgICAgICAgICAgICAgICBlbHNlCiAgICAgICAgICAg ICAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwotCiAgICAgICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBzZXRDb250aW51YXRpb24obnVsbHB0cik7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaCBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCmluZGV4IDI5MTdhZTRkZGVhMTQ5MTEx NjU1NzAwMDA3OWE1MzBhMzEwZGM4NTMuLjg4MWVhMGM2MmJlNzllZmQ0ZGQwZDZiZDVkOTE0MjFk NDc3YWIwMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCkBAIC0xODgs NyArMTg4LDYgQEAgcHVibGljOgogICAgIHZvaWQgYWRkQ29udGludWF0aW9uV2l0aE91dGxpbmUo UmVuZGVySW5saW5lKik7CiAgICAgYm9vbCBwYWludHNDb250aW51YXRpb25PdXRsaW5lKFJlbmRl cklubGluZSopOwogCi0gICAgUmVuZGVyQm94TW9kZWxPYmplY3QqIHZpcnR1YWxDb250aW51YXRp b24oKSBjb25zdCBmaW5hbCB7IHJldHVybiBjb250aW51YXRpb24oKTsgfQogICAgIGJvb2wgaXNB bm9ueW1vdXNCbG9ja0NvbnRpbnVhdGlvbigpIGNvbnN0IHsgcmV0dXJuIGlzQW5vbnltb3VzQmxv Y2soKSAmJiBjb250aW51YXRpb24oKTsgfQogICAgIFdFQkNPUkVfRVhQT1JUIFJlbmRlcklubGlu ZSogaW5saW5lRWxlbWVudENvbnRpbnVhdGlvbigpIGNvbnN0OwogICAgIFJlbmRlckJsb2NrKiBi bG9ja0VsZW1lbnRDb250aW51YXRpb24oKSBjb25zdDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJJbmxpbmUuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJJbmxpbmUuaAppbmRleCA0NmI0MGNkZmYxYjhiMWJmYTNiY2UzYjk2MjBlYzE4M2Q4YWFj ZDZkLi4zMGY5NmRkYmY1M2UwNjc4YTEwOGJhYzM4MjY1NzFkYWEzNWQ5YTYyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVySW5saW5lLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlcklubGluZS5oCkBAIC03OCw3ICs3OCw2IEBAIHB1YmxpYzoK ICAgICB2b2lkIGFic29sdXRlUXVhZHNGb3JTZWxlY3Rpb24oVmVjdG9yPEZsb2F0UXVhZD4mIHF1 YWRzKSBjb25zdCBvdmVycmlkZTsKICNlbmRpZgogCi0gICAgUmVuZGVyQm94TW9kZWxPYmplY3Qq IHZpcnR1YWxDb250aW51YXRpb24oKSBjb25zdCBmaW5hbCB7IHJldHVybiBjb250aW51YXRpb24o KTsgfQogICAgIFJlbmRlcklubGluZSogaW5saW5lRWxlbWVudENvbnRpbnVhdGlvbigpIGNvbnN0 OwogCiAgICAgdm9pZCB1cGRhdGVEcmFnU3RhdGUoYm9vbCBkcmFnT24pIGZpbmFsOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oCmluZGV4IGI0ODEwZWMzMTYxYWEwZDk1NDE1 YmMwYjgyMTFjN2ZhNzcxM2RhNTAuLjI1NzI4ODUwOTk1MTE2OWEyNTg4MThlMWRkZGM0MWJhNzkw MmUyMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJPYmplY3Qu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyT2JqZWN0LmgKQEAgLTQxNCw3 ICs0MTQsNiBAQCBwdWJsaWM6CiAgICAgYm9vbCBpc0VsZW1lbnRDb250aW51YXRpb24oKSBjb25z dCB7IHJldHVybiBub2RlKCkgJiYgbm9kZSgpLT5yZW5kZXJlcigpICE9IHRoaXM7IH0KICAgICBi b29sIGlzSW5saW5lRWxlbWVudENvbnRpbnVhdGlvbigpIGNvbnN0IHsgcmV0dXJuIGlzRWxlbWVu dENvbnRpbnVhdGlvbigpICYmIGlzSW5saW5lKCk7IH0KICAgICBib29sIGlzQmxvY2tFbGVtZW50 Q29udGludWF0aW9uKCkgY29uc3QgeyByZXR1cm4gaXNFbGVtZW50Q29udGludWF0aW9uKCkgJiYg IWlzSW5saW5lKCk7IH0KLSAgICB2aXJ0dWFsIFJlbmRlckJveE1vZGVsT2JqZWN0KiB2aXJ0dWFs Q29udGludWF0aW9uKCkgY29uc3QgeyByZXR1cm4gbnVsbHB0cjsgfQogCiAgICAgYm9vbCBpc0Zs b2F0aW5nKCkgY29uc3QgeyByZXR1cm4gbV9iaXRmaWVsZHMuZmxvYXRpbmcoKTsgfQogCg==