178090 2017-10-09 12:21:44 -0700 [WPE] Build failure due to invalid cast of EGLNativeWindowType when targetting 64-bit ARM 2023-04-23 13:15:04 -0700 1 1 1 Unclassified WebKit WPE WebKit Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=255846 P2 Normal --- 178147 1 aperez aperez bugs-noreply buildbot clopez commit-queue mcatanzaro webkit-bug-importer zan oldest_to_newest 1358331 0 aperez 2017-10-09 12:21:44 -0700 This is trying to build the upstream code with Buildroot targeting ARM Cortex A53 (AArch64): WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp: In member function ‘virtual uint64_t WebKit::AcceleratedSurfaceWPE::window() const’: WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:78:99: error: invalid cast from type ‘EGLNativeWindowType {aka long unsigned int}’ to type ‘uint64_t {aka long long unsigned int}’ return reinterpret_cast<uint64_t>(wpe_renderer_backend_egl_target_get_native_window(m_backend)); ^ Changing the cast to use “static_cast” works fine, I'll send a patch. 1358336 1 323197 aperez 2017-10-09 12:28:13 -0700 Created attachment 323197 Patch 1358342 2 323197 aperez 2017-10-09 12:34:16 -0700 Comment on attachment 323197 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323197&action=review > Source/WebKit/ChangeLog:3 > + [WPE] Build failure in Buildroot when targetting 32-bit ARM I have to edit the ChangeLog to follow the change in the bug title 8-) 1358344 3 323199 aperez 2017-10-09 12:36:13 -0700 Created attachment 323199 Patch 1358346 4 buildbot 2017-10-09 12:38:46 -0700 Attachment 323199 did not pass style-queue: ERROR: Source/WebKit/ChangeLog:3: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: invalid cast [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1358707 5 323199 zan 2017-10-10 03:55:36 -0700 Comment on attachment 323199 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323199&action=review > Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:75 > + No need for this newline. 1358723 6 aperez 2017-10-10 04:50:45 -0700 (In reply to Zan Dobersek from comment #5) > Comment on attachment 323199 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=323199&action=review > > > Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:75 > > + > > No need for this newline. Indeed, I'll remove it before landing. Thanks! 1358726 7 323298 aperez 2017-10-10 05:05:26 -0700 Created attachment 323298 Patch for landing 1358734 8 323298 commit-queue 2017-10-10 05:47:03 -0700 Comment on attachment 323298 Patch for landing Clearing flags on attachment: 323298 Committed r223130: <http://trac.webkit.org/changeset/223130> 1358735 9 commit-queue 2017-10-10 05:47:05 -0700 All reviewed patches have been landed. Closing bug. 1358796 10 clopez 2017-10-10 10:46:40 -0700 (In reply to WebKit Commit Bot from comment #8) > Comment on attachment 323298 [details] > Patch for landing > > Clearing flags on attachment: 323298 > > Committed r223130: <http://trac.webkit.org/changeset/223130> This has broken the build for me (GCC 5.3; ARMv7 Thumb2): [.... gcc .... ] -c /home/igalia/clopez/wpe-test/tmp/work/cortexa9t2hf-neon-mx6qdl-poky-linux-gnueabi/wpewebkit/0.r223132-r0/trunk/Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp /home/igalia/clopez/wpe-test/tmp/work/cortexa9t2hf-neon-mx6qdl-poky-linux-gnueabi/wpewebkit/0.r223132-r0/trunk/Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp: In member function 'virtual uint64_t WebKit::AcceleratedSurfaceWPE::window() const': /home/igalia/clopez/wpe-test/tmp/work/cortexa9t2hf-neon-mx6qdl-poky-linux-gnueabi/wpewebkit/0.r223132-r0/trunk/Source/WebKit/WebProcess/WebPage/wpe/AcceleratedSurfaceWPE.cpp:79:94: error: invalid static_cast from type 'EGLNativeWindowType {aka wl_egl_window*}' to type 'uint64_t {aka long long unsigned int}' return static_cast<uint64_t>(wpe_renderer_backend_egl_target_get_native_window(m_backend)); 1358811 11 aperez 2017-10-10 11:27:28 -0700 (In reply to Carlos Alberto Lopez Perez from comment #10) > (In reply to WebKit Commit Bot from comment #8) > > Comment on attachment 323298 [details] > > Patch for landing > > > > Clearing flags on attachment: 323298 > > > > Committed r223130: <http://trac.webkit.org/changeset/223130> > > This has broken the build for me (GCC 5.3; ARMv7 Thumb2): > > > [.... gcc .... ] -c > /home/igalia/clopez/wpe-test/tmp/work/cortexa9t2hf-neon-mx6qdl-poky-linux- > gnueabi/wpewebkit/0.r223132-r0/trunk/Source/WebKit/WebProcess/WebPage/wpe/ > AcceleratedSurfaceWPE.cpp > /home/igalia/clopez/wpe-test/tmp/work/cortexa9t2hf-neon-mx6qdl-poky-linux- > gnueabi/wpewebkit/0.r223132-r0/trunk/Source/WebKit/WebProcess/WebPage/wpe/ > AcceleratedSurfaceWPE.cpp: In member function 'virtual uint64_t > WebKit::AcceleratedSurfaceWPE::window() const': > /home/igalia/clopez/wpe-test/tmp/work/cortexa9t2hf-neon-mx6qdl-poky-linux- > gnueabi/wpewebkit/0.r223132-r0/trunk/Source/WebKit/WebProcess/WebPage/wpe/ > AcceleratedSurfaceWPE.cpp:79:94: error: invalid static_cast from type > 'EGLNativeWindowType {aka wl_egl_window*}' to type 'uint64_t {aka long long > unsigned int}' > return > static_cast<uint64_t>(wpe_renderer_backend_egl_target_get_native_window(m_bac > kend)); Right, we'll have to handle the configurations where “EGLNativeWindowType” is a pointer. 1358905 12 mcatanzaro 2017-10-10 14:17:29 -0700 Would it be correct to use a C-style cast here, with a comment explaining why C++ casts won't work? 1358946 13 aperez 2017-10-10 15:43:13 -0700 (In reply to Michael Catanzaro from comment #12) > Would it be correct to use a C-style cast here, with a comment explaining > why C++ casts won't work? Yes, I arrived to the same conclusion after checking the C++ standard and confirming that e.g. reinterpret_cast will only convert types of the same bit width (makes sense) and that static_cast will never convert a pointer to an integer :-( I've made a rollout of the previous patch and I will be posting a new one so it's easier to track and backport the change to stable branches. 1358950 14 323356 aperez 2017-10-10 15:55:24 -0700 Created attachment 323356 Patch 1358952 15 buildbot 2017-10-10 15:58:50 -0700 Attachment 323356 did not pass style-queue: ERROR: Source/WebKit/ChangeLog:3: Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: invalid cast [changelog/unwantedsecurityterms] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1360820 16 323356 commit-queue 2017-10-16 10:31:03 -0700 Comment on attachment 323356 Patch Clearing flags on attachment: 323356 Committed r223416: <https://trac.webkit.org/changeset/223416> 1360821 17 commit-queue 2017-10-16 10:31:04 -0700 All reviewed patches have been landed. Closing bug. 323197 2017-10-09 12:28:13 -0700 2017-10-09 12:36:09 -0700 Patch bug-178090-20171009212812.patch text/plain 1775 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY4ZWNlMDcwMzkyNzk4M2Ji NDE3ZGY3ODdmMmI1OGY0MjgxZTZmMjcuLjFmNzZjN2ExOTVkOWMxYzNjODEwM2NhZWYxMzZmMmFh MGU3YzU1ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMTAtMDkgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBCdWls ZCBmYWlsdXJlIGluIEJ1aWxkcm9vdCB3aGVuIHRhcmdldHRpbmcgMzItYml0IEFSTQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MDkwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dl YlBhZ2Uvd3BlL0FjY2VsZXJhdGVkU3VyZmFjZVdQRS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkFj Y2VsZXJhdGVkU3VyZmFjZVdQRTo6d2luZG93IGNvbnN0KTogVXNlIHN0YXRpY19jYXN0IGluc3Rl YWQgb2YgcmVpbnRlcnByZXRfY2FzdCwKKyAgICAgICAgdGhpcyB3YXkgZXh0ZW5kaW5nIHZhbHVl cyBvZiBFR0xOYXRpdmVXaW5kb3dUeXBlIHRvIDY0IGJpdHMgaXMgYWxsb3dlZC4KKwogMjAxNy0x MC0wOSAgSmVyZW15IEpvbmVzICA8amVyZW15akBhcHBsZS5jb20+CiAKICAgICAgICAgSW5jb3Jy ZWN0IGZ1bGxzY3JlZW4gYW5pbWF0aW9uIHdoZW4gZWxlbWVudCBoYXMgYSB0cmFuc2Zvcm0uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS93cGUvQWNjZWxlcmF0 ZWRTdXJmYWNlV1BFLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3dwZS9B Y2NlbGVyYXRlZFN1cmZhY2VXUEUuY3BwCmluZGV4IGNiZTg4ZGQ1YTg3Mzk0OGE1OGVhYWYzY2Iz ZjkxYThiY2U5ODI2Y2QuLjcwYzAyZGFlYThmOTUxNWM0NzYxMDExODQ5ZWI1MjAxNGFhMzg4Yjcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3dwZS9BY2NlbGVy YXRlZFN1cmZhY2VXUEUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl L3dwZS9BY2NlbGVyYXRlZFN1cmZhY2VXUEUuY3BwCkBAIC03MiwxMCArNzIsMTIgQEAgdm9pZCBB Y2NlbGVyYXRlZFN1cmZhY2VXUEU6OmZpbmFsaXplKCkKICAgICBtX2JhY2tlbmQgPSBudWxscHRy OwogfQogCisKIHVpbnQ2NF90IEFjY2VsZXJhdGVkU3VyZmFjZVdQRTo6d2luZG93KCkgY29uc3QK IHsKICAgICBBU1NFUlQobV9iYWNrZW5kKTsKLSAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDx1 aW50NjRfdD4od3BlX3JlbmRlcmVyX2JhY2tlbmRfZWdsX3RhcmdldF9nZXRfbmF0aXZlX3dpbmRv dyhtX2JhY2tlbmQpKTsKKyAgICBzdGF0aWNfYXNzZXJ0KHNpemVvZihFR0xOYXRpdmVXaW5kb3dU eXBlKSA8PSBzaXplb2YodWludDY0X3QpLCAiRUdMTmF0aXZlV2luZG93VHlwZSBtdXN0IG5vdCBi ZSBsb25nZXIgdGhhbiA2NCBiaXRzLiIpOworICAgIHJldHVybiBzdGF0aWNfY2FzdDx1aW50NjRf dD4od3BlX3JlbmRlcmVyX2JhY2tlbmRfZWdsX3RhcmdldF9nZXRfbmF0aXZlX3dpbmRvdyhtX2Jh Y2tlbmQpKTsKIH0KIAogdWludDY0X3QgQWNjZWxlcmF0ZWRTdXJmYWNlV1BFOjpzdXJmYWNlSUQo KSBjb25zdAo= 323199 2017-10-09 12:36:13 -0700 2017-10-10 05:05:23 -0700 Patch bug-178090-20171009213612.patch text/plain 1805 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY4ZWNlMDcwMzkyNzk4M2Ji NDE3ZGY3ODdmMmI1OGY0MjgxZTZmMjcuLmVlNjJhY2U0MmJiMWE2ZGEzOGQyMjhiY2QwMmZmOTRl NWIzNmM4OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMTAtMDkgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBCdWls ZCBmYWlsdXJlIGR1ZSB0byBpbnZhbGlkIGNhc3Qgb2YgRUdMTmF0aXZlV2luZG93VHlwZSB3aGVu IHRhcmdldHRpbmcgNjQtYml0IEFSTQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc4MDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uvd3BlL0FjY2VsZXJhdGVkU3VyZmFj ZVdQRS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkFjY2VsZXJhdGVkU3VyZmFjZVdQRTo6d2luZG93 IGNvbnN0KTogVXNlIHN0YXRpY19jYXN0IGluc3RlYWQgb2YgcmVpbnRlcnByZXRfY2FzdCwKKyAg ICAgICAgdGhpcyB3YXkgZXh0ZW5kaW5nIHZhbHVlcyBvZiBFR0xOYXRpdmVXaW5kb3dUeXBlIHRv IDY0IGJpdHMgaXMgYWxsb3dlZC4KKwogMjAxNy0xMC0wOSAgSmVyZW15IEpvbmVzICA8amVyZW15 akBhcHBsZS5jb20+CiAKICAgICAgICAgSW5jb3JyZWN0IGZ1bGxzY3JlZW4gYW5pbWF0aW9uIHdo ZW4gZWxlbWVudCBoYXMgYSB0cmFuc2Zvcm0uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvV2ViUGFnZS93cGUvQWNjZWxlcmF0ZWRTdXJmYWNlV1BFLmNwcCBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3dwZS9BY2NlbGVyYXRlZFN1cmZhY2VXUEUuY3BwCmlu ZGV4IGNiZTg4ZGQ1YTg3Mzk0OGE1OGVhYWYzY2IzZjkxYThiY2U5ODI2Y2QuLjcwYzAyZGFlYThm OTUxNWM0NzYxMDExODQ5ZWI1MjAxNGFhMzg4YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL3dwZS9BY2NlbGVyYXRlZFN1cmZhY2VXUEUuY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL3dwZS9BY2NlbGVyYXRlZFN1cmZhY2VXUEUu Y3BwCkBAIC03MiwxMCArNzIsMTIgQEAgdm9pZCBBY2NlbGVyYXRlZFN1cmZhY2VXUEU6OmZpbmFs aXplKCkKICAgICBtX2JhY2tlbmQgPSBudWxscHRyOwogfQogCisKIHVpbnQ2NF90IEFjY2VsZXJh dGVkU3VyZmFjZVdQRTo6d2luZG93KCkgY29uc3QKIHsKICAgICBBU1NFUlQobV9iYWNrZW5kKTsK LSAgICByZXR1cm4gcmVpbnRlcnByZXRfY2FzdDx1aW50NjRfdD4od3BlX3JlbmRlcmVyX2JhY2tl bmRfZWdsX3RhcmdldF9nZXRfbmF0aXZlX3dpbmRvdyhtX2JhY2tlbmQpKTsKKyAgICBzdGF0aWNf YXNzZXJ0KHNpemVvZihFR0xOYXRpdmVXaW5kb3dUeXBlKSA8PSBzaXplb2YodWludDY0X3QpLCAi RUdMTmF0aXZlV2luZG93VHlwZSBtdXN0IG5vdCBiZSBsb25nZXIgdGhhbiA2NCBiaXRzLiIpOwor ICAgIHJldHVybiBzdGF0aWNfY2FzdDx1aW50NjRfdD4od3BlX3JlbmRlcmVyX2JhY2tlbmRfZWds X3RhcmdldF9nZXRfbmF0aXZlX3dpbmRvdyhtX2JhY2tlbmQpKTsKIH0KIAogdWludDY0X3QgQWNj ZWxlcmF0ZWRTdXJmYWNlV1BFOjpzdXJmYWNlSUQoKSBjb25zdAo= 323298 2017-10-10 05:05:26 -0700 2017-10-10 15:55:20 -0700 Patch for landing bug-178090-20171010140525.patch text/plain 1812 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMTI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRlMGIyMzU3OGIwN2RmYTY1 NDkyMDBkZjBlODEyMTkwZjE3NmJlZmMuLmFiMGU0OTI1NzJiMjcxMDA1MDQwZmU5OTRjN2JlOGFh ZTNmZTU5YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMTAtMTAgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBCdWls ZCBmYWlsdXJlIGR1ZSB0byBpbnZhbGlkIGNhc3Qgb2YgRUdMTmF0aXZlV2luZG93VHlwZSB3aGVu IHRhcmdldHRpbmcgNjQtYml0IEFSTQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc4MDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgxb1hbiBEb2JlcsWh ZWsuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2Uvd3BlL0FjY2VsZXJhdGVkU3VyZmFj ZVdQRS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkFjY2VsZXJhdGVkU3VyZmFjZVdQRTo6d2luZG93 IGNvbnN0KTogVXNlIHN0YXRpY19jYXN0IGluc3RlYWQgb2YgcmVpbnRlcnByZXRfY2FzdCwKKyAg ICAgICAgdGhpcyB3YXkgZXh0ZW5kaW5nIHZhbHVlcyBvZiBFR0xOYXRpdmVXaW5kb3dUeXBlIHRv IDY0IGJpdHMgaXMgYWxsb3dlZC4KKwogMjAxNy0xMC0xMCAgQWRyaWFuIFBlcmV6IGRlIENhc3Ry byAgPGFwZXJlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEdMaWIgQVBJIGhlYWRlcnMg V2ViS2l0U2NyaXB0RGlhbG9nLmggYW5kIFdlYktpdEZpbGVDaG9vc2VyUmVxdWVzdC5oIGFyZSBu b3QgaW5zdGFsbGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS93cGUvQWNjZWxlcmF0ZWRTdXJmYWNlV1BFLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL3dwZS9BY2NlbGVyYXRlZFN1cmZhY2VXUEUuY3BwCmluZGV4IGNiZTg4ZGQ1YTg3 Mzk0OGE1OGVhYWYzY2IzZjkxYThiY2U5ODI2Y2QuLjU4OThlNDg0YzgzYWNkODNhMWU3ZWRjODcy ZWM0MDE2MmM4MmViY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ YWdlL3dwZS9BY2NlbGVyYXRlZFN1cmZhY2VXUEUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9XZWJQYWdlL3dwZS9BY2NlbGVyYXRlZFN1cmZhY2VXUEUuY3BwCkBAIC03NSw3ICs3 NSw4IEBAIHZvaWQgQWNjZWxlcmF0ZWRTdXJmYWNlV1BFOjpmaW5hbGl6ZSgpCiB1aW50NjRfdCBB Y2NlbGVyYXRlZFN1cmZhY2VXUEU6OndpbmRvdygpIGNvbnN0CiB7CiAgICAgQVNTRVJUKG1fYmFj a2VuZCk7Ci0gICAgcmV0dXJuIHJlaW50ZXJwcmV0X2Nhc3Q8dWludDY0X3Q+KHdwZV9yZW5kZXJl cl9iYWNrZW5kX2VnbF90YXJnZXRfZ2V0X25hdGl2ZV93aW5kb3cobV9iYWNrZW5kKSk7CisgICAg c3RhdGljX2Fzc2VydChzaXplb2YoRUdMTmF0aXZlV2luZG93VHlwZSkgPD0gc2l6ZW9mKHVpbnQ2 NF90KSwgIkVHTE5hdGl2ZVdpbmRvd1R5cGUgbXVzdCBub3QgYmUgbG9uZ2VyIHRoYW4gNjQgYml0 cy4iKTsKKyAgICByZXR1cm4gc3RhdGljX2Nhc3Q8dWludDY0X3Q+KHdwZV9yZW5kZXJlcl9iYWNr ZW5kX2VnbF90YXJnZXRfZ2V0X25hdGl2ZV93aW5kb3cobV9iYWNrZW5kKSk7CiB9CiAKIHVpbnQ2 NF90IEFjY2VsZXJhdGVkU3VyZmFjZVdQRTo6c3VyZmFjZUlEKCkgY29uc3QK 323356 2017-10-10 15:55:24 -0700 2017-10-16 10:31:03 -0700 Patch bug-178090-20171011005523.patch text/plain 2621 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDIzMjY2ZGZjYmI3ZjIwYjU5 OWNjZjRmZGI4MGI2MDEwZTJlYTIwYTguLjY2MGFlZDQ1MzIyNTZhNDdmODBlNThhNmVlMmI5MTYx MTE0ODkxZjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTctMTAtMTAgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBCdWls ZCBmYWlsdXJlIGR1ZSB0byBpbnZhbGlkIGNhc3Qgb2YgRUdMTmF0aXZlV2luZG93VHlwZSB3aGVu IHRhcmdldHRpbmcgNjQtYml0IEFSTQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc4MDkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRUdMTmF0aXZlV2luZG93VHlwZSBjYW4gYmUgYWxpYXNlZCB0byBhIGRp ZmZlcmVudCB0eXBlIGRlcGVuZGluZyAoYXQgbGVhc3QpIG9uIHRoZSBFR0wKKyAgICAgICAgaW1w bGVtZW50YXRpb24sIGl0cyBidWlsZCBvcHRpb25zLCBhbmQgdGhlIGxpYmVwb3h5IGJ1aWxkIG9w dGlvbnMuICBVc2luZyAic3RhdGljX2Nhc3QiCisgICAgICAgIHdvcmtzIHdoZW4gaXQgaXMgYSBu dW1lcmljIHZhbHVlIGFuZCB0aGUgd2lkdGggb2YgdGhlIHZhbHVlIG5lZWRzIHRvIGJlIG9wdGlv bmFsbHkKKyAgICAgICAgZXh0ZW5kZWQgdG8gNjQgYml0cyAoZS5nLiB0aGUgRUdMIHR5cGUgaXMg ImludCIgaW4gYSAzMi1iaXQgQ1BVKSBidXQgbm90IGZvciBwb2ludGVycywKKyAgICAgICAgYW5k IHVzaW5nICJyZWludGVycHJldF9jYXN0IiB3b3JrcyB3aGVuIHRoZSBzaXplIG9mIGEgcG9pbnRl ciBpcyA2NCBiaXRzIGJ1dCBub3QgaW4gb3RoZXIKKyAgICAgICAgY2FzZXMuIFRoZXJlZm9yZSBp dCBzZWVtcyByZWFzb25hYmxlIHRvIHVzZSBhIHBsYWluIEMgY2FzdCBleHByZXNzaW9uIHRvIHNv bHZlIHRoaXMKKyAgICAgICAgcGFydGljdWxhciBzaXR1YXRpb24uCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlBhZ2Uvd3BlL0FjY2VsZXJhdGVkU3VyZmFjZVdQRS5jcHA6CisgICAgICAgIChX ZWJLaXQ6OkFjY2VsZXJhdGVkU3VyZmFjZVdQRTo6d2luZG93IGNvbnN0KTogVXNlIGEgZ29vZCBv bGQgcGxhaW4gQyBjYXN0IGV4cHJlc3Npb24uCisKIDIwMTctMTAtMTAgIENvbW1pdCBRdWV1ZSAg PGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHIyMjMxMzAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFn ZS93cGUvQWNjZWxlcmF0ZWRTdXJmYWNlV1BFLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL3dwZS9BY2NlbGVyYXRlZFN1cmZhY2VXUEUuY3BwCmluZGV4IGNiZTg4ZGQ1YTg3 Mzk0OGE1OGVhYWYzY2IzZjkxYThiY2U5ODI2Y2QuLmYwZTY1MjFhNWYxMDBiZTA1NDQzY2UyMmE3 MGM3MjYwMmVjNzZhNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ YWdlL3dwZS9BY2NlbGVyYXRlZFN1cmZhY2VXUEUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2Vi UHJvY2Vzcy9XZWJQYWdlL3dwZS9BY2NlbGVyYXRlZFN1cmZhY2VXUEUuY3BwCkBAIC03NSw3ICs3 NSwxMiBAQCB2b2lkIEFjY2VsZXJhdGVkU3VyZmFjZVdQRTo6ZmluYWxpemUoKQogdWludDY0X3Qg QWNjZWxlcmF0ZWRTdXJmYWNlV1BFOjp3aW5kb3coKSBjb25zdAogewogICAgIEFTU0VSVChtX2Jh Y2tlbmQpOwotICAgIHJldHVybiByZWludGVycHJldF9jYXN0PHVpbnQ2NF90Pih3cGVfcmVuZGVy ZXJfYmFja2VuZF9lZ2xfdGFyZ2V0X2dldF9uYXRpdmVfd2luZG93KG1fYmFja2VuZCkpOworICAg IC8vIEVHTE5hdGl2ZVdpbmRvd1R5cGUgY2hhbmdlcyBkZXBlbmRpbmcgb24gdGhlIEVHTCBpbXBs ZW1lbnRhdGlvbjogcmVpbnRlcnByZXRfY2FzdCB3b3JrcworICAgIC8vIGZvciBwb2ludGVycyAo b25seSBpZiB0aGV5IGFyZSA2NC1iaXQgd2lkZSBhbmQgbm90IGZvciBvdGhlciBjYXNlcyksIGFu ZCBzdGF0aWNfY2FzdCBmb3IKKyAgICAvLyBudW1lcmljIHR5cGVzIChhbmQgd2hlbiBuZWVkZWQg dGhleSBnZXQgZXh0ZW5kZWQgdG8gNjQtYml0KSBidXQgbm90IGZvciBwb2ludGVycy4gVXNpbmcK KyAgICAvLyBhIHBsYWluIEMgY2FzdCBleHByZXNzaW9uIGluIHRoaXMgb25lIGluc3RhbmNlIHdv cmtzIGluIGFsbCBjYXNlcy4KKyAgICBzdGF0aWNfYXNzZXJ0KHNpemVvZihFR0xOYXRpdmVXaW5k b3dUeXBlKSA8PSBzaXplb2YodWludDY0X3QpLCAiRUdMTmF0aXZlV2luZG93VHlwZSBtdXN0IG5v dCBiZSBsb25nZXIgdGhhbiA2NCBiaXRzLiIpOworICAgIHJldHVybiAodWludDY0X3QpIHdwZV9y ZW5kZXJlcl9iYWNrZW5kX2VnbF90YXJnZXRfZ2V0X25hdGl2ZV93aW5kb3cobV9iYWNrZW5kKTsK IH0KIAogdWludDY0X3QgQWNjZWxlcmF0ZWRTdXJmYWNlV1BFOjpzdXJmYWNlSUQoKSBjb25zdAo=