17809 2008-03-12 14:33:37 -0700 Overload String::operator[] for integer types other than unsigned 2009-03-17 14:20:06 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Mac OS X 10.5 RESOLVED INVALID P2 Trivial --- 1 mark webkit-unassigned ap darin mjs oldest_to_newest 73516 0 mark 2008-03-12 14:33:37 -0700 I've found that using operator[ to subscript a String in EditorCommand.cpp fails, the compiler giving the following error: .../WebKit/WebCore/editing/EditorCommand.cpp: In function ‘bool WebCore::executeFormatBlock(WebCore::Frame*, WebCore::Event*, WebCore::EditorCommandSource, const WebCore::String&)’: .../WebKit/WebCore/editing/EditorCommand.cpp:387: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second: .../WebKit/WebCore/platform/text/PlatformString.h:72: note: candidate 1: UChar WebCore::String::operator[](unsigned int) const .../WebKit/WebCore/editing/EditorCommand.cpp:387: note: candidate 2: operator[](NSString*, int) <built-in> To resolve the ambiguity, I've used 0U instead of 0 to subscript the String in question. 73517 1 19714 mark 2008-03-12 14:35:25 -0700 Created attachment 19714 Use 0U instead of 0 73525 2 eric 2008-03-12 15:11:18 -0700 Ick. I hope there is some other way to avoid this error. 73577 3 19714 darin 2008-03-13 09:44:18 -0700 Comment on attachment 19714 Use 0U instead of 0 This should only be an issue in Objective-C++ files. The ambiguity comes from the operator NSString*() overload. Why are you seeing this ambiguity in a .cpp file? Are you trying to compile this file as ObjC++? 73578 4 19714 darin 2008-03-13 09:45:40 -0700 Comment on attachment 19714 Use 0U instead of 0 I'm going to mark this as review-. The real problem is that this file is being compiled with __OBJC__ defined -- you need to figure out why. 73579 5 darin 2008-03-13 09:47:34 -0700 Aside from the specific issues in this .cpp file, we can eliminate this ambiguity in ObjC++ files by overloading the String [] operator for integer types other than unsigned. But once we overload for any type other than unsigned, we'll need overloads for all the integer types we want to allow. Doing that overload would be nice for ObjC++ files -- should not be relevant for this file, though. 73610 6 mark 2008-03-13 11:38:07 -0700 Good catch, this file somehow got flipped to sourcecode.cpp.objcpp in my project. I've got a few other filetype things that I've verified do exist in the trunk WebCore.xcodeproj, I'll file separately for those, leaving this bug to be repurposed per comment 5 if desired. 73623 7 mark 2008-03-13 13:09:07 -0700 Filetype cleanup mentioned in comment 6 is bug 17833. 73758 8 mark 2008-03-14 12:11:29 -0700 I found other uses of 0U to disambiguate between the two choices for operator[] in platform/graphics/mac/IconMac.mm and platform/mac/KeyEvent.mm. 19714 2008-03-12 14:35:25 -0700 2008-03-13 13:08:44 -0700 Use 0U instead of 0 webkit-17809.1.patch text/plain 1175 mark SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMxMDA1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMDMt MTIgIE1hcmsgTWVudG92YWkgIDxtYXJrQG1veGllbmV0LmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGVkaXRpbmcvRWRpdG9yQ29tbWFuZC5j cHA6CisgICAgICAgIChXZWJDb3JlOjpleGVjdXRlRm9ybWF0QmxvY2spOiBTdWJzY3JpcHQgU3Ry aW5nIHVzaW5nIHVuc2lnbmVkIGludAorCXRvIGdldCB0aGUgcmlnaHQgb3BlcmF0b3JbIHVuZGVy IElTTyBhbWJpZ3VpdHkgcnVsZXMuCisKIDIwMDgtMDMtMTIgIERhdmlkIEh5YXR0ICA8aHlhdHRA YXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgdGhlIHpvb20gZmFjdG9yIGEgZmxvYXQgYW5kIG5v dCBhIHBlcmNlbnQuCiAKSW5kZXg6IGVkaXRpbmcvRWRpdG9yQ29tbWFuZC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gZWRpdGluZy9FZGl0b3JDb21tYW5kLmNwcAkocmV2aXNpb24gMzEwMDQpCisrKyBlZGl0 aW5nL0VkaXRvckNvbW1hbmQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zODUsNyArMzg1LDcgQEAg c3RhdGljIGJvb2wgZXhlY3V0ZUZvcmVDb2xvcihGcmFtZSogZnJhbQogc3RhdGljIGJvb2wgZXhl Y3V0ZUZvcm1hdEJsb2NrKEZyYW1lKiBmcmFtZSwgRXZlbnQqLCBFZGl0b3JDb21tYW5kU291cmNl LCBjb25zdCBTdHJpbmcmIHZhbHVlKQogewogICAgIFN0cmluZyB0YWdOYW1lID0gdmFsdWUubG93 ZXIoKTsKLSAgICBpZiAodGFnTmFtZVswXSA9PSAnPCcgJiYgdGFnTmFtZVt0YWdOYW1lLmxlbmd0 aCgpIC0gMV0gPT0gJz4nKQorICAgIGlmICh0YWdOYW1lWzBVXSA9PSAnPCcgJiYgdGFnTmFtZVt0 YWdOYW1lLmxlbmd0aCgpIC0gMV0gPT0gJz4nKQogICAgICAgICB0YWdOYW1lID0gdGFnTmFtZS5z dWJzdHJpbmcoMSwgdGFnTmFtZS5sZW5ndGgoKSAtIDIpOwogICAgIGlmICghdmFsaWRCbG9ja1Rh Zyh0YWdOYW1lKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwo=