178081 2017-10-09 08:16:23 -0700 [WPE][GTK] Propagate libepoxy compiler flags obtained from pkg-config 2017-10-09 09:05:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=175125 InRadar P2 Normal --- 1 aperez aperez achristensen clopez commit-queue dino fred.wang lforschler mcatanzaro sam webkit-bug-importer oldest_to_newest 1358233 0 aperez 2017-10-09 08:16:23 -0700 Similarly to what was done for bug #175125, we should use the value of the “Cflags” field from “epoxy.pc”. In most cases it will be empty, but the correct thing is respecting it. Example: changes like https://github.com/anholt/libepoxy/pull/113 may result in the “Cflags” field being populated, and it's better to make WebKit pick its value that being bitten by build failures in the future and/or in less desktop-y platforms. 1358234 1 323175 aperez 2017-10-09 08:21:09 -0700 Created attachment 323175 Patch 1358241 2 323175 commit-queue 2017-10-09 09:04:43 -0700 Comment on attachment 323175 Patch Clearing flags on attachment: 323175 Committed r223045: <http://trac.webkit.org/changeset/223045> 1358242 3 commit-queue 2017-10-09 09:04:45 -0700 All reviewed patches have been landed. Closing bug. 1358243 4 webkit-bug-importer 2017-10-09 09:05:19 -0700 <rdar://problem/34886578> 323175 2017-10-09 08:21:09 -0700 2017-10-09 09:04:43 -0700 Patch bug-178081-20171009172107.patch text/plain 3739 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTE5YmQyZWI3NmU3MDc0 NmViMzdjZTAzMjYwYTU1MmUzNTU5NTI1NC4uNTZjYjQ3MzJjMmQzODE2ZGZkNmJlYWJmOGM0ZTY5 ZDY3MzM0ODJiNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTEwLTA5ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dQRV1b R1RLXSBQcm9wYWdhdGUgbGliZXBveHkgY29tcGlsZXIgZmxhZ3Mgb2J0YWluZWQgZnJvbSBwa2ct Y29uZmlnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzgwODEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBO byBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6IFVzZSAke0xJ QkVQT1hZX0RFRklOSVRJT05TfSBmb3IgYnVpbGRpbmcgV2ViQ29yZS4KKwogMjAxNy0xMC0wOSAg Um9tYWluIEJlbGxlc3NvcnQgIDxyb21haW4uYmVsbGVzc29ydEBjcmYuY2Fub24uZnI+CiAKICAg ICAgICAgW1JlYWRhYmxlIFN0cmVhbXMgQVBJXSBJbXBsZW1lbnQgY2FuQ2xvc2VPckVucXVldWUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNzMzM2I2YzM5MTU5NmQ2MWZhMWIxNmFkMGUyOWRhMjFkYmYwYjliYy4uYzA3 NDg3M2MyZmY4OTczM2MyNmZmNTdkYTY3YTE0MzhlOTAyODI0OCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMiBAQAorMjAxNy0xMC0wOSAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10gUHJvcGFnYXRlIGxpYmVwb3h5IGNvbXBpbGVy IGZsYWdzIG9idGFpbmVkIGZyb20gcGtnLWNvbmZpZworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MDgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogVXNlICR7TElCRVBPWFlf REVGSU5JVElPTlN9IGZvciBidWlsZGluZyBXZWJLaXQuCisKIDIwMTctMTAtMDggIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgbWVkaWFQbGF5YmFja1Jl cXVpcmVzVXNlckFjdGlvbiBBUEkgcmVwbGFjZW1lbnQgYW5ub3RhdGlvbiBpcyB3cm9uZwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2ViQ29yZS9D TWFrZUxpc3RzLnR4dAppbmRleCAyZDc4NGI3MmRiOTQ3ZmE0NTMxOWQ4NGI2Y2M5MDllOWRkMmE2 YTkyLi44NWNjNzkwNTk2MzljOTU3OTRlOTczMzE3MmQ2NzJkZDYzMmQ1OTliIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29yZS9DTWFr ZUxpc3RzLnR4dApAQCAtMzQ4NSw2ICszNDg1LDcgQEAgaWYgKEVOQUJMRV9HUkFQSElDU19DT05U RVhUXzNEKQogICAgICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX0xJQlJBUklFUwogICAgICAgICAg ICAgJHtMSUJFUE9YWV9MSUJSQVJJRVN9CiAgICAgICAgICkKKyAgICAgICAgYWRkX2RlZmluaXRp b25zKCR7TElCRVBPWFlfREVGSU5JVElPTlN9KQogICAgIGVsc2UgKCkKICAgICAgICAgaWYgKFVT RV9PUEVOR0wpCiAgICAgICAgICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX1NZU1RFTV9JTkNMVURF X0RJUkVDVE9SSUVTCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0IGIv U291cmNlL1dlYktpdC9DTWFrZUxpc3RzLnR4dAppbmRleCBlNWQ0NzAxYmVmNWIxZjdhYTlkMDBj YWI4ZmVhNDMxYzIyZTUyYmFlLi5mMTk2ZmExODExMjE4ZTBiN2EwNzM0NTZmZjZlY2M0MzU2MGFm MWM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NNYWtlTGlzdHMudHh0CisrKyBiL1NvdXJj ZS9XZWJLaXQvQ01ha2VMaXN0cy50eHQKQEAgLTczNiw2ICs3MzYsNyBAQCBpZiAoRU5BQkxFX0dS QVBISUNTX0NPTlRFWFRfM0QpCiAgICAgICAgIGxpc3QoQVBQRU5EIFdlYktpdF9MSUJSQVJJRVMK ICAgICAgICAgICAgICR7TElCRVBPWFlfTElCUkFSSUVTfQogICAgICAgICApCisgICAgICAgIGFk ZF9kZWZpbml0aW9ucygke0xJQkVQT1hZX0RFRklOSVRJT05TfSkKICAgICBlbHNlICgpCiAgICAg ICAgIGlmIChVU0VfT1BFTkdMKQogICAgICAgICAgICAgbGlzdChBUFBFTkQgV2ViS2l0X1NZU1RF TV9JTkNMVURFX0RJUkVDVE9SSUVTCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvRmluZExpYkVw b3h5LmNtYWtlIGIvU291cmNlL2NtYWtlL0ZpbmRMaWJFcG94eS5jbWFrZQppbmRleCAzYmVmZjYz NGQxNjNiMDk0MDcyYzEzYjRiMjk3MDlmMGMyMTk2NzRjLi5lNTg5N2I1ZWYxOWU1Y2JkYjg2MGMw ZWNjMmQzZDdlYjBmYjI5N2QxIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvRmluZExpYkVwb3h5 LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9GaW5kTGliRXBveHkuY21ha2UKQEAgLTMwLDYgKzMw LDEwIEBACiBmaW5kX3BhY2thZ2UoUGtnQ29uZmlnKQogcGtnX2NoZWNrX21vZHVsZXMoUENfTElC RVBPWFkgUVVJRVQgZXBveHkpCiAKK2lmIChQQ19MSUJFUE9YWV9GT1VORCkKKyAgICBzZXQoTElC RVBPWFlfREVGSU5JVElPTlMgJHtQQ19MSUJFUE9YWV9DRkxBR1NfT1RIRVJ9KQorZW5kaWYgKCkK KwogZmluZF9wYXRoKExJQkVQT1hZX0lOQ0xVREVfRElSUwogICAgIE5BTUVTIGVwb3h5L2dsLmgK ICAgICBQQVRIUyAke1BDX0xJQkVQT1hZX0lOQ0xVREVESVJ9ICR7UENfTElCRVBPWFlfSU5DTFVE RV9ESVJTfQpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDMyNDBkZTlk YmE0Nzk1ZGRiZTFjYzQ3NzBjZjVlZTZkYzEyODkwY2MuLjJkNTNjYjNhMzU2ZDJmNDkxNGE1Mjhm ZjllNDRiNzNkOTc5YWNkZDIgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMyBAQAorMjAxNy0xMC0wOSAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFw ZXJlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW0dUS10gUHJvcGFnYXRlIGxpYmVwb3h5 IGNvbXBpbGVyIGZsYWdzIG9idGFpbmVkIGZyb20gcGtnLWNvbmZpZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MDgxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvRmluZExpYkVw b3h5LmNtYWtlOiBEZWZpbmUgdGhlICR7TElCRVBPWFlfREVGSU5JVElPTlN9IHZhcmlhYmxlIHdo ZW4gbGliZXBveHkKKyAgICAgICAgaXMgZm91bmQgYnkgcGtnLWNvbmZpZy4gVGhpcyBjb250YWlu cyB0aGUgdmFsdWUgb2YgdGhlICJDZmxhZ3MiIGZpZWxkIGZyb20gImVwb3h5LnBjIi4KKwogMjAx Ny0xMC0wNSAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+CiAKICAgICAgICAgUmVt b3ZlIFdPRkYyIGZyb20gU291cmNlL1RoaXJkUGFydHkuCg==