178079 2017-10-09 04:54:33 -0700 [GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc 2017-10-10 22:50:05 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 calvaris calvaris calvaris cgarcia commit-queue eocanha webkit-bug-importer zan oldest_to_newest 1358215 0 calvaris 2017-10-09 04:54:33 -0700 [GStreamer] Fix double seek requested by downloadbuffer GStreamer element in webkibwebsrc 1358216 1 323169 calvaris 2017-10-09 05:01:01 -0700 Created attachment 323169 Patch 1358706 2 323169 zan 2017-10-10 03:53:57 -0700 Comment on attachment 323169 Patch r=me if Quique approves. 1358733 3 323169 eocanha 2017-10-10 05:42:40 -0700 Comment on attachment 323169 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323169&action=review > Source/WebCore/ChangeLog:11 > + downloadbuffer element to seek bejond the file size, which causes "beyond" O:-) > Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:381 > + priv->seekable = FALSE; This change makes sense when webKitWebSrcStop() is called from https://github.com/WebKit/webkit/blob/f0e46ed/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp#L743 , but I was worried about what would happen when it's called from any of the other places which legitimate want to stop the element because of an error. However, after cheching all those places, they either can only happen before seeking is even possible (initial access control check, invalid url, change to GST_STATE_READY) or because of recoverable seek errors. Therefore there's no danger in this change and I support it. 1359044 4 323385 calvaris 2017-10-10 22:09:24 -0700 Created attachment 323385 Patch for landing 1359053 5 323385 commit-queue 2017-10-10 22:48:51 -0700 Comment on attachment 323385 Patch for landing Clearing flags on attachment: 323385 Committed r223168: <http://trac.webkit.org/changeset/223168> 1359054 6 commit-queue 2017-10-10 22:48:52 -0700 All reviewed patches have been landed. Closing bug. 1359057 7 webkit-bug-importer 2017-10-10 22:50:05 -0700 <rdar://problem/34927439> 323169 2017-10-09 05:01:01 -0700 2017-10-10 22:09:20 -0700 Patch bug-178079-20171009140059.patch text/plain 2415 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdlZmIzN2ZiZDQ0MjI2 NGYyY2ZlMzNlYTI4ZGE3ODUzYWQ0NmY1MC4uMGQwZDU0ZGM3OTgwMWI1MzdmOGMyNGI2NWUxZjkw NWUxYzI1ZjFlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTA5ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gRml4IGRvdWJsZSBzZWVrIHJlcXVlc3RlZCBieSBkb3dubG9hZGJ1ZmZlciBHU3Ry ZWFtZXIgZWxlbWVudCBpbiB3ZWJraWJ3ZWJzcmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODA3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gdGhlIGRvd25sb2FkYnVmZmVyIEdTdHJlYW1lciBl bGVtZW50IHJlcXVlc3RzIHR3byBzZWVrcyB0b28KKyAgICAgICAgY2xvc2UgdG8gZWFjaCBvdGhl ciB0aGVyZSdzIHNvbWUgcmFyZSByYWNlIGNvbmRpdGlvbiB3aGVyZSBvdXIKKyAgICAgICAgc291 cmNlIGFuc3dlcnMgdGhhdCBpdCBpcyBub3Qgc2Vla2FibGUgYW5kIGVuZHMgdXAgd2l0aAorICAg ICAgICBkb3dubG9hZGJ1ZmZlciBlbGVtZW50IHRvIHNlZWsgYmVqb25kIHRoZSBmaWxlIHNpemUs IHdoaWNoIGNhdXNlcworICAgICAgICB0aGUgc2VydmVyIHRvIGlzc3VlIGEgNDE2IEhUVFAgZXJy b3IgY29kZSBldmVudHVhbGx5LCBjYXVzaW5nIG91cgorICAgICAgICBNZWRpYVBsYXllciB0byBz dG9wLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNv dXJjZUdTdHJlYW1lci5jcHA6CisgICAgICAgICh3ZWJLaXRXZWJTcmNTdG9wKTogV2Ugb25seSB1 bnNldCBoZSBzZWVrYWJsZSBhdHRyaWJ1dGUgaWYgd2UgYXJlCisgICAgICAgIG5vdCBzZWVraW5n LgorCiAyMDE3LTEwLTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIGRyYWdlbnRlciBhbmQgZHJhZ2xlYXZlIHNob3VsZG4ndCB1c2UgdGhlIHNhbWUgZGF0YSB0 cmFuc2ZlciBvYmplY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5j cHAKaW5kZXggYjlkNTM5YjJiNzMyYjA1ZWM4YThiZDkyMGY2NDJiNDY1MWJiNWY4My4uOTVhZWMy OGQzZjQ4ZjBhZTg2ZDdjNWY2ZTlmM2YwZDlmYWY5YWIzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1l ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dl YktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTU4LDcgKzU4LDcgQEAgcHVibGljOgogICAg IHZpcnR1YWwgfkNhY2hlZFJlc291cmNlU3RyZWFtaW5nQ2xpZW50KCk7CiBwcml2YXRlOgogI2lm IFVTRShTT1VQKQotICAgIGNoYXIqIGdldE9yQ3JlYXRlUmVhZEJ1ZmZlcihQbGF0Zm9ybU1lZGlh UmVzb3VyY2UmLCBzaXplX3QgcmVxdWVzdGVkU2l6ZSwgc2l6ZV90JiBhY3R1YWxTaXplKTsKKyAg ICBjaGFyKiBnZXRPckNyZWF0ZVJlYWRCdWZmZXIoUGxhdGZvcm1NZWRpYVJlc291cmNlJiwgc2l6 ZV90IHJlcXVlc3RlZFNpemUsIHNpemVfdCYgYWN0dWFsU2l6ZSkgb3ZlcnJpZGU7CiAjZW5kaWYK ICAgICAvLyBQbGF0Zm9ybU1lZGlhUmVzb3VyY2VDbGllbnQgdmlydHVhbCBtZXRob2RzLgogICAg IHZvaWQgcmVzcG9uc2VSZWNlaXZlZChQbGF0Zm9ybU1lZGlhUmVzb3VyY2UmLCBjb25zdCBSZXNv dXJjZVJlc3BvbnNlJikgb3ZlcnJpZGU7CkBAIC0zNzMsMTIgKzM3MywxMiBAQCBzdGF0aWMgdm9p ZCB3ZWJLaXRXZWJTcmNTdG9wKFdlYktpdFdlYlNyYyogc3JjKQogICAgIHByaXYtPnBhdXNlZCA9 IGZhbHNlOwogCiAgICAgcHJpdi0+b2Zmc2V0ID0gMDsKLSAgICBwcml2LT5zZWVrYWJsZSA9IEZB TFNFOwogCiAgICAgaWYgKCF3YXNTZWVraW5nKSB7CiAgICAgICAgIHByaXYtPnNpemUgPSAwOwog ICAgICAgICBwcml2LT5yZXF1ZXN0ZWRPZmZzZXQgPSAwOwogICAgICAgICBwcml2LT5wbGF5ZXIg PSBudWxscHRyOworICAgICAgICBwcml2LT5zZWVrYWJsZSA9IEZBTFNFOwogICAgIH0KIAogICAg IGlmIChwcml2LT5hcHBzcmMpIHsK 323385 2017-10-10 22:09:24 -0700 2017-10-10 22:48:51 -0700 Patch for landing bug-178079-20171011070922.patch text/plain 2415 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjIzMDMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdlZmIzN2ZiZDQ0MjI2 NGYyY2ZlMzNlYTI4ZGE3ODUzYWQ0NmY1MC4uMWZhMTViZjkyZDgyMTkzZDlmZmFiNGY5MjcwMjlh NjhhNjk4ZDJlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTA5ICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl0gRml4IGRvdWJsZSBzZWVrIHJlcXVlc3RlZCBieSBkb3dubG9hZGJ1ZmZlciBHU3Ry ZWFtZXIgZWxlbWVudCBpbiB3ZWJraWJ3ZWJzcmMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODA3OQorCisgICAgICAgIFJldmlld2VkIGJ5IMW9YW4g RG9iZXLFoWVrLgorCisgICAgICAgIFdoZW4gdGhlIGRvd25sb2FkYnVmZmVyIEdTdHJlYW1lciBl bGVtZW50IHJlcXVlc3RzIHR3byBzZWVrcyB0b28KKyAgICAgICAgY2xvc2UgdG8gZWFjaCBvdGhl ciB0aGVyZSdzIHNvbWUgcmFyZSByYWNlIGNvbmRpdGlvbiB3aGVyZSBvdXIKKyAgICAgICAgc291 cmNlIGFuc3dlcnMgdGhhdCBpdCBpcyBub3Qgc2Vla2FibGUgYW5kIGVuZHMgdXAgd2l0aAorICAg ICAgICBkb3dubG9hZGJ1ZmZlciBlbGVtZW50IHRvIHNlZWsgYmV5b25kIHRoZSBmaWxlIHNpemUs IHdoaWNoIGNhdXNlcworICAgICAgICB0aGUgc2VydmVyIHRvIGlzc3VlIGEgNDE2IEhUVFAgZXJy b3IgY29kZSBldmVudHVhbGx5LCBjYXVzaW5nIG91cgorICAgICAgICBNZWRpYVBsYXllciB0byBz dG9wLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNv dXJjZUdTdHJlYW1lci5jcHA6CisgICAgICAgICh3ZWJLaXRXZWJTcmNTdG9wKTogV2Ugb25seSB1 bnNldCBoZSBzZWVrYWJsZSBhdHRyaWJ1dGUgaWYgd2UgYXJlCisgICAgICAgIG5vdCBzZWVraW5n LgorCiAyMDE3LTEwLTA4ICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAg ICAgIGRyYWdlbnRlciBhbmQgZHJhZ2xlYXZlIHNob3VsZG4ndCB1c2UgdGhlIHNhbWUgZGF0YSB0 cmFuc2ZlciBvYmplY3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9XZWJLaXRXZWJTb3VyY2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1lci5j cHAKaW5kZXggYjlkNTM5YjJiNzMyYjA1ZWM4YThiZDkyMGY2NDJiNDY1MWJiNWY4My4uOTVhZWMy OGQzZjQ4ZjBhZTg2ZDdjNWY2ZTlmM2YwZDlmYWY5YWIzYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdFdlYlNvdXJjZUdTdHJlYW1l ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dl YktpdFdlYlNvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTU4LDcgKzU4LDcgQEAgcHVibGljOgogICAg IHZpcnR1YWwgfkNhY2hlZFJlc291cmNlU3RyZWFtaW5nQ2xpZW50KCk7CiBwcml2YXRlOgogI2lm IFVTRShTT1VQKQotICAgIGNoYXIqIGdldE9yQ3JlYXRlUmVhZEJ1ZmZlcihQbGF0Zm9ybU1lZGlh UmVzb3VyY2UmLCBzaXplX3QgcmVxdWVzdGVkU2l6ZSwgc2l6ZV90JiBhY3R1YWxTaXplKTsKKyAg ICBjaGFyKiBnZXRPckNyZWF0ZVJlYWRCdWZmZXIoUGxhdGZvcm1NZWRpYVJlc291cmNlJiwgc2l6 ZV90IHJlcXVlc3RlZFNpemUsIHNpemVfdCYgYWN0dWFsU2l6ZSkgb3ZlcnJpZGU7CiAjZW5kaWYK ICAgICAvLyBQbGF0Zm9ybU1lZGlhUmVzb3VyY2VDbGllbnQgdmlydHVhbCBtZXRob2RzLgogICAg IHZvaWQgcmVzcG9uc2VSZWNlaXZlZChQbGF0Zm9ybU1lZGlhUmVzb3VyY2UmLCBjb25zdCBSZXNv dXJjZVJlc3BvbnNlJikgb3ZlcnJpZGU7CkBAIC0zNzMsMTIgKzM3MywxMiBAQCBzdGF0aWMgdm9p ZCB3ZWJLaXRXZWJTcmNTdG9wKFdlYktpdFdlYlNyYyogc3JjKQogICAgIHByaXYtPnBhdXNlZCA9 IGZhbHNlOwogCiAgICAgcHJpdi0+b2Zmc2V0ID0gMDsKLSAgICBwcml2LT5zZWVrYWJsZSA9IEZB TFNFOwogCiAgICAgaWYgKCF3YXNTZWVraW5nKSB7CiAgICAgICAgIHByaXYtPnNpemUgPSAwOwog ICAgICAgICBwcml2LT5yZXF1ZXN0ZWRPZmZzZXQgPSAwOwogICAgICAgICBwcml2LT5wbGF5ZXIg PSBudWxscHRyOworICAgICAgICBwcml2LT5zZWVrYWJsZSA9IEZBTFNFOwogICAgIH0KIAogICAg IGlmIChwcml2LT5hcHBzcmMpIHsK