178074 2017-10-09 02:20:12 -0700 [MSE][GStreamer] Add dump of append pipeline 2017-10-11 02:33:51 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aboya webkit-unassigned bugs-noreply calvaris commit-queue eocanha Ms2ger oldest_to_newest 1358196 0 aboya 2017-10-09 02:20:12 -0700 Pipeline dumps are very useful for debugging. Right now we have one for PlaybackPipeline but none for AppendPipeline. 1358199 1 323164 aboya 2017-10-09 02:45:48 -0700 Created attachment 323164 Patch 1358203 2 323164 eocanha 2017-10-09 03:16:09 -0700 Comment on attachment 323164 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323164&action=review > Source/WebCore/ChangeLog:3 > + [GTK][MSE] Add dump of append pipeline The whole patch looks very good. I would just rename the bug to "[MSE][GStreamer] ..." because it applies to all GStreamer ports (GTK, WPE or any other in the future). 1358205 3 323164 calvaris 2017-10-09 03:23:41 -0700 Comment on attachment 323164 Patch I agree with Enrique. This said, the patch is good enough and we can land it provided that you create a bug (and fix if if you can) to rework the way we subscribe and unsubscribe to signals in this and other pipelines. First. we should subscribe with lambdas. Second, we should unsubscribe with the by_data function instead of the by_func one. That way, as we always pass this as user_data, we'll always unsubscribe from stuff even when we haven't done it explicitly for all functions (and we won't need declared functions, lambdas will suffice). 1358206 4 323165 aboya 2017-10-09 03:32:32 -0700 Created attachment 323165 Patch 1358212 5 323165 calvaris 2017-10-09 04:12:00 -0700 Comment on attachment 323165 Patch By request of Alicia, we set cq- because she can't check the landing now. 1359098 6 323165 commit-queue 2017-10-11 02:33:49 -0700 Comment on attachment 323165 Patch Clearing flags on attachment: 323165 Committed r223172: <http://trac.webkit.org/changeset/223172> 1359099 7 commit-queue 2017-10-11 02:33:51 -0700 All reviewed patches have been landed. Closing bug. 323164 2017-10-09 02:45:48 -0700 2017-10-09 03:32:26 -0700 Patch bug-178074-20171009114547.patch text/plain 4146 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE1NjcwNTEwMDYyNGM0 Zjk5MGE2Nzk5ZjhlNDk4MmZmMzg0YmMzYi4uMTllNjU1MDc5NDQ2Zjk3OGNiYzgxZTEyYTNmMWUw YWI1MjU1ZDkwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEwLTA5ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtNU0Vd IEFkZCBkdW1wIG9mIGFwcGVuZCBwaXBlbGluZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MDc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIGR1bXAgb2YgQXBwZW5kUGlwZWxpbmUuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBpcGVsaW5lLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OmFwcGVuZFBpcGVsaW5lU3RhdGVDaGFuZ2VNZXNzYWdlQ2Fs bGJhY2spOgorICAgICAgICAoV2ViQ29yZTo6QXBwZW5kUGlwZWxpbmU6OkFwcGVuZFBpcGVsaW5l KToKKyAgICAgICAgKFdlYkNvcmU6OkFwcGVuZFBpcGVsaW5lOjpoYW5kbGVTdGF0ZUNoYW5nZU1l c3NhZ2UpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5k UGlwZWxpbmUuaDoKKwogMjAxNy0xMC0wMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9y Zz4KIAogICAgICAgICBQYXN0ZWJvYXJkIHNob3VsZG4ndCBhZGQgIkZpbGVzIiBhcyBhIHR5cGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9t c2UvQXBwZW5kUGlwZWxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKaW5kZXggYmQ2NDg5ODYxYjRhZTQ3Y2Y2 NmZiNGRjNGY0Yzc3NzRlNWNiY2E4Mi4uM2VhZDdkNGIxZDhiZjU1MzI3OTEwOGNmNTU4NmY5NTI5 ZjQ1OWRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKQEAgLTEwMCw2ICsx MDAsMTEgQEAgc3RhdGljIHZvaWQgYXBwZW5kUGlwZWxpbmVFbGVtZW50TWVzc2FnZUNhbGxiYWNr KEdzdEJ1cyosIEdzdE1lc3NhZ2UqIG1lc3NhZ2UsIEEKIH0KICNlbmRpZgogCitzdGF0aWMgdm9p ZCBhcHBlbmRQaXBlbGluZVN0YXRlQ2hhbmdlTWVzc2FnZUNhbGxiYWNrKEdzdEJ1cyosIEdzdE1l c3NhZ2UqIG1lc3NhZ2UsIEFwcGVuZFBpcGVsaW5lKiBhcHBlbmRQaXBlbGluZSkKK3sKKyAgICBh cHBlbmRQaXBlbGluZS0+aGFuZGxlU3RhdGVDaGFuZ2VNZXNzYWdlKG1lc3NhZ2UpOworfQorCiBB cHBlbmRQaXBlbGluZTo6QXBwZW5kUGlwZWxpbmUoUmVmPE1lZGlhU291cmNlQ2xpZW50R1N0cmVh bWVyTVNFPiBtZWRpYVNvdXJjZUNsaWVudCwgUmVmPFNvdXJjZUJ1ZmZlclByaXZhdGVHU3RyZWFt ZXI+IHNvdXJjZUJ1ZmZlclByaXZhdGUsIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck1TRSYg cGxheWVyUHJpdmF0ZSkKICAgICA6IG1fbWVkaWFTb3VyY2VDbGllbnQobWVkaWFTb3VyY2VDbGll bnQuZ2V0KCkpCiAgICAgLCBtX3NvdXJjZUJ1ZmZlclByaXZhdGUoc291cmNlQnVmZmVyUHJpdmF0 ZS5nZXQoKSkKQEAgLTEyOSw2ICsxMzQsNyBAQCBBcHBlbmRQaXBlbGluZTo6QXBwZW5kUGlwZWxp bmUoUmVmPE1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyTVNFPiBtZWRpYVNvdXJjZUNsaQogI2lm IEVOQUJMRShFTkNSWVBURURfTUVESUEpCiAgICAgZ19zaWduYWxfY29ubmVjdChtX2J1cy5nZXQo KSwgIm1lc3NhZ2U6OmVsZW1lbnQiLCBHX0NBTExCQUNLKGFwcGVuZFBpcGVsaW5lRWxlbWVudE1l c3NhZ2VDYWxsYmFjayksIHRoaXMpOwogI2VuZGlmCisgICAgZ19zaWduYWxfY29ubmVjdChtX2J1 cy5nZXQoKSwgIm1lc3NhZ2U6OnN0YXRlLWNoYW5nZWQiLCBHX0NBTExCQUNLKGFwcGVuZFBpcGVs aW5lU3RhdGVDaGFuZ2VNZXNzYWdlQ2FsbGJhY2spLCB0aGlzKTsKIAogICAgIC8vIFdlIGFzc2ln biB0aGUgY3JlYXRlZCBpbnN0YW5jZXMgaGVyZSBpbnN0ZWFkIG9mIGFkb3B0UmVmKCkgYmVjYXVz ZSBnc3RfYmluX2FkZF9tYW55KCkKICAgICAvLyBiZWxvdyB3aWxsIGFscmVhZHkgdGFrZSB0aGUg aW5pdGlhbCByZWZlcmVuY2UgYW5kIHdlIG5lZWQgYW4gYWRkaXRpb25hbCBvbmUgZm9yIHVzLgpA QCAtMzQyLDYgKzM0OCwyNCBAQCB2b2lkIEFwcGVuZFBpcGVsaW5lOjpoYW5kbGVFbGVtZW50TWVz c2FnZShHc3RNZXNzYWdlKiBtZXNzYWdlKQogfQogI2VuZGlmCiAKK3ZvaWQgQXBwZW5kUGlwZWxp bmU6OmhhbmRsZVN0YXRlQ2hhbmdlTWVzc2FnZShHc3RNZXNzYWdlKiBtZXNzYWdlKQoreworICAg IEFTU0VSVChXVEY6OmlzTWFpblRocmVhZCgpKTsKKworICAgIGlmIChHU1RfTUVTU0FHRV9TUkMo bWVzc2FnZSkgPT0gcmVpbnRlcnByZXRfY2FzdDxHc3RPYmplY3QqPihtX3BpcGVsaW5lLmdldCgp KSkgeworICAgICAgICBHc3RTdGF0ZSBjdXJyZW50U3RhdGUsIG5ld1N0YXRlOworICAgICAgICBn c3RfbWVzc2FnZV9wYXJzZV9zdGF0ZV9jaGFuZ2VkKG1lc3NhZ2UsICZjdXJyZW50U3RhdGUsICZu ZXdTdGF0ZSwgbnVsbHB0cik7CisgICAgICAgIENTdHJpbmcgc291cmNlQnVmZmVyVHlwZSA9IFN0 cmluZyhtX3NvdXJjZUJ1ZmZlclByaXZhdGUtPnR5cGUoKS5yYXcoKSkKKyAgICAgICAgICAgIC5y ZXBsYWNlKCIvIiwgIl8iKS5yZXBsYWNlKCIgIiwgIl8iKQorICAgICAgICAgICAgLnJlcGxhY2Uo IlwiIiwgIiIpLnJlcGxhY2UoIlwnIiwgIiIpLnV0ZjgoKTsKKyAgICAgICAgQ1N0cmluZyBkb3RG aWxlTmFtZSA9IFN0cmluZzo6Zm9ybWF0KCJ3ZWJraXQtYXBwZW5kLSVzLSVzXyVzIiwKKyAgICAg ICAgICAgIHNvdXJjZUJ1ZmZlclR5cGUuZGF0YSgpLAorICAgICAgICAgICAgZ3N0X2VsZW1lbnRf c3RhdGVfZ2V0X25hbWUoY3VycmVudFN0YXRlKSwKKyAgICAgICAgICAgIGdzdF9lbGVtZW50X3N0 YXRlX2dldF9uYW1lKG5ld1N0YXRlKSkudXRmOCgpOworICAgICAgICBHU1RfREVCVUdfQklOX1RP X0RPVF9GSUxFX1dJVEhfVFMoR1NUX0JJTihtX3BpcGVsaW5lLmdldCgpKSwgR1NUX0RFQlVHX0dS QVBIX1NIT1dfQUxMLCBkb3RGaWxlTmFtZS5kYXRhKCkpOworICAgIH0KK30KKwogdm9pZCBBcHBl bmRQaXBlbGluZTo6aGFuZGxlQXBwc3JjTmVlZERhdGFSZWNlaXZlZCgpCiB7CiAgICAgaWYgKCFt X2FwcHNyY0F0TGVhc3RBQnVmZmVyTGVmdCkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5oIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5o CmluZGV4IDViMTcxNWFmZjQ3MWRhMTg4MzkyOTgxMDcwNjA1NjFiZWY5M2Q4ODEuLjI1Y2IzYmVk NTQxNjMzMDk1YjFjZmU2MzAyYmUxNGI0MTUyNDUyNDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBp cGVsaW5lLmgKQEAgLTUwLDYgKzUwLDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBoYW5kbGVOZWVk Q29udGV4dFN5bmNNZXNzYWdlKEdzdE1lc3NhZ2UqKTsKICAgICB2b2lkIGhhbmRsZUFwcGxpY2F0 aW9uTWVzc2FnZShHc3RNZXNzYWdlKik7CisgICAgdm9pZCBoYW5kbGVTdGF0ZUNoYW5nZU1lc3Nh Z2UoR3N0TWVzc2FnZSopOwogI2lmIEVOQUJMRShFTkNSWVBURURfTUVESUEpCiAgICAgdm9pZCBo YW5kbGVFbGVtZW50TWVzc2FnZShHc3RNZXNzYWdlKik7CiAjZW5kaWYK 323165 2017-10-09 03:32:32 -0700 2017-10-11 02:33:49 -0700 Patch bug-178074-20171009123231.patch text/plain 4152 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDE1NjcwNTEwMDYyNGM0 Zjk5MGE2Nzk5ZjhlNDk4MmZmMzg0YmMzYi4uNzBmZGFmZTZkNzk3YmIwN2VmNTY5ZDk0YTVlYmIw ZThmNWIzZGIzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTEwLTA5ICBBbGlj aWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbTVNFXVtHU3Ry ZWFtZXJdIEFkZCBkdW1wIG9mIGFwcGVuZCBwaXBlbGluZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MDc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5hYmxlIGR1bXAgb2YgQXBwZW5kUGlwZWxpbmUu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL0FwcGVuZFBpcGVs aW5lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmFwcGVuZFBpcGVsaW5lU3RhdGVDaGFuZ2VNZXNz YWdlQ2FsbGJhY2spOgorICAgICAgICAoV2ViQ29yZTo6QXBwZW5kUGlwZWxpbmU6OkFwcGVuZFBp cGVsaW5lKToKKyAgICAgICAgKFdlYkNvcmU6OkFwcGVuZFBpcGVsaW5lOjpoYW5kbGVTdGF0ZUNo YW5nZU1lc3NhZ2UpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2Uv QXBwZW5kUGlwZWxpbmUuaDoKKwogMjAxNy0xMC0wMSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBQYXN0ZWJvYXJkIHNob3VsZG4ndCBhZGQgIkZpbGVzIiBhcyBh IHR5cGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9tc2UvQXBwZW5kUGlwZWxpbmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKaW5kZXggYmQ2NDg5ODYxYjRh ZTQ3Y2Y2NmZiNGRjNGY0Yzc3NzRlNWNiY2E4Mi4uM2VhZDdkNGIxZDhiZjU1MzI3OTEwOGNmNTU4 NmY5NTI5ZjQ1OWRlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5jcHAKQEAgLTEw MCw2ICsxMDAsMTEgQEAgc3RhdGljIHZvaWQgYXBwZW5kUGlwZWxpbmVFbGVtZW50TWVzc2FnZUNh bGxiYWNrKEdzdEJ1cyosIEdzdE1lc3NhZ2UqIG1lc3NhZ2UsIEEKIH0KICNlbmRpZgogCitzdGF0 aWMgdm9pZCBhcHBlbmRQaXBlbGluZVN0YXRlQ2hhbmdlTWVzc2FnZUNhbGxiYWNrKEdzdEJ1cyos IEdzdE1lc3NhZ2UqIG1lc3NhZ2UsIEFwcGVuZFBpcGVsaW5lKiBhcHBlbmRQaXBlbGluZSkKK3sK KyAgICBhcHBlbmRQaXBlbGluZS0+aGFuZGxlU3RhdGVDaGFuZ2VNZXNzYWdlKG1lc3NhZ2UpOwor fQorCiBBcHBlbmRQaXBlbGluZTo6QXBwZW5kUGlwZWxpbmUoUmVmPE1lZGlhU291cmNlQ2xpZW50 R1N0cmVhbWVyTVNFPiBtZWRpYVNvdXJjZUNsaWVudCwgUmVmPFNvdXJjZUJ1ZmZlclByaXZhdGVH U3RyZWFtZXI+IHNvdXJjZUJ1ZmZlclByaXZhdGUsIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ck1TRSYgcGxheWVyUHJpdmF0ZSkKICAgICA6IG1fbWVkaWFTb3VyY2VDbGllbnQobWVkaWFTb3Vy Y2VDbGllbnQuZ2V0KCkpCiAgICAgLCBtX3NvdXJjZUJ1ZmZlclByaXZhdGUoc291cmNlQnVmZmVy UHJpdmF0ZS5nZXQoKSkKQEAgLTEyOSw2ICsxMzQsNyBAQCBBcHBlbmRQaXBlbGluZTo6QXBwZW5k UGlwZWxpbmUoUmVmPE1lZGlhU291cmNlQ2xpZW50R1N0cmVhbWVyTVNFPiBtZWRpYVNvdXJjZUNs aQogI2lmIEVOQUJMRShFTkNSWVBURURfTUVESUEpCiAgICAgZ19zaWduYWxfY29ubmVjdChtX2J1 cy5nZXQoKSwgIm1lc3NhZ2U6OmVsZW1lbnQiLCBHX0NBTExCQUNLKGFwcGVuZFBpcGVsaW5lRWxl bWVudE1lc3NhZ2VDYWxsYmFjayksIHRoaXMpOwogI2VuZGlmCisgICAgZ19zaWduYWxfY29ubmVj dChtX2J1cy5nZXQoKSwgIm1lc3NhZ2U6OnN0YXRlLWNoYW5nZWQiLCBHX0NBTExCQUNLKGFwcGVu ZFBpcGVsaW5lU3RhdGVDaGFuZ2VNZXNzYWdlQ2FsbGJhY2spLCB0aGlzKTsKIAogICAgIC8vIFdl IGFzc2lnbiB0aGUgY3JlYXRlZCBpbnN0YW5jZXMgaGVyZSBpbnN0ZWFkIG9mIGFkb3B0UmVmKCkg YmVjYXVzZSBnc3RfYmluX2FkZF9tYW55KCkKICAgICAvLyBiZWxvdyB3aWxsIGFscmVhZHkgdGFr ZSB0aGUgaW5pdGlhbCByZWZlcmVuY2UgYW5kIHdlIG5lZWQgYW4gYWRkaXRpb25hbCBvbmUgZm9y IHVzLgpAQCAtMzQyLDYgKzM0OCwyNCBAQCB2b2lkIEFwcGVuZFBpcGVsaW5lOjpoYW5kbGVFbGVt ZW50TWVzc2FnZShHc3RNZXNzYWdlKiBtZXNzYWdlKQogfQogI2VuZGlmCiAKK3ZvaWQgQXBwZW5k UGlwZWxpbmU6OmhhbmRsZVN0YXRlQ2hhbmdlTWVzc2FnZShHc3RNZXNzYWdlKiBtZXNzYWdlKQor eworICAgIEFTU0VSVChXVEY6OmlzTWFpblRocmVhZCgpKTsKKworICAgIGlmIChHU1RfTUVTU0FH RV9TUkMobWVzc2FnZSkgPT0gcmVpbnRlcnByZXRfY2FzdDxHc3RPYmplY3QqPihtX3BpcGVsaW5l LmdldCgpKSkgeworICAgICAgICBHc3RTdGF0ZSBjdXJyZW50U3RhdGUsIG5ld1N0YXRlOworICAg ICAgICBnc3RfbWVzc2FnZV9wYXJzZV9zdGF0ZV9jaGFuZ2VkKG1lc3NhZ2UsICZjdXJyZW50U3Rh dGUsICZuZXdTdGF0ZSwgbnVsbHB0cik7CisgICAgICAgIENTdHJpbmcgc291cmNlQnVmZmVyVHlw ZSA9IFN0cmluZyhtX3NvdXJjZUJ1ZmZlclByaXZhdGUtPnR5cGUoKS5yYXcoKSkKKyAgICAgICAg ICAgIC5yZXBsYWNlKCIvIiwgIl8iKS5yZXBsYWNlKCIgIiwgIl8iKQorICAgICAgICAgICAgLnJl cGxhY2UoIlwiIiwgIiIpLnJlcGxhY2UoIlwnIiwgIiIpLnV0ZjgoKTsKKyAgICAgICAgQ1N0cmlu ZyBkb3RGaWxlTmFtZSA9IFN0cmluZzo6Zm9ybWF0KCJ3ZWJraXQtYXBwZW5kLSVzLSVzXyVzIiwK KyAgICAgICAgICAgIHNvdXJjZUJ1ZmZlclR5cGUuZGF0YSgpLAorICAgICAgICAgICAgZ3N0X2Vs ZW1lbnRfc3RhdGVfZ2V0X25hbWUoY3VycmVudFN0YXRlKSwKKyAgICAgICAgICAgIGdzdF9lbGVt ZW50X3N0YXRlX2dldF9uYW1lKG5ld1N0YXRlKSkudXRmOCgpOworICAgICAgICBHU1RfREVCVUdf QklOX1RPX0RPVF9GSUxFX1dJVEhfVFMoR1NUX0JJTihtX3BpcGVsaW5lLmdldCgpKSwgR1NUX0RF QlVHX0dSQVBIX1NIT1dfQUxMLCBkb3RGaWxlTmFtZS5kYXRhKCkpOworICAgIH0KK30KKwogdm9p ZCBBcHBlbmRQaXBlbGluZTo6aGFuZGxlQXBwc3JjTmVlZERhdGFSZWNlaXZlZCgpCiB7CiAgICAg aWYgKCFtX2FwcHNyY0F0TGVhc3RBQnVmZmVyTGVmdCkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBlbGluZS5oIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL21zZS9BcHBlbmRQaXBl bGluZS5oCmluZGV4IDViMTcxNWFmZjQ3MWRhMTg4MzkyOTgxMDcwNjA1NjFiZWY5M2Q4ODEuLjI1 Y2IzYmVkNTQxNjMzMDk1YjFjZmU2MzAyYmUxNGI0MTUyNDUyNDIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9tc2UvQXBwZW5kUGlwZWxpbmUu aAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvbXNlL0Fw cGVuZFBpcGVsaW5lLmgKQEAgLTUwLDYgKzUwLDcgQEAgcHVibGljOgogCiAgICAgdm9pZCBoYW5k bGVOZWVkQ29udGV4dFN5bmNNZXNzYWdlKEdzdE1lc3NhZ2UqKTsKICAgICB2b2lkIGhhbmRsZUFw cGxpY2F0aW9uTWVzc2FnZShHc3RNZXNzYWdlKik7CisgICAgdm9pZCBoYW5kbGVTdGF0ZUNoYW5n ZU1lc3NhZ2UoR3N0TWVzc2FnZSopOwogI2lmIEVOQUJMRShFTkNSWVBURURfTUVESUEpCiAgICAg dm9pZCBoYW5kbGVFbGVtZW50TWVzc2FnZShHc3RNZXNzYWdlKik7CiAjZW5kaWYK