178068 2017-10-08 15:04:13 -0700 Web Inspector: add autocompletion for min/max within a CSS calc 2017-10-08 18:11:37 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1358130 0 hi 2017-10-08 15:04:13 -0700 When typing the following width: calc(m| we should show autocompletions for "min()" and "max()", as they are now supported for CSS calc. 1358131 1 323145 hi 2017-10-08 15:04:58 -0700 Created attachment 323145 Patch 1358140 2 323145 joepeck 2017-10-08 15:25:18 -0700 Comment on attachment 323145 Patch Heh, I did this the other day and decided against it. I can't remember my reasons though, so lets do it. Can calc be recursive? So should calc be in this list? 1358144 3 323148 hi 2017-10-08 16:33:04 -0700 Created attachment 323148 Patch 1358158 4 323148 commit-queue 2017-10-08 18:10:47 -0700 Comment on attachment 323148 Patch Clearing flags on attachment: 323148 Committed r223038: <http://trac.webkit.org/changeset/223038> 1358159 5 commit-queue 2017-10-08 18:10:48 -0700 All reviewed patches have been landed. Closing bug. 1358160 6 webkit-bug-importer 2017-10-08 18:11:37 -0700 <rdar://problem/34877729> 323145 2017-10-08 15:04:58 -0700 2017-10-08 16:33:02 -0700 Patch bug-178068-20171008150457.patch text/plain 1634 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI1OGExNzY0N2JkMTU0M2ViMTY3ZTlhYzBiNjhj MjNmYWIyNzNlMWEuLjgxYTM1Y2I2YWU3Mjk1ODI5ZWMzNzQxZWY3OTIyMDQxN2YzMzk4ZDggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTEwLTA4ICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGFkZCBhdXRvY29tcGxldGlvbiBmb3IgbWluL21heCB3aXRoaW4gYSBDU1MgY2FsYworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MDY4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJm YWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMuanM6CisgICAgICAgIChXSS5DU1NLZXl3 b3JkQ29tcGxldGlvbnMuZm9yRnVuY3Rpb24pOgorCiAyMDE3LTEwLTA2ICBNYXR0IEJha2VyICA8 bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBBZGQgQ2FudmFz IHRhYiBhbmQgQ2FudmFzT3ZlcnZpZXdDb250ZW50VmlldwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3Jk Q29tcGxldGlvbnMuanMKaW5kZXggZGJiOTdjMGYzNGRhYTEyYmNiZGZmMjExMDYzZmE4MDgyOGY2 Nzg2Mi4uMGRlOGM5OTI1YzU3N2UzYjdkZTU4NjRhYjg4MTY3MDZlNDBjNDVlMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NTU0tleXdvcmRD b21wbGV0aW9ucy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9N b2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzCkBAIC02OCw2ICs2OCw4IEBAIFdJLkNTU0tl eXdvcmRDb21wbGV0aW9ucy5mb3JGdW5jdGlvbiA9IGZ1bmN0aW9uKGZ1bmN0aW9uTmFtZSkKIAog ICAgIGlmIChmdW5jdGlvbk5hbWUgPT09ICJ2YXIiKQogICAgICAgICBzdWdnZXN0aW9ucyA9IFtd OworICAgIGVsc2UgaWYgKGZ1bmN0aW9uTmFtZSA9PT0gImNhbGMiIHx8IGZ1bmN0aW9uTmFtZSA9 PT0gIm1pbiIgfHwgZnVuY3Rpb25OYW1lID09PSAibWF4IikKKyAgICAgICAgc3VnZ2VzdGlvbnMg PSBzdWdnZXN0aW9ucy5jb25jYXQoWyJtaW4oKSIsICJtYXgoKSJdKTsKICAgICBlbHNlIGlmIChm dW5jdGlvbk5hbWUgPT0gImVudiIpCiAgICAgICAgIHN1Z2dlc3Rpb25zID0gc3VnZ2VzdGlvbnMu Y29uY2F0KFsic2FmZS1hcmVhLWluc2V0LXRvcCIsICJzYWZlLWFyZWEtaW5zZXQtcmlnaHQiLCAi c2FmZS1hcmVhLWluc2V0LWJvdHRvbSIsICJzYWZlLWFyZWEtaW5zZXQtbGVmdCJdKTsKICAgICBl bHNlIGlmIChmdW5jdGlvbk5hbWUgPT09ICJpbWFnZS1zZXQiKQo= 323148 2017-10-08 16:33:04 -0700 2017-10-08 18:10:47 -0700 Patch bug-178068-20171008163303.patch text/plain 1645 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI1OGExNzY0N2JkMTU0M2ViMTY3ZTlhYzBiNjhj MjNmYWIyNzNlMWEuLjExMWZiOGI3NzdiMjQ1MTA5ODUzMmI0OWI1MDI2ZDhhMDQ2NTM2OGYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTEwLTA4ICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGFkZCBhdXRvY29tcGxldGlvbiBmb3IgbWluL21heCB3aXRoaW4gYSBDU1MgY2FsYworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MDY4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgSm9zZXBoIFBlY29yYXJvLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9Nb2RlbHMvQ1NTS2V5d29yZENvbXBsZXRpb25zLmpzOgorICAgICAgICAoV0kuQ1NTS2V5 d29yZENvbXBsZXRpb25zLmZvckZ1bmN0aW9uKToKKwogMjAxNy0xMC0wNiAgTWF0dCBCYWtlciAg PG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIENhbnZh cyB0YWIgYW5kIENhbnZhc092ZXJ2aWV3Q29udGVudFZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3JkQ29tcGxldGlvbnMu anMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvQ1NTS2V5d29y ZENvbXBsZXRpb25zLmpzCmluZGV4IGRiYjk3YzBmMzRkYWExMmJjYmRmZjIxMTA2M2ZhODA4Mjhm Njc4NjIuLjdmODc5ZmRlZTBhNTA4NDFhYjVkNTIzNGY2ZjdiN2NhZDdmMGQ1NmEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9DU1NLZXl3b3Jk Q29tcGxldGlvbnMuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv TW9kZWxzL0NTU0tleXdvcmRDb21wbGV0aW9ucy5qcwpAQCAtNjgsNiArNjgsOCBAQCBXSS5DU1NL ZXl3b3JkQ29tcGxldGlvbnMuZm9yRnVuY3Rpb24gPSBmdW5jdGlvbihmdW5jdGlvbk5hbWUpCiAK ICAgICBpZiAoZnVuY3Rpb25OYW1lID09PSAidmFyIikKICAgICAgICAgc3VnZ2VzdGlvbnMgPSBb XTsKKyAgICBlbHNlIGlmIChmdW5jdGlvbk5hbWUgPT09ICJjYWxjIiB8fCBmdW5jdGlvbk5hbWUg PT09ICJtaW4iIHx8IGZ1bmN0aW9uTmFtZSA9PT0gIm1heCIpCisgICAgICAgIHN1Z2dlc3Rpb25z ID0gc3VnZ2VzdGlvbnMuY29uY2F0KFsiY2FsYygpIiwgIm1pbigpIiwgIm1heCgpIl0pOwogICAg IGVsc2UgaWYgKGZ1bmN0aW9uTmFtZSA9PSAiZW52IikKICAgICAgICAgc3VnZ2VzdGlvbnMgPSBz dWdnZXN0aW9ucy5jb25jYXQoWyJzYWZlLWFyZWEtaW5zZXQtdG9wIiwgInNhZmUtYXJlYS1pbnNl dC1yaWdodCIsICJzYWZlLWFyZWEtaW5zZXQtYm90dG9tIiwgInNhZmUtYXJlYS1pbnNldC1sZWZ0 Il0pOwogICAgIGVsc2UgaWYgKGZ1bmN0aW9uTmFtZSA9PT0gImltYWdlLXNldCIpCg==