17805 2008-03-12 13:54:52 -0700 Can't build FastMalloc.cpp in certain non-pch non-AllInOneFile configurations 2008-03-13 20:45:45 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 17493 1 mark eric oldest_to_newest 73503 0 mark 2008-03-12 13:54:52 -0700 FastMalloc.cpp has an #include that can, in certain configurations, occur within "namespace WTF". This is incorrect. The #include should be moved so that it never occurs within an unexpected scope. 73504 1 19709 mark 2008-03-12 13:57:07 -0700 Created attachment 19709 Move #include The existing #include occurs within #if defined(WTF_CHANGES) && PLATFORM(DARWIN). I selected the new location to also occur within preprocessor source that's active in the same case. 73510 2 19709 eric 2008-03-12 14:22:41 -0700 Comment on attachment 19709 Move #include Yup. Include was clearly wrong. This looks fine. Again, very surprised this would be failing in your compile environment and not ours. r=me. 73664 3 eric 2008-03-13 20:45:45 -0700 Thank you mark for making such easy-to-land patches. These took only a few minutes to land on my train ride home. :) These are revisions r31048 through r31053 19709 2008-03-12 13:57:07 -0700 2008-03-12 14:22:41 -0700 Move #include webkit-17805.1.patch text/plain 991 mark SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMxMDA0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTAgQEAKKzIwMDgtMDMt MTIgIE1hcmsgTWVudG92YWkgIDxtYXJrQG1veGllbmV0LmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9GYXN0TWFsbG9jLmNwcDogI2lu Y2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+IG91dHNpZGUgb2YgYW55CisJICBuYW1lc3BhY2VzLgorCiAy MDA4LTAzLTEyICBBbHAgVG9rZXIgIDxhbHBAYXRva2VyLmNvbT4KIAogICAgICAgICBBbm90aGVy IGF1dG90b29scyB0ZXN0a2pzIGJ1aWxkIGZpeCBhdHRlbXB0LgpJbmRleDogd3RmL0Zhc3RNYWxs b2MuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIHd0Zi9GYXN0TWFsbG9jLmNwcAkocmV2aXNpb24gMzEwMDQp CisrKyB3dGYvRmFzdE1hbGxvYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIzNiw2ICsyMzYsNyBA QCBleHRlcm4gIkMiIGNvbnN0IGludCBqc2NvcmVfZmFzdG1hbGxvY19pCiAKICNpZiBQTEFURk9S TShEQVJXSU4pCiAjaW5jbHVkZSAiTWFsbG9jWm9uZVN1cHBvcnQuaCIKKyNpbmNsdWRlIDx3dGYv SGFzaFNldC5oPgogI2VuZGlmCiAKICNpZm5kZWYgUFJJdVMKQEAgLTM0MTIsNyArMzQxMyw2IEBA IHZvaWQgKigqX19tZW1hbGlnbl9ob29rKShzaXplX3QsIHNpemVfdCwKICNlbmRpZgogCiAjaWYg ZGVmaW5lZChXVEZfQ0hBTkdFUykgJiYgUExBVEZPUk0oREFSV0lOKQotI2luY2x1ZGUgPHd0Zi9I YXNoU2V0Lmg+CiAKIGNsYXNzIEZyZWVPYmplY3RGaW5kZXIgewogICAgIGNvbnN0IFJlbW90ZU1l bW9yeVJlYWRlciYgbV9yZWFkZXI7Cg==