178030 2017-10-06 15:06:46 -0700 RenderTable should not hold a collection of raw pointers to RenderTableCol 2017-10-06 16:15:36 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1357748 0 zalan 2017-10-06 15:06:46 -0700 m_columnRenderers 1357749 1 webkit-bug-importer 2017-10-06 15:07:12 -0700 <rdar://problem/34865236> 1357771 2 323052 zalan 2017-10-06 15:15:17 -0700 Created attachment 323052 Patch 1357806 3 323052 commit-queue 2017-10-06 16:15:35 -0700 Comment on attachment 323052 Patch Clearing flags on attachment: 323052 Committed r223009: <http://trac.webkit.org/changeset/223009> 1357807 4 commit-queue 2017-10-06 16:15:36 -0700 All reviewed patches have been landed. Closing bug. 323052 2017-10-06 15:15:17 -0700 2017-10-06 16:15:35 -0700 Patch bug-178030-20171006151517.patch text/plain 3687 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyOTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTA1OGVhYWFmZTllOWFl ZGIzYzdkNDAxNWEzMmI5YjRkZTIyMWFiNi4uMWY5MTAwZTdlMWY0NTlhYjY3ZDIwZDg2YjFjY2Vi MTEzNGU1YjcyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTA2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuZGVyVGFibGUgc2hvdWxk IG5vdCBob2xkIGEgY29sbGVjdGlvbiBvZiByYXcgcG9pbnRlcnMgdG8gUmVuZGVyVGFibGVDb2wK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODAzMAor ICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzQ4NjUyMzY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gYWRkaXRpb24gdG8gdGhlIG1fY29sdW1uUmVu ZGVyZXJzVmFsaWQgZmxhZywgdGhpcyBwYXRjaCBlbnN1cmVzIHRoYXQKKyAgICAgICAgd2UgZG9u J3QgZGVyZWZlcmVuY2Ugc3RhbGUgY29sdW1uIHJlbmRlcmVycyBldmVuIHdoZW4gdGhlIGZsYWcg aXMgb3V0IG9mIHN5bmMuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpS ZW5kZXJUYWJsZTo6dXBkYXRlQ29sdW1uQ2FjaGUgY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6 UmVuZGVyVGFibGU6OnNsb3dDb2xFbGVtZW50IGNvbnN0KToKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyVGFibGUuaDoKKwogMjAxNy0xMC0wNiAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGln YWxpYS5jb20+CiAKICAgICAgICAgW0NhaXJvXSBDcmVhdGUgQ2Fpcm8gcGF0dGVybnMgZnJvbSBH cmFkaWVudCBvYmplY3RzIG9uLXRoZS1mbHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUYWJsZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGFibGUuY3BwCmluZGV4IDcxOTBkZWY4NDVmMzUwZTdhY2IxMTRhM2FiZjAyY2Y0YzAxY2ZmMDQu LjZiNjNjNGJhODJiMTNiNjkwNTc0N2E0YzVhYjc2MjhhMjMyOTQzMzAgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcApAQCAtOTMxLDcgKzkzMSw3IEBAIHZvaWQgUmVu ZGVyVGFibGU6OnVwZGF0ZUNvbHVtbkNhY2hlKCkgY29uc3QKICAgICBmb3IgKFJlbmRlclRhYmxl Q29sKiBjb2x1bW5SZW5kZXJlciA9IGZpcnN0Q29sdW1uKCk7IGNvbHVtblJlbmRlcmVyOyBjb2x1 bW5SZW5kZXJlciA9IGNvbHVtblJlbmRlcmVyLT5uZXh0Q29sdW1uKCkpIHsKICAgICAgICAgaWYg KGNvbHVtblJlbmRlcmVyLT5pc1RhYmxlQ29sdW1uR3JvdXBXaXRoQ29sdW1uQ2hpbGRyZW4oKSkK ICAgICAgICAgICAgIGNvbnRpbnVlOwotICAgICAgICBtX2NvbHVtblJlbmRlcmVycy5hcHBlbmQo Y29sdW1uUmVuZGVyZXIpOworICAgICAgICBtX2NvbHVtblJlbmRlcmVycy5hcHBlbmQobWFrZVdl YWtQdHIoY29sdW1uUmVuZGVyZXIpKTsKICAgICAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBsb29r IHRvIGNvbXB1dGUgdGhlIGVmZmVjdGl2ZSBjb2x1bW4gaW5kZXggc3VjY2Vzc2l2ZWx5IGZyb20g cHJldmlvdXMgdmFsdWVzIGluc3RlYWQgb2YKICAgICAgICAgLy8gY2FsbGluZyBjb2xUb0VmZkNv bCgpLCB3aGljaCBpcyBpbiBPKG51bUVmZkNvbHMoKSkuIEFsdGhvdWdoIGl0J3MgdW5saWtlbHkg dGhhdCB0aGlzIGlzIGEgaG90IGZ1bmN0aW9uLgogICAgICAgICBtX2VmZmVjdGl2ZUNvbHVtbklu ZGV4TWFwLmFkZChjb2x1bW5SZW5kZXJlciwgY29sVG9FZmZDb2woY29sdW1uSW5kZXgpKTsKQEAg LTEwMjcsOCArMTAyNyw5IEBAIFJlbmRlclRhYmxlQ29sKiBSZW5kZXJUYWJsZTo6c2xvd0NvbEVs ZW1lbnQodW5zaWduZWQgY29sLCBib29sKiBzdGFydEVkZ2UsIGJvb2wqCiAgICAgICAgIHVwZGF0 ZUNvbHVtbkNhY2hlKCk7CiAKICAgICB1bnNpZ25lZCBjb2x1bW5Db3VudCA9IDA7Ci0gICAgZm9y ICh1bnNpZ25lZCBpID0gMDsgaSA8IG1fY29sdW1uUmVuZGVyZXJzLnNpemUoKTsgaSsrKSB7Ci0g ICAgICAgIFJlbmRlclRhYmxlQ29sKiBjb2x1bW5SZW5kZXJlciA9IG1fY29sdW1uUmVuZGVyZXJz W2ldOworICAgIGZvciAoYXV0byYgY29sdW1uUmVuZGVyZXIgOiBtX2NvbHVtblJlbmRlcmVycykg eworICAgICAgICBpZiAoIWNvbHVtblJlbmRlcmVyKQorICAgICAgICAgICAgY29udGludWU7CiAg ICAgICAgIHVuc2lnbmVkIHNwYW4gPSBjb2x1bW5SZW5kZXJlci0+c3BhbigpOwogICAgICAgICB1 bnNpZ25lZCBzdGFydENvbCA9IGNvbHVtbkNvdW50OwogICAgICAgICBBU1NFUlQoc3BhbiA+PSAx KTsKQEAgLTEwMzksMTAgKzEwNDAsMTAgQEAgUmVuZGVyVGFibGVDb2wqIFJlbmRlclRhYmxlOjpz bG93Q29sRWxlbWVudCh1bnNpZ25lZCBjb2wsIGJvb2wqIHN0YXJ0RWRnZSwgYm9vbCoKICAgICAg ICAgICAgICAgICAqc3RhcnRFZGdlID0gc3RhcnRDb2wgPT0gY29sOwogICAgICAgICAgICAgaWYg KGVuZEVkZ2UpCiAgICAgICAgICAgICAgICAgKmVuZEVkZ2UgPSBlbmRDb2wgPT0gY29sOwotICAg ICAgICAgICAgcmV0dXJuIGNvbHVtblJlbmRlcmVyOworICAgICAgICAgICAgcmV0dXJuIGNvbHVt blJlbmRlcmVyLmdldCgpOwogICAgICAgICB9CiAgICAgfQotICAgIHJldHVybiAwOworICAgIHJl dHVybiBudWxscHRyOwogfQogCiB2b2lkIFJlbmRlclRhYmxlOjpyZWNhbGNTZWN0aW9ucygpIGNv bnN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuaCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5oCmluZGV4IDYwM2I4MWVjNmY5 ZWRjZTk1YjBmMWVmNDBlNTJhNmQ1MjdiMDE2ZGYuLjQ4Yzk4MmRlM2E3MDIxZTU5ZDVlMzg3YjM5 MjZkNjUwOTU2MmQyNGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJUYWJsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5oCkBA IC0zMjYsNyArMzI2LDcgQEAgcHJpdmF0ZToKICAgICBtdXRhYmxlIFZlY3RvcjxMYXlvdXRVbml0 PiBtX2NvbHVtblBvczsKICAgICBtdXRhYmxlIFZlY3RvcjxDb2x1bW5TdHJ1Y3Q+IG1fY29sdW1u czsKICAgICBtdXRhYmxlIFZlY3RvcjxSZW5kZXJUYWJsZUNhcHRpb24qPiBtX2NhcHRpb25zOwot ICAgIG11dGFibGUgVmVjdG9yPFJlbmRlclRhYmxlQ29sKj4gbV9jb2x1bW5SZW5kZXJlcnM7Cisg ICAgbXV0YWJsZSBWZWN0b3I8V2Vha1B0cjxSZW5kZXJUYWJsZUNvbD4+IG1fY29sdW1uUmVuZGVy ZXJzOwogCiAgICAgdW5zaWduZWQgZWZmZWN0aXZlSW5kZXhPZkNvbHVtbihjb25zdCBSZW5kZXJU YWJsZUNvbCYpIGNvbnN0OwogICAgIHR5cGVkZWYgSGFzaE1hcDxjb25zdCBSZW5kZXJUYWJsZUNv bCosIHVuc2lnbmVkPiBFZmZlY3RpdmVDb2x1bW5JbmRleE1hcDsK