17803 2008-03-12 13:24:10 -0700 Can't build ThreadingPthreads.cpp in non-pch build; can't build pcre_exec.cpp with -DDEBUG 2008-03-13 20:45:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 17493 1 mark eric oldest_to_newest 73499 0 mark 2008-03-12 13:24:10 -0700 During a non-precompiled header build, wtf/ThreadingPthreads.cpp compilation fails for want of a declaration of gettimeofday. ThreadingPthreads.cpp includes time.h, but should include sys/time.h. sys/time.h will bring in time.h under normal circumstances. During a build with -DDEBUG set (the checked-in project file does not set -DDEBUG, but it's not abnormal for -DDEBUG to be set in debug builds), pcre/pcre_exec.cpp compilation fails because rc is not defined. rc is used in two DPRINTF statements, which are only used when DEBUG is defined. rc is a typo, these DPRINTFs should use returnCode. 73500 1 19708 mark 2008-03-12 13:25:26 -0700 Created attachment 19708 Fix #include in ThreadingPthreads.cpp, fix variable name in pcre_exec.cpp 73512 2 19708 eric 2008-03-12 14:27:08 -0700 Comment on attachment 19708 Fix #include in ThreadingPthreads.cpp, fix variable name in pcre_exec.cpp oops. rc vs. returnCode was my fault I bet. sys/time.h includes time.h, so that should be fine. r=me. 73663 3 eric 2008-03-13 20:45:44 -0700 Thank you mark for making such easy-to-land patches. These took only a few minutes to land on my train ride home. :) These are revisions r31048 through r31053 19708 2008-03-12 13:25:26 -0700 2008-03-12 14:27:08 -0700 Fix #include in ThreadingPthreads.cpp, fix variable name in pcre_exec.cpp webkit-17803.1.patch text/plain 1742 mark SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDMxMDA0 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMDMt MTIgIE1hcmsgTWVudG92YWkgIDxtYXJrQG1veGllbmV0LmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBjcmUvcGNyZV9leGVjLmNwcDogRml4 IG1pc25hbWVkIHZhcmlhYmxlLCBhbGxvd2luZyAtRERFQlVHIGJ1aWxkCisJICB0byBzdWNjZWVk LgorICAgICAgICAqIHd0Zi9UaHJlYWRpbmdQdGhyZWFkcy5jcHA6ICNpbmNsdWRlIDxzeXMvdGlt ZS5oPiBmb3IgZ2V0dGltZW9mZGF5CisJICBpbiBub24tcGNoIGJ1aWxkLgorCiAyMDA4LTAzLTEy ICBBbHAgVG9rZXIgIDxhbHBAYXRva2VyLmNvbT4KIAogICAgICAgICBBbm90aGVyIGF1dG90b29s cyB0ZXN0a2pzIGJ1aWxkIGZpeCBhdHRlbXB0LgpJbmRleDogcGNyZS9wY3JlX2V4ZWMuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIHBjcmUvcGNyZV9leGVjLmNwcAkocmV2aXNpb24gMzEwMDQpCisrKyBwY3Jl L3BjcmVfZXhlYy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwMjQsNyArMjAyNCw3IEBAIGludCBq c1JlZ0V4cEV4ZWN1dGUoY29uc3QgSlNSZWdFeHAqIHJlLAogCiAgICAgICAgIGlmIChyZXR1cm5D b2RlICE9IDEpIHsKICAgICAgICAgICAgIEFTU0VSVChyZXR1cm5Db2RlID09IEpTUmVnRXhwRXJy b3JIaXRMaW1pdCB8fCByZXR1cm5Db2RlID09IEpTUmVnRXhwRXJyb3JOb01lbW9yeSk7Ci0gICAg ICAgICAgICBEUFJJTlRGKCgiPj4+PiBlcnJvcjogcmV0dXJuaW5nICVkXG4iLCByYykpOworICAg ICAgICAgICAgRFBSSU5URigoIj4+Pj4gZXJyb3I6IHJldHVybmluZyAlZFxuIiwgcmV0dXJuQ29k ZSkpOwogICAgICAgICAgICAgcmV0dXJuIHJldHVybkNvZGU7CiAgICAgICAgIH0KICAgICAgICAg CkBAIC0yMDUyLDcgKzIwNTIsNyBAQCBpbnQganNSZWdFeHBFeGVjdXRlKGNvbnN0IEpTUmVnRXhw KiByZSwKICAgICAgICAgICAgIG9mZnNldHNbMV0gPSBtYXRjaEJsb2NrLmVuZE1hdGNoUHRyIC0g bWF0Y2hCbG9jay5zdGFydFN1YmplY3Q7CiAgICAgICAgIH0KICAgICAgICAgCi0gICAgICAgIERQ UklOVEYoKCI+Pj4+IHJldHVybmluZyAlZFxuIiwgcmMpKTsKKyAgICAgICAgRFBSSU5URigoIj4+ Pj4gcmV0dXJuaW5nICVkXG4iLCByZXR1cm5Db2RlKSk7CiAgICAgICAgIHJldHVybiByZXR1cm5D b2RlOwogICAgIH0gd2hpbGUgKHN0YXJ0TWF0Y2ggPD0gZW5kU3ViamVjdCk7CiAgICAgCkluZGV4 OiB3dGYvVGhyZWFkaW5nUHRocmVhZHMuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHd0Zi9UaHJlYWRpbmdQ dGhyZWFkcy5jcHAJKHJldmlzaW9uIDMxMDA0KQorKysgd3RmL1RocmVhZGluZ1B0aHJlYWRzLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzIsNyArMzIsNyBAQAogI2luY2x1ZGUgPHd0Zi9IYXNoTWFw Lmg+CiAKICNpbmNsdWRlIDxlcnJuby5oPgotI2luY2x1ZGUgPHRpbWUuaD4KKyNpbmNsdWRlIDxz eXMvdGltZS5oPgogCiBuYW1lc3BhY2UgV1RGIHsKIAo=