178025 2017-10-06 13:03:05 -0700 RootInlineBox should not hold a collection of raw pointers to RenderBox 2017-10-06 15:14:10 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1357707 0 zalan 2017-10-06 13:03:05 -0700 There's already some assertions in place to check if the renderers are valid. 1357708 1 webkit-bug-importer 2017-10-06 13:03:37 -0700 <rdar://problem/34862488> 1357709 2 323039 zalan 2017-10-06 13:08:02 -0700 Created attachment 323039 Patch 1357766 3 323039 commit-queue 2017-10-06 15:14:08 -0700 Comment on attachment 323039 Patch Clearing flags on attachment: 323039 Committed r223004: <http://trac.webkit.org/changeset/223004> 1357767 4 commit-queue 2017-10-06 15:14:10 -0700 All reviewed patches have been landed. Closing bug. 323039 2017-10-06 13:08:02 -0700 2017-10-06 15:14:08 -0700 Patch bug-178025-20171006130801.patch text/plain 6317 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyOTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTA1OGVhYWFmZTllOWFl ZGIzYzdkNDAxNWEzMmI5YjRkZTIyMWFiNi4uZjYzOTYzNGUyOTA2NDgwZDEzYTkzYjQwZTc5NDg2 NjkyNmNlNmM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTEwLTA2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUm9vdElubGluZUJveCBzaG91 bGQgbm90IGhvbGQgYSBjb2xsZWN0aW9uIG9mIHJhdyBwb2ludGVycyB0byBSZW5kZXJCb3gKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3ODAyNQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMzQ4NjI0ODg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgYXJlIGFscmVhZHkgc29tZSBhc3NlcnRpb25z IGluIHBsYWNlIHRvIGNoZWNrIGlmIHRoZSByZW5kZXJlcnMgYXJlIHZhbGlkLgorCisgICAgICAg IENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdCBjYXNlcy4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQmxvY2tG bG93OjpyZWF0dGFjaENsZWFuTGluZUZsb2F0cyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJC bG9ja0Zsb3c6OmRldGVybWluZVN0YXJ0UG9zaXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyQmxvY2tGbG93OjpkZXRlcm1pbmVFbmRQb3NpdGlvbik6CisgICAgICAgICogcmVuZGVyaW5n L1Jvb3RJbmxpbmVCb3guaDoKKyAgICAgICAgKFdlYkNvcmU6OlJvb3RJbmxpbmVCb3g6OmFwcGVu ZEZsb2F0KToKKyAgICAgICAgKFdlYkNvcmU6OlJvb3RJbmxpbmVCb3g6OmZsb2F0c1B0cik6CisK IDIwMTctMTAtMDYgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtDYWlyb10gQ3JlYXRlIENhaXJvIHBhdHRlcm5zIGZyb20gR3JhZGllbnQgb2JqZWN0cyBv bi10aGUtZmx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxv Y2tMaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xp bmVMYXlvdXQuY3BwCmluZGV4IGYxYTRjN2E4YmFiYmFjZmU4MDQ2YjkzYjg0NGRlYmVjOGIyNTY0 OTUuLjE4MzhmMTkwYzhkZjJlZGFjNGZjZDQzOWY0NGExZjNjYzFkN2YzOWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0xpbmVMYXlvdXQuY3BwCkBAIC0x NTQ5LDcgKzE1NDksOSBAQCB2b2lkIFJlbmRlckJsb2NrRmxvdzo6cmVhdHRhY2hDbGVhbkxpbmVG bG9hdHMoUm9vdElubGluZUJveCYgY2xlYW5MaW5lLCBMYXlvdXRVbgogICAgIGlmICghY2xlYW5M aW5lRmxvYXRzKQogICAgICAgICByZXR1cm47CiAKLSAgICBmb3IgKGF1dG8qIGZsb2F0aW5nQm94 IDogKmNsZWFuTGluZUZsb2F0cykgeworICAgIGZvciAoYXV0byYgZmxvYXRpbmdCb3ggOiAqY2xl YW5MaW5lRmxvYXRzKSB7CisgICAgICAgIGlmICghZmxvYXRpbmdCb3gpCisgICAgICAgICAgICBj b250aW51ZTsKICAgICAgICAgYXV0byogZmxvYXRpbmdPYmplY3QgPSBpbnNlcnRGbG9hdGluZ09i amVjdCgqZmxvYXRpbmdCb3gpOwogICAgICAgICBpZiAoaXNGaXJzdENsZWFuTGluZSAmJiBmbG9h dGluZ09iamVjdC0+b3JpZ2luYXRpbmdMaW5lKCkpIHsKICAgICAgICAgICAgIC8vIEZsb2F0IGJv eCBkb2VzIG5vdCBiZWxvbmcgdG8gdGhpcyBsaW5lIGFueW1vcmUuCkBAIC0xODIwLDggKzE4MjIs MTAgQEAgUm9vdElubGluZUJveCogUmVuZGVyQmxvY2tGbG93OjpkZXRlcm1pbmVTdGFydFBvc2l0 aW9uKExpbmVMYXlvdXRTdGF0ZSYgbGF5b3V0U3QKICAgICAgICAgICAgIGlmIChhdXRvKiBjbGVh bkxpbmVGbG9hdHMgPSBjdXJyZW50TGluZS0+ZmxvYXRzUHRyKCkpIHsKICAgICAgICAgICAgICAg ICAvLyBJZiBhIG5ldyBmbG9hdCBoYXMgYmVlbiBpbnNlcnRlZCBiZWZvcmUgdGhpcyBsaW5lIG9y IGJlZm9yZSBpdHMgbGFzdCBrbm93biBmbG9hdCwganVzdCBkbyBhIGZ1bGwgbGF5b3V0LgogICAg ICAgICAgICAgICAgIGJvb2wgZW5jb3VudGVyZWROZXdGbG9hdCA9IGZhbHNlOwotICAgICAgICAg ICAgICAgIGZvciAoYXV0byogZmxvYXRCb3hPbkNsZWFuTGluZSA6ICpjbGVhbkxpbmVGbG9hdHMp IHsKKyAgICAgICAgICAgICAgICBmb3IgKGF1dG8mIGZsb2F0Qm94T25DbGVhbkxpbmUgOiAqY2xl YW5MaW5lRmxvYXRzKSB7CiAgICAgICAgICAgICAgICAgICAgIEFTU0VSVChmbG9hdHNJdGVyYXRv ciAhPSBlbmQpOworICAgICAgICAgICAgICAgICAgICBpZiAoIWZsb2F0Qm94T25DbGVhbkxpbmUp CisgICAgICAgICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgICAgICAgICAgICAg Y2hlY2tGbG9hdEluQ2xlYW5MaW5lKCpjdXJyZW50TGluZSwgKmZsb2F0Qm94T25DbGVhbkxpbmUs ICpmbG9hdHNJdGVyYXRvciwgZW5jb3VudGVyZWROZXdGbG9hdCwgZGlydGllZEJ5RmxvYXQpOwog ICAgICAgICAgICAgICAgICAgICArK2Zsb2F0c0l0ZXJhdG9yOwogICAgICAgICAgICAgICAgICAg ICBpZiAoZmxvYXRzSXRlcmF0b3IgPT0gZW5kIHx8IGVuY291bnRlcmVkTmV3RmxvYXQpIHsKQEAg LTE4NjYsOSArMTg3MCwxMCBAQCBSb290SW5saW5lQm94KiBSZW5kZXJCbG9ja0Zsb3c6OmRldGVy bWluZVN0YXJ0UG9zaXRpb24oTGluZUxheW91dFN0YXRlJiBsYXlvdXRTdAogICAgICAgICAvLyBS ZXN0b3JlIGZsb2F0cyBmcm9tIGNsZWFuIGxpbmVzLgogICAgICAgICBSb290SW5saW5lQm94KiBs aW5lID0gZmlyc3RSb290Qm94KCk7CiAgICAgICAgIHdoaWxlIChsaW5lICE9IGN1cnJlbnRMaW5l KSB7Ci0gICAgICAgICAgICBpZiAoVmVjdG9yPFJlbmRlckJveCo+KiBjbGVhbkxpbmVGbG9hdHMg PSBsaW5lLT5mbG9hdHNQdHIoKSkgewotICAgICAgICAgICAgICAgIGZvciAoYXV0byBpdCA9IGNs ZWFuTGluZUZsb2F0cy0+YmVnaW4oKSwgZW5kID0gY2xlYW5MaW5lRmxvYXRzLT5lbmQoKTsgaXQg IT0gZW5kOyArK2l0KSB7Ci0gICAgICAgICAgICAgICAgICAgIGF1dG8qIGZsb2F0aW5nQm94ID0g Kml0OworICAgICAgICAgICAgaWYgKGF1dG8qIGNsZWFuTGluZUZsb2F0cyA9IGxpbmUtPmZsb2F0 c1B0cigpKSB7CisgICAgICAgICAgICAgICAgZm9yIChhdXRvJiBmbG9hdGluZ0JveCA6ICpjbGVh bkxpbmVGbG9hdHMpIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKCFmbG9hdGluZ0JveCkKKyAg ICAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgICAgICBhdXRv KiBmbG9hdGluZ09iamVjdCA9IGluc2VydEZsb2F0aW5nT2JqZWN0KCpmbG9hdGluZ0JveCk7CiAg ICAgICAgICAgICAgICAgICAgIEFTU0VSVF9XSVRIX1NFQ1VSSVRZX0lNUExJQ0FUSU9OKCFmbG9h dGluZ09iamVjdC0+b3JpZ2luYXRpbmdMaW5lKCkpOwogICAgICAgICAgICAgICAgICAgICBmbG9h dGluZ09iamVjdC0+c2V0T3JpZ2luYXRpbmdMaW5lKCpsaW5lKTsKQEAgLTE5MjEsNyArMTkyNiw5 IEBAIHZvaWQgUmVuZGVyQmxvY2tGbG93OjpkZXRlcm1pbmVFbmRQb3NpdGlvbihMaW5lTGF5b3V0 U3RhdGUmIGxheW91dFN0YXRlLCBSb290SW5sCiAgICAgICAgICAgICBpZiAoYXV0byogY2xlYW5M aW5lRmxvYXRzID0gY3VycmVudExpbmUtPmZsb2F0c1B0cigpKSB7CiAgICAgICAgICAgICAgICAg Ym9vbCBlbmNvdW50ZXJlZE5ld0Zsb2F0ID0gZmFsc2U7CiAgICAgICAgICAgICAgICAgYm9vbCBk aXJ0aWVkQnlGbG9hdCA9IGZhbHNlOwotICAgICAgICAgICAgICAgIGZvciAoYXV0byogZmxvYXRC b3hPbkNsZWFuTGluZSA6ICpjbGVhbkxpbmVGbG9hdHMpIHsKKyAgICAgICAgICAgICAgICBmb3Ig KGF1dG8mIGZsb2F0Qm94T25DbGVhbkxpbmUgOiAqY2xlYW5MaW5lRmxvYXRzKSB7CisgICAgICAg ICAgICAgICAgICAgIGlmICghZmxvYXRCb3hPbkNsZWFuTGluZSkKKyAgICAgICAgICAgICAgICAg ICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgICAgICAgICBBU1NFUlQoZmxvYXRzSXRlcmF0 b3IgIT0gZW5kKTsKICAgICAgICAgICAgICAgICAgICAgY2hlY2tGbG9hdEluQ2xlYW5MaW5lKCpj dXJyZW50TGluZSwgKmZsb2F0Qm94T25DbGVhbkxpbmUsICpmbG9hdHNJdGVyYXRvciwgZW5jb3Vu dGVyZWROZXdGbG9hdCwgZGlydGllZEJ5RmxvYXQpOwogICAgICAgICAgICAgICAgICAgICArK2Zs b2F0c0l0ZXJhdG9yOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jvb3RJ bmxpbmVCb3guaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9Sb290SW5saW5lQm94LmgKaW5k ZXggY2U4NmNhMmM1NWE2ZGViMDUzOTg3MGQzOGYwMWJmZDMyN2JlZmIyYy4uN2NiZWQyMTdjOTA4 MDE1MjMwYzVlZjQzYjE2OTdjZTAxNTQ2NjAwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1Jvb3RJbmxpbmVCb3guaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv Um9vdElubGluZUJveC5oCkBAIC0yMiw2ICsyMiw3IEBACiAKICNpbmNsdWRlICJCaWRpQ29udGV4 dC5oIgogI2luY2x1ZGUgIklubGluZUZsb3dCb3guaCIKKyNpbmNsdWRlICJSZW5kZXJCb3guaCIK ICNpbmNsdWRlIDx3dGYvV2Vha1B0ci5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0xMzcs MTMgKzEzOCwxNCBAQCBwdWJsaWM6CiAgICAgSW5saW5lQm94KiBjbG9zZXN0TGVhZkNoaWxkRm9y UG9pbnQoY29uc3QgSW50UG9pbnQmLCBib29sIG9ubHlFZGl0YWJsZUxlYXZlcyk7CiAgICAgSW5s aW5lQm94KiBjbG9zZXN0TGVhZkNoaWxkRm9yTG9naWNhbExlZnRQb3NpdGlvbihpbnQsIGJvb2wg b25seUVkaXRhYmxlTGVhdmVzID0gZmFsc2UpOwogCisgICAgdXNpbmcgQ2xlYW5MaW5lRmxvYXRM aXN0ID0gVmVjdG9yPFdlYWtQdHI8UmVuZGVyQm94Pj47CiAgICAgdm9pZCBhcHBlbmRGbG9hdChS ZW5kZXJCb3gmIGZsb2F0aW5nQm94KQogICAgIHsKICAgICAgICAgQVNTRVJUKCFpc0RpcnR5KCkp OwogICAgICAgICBpZiAobV9mbG9hdHMpCi0gICAgICAgICAgICBtX2Zsb2F0cy0+YXBwZW5kKCZm bG9hdGluZ0JveCk7CisgICAgICAgICAgICBtX2Zsb2F0cy0+YXBwZW5kKG1ha2VXZWFrUHRyKGZs b2F0aW5nQm94KSk7CiAgICAgICAgIGVsc2UKLSAgICAgICAgICAgIG1fZmxvYXRzID0gc3RkOjpt YWtlX3VuaXF1ZTxWZWN0b3I8UmVuZGVyQm94Kj4+KDEsICZmbG9hdGluZ0JveCk7CisgICAgICAg ICAgICBtX2Zsb2F0cyA9IHN0ZDo6bWFrZV91bmlxdWU8Q2xlYW5MaW5lRmxvYXRMaXN0PigxLCBt YWtlV2Vha1B0cihmbG9hdGluZ0JveCkpOwogICAgIH0KIAogICAgIHZvaWQgcmVtb3ZlRmxvYXQo UmVuZGVyQm94JiBmbG9hdGluZ0JveCkKQEAgLTE1Myw3ICsxNTUsNyBAQCBwdWJsaWM6CiAgICAg ICAgIG1fZmxvYXRzLT5yZW1vdmUobV9mbG9hdHMtPmZpbmQoJmZsb2F0aW5nQm94KSk7CiAgICAg fQogCi0gICAgVmVjdG9yPFJlbmRlckJveCo+KiBmbG9hdHNQdHIoKSB7IEFTU0VSVCghaXNEaXJ0 eSgpKTsgcmV0dXJuIG1fZmxvYXRzLmdldCgpOyB9CisgICAgQ2xlYW5MaW5lRmxvYXRMaXN0KiBm bG9hdHNQdHIoKSB7IEFTU0VSVCghaXNEaXJ0eSgpKTsgcmV0dXJuIG1fZmxvYXRzLmdldCgpOyB9 CiAKICAgICB2b2lkIGV4dHJhY3RMaW5lQm94RnJvbVJlbmRlck9iamVjdCgpIGZpbmFsOwogICAg IHZvaWQgYXR0YWNoTGluZUJveFRvUmVuZGVyT2JqZWN0KCkgZmluYWw7CkBAIC0yMjgsNyArMjMw LDcgQEAgcHJpdmF0ZToKIAogICAgIC8vIEZsb2F0cyBoYW5naW5nIG9mZiB0aGUgbGluZSBhcmUg cHVzaGVkIGludG8gdGhpcyB2ZWN0b3IgZHVyaW5nIGxheW91dC4gSXQgaXMgb25seQogICAgIC8v IGdvb2QgZm9yIGFzIGxvbmcgYXMgdGhlIGxpbmUgaGFzIG5vdCBiZWVuIG1hcmtlZCBkaXJ0eS4K LSAgICBzdGQ6OnVuaXF1ZV9wdHI8VmVjdG9yPFJlbmRlckJveCo+PiBtX2Zsb2F0czsKKyAgICBz dGQ6OnVuaXF1ZV9wdHI8Q2xlYW5MaW5lRmxvYXRMaXN0PiBtX2Zsb2F0czsKICAgICBXZWFrUHRy RmFjdG9yeTxSb290SW5saW5lQm94PiBtX3dlYWtQdHJGYWN0b3J5OwogfTsKIAo=