178021 2017-10-06 12:12:51 -0700 Continuation map should not hold a raw pointer 2017-10-06 15:13:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1357694 0 zalan 2017-10-06 12:12:51 -0700 This hashmap has a raw renderer pointer to a "sibling" renderer. 1357695 1 webkit-bug-importer 2017-10-06 12:14:34 -0700 <rdar://problem/34861590> 1357699 2 323035 zalan 2017-10-06 12:21:03 -0700 Created attachment 323035 Patch 1357700 3 323036 zalan 2017-10-06 12:21:37 -0700 Created attachment 323036 Patch 1357763 4 323036 commit-queue 2017-10-06 15:13:17 -0700 Comment on attachment 323036 Patch Clearing flags on attachment: 323036 Committed r223003: <http://trac.webkit.org/changeset/223003> 1357764 5 commit-queue 2017-10-06 15:13:19 -0700 All reviewed patches have been landed. Closing bug. 323035 2017-10-06 12:21:03 -0700 2017-10-06 12:21:36 -0700 Patch bug-178021-20171006122103.patch text/plain 2486 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyOTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTA1OGVhYWFmZTllOWFl ZGIzYzdkNDAxNWEzMmI5YjRkZTIyMWFiNi4uNzYwYWQxZTg2NDI3OGFkMzRiNjNkOWFmYzIwYzIy Y2VhNjVhMGYwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTA2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ29udGludWF0aW9uIG1hcCBz aG91bGQgbm90IGhvbGQgYSByYXcgcG9pbnRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MDIxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNDg2 MTU5MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHBhdGNoIGVuc3VyZXMgcHJvcGVyIGxpZmV0aW1lIG1hbmFnZW1lbnQgZm9yIHJlbmRlcmVy cyBzdG9yZWQgaW4gdGhlIENvbnRpbnVhdGlvbiBtYXAKKyAgICAgICAgKGN1cnJlbnRseSB0aGV5 IHJlbHkgb24gdGhlIGNvcnJlY3RuZXNzIG9mIGFkZENoaWxkL3Rha2VDaGlsZCBtZXRob2RzKS4g CisgICAgICAgICAKKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlJlbmRlckJveE1vZGVsT2JqZWN0Ojpjb250aW51YXRpb24gY29uc3QpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6OnNldENvbnRpbnVhdGlvbik6CisKIDIwMTct MTAtMDYgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtD YWlyb10gQ3JlYXRlIENhaXJvIHBhdHRlcm5zIGZyb20gR3JhZGllbnQgb2JqZWN0cyBvbi10aGUt Zmx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxP YmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0 LmNwcAppbmRleCAxZTU4M2FkMTc2ZTNkYzgxMDU1ZDMzY2M0NDgyMzRhNDc1NGZjOGNkLi5lYjJk ZDNkNzIxNjA4YTAzZWFmOGIyM2YxNGZmNjU1OGE3MzExYjZlIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKQEAgLTc3LDcgKzc3LDcg QEAgdXNpbmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKIC8vIGFuIGFub255bW91cyBibG9jayAodGhh dCBob3VzZXMgb3RoZXIgYmxvY2tzKSBvciBpdCB3aWxsIGJlIGFuIGlubGluZSBmbG93LgogLy8g PGI+PGk+PHA+SGVsbG88L3A+PC9pPjwvYj4uIEluIHRoaXMgZXhhbXBsZSB0aGUgPGk+IHdpbGwg aGF2ZSBhIGJsb2NrIGFzCiAvLyBpdHMgY29udGludWF0aW9uIGJ1dCB0aGUgPGI+IHdpbGwganVz dCBoYXZlIGFuIGlubGluZSBhcyBpdHMgY29udGludWF0aW9uLgotdHlwZWRlZiBIYXNoTWFwPGNv bnN0IFJlbmRlckJveE1vZGVsT2JqZWN0KiwgUmVuZGVyQm94TW9kZWxPYmplY3QqPiBDb250aW51 YXRpb25NYXA7Cit0eXBlZGVmIEhhc2hNYXA8Y29uc3QgUmVuZGVyQm94TW9kZWxPYmplY3QqLCBX ZWFrUHRyPFJlbmRlckJveE1vZGVsT2JqZWN0Pj4gQ29udGludWF0aW9uTWFwOwogc3RhdGljIENv bnRpbnVhdGlvbk1hcCYgY29udGludWF0aW9uTWFwKCkKIHsKICAgICBzdGF0aWMgTmV2ZXJEZXN0 cm95ZWQ8Q29udGludWF0aW9uTWFwPiBtYXA7CkBAIC0yNDQ5LDEzICsyNDQ5LDEzIEBAIFJlbmRl ckJveE1vZGVsT2JqZWN0KiBSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y29udGludWF0aW9uKCkgY29u c3QKIHsKICAgICBpZiAoIWhhc0NvbnRpbnVhdGlvbigpKQogICAgICAgICByZXR1cm4gbnVsbHB0 cjsKLSAgICByZXR1cm4gY29udGludWF0aW9uTWFwKCkuZ2V0KHRoaXMpOworICAgIHJldHVybiBj b250aW51YXRpb25NYXAoKS5nZXQodGhpcykuZ2V0KCk7CiB9CiAKIHZvaWQgUmVuZGVyQm94TW9k ZWxPYmplY3Q6OnNldENvbnRpbnVhdGlvbihSZW5kZXJCb3hNb2RlbE9iamVjdCogY29udGludWF0 aW9uKQogewogICAgIGlmIChjb250aW51YXRpb24pCi0gICAgICAgIGNvbnRpbnVhdGlvbk1hcCgp LnNldCh0aGlzLCBjb250aW51YXRpb24pOworICAgICAgICBjb250aW51YXRpb25NYXAoKS5zZXQo dGhpcywgbWFrZVdlYWtQdHIoY29udGludWF0aW9uKSk7CiAgICAgZWxzZSBpZiAoaGFzQ29udGlu dWF0aW9uKCkpCiAgICAgICAgIGNvbnRpbnVhdGlvbk1hcCgpLnJlbW92ZSh0aGlzKTsKICAgICBz ZXRIYXNDb250aW51YXRpb24oISFjb250aW51YXRpb24pOwo= 323036 2017-10-06 12:21:37 -0700 2017-10-06 15:13:17 -0700 Patch bug-178021-20171006122137.patch text/plain 2474 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyOTc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTA1OGVhYWFmZTllOWFl ZGIzYzdkNDAxNWEzMmI5YjRkZTIyMWFiNi4uMDYwOTQyYWNmNmQzMDMxZWRmMmJhNTFmMDJhMzBl NzgzNTdkYzY0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTEwLTA2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgQ29udGludWF0aW9uIG1hcCBz aG91bGQgbm90IGhvbGQgYSByYXcgcG9pbnRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc4MDIxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNDg2 MTU5MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHBhdGNoIGVuc3VyZXMgcHJvcGVyIGxpZmV0aW1lIG1hbmFnZW1lbnQgZm9yIHJlbmRlcmVy cyBzdG9yZWQgaW4gdGhlIENvbnRpbnVhdGlvbiBtYXAKKyAgICAgICAgKGN1cnJlbnRseSB0aGV5 IHJlbHkgb24gdGhlIGNvcnJlY3RuZXNzIG9mIGFkZENoaWxkL3Rha2VDaGlsZCBtZXRob2RzKS4K KworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJv eE1vZGVsT2JqZWN0Ojpjb250aW51YXRpb24gY29uc3QpOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyQm94TW9kZWxPYmplY3Q6OnNldENvbnRpbnVhdGlvbik6CisKIDIwMTctMTAtMDYgIFphbiBE b2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtDYWlyb10gQ3JlYXRl IENhaXJvIHBhdHRlcm5zIGZyb20gR3JhZGllbnQgb2JqZWN0cyBvbi10aGUtZmx5CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0LmNwcAppbmRleCAx ZTU4M2FkMTc2ZTNkYzgxMDU1ZDMzY2M0NDgyMzRhNDc1NGZjOGNkLi5lYjJkZDNkNzIxNjA4YTAz ZWFmOGIyM2YxNGZmNjU1OGE3MzExYjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKQEAgLTc3LDcgKzc3LDcgQEAgdXNpbmcgbmFt ZXNwYWNlIEhUTUxOYW1lczsKIC8vIGFuIGFub255bW91cyBibG9jayAodGhhdCBob3VzZXMgb3Ro ZXIgYmxvY2tzKSBvciBpdCB3aWxsIGJlIGFuIGlubGluZSBmbG93LgogLy8gPGI+PGk+PHA+SGVs bG88L3A+PC9pPjwvYj4uIEluIHRoaXMgZXhhbXBsZSB0aGUgPGk+IHdpbGwgaGF2ZSBhIGJsb2Nr IGFzCiAvLyBpdHMgY29udGludWF0aW9uIGJ1dCB0aGUgPGI+IHdpbGwganVzdCBoYXZlIGFuIGlu bGluZSBhcyBpdHMgY29udGludWF0aW9uLgotdHlwZWRlZiBIYXNoTWFwPGNvbnN0IFJlbmRlckJv eE1vZGVsT2JqZWN0KiwgUmVuZGVyQm94TW9kZWxPYmplY3QqPiBDb250aW51YXRpb25NYXA7Cit0 eXBlZGVmIEhhc2hNYXA8Y29uc3QgUmVuZGVyQm94TW9kZWxPYmplY3QqLCBXZWFrUHRyPFJlbmRl ckJveE1vZGVsT2JqZWN0Pj4gQ29udGludWF0aW9uTWFwOwogc3RhdGljIENvbnRpbnVhdGlvbk1h cCYgY29udGludWF0aW9uTWFwKCkKIHsKICAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8Q29udGlu dWF0aW9uTWFwPiBtYXA7CkBAIC0yNDQ5LDEzICsyNDQ5LDEzIEBAIFJlbmRlckJveE1vZGVsT2Jq ZWN0KiBSZW5kZXJCb3hNb2RlbE9iamVjdDo6Y29udGludWF0aW9uKCkgY29uc3QKIHsKICAgICBp ZiAoIWhhc0NvbnRpbnVhdGlvbigpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKLSAgICByZXR1 cm4gY29udGludWF0aW9uTWFwKCkuZ2V0KHRoaXMpOworICAgIHJldHVybiBjb250aW51YXRpb25N YXAoKS5nZXQodGhpcykuZ2V0KCk7CiB9CiAKIHZvaWQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OnNl dENvbnRpbnVhdGlvbihSZW5kZXJCb3hNb2RlbE9iamVjdCogY29udGludWF0aW9uKQogewogICAg IGlmIChjb250aW51YXRpb24pCi0gICAgICAgIGNvbnRpbnVhdGlvbk1hcCgpLnNldCh0aGlzLCBj b250aW51YXRpb24pOworICAgICAgICBjb250aW51YXRpb25NYXAoKS5zZXQodGhpcywgbWFrZVdl YWtQdHIoY29udGludWF0aW9uKSk7CiAgICAgZWxzZSBpZiAoaGFzQ29udGludWF0aW9uKCkpCiAg ICAgICAgIGNvbnRpbnVhdGlvbk1hcCgpLnJlbW92ZSh0aGlzKTsKICAgICBzZXRIYXNDb250aW51 YXRpb24oISFjb250aW51YXRpb24pOwo=