178014 2017-10-06 09:42:38 -0700 Web Inspector: clicking in Inspector webview clears the selection in the inspected page 2017-10-06 16:05:48 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 bburg bburg bburg commit-queue inspector-bugzilla-changes thorton timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1357623 0 bburg 2017-10-06 09:42:38 -0700 I know how to fix this, thanks thorton! 1357625 1 bburg 2017-10-06 09:43:30 -0700 <rdar://problem/12706857> 1357631 2 bburg 2017-10-06 09:50:21 -0700 Steps to repro: 1. Open inspector docked 2. Make selection on inspected page 3. Click in inspector webview => lost selection in inspected view This does not affect windowed web inspector, as selections are maintained when a window is not key. 1357635 3 323023 bburg 2017-10-06 09:55:59 -0700 Created attachment 323023 Patch 1357793 4 323023 commit-queue 2017-10-06 16:05:47 -0700 Comment on attachment 323023 Patch Clearing flags on attachment: 323023 Committed r223007: <http://trac.webkit.org/changeset/223007> 1357794 5 commit-queue 2017-10-06 16:05:48 -0700 All reviewed patches have been landed. Closing bug. 323023 2017-10-06 09:55:59 -0700 2017-10-06 16:05:47 -0700 Patch bug-178014-20171006095558.patch text/plain 3518 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyOTc3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI0MmVlMjczNWQ3ZDY4YWM4 NGJkZWY3N2EzN2RkNDllZmE0YzYxMDMuLjRjYWMwNDFlNzhlNDJlYmI0ZTcxNzExNDY1YjU2ODcx NzA0MmY3M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTctMTAtMDYgIEJyaWFuIEJ1 cmcgIDxiYnVyZ0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogY2xpY2tpbmcg aW4gSW5zcGVjdG9yIHdlYnZpZXcgY2xlYXJzIHRoZSBzZWxlY3Rpb24gaW4gdGhlIGluc3BlY3Rl ZCBwYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzgwMTQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyNzA2ODU3PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIElmIHRoZSBJbnNwZWN0b3IgaXMgZG9j a2VkIHRvIHRoZSBpbnNwZWN0ZWQgdmlldywgY2xpY2tpbmcgb24gdGhlIEluc3BlY3RvcgorICAg ICAgICB3ZWJ2aWV3IHdpbGwgY2F1c2Ugc2VsZWN0aW9uIGluIHRoZSBpbnNwZWN0ZWQgdmlldyB0 byBiZSBsb3N0LiBUaGlzIGlzIGJlY2F1c2UKKyAgICAgICAgdGhlIHNlbGVjdGlvbiBpcyBsb3N0 IHdoZW4gdGhlIHdlYiB2aWV3IHJlc2lnbnMgZmlyc3QgcmVzcG9uZGVyLgorCisgICAgICAgIEFk ZCBhIGNoZWNrIGluIG1haW50YWluc0luYWN0aXZlU2VsZWN0aW9uIHRvIGFsd2F5cyByZXRhaW4g c2VsZWN0aW9uIGlmCisgICAgICAgIFdlYiBJbnNwZWN0b3IgaXMgb3Blbi4gVGhpcyBhcHByb2Fj aCBzZWVtcyBzaW1wbGVyIHRoYW4gdHJ5aW5nIHRvIHN5bmMgYSBjbGllbnQncworICAgICAgICB1 c2FnZSBvZiBXS1BhZ2VTZXRNYWludGFpbnNJbmFjdGl2ZVNlbGVjdGlvbiB3aXRoIG92ZXJyaWRl cyB0aGF0IG5lZWQgdG8gYmUgYXBwbGllZAorICAgICAgICBhbmQgdW5hcHBsaWVkIHdoZW4gYW4g aW5zcGVjdG9yIHdlYiB2aWV3IGlzIHNob3duIG9yIGhpZGRlbi4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlUHJveHk6Om1h aW50YWluc0luYWN0aXZlU2VsZWN0aW9uIGNvbnN0KToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZVByb3h5OjppbnNwZWN0b3IgY29uc3QpOiBEcml2ZSBieSwgdXNlIG51bGxwdHIuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvV2ViUGFnZVByb3h5Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQ cm94eTo6bWFpbnRhaW5zSW5hY3RpdmVTZWxlY3Rpb24gY29uc3QpOiBEZWxldGVkLgorCiAyMDE3 LTEwLTA1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBbR1RLXVtXUEVdIEFkZCBBUEkgdG8gY29uZmlndXJlIGFuZCBlbmFibGUgcmVzb3VyY2Ug bG9hZCBzdGF0aXN0aWNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQ YWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcApp bmRleCBiYzFmMzZkYThlNjM1ZDU2ODY2MWI4YTc4Y2M4N2M3NTFjMzFkZGYyLi40YWUyNWVhZDlk NGM2MTA5ZDhlOTUxMjZlNWI4YzU3MzQxN2U2ZjYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5jcHAKQEAgLTE2NDQsNiArMTY0NCwxNiBAQCB2b2lkIFdlYlBhZ2VQcm94 eTo6dmFsaWRhdGVDb21tYW5kKGNvbnN0IFN0cmluZyYgY29tbWFuZE5hbWUsIFdURjo6RnVuY3Rp b248dm9pZAogICAgIG1fcHJvY2Vzcy0+c2VuZChNZXNzYWdlczo6V2ViUGFnZTo6VmFsaWRhdGVD b21tYW5kKGNvbW1hbmROYW1lLCBjYWxsYmFja0lEKSwgbV9wYWdlSUQpOwogfQogCitib29sIFdl YlBhZ2VQcm94eTo6bWFpbnRhaW5zSW5hY3RpdmVTZWxlY3Rpb24oKSBjb25zdAoreworICAgIC8v IFJlZ2FyZGxlc3Mgb2Ygd2hhdCB0aGUgY2xpZW50IHdhbnRzIHRvIGRvLCBrZWVwIHNlbGVjdGlv bnMgaWYgYSBsb2NhbCBJbnNwZWN0b3IgaXMgb3Blbi4KKyAgICAvLyBPdGhlcndpc2UsIHRoZXJl IGlzIG5vIHdheSB0byB1c2UgdGhlIGNvbnNvbGUgdG8gaW5zcGVjdCB0aGUgc3RhdGUgb2YgYSBz ZWxlY3Rpb24uCisgICAgaWYgKGluc3BlY3RvcigpICYmIGluc3BlY3RvcigpLT5pc1Zpc2libGUo KSkKKyAgICAgICAgcmV0dXJuIHRydWU7CisKKyAgICByZXR1cm4gbV9tYWludGFpbnNJbmFjdGl2 ZVNlbGVjdGlvbjsKK30KKwogdm9pZCBXZWJQYWdlUHJveHk6OnNldE1haW50YWluc0luYWN0aXZl U2VsZWN0aW9uKGJvb2wgbmV3VmFsdWUpCiB7CiAgICAgbV9tYWludGFpbnNJbmFjdGl2ZVNlbGVj dGlvbiA9IG5ld1ZhbHVlOwpAQCAtNDQxMSwxMSArNDQyMSwxMCBAQCB2b2lkIFdlYlBhZ2VQcm94 eTo6ZGlkRW5kQ29sb3JQaWNrZXIoKQogfQogI2VuZGlmCiAKLS8vIEluc3BlY3RvcgogV2ViSW5z cGVjdG9yUHJveHkqIFdlYlBhZ2VQcm94eTo6aW5zcGVjdG9yKCkgY29uc3QKIHsKICAgICBpZiAo aXNDbG9zZWQoKSB8fCAhaXNWYWxpZCgpKQotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0 dXJuIG51bGxwdHI7CiAgICAgcmV0dXJuIG1faW5zcGVjdG9yLmdldCgpOwogfQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuaCBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCmluZGV4IDU5ZDA3YzMzYjZkYmY5MmI3MTZjYmVi ZGFhYTgxMGU0NzFhYjY0NDEuLjgzN2FlNmRhN2UwYzk3N2FjMDc5ODNiNmI5NWU5ZWM3OTA4ODJi YzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oCkBAIC00NzIsNyArNDcy LDcgQEAgcHVibGljOgogICAgIGJvb2wgaGFzU2VsZWN0ZWRSYW5nZSgpIGNvbnN0IHsgcmV0dXJu IG1fZWRpdG9yU3RhdGUuc2VsZWN0aW9uSXNSYW5nZTsgfQogICAgIGJvb2wgaXNDb250ZW50RWRp dGFibGUoKSBjb25zdCB7IHJldHVybiBtX2VkaXRvclN0YXRlLmlzQ29udGVudEVkaXRhYmxlOyB9 CiAgICAgCi0gICAgYm9vbCBtYWludGFpbnNJbmFjdGl2ZVNlbGVjdGlvbigpIGNvbnN0IHsgcmV0 dXJuIG1fbWFpbnRhaW5zSW5hY3RpdmVTZWxlY3Rpb247IH0KKyAgICBib29sIG1haW50YWluc0lu YWN0aXZlU2VsZWN0aW9uKCkgY29uc3Q7CiAgICAgdm9pZCBzZXRNYWludGFpbnNJbmFjdGl2ZVNl bGVjdGlvbihib29sKTsKICAgICB2b2lkIHNldEVkaXRhYmxlKGJvb2wpOwogICAgIGJvb2wgaXNF ZGl0YWJsZSgpIGNvbnN0IHsgcmV0dXJuIG1faXNFZGl0YWJsZTsgfQo=