177990 2017-10-05 20:40:40 -0700 Web Inspector: Network Tab - Make selection in the table more reliable (mousedown instead of click) 2017-10-06 11:04:35 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1357438 0 joepeck 2017-10-05 20:40:40 -0700 Network Tab - Make selection in the table more reliable (mousedown instead of click) After living on this for a while I sometimes see clicking not working. Lets move to mousedown which ensures the "click" goes through early and doesn't depend on no mouse jitter, etc. 1357439 1 322981 joepeck 2017-10-05 20:41:13 -0700 Created attachment 322981 [PATCH] Proposed Fix 1357654 2 322981 bburg 2017-10-06 10:35:49 -0700 Comment on attachment 322981 [PATCH] Proposed Fix r=me 1357667 3 322981 commit-queue 2017-10-06 11:03:20 -0700 Comment on attachment 322981 [PATCH] Proposed Fix Clearing flags on attachment: 322981 Committed r222988: <http://trac.webkit.org/changeset/222988> 1357668 4 commit-queue 2017-10-06 11:03:21 -0700 All reviewed patches have been landed. Closing bug. 1357669 5 webkit-bug-importer 2017-10-06 11:04:35 -0700 <rdar://problem/34859712> 322981 2017-10-05 20:41:13 -0700 2017-10-06 11:03:20 -0700 [PATCH] Proposed Fix mousedown-1.patch text/plain 3342 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDNlYzBkNjE0M2EzLi44MmI0YWI5NjQ3NCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTctMTAtMDUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBOZXR3b3JrIFRhYiAtIE1ha2Ugc2VsZWN0aW9uIGluIHRoZSB0YWJsZSBtb3JlIHJlbGlhYmxl IChtb3VzZWRvd24gaW5zdGVhZCBvZiBjbGljaykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Nzk5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVD b250ZW50Vmlldy5qczoKKyAgICAgICAgKFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LnByb3Rv dHlwZS50YWJsZUNlbGxDbGlja2VkKTogRGVsZXRlZC4KKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1RhYmxlLmpzOgorICAgICAgICAoV0kuVGFibGUucHJvdG90eXBlLl9oYW5kbGVNb3Vz ZURvd24pOgorICAgICAgICAoV0kuVGFibGUucHJvdG90eXBlLl9oYW5kbGVDbGljayk6IERlbGV0 ZWQuCisgICAgICAgIFN3aXRjaCB0byBtb3VzZWRvd24uCisKKzIwMTctMTAtMDUgIEpvc2VwaCBQ ZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJ bXByb3ZlIHNldHRpbmcgdGhlIGRlZmF1bHQgLyBpbml0aWFsIHNvcnQgb2YgYSBUYWJsZQogICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3OTg5CiAKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05ldHdv cmtUYWJsZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKaW5kZXggZGU1MWI0YmU1NzkuLjEz NGIyNThhOWZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcwpAQCAt MjI5LDcgKzIyOSw3IEBAIFdJLk5ldHdvcmtUYWJsZUNvbnRlbnRWaWV3ID0gY2xhc3MgTmV0d29y a1RhYmxlQ29udGVudFZpZXcgZXh0ZW5kcyBXSS5Db250ZW50VmllCiAKICAgICAvLyBUYWJsZSBk ZWxlZ2F0ZQogCi0gICAgdGFibGVDZWxsQ2xpY2tlZCh0YWJsZSwgY2VsbCwgY29sdW1uLCByb3dJ bmRleCwgZXZlbnQpCisgICAgdGFibGVDZWxsTW91c2VEb3duKHRhYmxlLCBjZWxsLCBjb2x1bW4s IHJvd0luZGV4LCBldmVudCkKICAgICB7CiAgICAgICAgIGlmIChjb2x1bW4gIT09IHRoaXMuX25h bWVDb2x1bW4pCiAgICAgICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzCmluZGV4IDY4MTViNzIwMWYxLi42ODEy ZGM0YTU1ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGFibGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGFibGUuanMKQEAgLTU2LDggKzU2LDggQEAgV0kuVGFibGUgPSBjbGFzcyBUYWJsZSBl eHRlbmRzIFdJLlZpZXcKICAgICAgICAgdGhpcy5fc2Nyb2xsQ29udGFpbmVyRWxlbWVudC5jbGFz c05hbWUgPSAiZGF0YS1jb250YWluZXIiOwogICAgICAgICB0aGlzLl9zY3JvbGxDb250YWluZXJF bGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoInNjcm9sbCIsIHNjcm9sbEhhbmRsZXIpOwogICAgICAg ICB0aGlzLl9zY3JvbGxDb250YWluZXJFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNld2hl ZWwiLCBzY3JvbGxIYW5kbGVyKTsKLSAgICAgICAgaWYgKHRoaXMuX2RlbGVnYXRlLnRhYmxlQ2Vs bENsaWNrZWQpCi0gICAgICAgICAgICB0aGlzLl9zY3JvbGxDb250YWluZXJFbGVtZW50LmFkZEV2 ZW50TGlzdGVuZXIoImNsaWNrIiwgdGhpcy5faGFuZGxlQ2xpY2suYmluZCh0aGlzKSk7CisgICAg ICAgIGlmICh0aGlzLl9kZWxlZ2F0ZS50YWJsZUNlbGxNb3VzZURvd24pCisgICAgICAgICAgICB0 aGlzLl9zY3JvbGxDb250YWluZXJFbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlZG93biIs IHRoaXMuX2hhbmRsZU1vdXNlRG93bi5iaW5kKHRoaXMpKTsKICAgICAgICAgaWYgKHRoaXMuX2Rl bGVnYXRlLnRhYmxlQ2VsbENvbnRleHRNZW51Q2xpY2tlZCkKICAgICAgICAgICAgIHRoaXMuX3Nj cm9sbENvbnRhaW5lckVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigiY29udGV4dG1lbnUiLCB0aGlz Ll9oYW5kbGVDb250ZXh0TWVudS5iaW5kKHRoaXMpKTsKIApAQCAtMTEwNCw4ICsxMTA0LDExIEBA IFdJLlRhYmxlID0gY2xhc3MgVGFibGUgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgIH0KICAgICB9 CiAKLSAgICBfaGFuZGxlQ2xpY2soZXZlbnQpCisgICAgX2hhbmRsZU1vdXNlRG93bihldmVudCkK ICAgICB7CisgICAgICAgIGlmIChldmVudC5idXR0b24gIT09IDAgfHwgZXZlbnQuY3RybEtleSkK KyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBsZXQgY2VsbCA9IGV2ZW50LnRhcmdldC5l bmNsb3NpbmdOb2RlT3JTZWxmV2l0aENsYXNzKCJjZWxsIik7CiAgICAgICAgIGlmICghY2VsbCkK ICAgICAgICAgICAgIHJldHVybjsKQEAgLTExMTgsNyArMTEyMSw3IEBAIFdJLlRhYmxlID0gY2xh c3MgVGFibGUgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgIGxldCBjb2x1bW4gPSB0aGlzLl92aXNp YmxlQ29sdW1uc1tjb2x1bW5JbmRleF07CiAgICAgICAgIGxldCByb3dJbmRleCA9IHJvdy5fX2lu ZGV4OwogCi0gICAgICAgIHRoaXMuX2RlbGVnYXRlLnRhYmxlQ2VsbENsaWNrZWQodGhpcywgY2Vs bCwgY29sdW1uLCByb3dJbmRleCwgZXZlbnQpOworICAgICAgICB0aGlzLl9kZWxlZ2F0ZS50YWJs ZUNlbGxNb3VzZURvd24odGhpcywgY2VsbCwgY29sdW1uLCByb3dJbmRleCwgZXZlbnQpOwogICAg IH0KIAogICAgIF9oYW5kbGVDb250ZXh0TWVudShldmVudCkK