17799 2008-03-12 10:59:23 -0700 WebView signals should use more specific types 2008-03-12 12:41:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 tkomulai+webkit webkit-unassigned alp oldest_to_newest 73482 0 tkomulai+webkit 2008-03-12 10:59:23 -0700 The signals "script-alert", "script-confirm", "script-script-prompt" are using G_TYPE_OBJECT as the type for the WebFrame argument. This causes generated documentation to document the type as GObject rather than WebkitWebFrame, so it would be better to use the more specific type instead. 73483 1 19703 tkomulai+webkit 2008-03-12 11:01:08 -0700 Created attachment 19703 Fix types of signal parameters 73489 2 alp 2008-03-12 12:41:46 -0700 Landed in r31004. 19703 2008-03-12 11:01:08 -0700 2008-03-12 12:40:18 -0700 Fix types of signal parameters 0001-Fix-types-of-signal-parameters.patch text/plain 2031 tkomulai+webkit RnJvbSBlZDZjNjY5NmU0NzQzMDA0MDY0ZjI1MGNjODk3YzhhNjA0MjE4MTgzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb21taSBLb211bGFpbmVuIDx0b21taS5rb211bGFpbmVuQGlr aS5maT4KRGF0ZTogV2VkLCAxMiBNYXIgMjAwOCAxNjoyMTozNyArMDEwMApTdWJqZWN0OiBbUEFU Q0hdIEZpeCB0eXBlcyBvZiBzaWduYWwgcGFyYW1ldGVycwoKMjAwOC0wMy0xMiAgVG9tbWkgS29t dWxhaW5lbiAgPHRvbW1pLmtvbXVsYWluZW5AaWtpLmZpPgoKICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KCiAgICAgICAgRml4IHR5cGVzIG9mIHNpZ25hbCBwYXJhbWV0ZXJzCgog ICAgICAgICogd2Via2l0L3dlYmtpdHdlYnZpZXcuY3BwOiBVc2UgV0VCS0lUX1RZUEVfV0VCX0ZS QU1FIGFyZ3VtZW50CiAgICAgICAgdHlwZSBpbiAic2NyaXB0LWFsZXJ0IiwgInNjcmlwdC1jb25m aXJtIiwgInNjcmlwdC1zY3JpcHQtcHJvbXB0IgogICAgICAgIHNpZ25hbHMgc28gdGhhdCBpdCBn ZXRzIG1vcmUgY2xlYXJseSBkb2N1bWVudGVkIHJhdGhlciB0aGFuIGp1c3QKCXBsYWluIEdPYmpl Y3QuCi0tLQogV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgfCAgICA2ICsrKy0t LQogMSBmaWxlcyBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvV2ViS2l0L2d0ay93ZWJraXQvd2Via2l0d2Vidmlldy5jcHAgYi9XZWJLaXQvZ3Rr L3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAppbmRleCAxNmEzZjFmLi4wZjcwZmEyIDEwMDY0NAot LS0gYS9XZWJLaXQvZ3RrL3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvZ3Rr L3dlYmtpdC93ZWJraXR3ZWJ2aWV3LmNwcApAQCAtODc2LDcgKzg3Niw3IEBAIHN0YXRpYyB2b2lk IHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0Ns YXNzKQogICAgICAgICAgICAgTlVMTCwKICAgICAgICAgICAgIHdlYmtpdF9tYXJzaGFsX0JPT0xF QU5fX09CSkVDVF9TVFJJTkcsCiAgICAgICAgICAgICBHX1RZUEVfQk9PTEVBTiwgMiwKLSAgICAg ICAgICAgIEdfVFlQRV9PQkpFQ1QsIEdfVFlQRV9TVFJJTkcpOworICAgICAgICAgICAgV0VCS0lU X1RZUEVfV0VCX0ZSQU1FLCBHX1RZUEVfU1RSSU5HKTsKIAogICAgIC8qKgogICAgICAqIFdlYktp dFdlYlZpZXc6OnNjcmlwdC1jb25maXJtOgpAQCAtODk2LDcgKzg5Niw3IEBAIHN0YXRpYyB2b2lk IHdlYmtpdF93ZWJfdmlld19jbGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0Ns YXNzKQogICAgICAgICAgICAgTlVMTCwKICAgICAgICAgICAgIHdlYmtpdF9tYXJzaGFsX0JPT0xF QU5fX09CSkVDVF9TVFJJTkdfQk9PTEVBTiwKICAgICAgICAgICAgIEdfVFlQRV9CT09MRUFOLCAz LAotICAgICAgICAgICAgR19UWVBFX09CSkVDVCwgR19UWVBFX1NUUklORywgR19UWVBFX0JPT0xF QU4pOworICAgICAgICAgICAgV0VCS0lUX1RZUEVfV0VCX0ZSQU1FLCBHX1RZUEVfU1RSSU5HLCBH X1RZUEVfQk9PTEVBTik7CiAKICAgICAvKioKICAgICAgKiBXZWJLaXRXZWJWaWV3OjpzY3JpcHQt cHJvbXB0OgpAQCAtOTE3LDcgKzkxNyw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdF93ZWJfdmlld19j bGFzc19pbml0KFdlYktpdFdlYlZpZXdDbGFzcyogd2ViVmlld0NsYXNzKQogICAgICAgICAgICAg TlVMTCwKICAgICAgICAgICAgIHdlYmtpdF9tYXJzaGFsX0JPT0xFQU5fX09CSkVDVF9TVFJJTkdf U1RSSU5HX1NUUklORywKICAgICAgICAgICAgIEdfVFlQRV9CT09MRUFOLCA0LAotICAgICAgICAg ICAgR19UWVBFX09CSkVDVCwgR19UWVBFX1NUUklORywgR19UWVBFX1NUUklORywgR19UWVBFX1BP SU5URVIpOworICAgICAgICAgICAgV0VCS0lUX1RZUEVfV0VCX0ZSQU1FLCBHX1RZUEVfU1RSSU5H LCBHX1RZUEVfU1RSSU5HLCBHX1RZUEVfUE9JTlRFUik7CiAKICAgICAvKioKICAgICAgKiBXZWJL aXRXZWJWaWV3OjpzZWxlY3QtYWxsOgotLSAKMS41LjQuMwoK