177989 2017-10-05 20:27:48 -0700 Web Inspector: Improve setting the default / initial sort of a Table 2017-10-06 09:39:02 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1357435 0 joepeck 2017-10-05 20:27:48 -0700 Improve setting the default / initial sort of a Table Its hard / impossible to set the initial sort of a Table. Lets make it easier and better. let table = new Table(identifier, ...); if (!table.sortColumnIdentifier) { table.sortOrder = ...; table.sortColumnIdentifier = ...; } The initialLayout of the table will ensure it displays appropriately. 1357436 1 322980 joepeck 2017-10-05 20:30:32 -0700 Created attachment 322980 [PATCH] Proposed Fix I like this approach for setting up the default sort. Its easy to find and not too invasive in code. It probably depends on ordering (ensure columns are added before setting the default sort) but thats a pattern I'm already following and encouraging. 1357598 2 322980 bburg 2017-10-06 09:10:44 -0700 Comment on attachment 322980 [PATCH] Proposed Fix r=me 1357615 3 322980 commit-queue 2017-10-06 09:38:00 -0700 Comment on attachment 322980 [PATCH] Proposed Fix Clearing flags on attachment: 322980 Committed r222983: <http://trac.webkit.org/changeset/222983> 1357616 4 commit-queue 2017-10-06 09:38:02 -0700 All reviewed patches have been landed. Closing bug. 1357618 5 webkit-bug-importer 2017-10-06 09:39:02 -0700 <rdar://problem/34857354> 322980 2017-10-05 20:30:32 -0700 2017-10-06 09:38:00 -0700 [PATCH] Proposed Fix table-sort-1.patch text/plain 3945 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDlkMGJkMjA5YjdhLi4zZWMwZDYxNDNhMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTctMTAtMDUgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBJbXByb3ZlIHNldHRpbmcgdGhlIGRlZmF1bHQgLyBpbml0aWFsIHNvcnQgb2YgYSBUYWJsZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3OTg5CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzOgorICAgICAgICAoV0kuTmV0 d29ya1RhYmxlQ29udGVudFZpZXcucHJvdG90eXBlLmluaXRpYWxMYXlvdXQpOgorICAgICAgICBT ZXQgdGhlIGRlZmF1bHQgLyBpbml0aWFsIHNvcnQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L1ZpZXdzL1RhYmxlLmpzOgorICAgICAgICAoV0kuVGFibGUpOgorICAgICAgICAoV0kuVGFibGUu cHJvdG90eXBlLnNldCBzb3J0T3JkZXIpOgorICAgICAgICAoV0kuVGFibGUucHJvdG90eXBlLnNl dCBzb3J0Q29sdW1uSWRlbnRpZmllcik6CisgICAgICAgIER1cmluZyBzZXR1cCB3ZSBzaG91bGQg YWx3YXlzIHVwZGF0ZSBoZWFkZXIgdmlld3MuCisKKzIwMTctMTAtMDUgIEpvc2VwaCBQZWNvcmFy byAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBOZXR3b3Jr IFRhYiAtIENvb2tpZXMgRGV0YWlsIFZpZXcKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3Nzk4OAogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzQwNzE5 Mjc+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9OZXR3b3JrVGFibGVDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL05ldHdvcmtUYWJsZUNvbnRlbnRWaWV3LmpzCmluZGV4IDAwNDI0Mzg4 YzA2Li5kZTUxYjRiZTU3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcuanMKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmV0d29ya1RhYmxlQ29udGVudFZpZXcu anMKQEAgLTU2OSw2ICs1NjksMTEgQEAgV0kuTmV0d29ya1RhYmxlQ29udGVudFZpZXcgPSBjbGFz cyBOZXR3b3JrVGFibGVDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRlbnRWaWUKICAgICAgICAg dGhpcy5fdGFibGUuYWRkQ29sdW1uKHRoaXMuX3RpbWVDb2x1bW4pOwogICAgICAgICB0aGlzLl90 YWJsZS5hZGRDb2x1bW4odGhpcy5fd2F0ZXJmYWxsQ29sdW1uKTsKIAorICAgICAgICBpZiAoIXRo aXMuX3RhYmxlLnNvcnRDb2x1bW5JZGVudGlmaWVyKSB7CisgICAgICAgICAgICB0aGlzLl90YWJs ZS5zb3J0T3JkZXIgPSBXSS5UYWJsZS5Tb3J0T3JkZXIuQXNjZW5kaW5nOworICAgICAgICAgICAg dGhpcy5fdGFibGUuc29ydENvbHVtbklkZW50aWZpZXIgPSAid2F0ZXJmYWxsIjsKKyAgICAgICAg fQorCiAgICAgICAgIHRoaXMuYWRkU3Vidmlldyh0aGlzLl90YWJsZSk7CiAgICAgfQogCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzCmlu ZGV4IDRmNDQ0ZWRhNDg2Li42ODE1YjcyMDFmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMKQEAgLTk2LDE0ICs5NiwxMyBAQCBX SS5UYWJsZSA9IGNsYXNzIFRhYmxlIGV4dGVuZHMgV0kuVmlldwogICAgICAgICB0aGlzLl9yZXNp emVPcmlnaW5hbENvbHVtbldpZHRocyA9IG51bGw7CiAgICAgICAgIHRoaXMuX2xhc3RDb2x1bW5J bmRleFRvQWNjZXB0UmVtYWluZGVyUGl4ZWwgPSAwOwogCi0gICAgICAgIHRoaXMuX3NvcnRPcmRl ciA9IFdJLlRhYmxlLlNvcnRPcmRlci5JbmRldGVybWluYXRlOwotICAgICAgICB0aGlzLl9zb3J0 Q29sdW1uSWRlbnRpZmllciA9IG51bGw7Ci0gICAgICAgIHRoaXMuX3NvcnRSZXF1ZXN0SWRlbnRp ZmllciA9IHVuZGVmaW5lZDsKLQotICAgICAgICB0aGlzLl9zb3J0T3JkZXJTZXR0aW5nID0gbmV3 IFdJLlNldHRpbmcodGhpcy5faWRlbnRpZmllciArICItc29ydC1vcmRlciIsIHRoaXMuX3NvcnRP cmRlcik7Ci0gICAgICAgIHRoaXMuX3NvcnRDb2x1bW5JZGVudGlmaWVyU2V0dGluZyA9IG5ldyBX SS5TZXR0aW5nKHRoaXMuX2lkZW50aWZpZXIgKyAiLXNvcnQiLCB0aGlzLl9zb3J0Q29sdW1uSWRl bnRpZmllcik7CisgICAgICAgIHRoaXMuX3NvcnRPcmRlclNldHRpbmcgPSBuZXcgV0kuU2V0dGlu Zyh0aGlzLl9pZGVudGlmaWVyICsgIi1zb3J0LW9yZGVyIiwgV0kuVGFibGUuU29ydE9yZGVyLklu ZGV0ZXJtaW5hdGUpOworICAgICAgICB0aGlzLl9zb3J0Q29sdW1uSWRlbnRpZmllclNldHRpbmcg PSBuZXcgV0kuU2V0dGluZyh0aGlzLl9pZGVudGlmaWVyICsgIi1zb3J0IiwgbnVsbCk7CiAgICAg ICAgIHRoaXMuX2NvbHVtblZpc2liaWxpdHlTZXR0aW5nID0gbmV3IFdJLlNldHRpbmcodGhpcy5f aWRlbnRpZmllciArICItY29sdW1uLXZpc2liaWxpdHkiLCB7fSk7CiAKKyAgICAgICAgdGhpcy5f c29ydE9yZGVyID0gdGhpcy5fc29ydE9yZGVyU2V0dGluZy52YWx1ZTsKKyAgICAgICAgdGhpcy5f c29ydENvbHVtbklkZW50aWZpZXIgPSB0aGlzLl9zb3J0Q29sdW1uSWRlbnRpZmllclNldHRpbmcu dmFsdWU7CisKICAgICAgICAgdGhpcy5fY2FjaGVkV2lkdGggPSBOYU47CiAgICAgICAgIHRoaXMu X2NhY2hlZEhlaWdodCA9IE5hTjsKICAgICAgICAgdGhpcy5fY2FjaGVkU2Nyb2xsVG9wID0gTmFO OwpAQCAtMTMzLDcgKzEzMiw3IEBAIFdJLlRhYmxlID0gY2xhc3MgVGFibGUgZXh0ZW5kcyBXSS5W aWV3CiAKICAgICBzZXQgc29ydE9yZGVyKHNvcnRPcmRlcikKICAgICB7Ci0gICAgICAgIGlmIChz b3J0T3JkZXIgPT09IHRoaXMuX3NvcnRPcmRlcikKKyAgICAgICAgaWYgKHNvcnRPcmRlciA9PT0g dGhpcy5fc29ydE9yZGVyICYmIHRoaXMuZGlkSW5pdGlhbExheW91dCkKICAgICAgICAgICAgIHJl dHVybjsKIAogICAgICAgICBjb25zb2xlLmFzc2VydChzb3J0T3JkZXIgPT09IFdJLlRhYmxlLlNv cnRPcmRlci5JbmRldGVybWluYXRlIHx8IHNvcnRPcmRlciA9PT0gV0kuVGFibGUuU29ydE9yZGVy LkFzY2VuZGluZyB8fCBzb3J0T3JkZXIgPT09IFdJLlRhYmxlLlNvcnRPcmRlci5EZXNjZW5kaW5n KTsKQEAgLTE2Miw3ICsxNjEsNyBAQCBXSS5UYWJsZSA9IGNsYXNzIFRhYmxlIGV4dGVuZHMgV0ku VmlldwogCiAgICAgc2V0IHNvcnRDb2x1bW5JZGVudGlmaWVyKGNvbHVtbklkZW50aWZpZXIpCiAg ICAgewotICAgICAgICBpZiAoY29sdW1uSWRlbnRpZmllciA9PT0gdGhpcy5fc29ydENvbHVtbklk ZW50aWZpZXIpCisgICAgICAgIGlmIChjb2x1bW5JZGVudGlmaWVyID09PSB0aGlzLl9zb3J0Q29s dW1uSWRlbnRpZmllciAmJiB0aGlzLmRpZEluaXRpYWxMYXlvdXQpCiAgICAgICAgICAgICByZXR1 cm47CiAKICAgICAgICAgbGV0IGNvbHVtbiA9IHRoaXMuX2NvbHVtblNwZWNzLmdldChjb2x1bW5J ZGVudGlmaWVyKTsK