177976 2017-10-05 15:58:42 -0700 [MSE][GStreamer] Seek on youtube.com/tv fails after r217185 2017-10-06 00:45:15 -0700 1 1 1 Unclassified WebKit Media WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eocanha eocanha commit-queue jer.noble webkit-bug-importer oldest_to_newest 1357303 0 eocanha 2017-10-05 15:58:42 -0700 http://trac.webkit.org/changeset/217185 added an extra call to MediaSourcePrivate::waitForSeekCompleted() on MediaSource::seekToTime() that our MediaPlayerPrivateGStreamerMSE (the final receiver) isn't expecting. This is completely breaking the seek behaviour because, unlike MediaPlayerPrivateMediaSourceAVFObjC, the GStreamer MSE player private doesn't have an internal seek state to distinguish the original call from the new one. 1357313 1 322931 eocanha 2017-10-05 16:07:05 -0700 Created attachment 322931 Patch 1357325 2 jer.noble 2017-10-05 16:31:55 -0700 Sorry about that! But keep in mind, there are some WebGL conformance tests that require that the <video> element has a decoded frame available as soon as the "seeked" event fires. The point of the second "waitForSeekCompleted()" was to give the private an opportunity to delay completion of a seek until it's had a chance to decode the frame at the seeded time. So you may want to look into adding that kind of behavior to the GStreamer back-end. 1357491 3 eocanha 2017-10-06 00:19:48 -0700 Thanks for pointing it out. However, by now our priority should be to put MSE in GStreamer on a better shape (lots of w3c tests failing, webm support, still some seek corner cases). Then we can focus on proper interoperation with other parts of webkit (WebGL, as you mention). 1357501 4 322931 commit-queue 2017-10-06 00:44:14 -0700 Comment on attachment 322931 Patch Clearing flags on attachment: 322931 Committed r222966: <http://trac.webkit.org/changeset/222966> 1357502 5 commit-queue 2017-10-06 00:44:15 -0700 All reviewed patches have been landed. Closing bug. 1357503 6 webkit-bug-importer 2017-10-06 00:45:15 -0700 <rdar://problem/34851779> 322931 2017-10-05 16:07:05 -0700 2017-10-06 00:44:14 -0700 Patch bug-177976-20171005230703.patch text/plain 1488 eocanha U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNDk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmQwNThhZmE4ODMwNjRj OTAzMjllM2I4YjYzZThiMTRlYTllNmJhMy4uMzAxYzBlZGMyNDQ2NDdhMDQzODFhYzk0NmVmMDQy MjFlZGM4YjA0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTEwLTA1ICBFbnJp cXVlIE9jYcOxYSBHb256w6FsZXogIDxlb2NhbmhhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW01T RV1bR1N0cmVhbWVyXSBTZWVrIG9uIHlvdXR1YmUuY29tL3R2IGZhaWxzIGFmdGVyIHIyMTcxODUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Nzk3Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVyZWQg YnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBNb2R1bGVzL21lZGlhc291cmNlL01lZGlh U291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU291cmNlOjpzZWVrVG9UaW1lKTog T25seSBjYWxsIHdhaXRGb3JTZWVrQ29tcGxldGVkKCkKKyAgICAgICAgd2hlbiB0aGUgdGltZSBp cyBub3QgYnVmZmVyZWQgd2hlbiB1c2luZyBHU3RyZWFtZXIuCisKIDIwMTctMDktMjYgIFphbiBE b2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtFTUVdIEFkZCBDbGVh cktleSBzdXBwb3J0IGZvciBwZXJzaXN0ZW50IHNlc3Npb24gZGF0YSBsb2FkIGFuZCByZW1vdmFs CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL01lZGlhU291 cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2Uu Y3BwCmluZGV4IGMyY2VmYzY5YjA4YWU4MGNhNGI1NzNjOWY5ZjNlMTVkZDI5NTEzMzYuLjVmMjhi MzRjMzg4YmMyMjkzMDEyYTQ4MTE4YTIxOTQ0MjYxYmZhNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuY3BwCkBAIC0yMzIsNyArMjMy LDEwIEBAIHZvaWQgTWVkaWFTb3VyY2U6OnNlZWtUb1RpbWUoY29uc3QgTWVkaWFUaW1lJiB0aW1l KQogICAgIC8vIOKGsyBPdGhlcndpc2UKICAgICAvLyBDb250aW51ZQogCisvLyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTI1MTU3IGJyb2tlIHNlZWsgb24gTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyTVNFCisjaWYgIVVTRShHU1RSRUFNRVIpCiAgICAgbV9wcml2 YXRlLT53YWl0Rm9yU2Vla0NvbXBsZXRlZCgpOworI2VuZGlmCiAgICAgY29tcGxldGVTZWVrKCk7 CiB9CiAK