177970 2017-10-05 14:49:19 -0700 Win EWS bots should reboot after N webkit-patch iterations. 2018-01-26 09:16:33 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 pvollan pvollan achristensen ap bfulgham commit-queue lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1357258 0 pvollan 2017-10-05 14:49:19 -0700 I believe the macOS EWS bots reboot after webkit-patch has processed N patches. 1357261 1 322920 pvollan 2017-10-05 14:51:36 -0700 Created attachment 322920 Patch 1357268 2 ryanhaddad 2017-10-05 15:09:26 -0700 I know we have seen Windows EWS bots require a manual log in before coming back online in the past. Do we think this will still be an issue? 1357276 3 pvollan 2017-10-05 15:16:09 -0700 (In reply to Ryan Haddad from comment #2) > I know we have seen Windows EWS bots require a manual log in before coming > back online in the past. Do we think this will still be an issue? I believe we have fixed this by enabling auto-login again. 1357312 4 ryanhaddad 2017-10-05 16:05:38 -0700 (In reply to Per Arne Vollan from comment #3) > (In reply to Ryan Haddad from comment #2) > > I know we have seen Windows EWS bots require a manual log in before coming > > back online in the past. Do we think this will still be an issue? > > I believe we have fixed this by enabling auto-login again. Ah, that would do it. I made this change for the macOS EWS bots to try to prevent them from getting into weird states with stuck processes. If we think the reboots benefit Windows EWS, this looks good to me. 1371181 5 ryanhaddad 2017-11-13 17:22:13 -0800 I hit a case today where a Windows EWS bot needed 'svn cleanup' to be run. This change would have allowed the bot to recover itself after a few more runs without my intervention. Any reviewers willing to r+ this? 1371205 6 322920 bfulgham 2017-11-13 18:42:37 -0800 Comment on attachment 322920 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322920&action=review > Tools/ChangeLog:3 > + Win EWS bots should reboot after N webkit-patch iterations. It looks like N in this case is 1. If you think EWS will keep up with the change, r=me 1372602 7 322920 pvollan 2017-11-16 07:32:52 -0800 Comment on attachment 322920 Patch Thanks for reviewing! 1372612 8 322920 commit-queue 2017-11-16 07:52:32 -0800 Comment on attachment 322920 Patch Clearing flags on attachment: 322920 Committed r224920: <https://trac.webkit.org/changeset/224920> 1372613 9 commit-queue 2017-11-16 07:52:33 -0800 All reviewed patches have been landed. Closing bug. 1372614 10 webkit-bug-importer 2017-11-16 07:53:16 -0800 <rdar://problem/35588672> 1393540 11 pvollan 2018-01-26 09:16:33 -0800 Rolled out in <https://trac.webkit.org/changeset/227679/webkit>. Some EWS bots are not coming back online after initiating reboot. 322920 2017-10-05 14:51:36 -0700 2017-11-16 07:52:32 -0800 Patch bug-177970-20171005235134.patch text/plain 3397 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMjkzMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEyIEBACisyMDE3LTEwLTA1ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBXaW4gRVdTIGJvdHMgc2hvdWxkIHJlYm9vdCBhZnRlciBOIHdlYmtpdC1w YXRjaCBpdGVyYXRpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTc3OTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBFV1NUb29scy9zdGFydC1xdWV1ZS13aW4uc2g6CisKIDIwMTctMTAtMDUgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQuIFJ1biBXZWJLaXQyIEMgQVBJIHRlc3RzIGluIEdUSysgYm90cyBhZ2FpbiBhZnRlciB0 aGUgbGFzdCBXZWJLaXQyIC0+IFdlYktpdCByZW5hbWUuCkluZGV4OiBUb29scy9FV1NUb29scy9z dGFydC1xdWV1ZS13aW4uc2gKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvRVdTVG9vbHMvc3RhcnQtcXVl dWUtd2luLnNoCShyZXZpc2lvbiAyMjI4NTkpCisrKyBUb29scy9FV1NUb29scy9zdGFydC1xdWV1 ZS13aW4uc2gJKHdvcmtpbmcgY29weSkKQEAgLTIxLDQ0ICsyMSw0MSBAQCBmdW5jdGlvbiBzdGFy dF9ld3MoKQogCiAgICAgIiRQUk9HUkFNRklMRVNfWDg2L01pY3Jvc29mdCBWaXN1YWwgU3R1ZGlv IDE0LjAvVkMvdmN2YXJzYWxsLmJhdCIKIAotICAgIHdoaWxlIDoKLSAgICBkbwotICAgICAgICBk YXRlCi0gICAgICAgIGVjaG8gIlRBU0s6IGNsZWFuaW5nIHVwIG9sZCBsb2cgZmlsZXMuIgotICAg ICAgICBjZCB+L3dpbi1ld3MtbG9ncwotICAgICAgICBybSAtcmYgd2luLWV3cy5vbGQKLSAgICAg ICAgbXYgd2luLWV3cy5sb2cgd2luLWV3cy5vbGQKLSAgICAgICAgZmluZCB+L3dpbi1ld3MtbG9n cyAtbXRpbWUgKzcgLWV4ZWMgcm0gLWYge30gXDsKLSAgICAgICAgZWNobyAiVEFTSzogU3RhcnRp bmcgdXAiCi0gICAgICAgIGNkIH4vV2ViS2l0Ci0gICAgICAgIGV4cG9ydCBWU0lOU1RBTExESVI9 IiRQUk9HUkFNRklMRVNfWDg2XE1pY3Jvc29mdCBWaXN1YWwgU3R1ZGlvIDE0LjAiCi0gICAgICAg IGVjaG8gIlRBU0s6IENsZWFuaW5nIFdlYktpdEJ1aWxkIgotICAgICAgICBybSAtcmYgV2ViS2l0 QnVpbGQKLSAgICAgICAgZGF0ZQotICAgICAgICBlY2hvICJUQVNLOiBDbGVhbmluZyB1cCIKLSAg ICAgICAgc3ZuIGNsZWFudXAKLSAgICAgICAgZGF0ZQotICAgICAgICBlY2hvICJUQVNLOiBzdm4g cmV2ZXJ0IC1SICoiCi0gICAgICAgIHN2biByZXZlcnQgLVIgKgotICAgICAgICBkYXRlCi0gICAg ICAgIGVjaG8gIlRBU0s6IHN2biBzdGF0dXMiCi0gICAgICAgIHN2biBzdGF0dXMgfCBncmVwICI/ IiB8IGF3ayAne3ByaW50ICQyfScgfCB4YXJncyBybSAtcmYKLSAgICAgICAgZGF0ZQotICAgICAg ICBlY2hvICJUQVNLOiB3ZWJraXQtcGF0Y2ggY2xlYW4iCi0gICAgICAgIH4vV2ViS2l0L1Rvb2xz L1NjcmlwdHMvd2Via2l0LXBhdGNoIGNsZWFuCi0gICAgICAgIGRhdGUKLSAgICAgICAgZWNobyAi VEFTSzogc3ZuIHVwIC0tbm9uLWludGVyYWN0aXZlIgotICAgICAgICBzdm4gdXAgLS1ub24taW50 ZXJhY3RpdmUKLSAgICAgICAgZGF0ZQotICAgICAgICBlY2hvICJUQVNLOiBraWxsIG9ycGhhbmVk IHRhc2tzIgotICAgICAgICB0YXNra2lsbC5leGUgL2YgL2ltIGNsLmV4ZQotICAgICAgICBlY2hv ICJUQVNLOiB0ZXN0LXdlYmtpdHB5IgotICAgICAgICB+L1dlYktpdC9Ub29scy9TY3JpcHRzL3Rl c3Qtd2Via2l0cHkKLSAgICAgICAgZWNobyAiVEFTSzogd2Via2l0LXBhdGNoIHdpbi1ld3MiCi0g ICAgICAgIH4vV2ViS2l0L1Rvb2xzL1NjcmlwdHMvd2Via2l0LXBhdGNoIHdpbi1ld3MgLS1ib3Qt aWQ9JEJPVF9JRCAtLW5vLWNvbmZpcm0gLS1leGl0LWFmdGVyLWl0ZXJhdGlvbiAxMAotICAgICAg ICBlY2hvICJUQVNLOiBraWxsIG9sZCBwcm9jZXNzZXMiCi0gICAgICAgIH4vV2ViS2l0L1Rvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2tpbGwtb2xkLXByb2Nlc3NlcwotICAgIGRvbmUKKyAgICBkYXRl CisgICAgZWNobyAiVEFTSzogY2xlYW5pbmcgdXAgb2xkIGxvZyBmaWxlcy4iCisgICAgY2Qgfi93 aW4tZXdzLWxvZ3MKKyAgICBybSAtcmYgd2luLWV3cy5vbGQKKyAgICBtdiB3aW4tZXdzLmxvZyB3 aW4tZXdzLm9sZAorICAgIGZpbmQgfi93aW4tZXdzLWxvZ3MgLW10aW1lICs3IC1leGVjIHJtIC1m IHt9IFw7CisgICAgZWNobyAiVEFTSzogU3RhcnRpbmcgdXAiCisgICAgY2Qgfi9XZWJLaXQKKyAg ICBleHBvcnQgVlNJTlNUQUxMRElSPSIkUFJPR1JBTUZJTEVTX1g4NlxNaWNyb3NvZnQgVmlzdWFs IFN0dWRpbyAxNC4wIgorICAgIGVjaG8gIlRBU0s6IENsZWFuaW5nIFdlYktpdEJ1aWxkIgorICAg IHJtIC1yZiBXZWJLaXRCdWlsZAorICAgIGRhdGUKKyAgICBlY2hvICJUQVNLOiBDbGVhbmluZyB1 cCIKKyAgICBzdm4gY2xlYW51cAorICAgIGRhdGUKKyAgICBlY2hvICJUQVNLOiBzdm4gcmV2ZXJ0 IC1SICoiCisgICAgc3ZuIHJldmVydCAtUiAqCisgICAgZGF0ZQorICAgIGVjaG8gIlRBU0s6IHN2 biBzdGF0dXMiCisgICAgc3ZuIHN0YXR1cyB8IGdyZXAgIj8iIHwgYXdrICd7cHJpbnQgJDJ9JyB8 IHhhcmdzIHJtIC1yZgorICAgIGRhdGUKKyAgICBlY2hvICJUQVNLOiB3ZWJraXQtcGF0Y2ggY2xl YW4iCisgICAgfi9XZWJLaXQvVG9vbHMvU2NyaXB0cy93ZWJraXQtcGF0Y2ggY2xlYW4KKyAgICBk YXRlCisgICAgZWNobyAiVEFTSzogc3ZuIHVwIC0tbm9uLWludGVyYWN0aXZlIgorICAgIHN2biB1 cCAtLW5vbi1pbnRlcmFjdGl2ZQorICAgIGRhdGUKKyAgICBlY2hvICJUQVNLOiBraWxsIG9ycGhh bmVkIHRhc2tzIgorICAgIHRhc2traWxsLmV4ZSAvZiAvaW0gY2wuZXhlCisgICAgZWNobyAiVEFT SzogdGVzdC13ZWJraXRweSIKKyAgICB+L1dlYktpdC9Ub29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0 cHkKKyAgICBlY2hvICJUQVNLOiB3ZWJraXQtcGF0Y2ggd2luLWV3cyIKKyAgICB+L1dlYktpdC9U b29scy9TY3JpcHRzL3dlYmtpdC1wYXRjaCB3aW4tZXdzIC0tYm90LWlkPSRCT1RfSUQgLS1uby1j b25maXJtIC0tZXhpdC1hZnRlci1pdGVyYXRpb24gMTAKKyAgICBlY2hvICJUQVNLOiByZWJvb3Qi CisgICAgc2h1dGRvd24gL3IKIH0KIAogc3RhcnRfZXdzCg==