17797 2008-03-12 10:38:21 -0700 WinLauncher Fails to Build on Build Bot 2008-03-13 21:40:07 -0700 1 1 1 Unclassified WebKit WebKit Misc. 523.x (Safari 3) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 bfulgham webkit-unassigned oldest_to_newest 73479 0 bfulgham 2008-03-12 10:38:21 -0700 Although WinLauncher builds correctly if the build is controlled through the Visual Studio IDE, it fails to build via the "build-webkit" script. This is because certain core windows libraries are not included in the link commands for the WinLauncher target. 73480 1 19702 bfulgham 2008-03-12 10:44:22 -0700 Created attachment 19702 Use explicit library callouts * Correct include path for Release vsprops to use project variables (to be consistent with all other project files). * Correct Release and Debug builds to explicitly call out the required Windows libraries needed to produce a working executable. 73488 2 19704 bfulgham 2008-03-12 12:33:17 -0700 Created attachment 19704 Revised to just correct vsprops * Revised patch now that sfalken has added the library includes needed to build in r31000. 73587 3 19704 darin 2008-03-13 10:19:56 -0700 Comment on attachment 19704 Revised to just correct vsprops Looks fine, even to someone with my admittedly-small level of Windows expertise. r=me 73671 4 dev+webkit 2008-03-13 21:40:07 -0700 Committed revision 31053. 19702 2008-03-12 10:44:22 -0700 2008-03-12 12:33:17 -0700 Use explicit library callouts WinLauncher.patch text/plain 2620 bfulgham SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDMwOTk0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMDMtMTIgIEJyZW50IEZ1bGdoYW0gIDxi ZnVsZ2hhbUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2luTGF1bmNoZXIgZmFpbGVkIHRvIGJ1aWxkIG9uIHRoZSBidWlsZCBib3Qg YmVjYXVzZSBjZXJ0YWluCisgICAgICAgIGtleSBsaWJyYXJpZXMgd2VyZSBub3QgZXhwbGljaXRs eSBzcGVjaWZpZWQgaW4gdGhlIHByb2plY3QKKyAgICAgICAgcnVsZXMuICBUaGV5IHdlcmUgaW1w bGljaXRseSBhZGRlZCBpbnNpZGUgdGhlIFZpc3VhbCBTdHVkaW8KKyAgICAgICAgZW52aXJvbm1l bnQsIG1hc2tpbmcgdGhlIHByb2JsZW0uCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3Nzk3LgorCisgICAgICAgICogV2luTGF1bmNoZXIvV2luTGF1bmNo ZXIudmNwcm9qOiAgQWRkIG1pc3NpbmcgbGlicmFyeSBsaW5rYWdlCisKIDIwMDgtMDMtMTEgIEJy ZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg QWRhbSBSb2Jlbi4KSW5kZXg6IFdlYktpdFRvb2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLnZj cHJvago9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9XaW5MYXVuY2hlci9XaW5MYXVuY2hlci52 Y3Byb2oJKHJldmlzaW9uIDMwOTkyKQorKysgV2ViS2l0VG9vbHMvV2luTGF1bmNoZXIvV2luTGF1 bmNoZXIudmNwcm9qCSh3b3JraW5nIGNvcHkpCkBAIC0yMCw3ICsyMCw3IEBACiAJCQlPdXRwdXRE aXJlY3Rvcnk9IiQoV2ViS2l0T3V0cHV0RGlyKVxiaW4iCiAJCQlJbnRlcm1lZGlhdGVEaXJlY3Rv cnk9IiQoV2ViS2l0T3V0cHV0RGlyKVxvYmpcJChQcm9qZWN0TmFtZSlcJChDb25maWd1cmF0aW9u TmFtZSkiCiAJCQlDb25maWd1cmF0aW9uVHlwZT0iMSIKLQkJCUluaGVyaXRlZFByb3BlcnR5U2hl ZXRzPSIuLlwuLlxXZWJLaXRMaWJyYXJpZXNcd2luXHRvb2xzXHZzcHJvcHNcY29tbW9uLnZzcHJv cHM7Li5cLi5cV2ViS2l0TGlicmFyaWVzXHdpblx0b29sc1x2c3Byb3BzXGRlYnVnLnZzcHJvcHMi CisJCQlJbmhlcml0ZWRQcm9wZXJ0eVNoZWV0cz0iJChXZWJLaXRMaWJyYXJpZXNEaXIpXHRvb2xz XHZzcHJvcHNcY29tbW9uLnZzcHJvcHM7JChXZWJLaXRMaWJyYXJpZXNEaXIpXHRvb2xzXHZzcHJv cHNcZGVidWcudnNwcm9wcyIKIAkJCUNoYXJhY3RlclNldD0iMSIKIAkJCT4KIAkJCTxUb29sCkBA IC02NSw3ICs2NSw3IEBACiAJCQk8VG9vbAogCQkJCU5hbWU9IlZDTGlua2VyVG9vbCIKIAkJCQlM aW5rTGlicmFyeURlcGVuZGVuY2llcz0iZmFsc2UiCi0JCQkJQWRkaXRpb25hbERlcGVuZGVuY2ll cz0iY29tY3RsMzIubGliIHNobHdhcGkubGliIFdlYktpdEdVSUQkKFdlYktpdENvbmZpZ1N1ZmZp eCkubGliIFdlYktpdCQoV2ViS2l0RExMQ29uZmlnU3VmZml4KS5saWIiCisJCQkJQWRkaXRpb25h bERlcGVuZGVuY2llcz0iV2ViS2l0R1VJRCQoV2ViS2l0Q29uZmlnU3VmZml4KS5saWIgV2ViS2l0 JChXZWJLaXRETExDb25maWdTdWZmaXgpLmxpYiBnZGkzMi5saWIgb2xlMzIubGliIG9sZWF1dDMy LmxpYiB1c2VyMzIubGliIGNvbWN0bDMyLmxpYiBzaGx3YXBpLmxpYiIKIAkJCQlMaW5rSW5jcmVt ZW50YWw9IjIiCiAJCQkJQWRkaXRpb25hbExpYnJhcnlEaXJlY3Rvcmllcz0iJnF1b3Q7JChXZWJL aXRPdXRwdXREaXIpXGxpYiZxdW90OzsmcXVvdDskKFByb2plY3REaXIpXC4uXC4uXC4uXCZxdW90 OyIKIAkJCQlHZW5lcmF0ZURlYnVnSW5mb3JtYXRpb249InRydWUiCkBAIC0xNDYsNyArMTQ2LDcg QEAKIAkJCQlOYW1lPSJWQ0xpbmtlclRvb2wiCiAJCQkJTGlua0xpYnJhcnlEZXBlbmRlbmNpZXM9 ImZhbHNlIgogCQkJCUFkZGl0aW9uYWxPcHRpb25zPSImI3gwRDsmI3gwQTsiCi0JCQkJQWRkaXRp b25hbERlcGVuZGVuY2llcz0iY29tY3RsMzIubGliIHNobHdhcGkubGliIFdlYktpdEdVSUQkKFdl YktpdENvbmZpZ1N1ZmZpeCkubGliIFdlYktpdCQoV2ViS2l0RExMQ29uZmlnU3VmZml4KS5saWIi CisJCQkJQWRkaXRpb25hbERlcGVuZGVuY2llcz0iV2ViS2l0R1VJRCQoV2ViS2l0Q29uZmlnU3Vm Zml4KS5saWIgV2ViS2l0JChXZWJLaXRETExDb25maWdTdWZmaXgpLmxpYiBnZGkzMi5saWIgb2xl MzIubGliIG9sZWF1dDMyLmxpYiB1c2VyMzIubGliIGNvbWN0bDMyLmxpYiBzaGx3YXBpLmxpYiIK IAkJCQlMaW5rSW5jcmVtZW50YWw9IjEiCiAJCQkJQWRkaXRpb25hbExpYnJhcnlEaXJlY3Rvcmll cz0iJnF1b3Q7JChXZWJLaXRPdXRwdXREaXIpXGxpYiZxdW90OzsmcXVvdDskKFByb2plY3REaXIp XC4uXC4uXC4uXCZxdW90OyIKIAkJCQlHZW5lcmF0ZURlYnVnSW5mb3JtYXRpb249InRydWUiCg== 19704 2008-03-12 12:33:17 -0700 2008-03-13 10:19:56 -0700 Revised to just correct vsprops WinLauncher.patch text/plain 1350 bfulgham SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDMxMDAzKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMDMtMTIgIEJyZW50IEZ1bGdoYW0gIDxi ZnVsZ2hhbUBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ29ycmVjdCBwYXRocyB0byB2c3Byb3BzIGZpbGVzIHNvIHRoZXkgdXNlIHRo ZSBlbnZpcm9ubWVudAorICAgICAgICB2YXJpYWJsZSwgcmF0aGVyIHRoYW4gaGFyZC1jb2RlZCBw YXRoLgorICAgICAgICBodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc5 Ny4KKworICAgICAgICAqIFdpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLnZjcHJvajogIENvcnJlY3Qg cGF0aHMgdG8gdnNwcm9wcy4KKwogMjAwOC0wMy0xMiAgU3RldmUgRmFsa2VuYnVyZyAgPHNmYWxr ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFZTRXhwcmVzcyBidWlsZCBmaXgKSW5kZXg6IFdlYktp dFRvb2xzL1dpbkxhdW5jaGVyL1dpbkxhdW5jaGVyLnZjcHJvago9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXRUb29scy9XaW5MYXVuY2hlci9XaW5MYXVuY2hlci52Y3Byb2oJKHJldmlzaW9uIDMxMDAzKQor KysgV2ViS2l0VG9vbHMvV2luTGF1bmNoZXIvV2luTGF1bmNoZXIudmNwcm9qCSh3b3JraW5nIGNv cHkpCkBAIC0yMCw3ICsyMCw3IEBACiAJCQlPdXRwdXREaXJlY3Rvcnk9IiQoV2ViS2l0T3V0cHV0 RGlyKVxiaW4iDQogCQkJSW50ZXJtZWRpYXRlRGlyZWN0b3J5PSIkKFdlYktpdE91dHB1dERpcilc b2JqXCQoUHJvamVjdE5hbWUpXCQoQ29uZmlndXJhdGlvbk5hbWUpIg0KIAkJCUNvbmZpZ3VyYXRp b25UeXBlPSIxIg0KLQkJCUluaGVyaXRlZFByb3BlcnR5U2hlZXRzPSIuLlwuLlxXZWJLaXRMaWJy YXJpZXNcd2luXHRvb2xzXHZzcHJvcHNcY29tbW9uLnZzcHJvcHM7Li5cLi5cV2ViS2l0TGlicmFy aWVzXHdpblx0b29sc1x2c3Byb3BzXGRlYnVnLnZzcHJvcHMiDQorCQkJSW5oZXJpdGVkUHJvcGVy dHlTaGVldHM9IiQoV2ViS2l0TGlicmFyaWVzRGlyKVx0b29sc1x2c3Byb3BzXGNvbW1vbi52c3By b3BzOyQoV2ViS2l0TGlicmFyaWVzRGlyKVx0b29sc1x2c3Byb3BzXGRlYnVnLnZzcHJvcHMiDQog CQkJQ2hhcmFjdGVyU2V0PSIxIg0KIAkJCT4NCiAJCQk8VG9vbA0K