177967 2017-10-05 14:15:14 -0700 EWS should run Windows tests. 2018-02-12 10:44:06 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan aakash_jain achristensen ap bfulgham buildbot commit-queue glenn jlewis3 lforschler ryanhaddad webkit-bug-importer oldest_to_newest 1357242 0 pvollan 2017-10-05 14:15:14 -0700 This will help catch regressions at an early stage. 1357243 1 pvollan 2017-10-05 14:17:13 -0700 <rdar://problem/22918746> 1357244 2 322915 pvollan 2017-10-05 14:18:52 -0700 Created attachment 322915 Patch 1357639 3 322915 ap 2017-10-06 10:16:33 -0700 Comment on attachment 322915 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322915&action=review > Tools/Scripts/webkitpy/common/config/ews.json:13 > + "runTests": true Do we have enough hardware set up for Windows EWS already? 1357647 4 pvollan 2017-10-06 10:28:49 -0700 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 322915 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322915&action=review > > > Tools/Scripts/webkitpy/common/config/ews.json:13 > > + "runTests": true > > Do we have enough hardware set up for Windows EWS already? Yes, I believe so, although it wouldn't hurt to get more :) I think I overestimated the extra time this would add to the total processing time. It adds 10-12 minutes for each EWS pass. 1357780 5 ap 2017-10-06 15:34:30 -0700 I see. Leaving this for Lucas to r+, and to face the consequences :) 1357808 6 pvollan 2017-10-06 16:16:01 -0700 (In reply to Alexey Proskuryakov from comment #5) > I see. Leaving this for Lucas to r+, and to face the consequences :) Sounds good :) Thanks! 1358393 7 lforschler 2017-10-09 13:32:42 -0700 I spoke with Alexey this morning. We discussed moving all Windows EWS bots to SSDs before turning this on. I’ll be tracking that in <rdar://problem/34891365> Check EWS hardware, find units that need SSD 1358485 8 pvollan 2017-10-09 16:20:59 -0700 (In reply to Lucas Forschler from comment #7) > I spoke with Alexey this morning. We discussed moving all Windows EWS bots > to SSDs before turning this on. > > I’ll be tracking that in > <rdar://problem/34891365> Check EWS hardware, find units that need SSD Great, thank you! 1398387 9 322915 commit-queue 2018-02-12 10:44:04 -0800 Comment on attachment 322915 Patch Clearing flags on attachment: 322915 Committed r228383: <https://trac.webkit.org/changeset/228383> 1398388 10 commit-queue 2018-02-12 10:44:06 -0800 All reviewed patches have been landed. Closing bug. 322915 2017-10-05 14:18:52 -0700 2018-02-12 10:44:04 -0800 Patch bug-177967-20171005231851.patch text/plain 1106 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMjkzMikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTEwLTA1ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBFV1Mgc2hvdWxkIHJ1biBXaW5kb3dzIHRlc3RzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3OTY3CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyB3aWxsIGhlbHAgY2F0Y2gg cmVncmVzc2lvbnMgYXQgYW4gZWFybHkgc3RhZ2UuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L2NvbW1vbi9jb25maWcvZXdzLmpzb246CisKIDIwMTctMTAtMDUgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJ1biBX ZWJLaXQyIEMgQVBJIHRlc3RzIGluIEdUSysgYm90cyBhZ2FpbiBhZnRlciB0aGUgbGFzdCBXZWJL aXQyIC0+IFdlYktpdCByZW5hbWUuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1v bi9jb25maWcvZXdzLmpzb24KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9j b21tb24vY29uZmlnL2V3cy5qc29uCShyZXZpc2lvbiAyMjI4NTkpCisrKyBUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jb25maWcvZXdzLmpzb24JKHdvcmtpbmcgY29weSkKQEAgLTksNyAr OSw4IEBACiAgICAgICAgICJwb3J0IjogIndpbiIsCiAgICAgICAgICJ3YXRjaGVycyI6IFsKICAg ICAgICAgICAgICJiZnVsZ2hhbUBhcHBsZS5jb20iCi0gICAgICAgIF0KKyAgICAgICAgXSwKKyAg ICAgICAgInJ1blRlc3RzIjogdHJ1ZQogICAgIH0sCiAgICAgImlPUyBFV1MiOiB7CiAgICAgICAg ICJwb3J0IjogImlvcy1kZXZpY2UiLAo=