177958 2017-10-05 12:23:40 -0700 Minor WeakPtr improvements 2017-10-06 06:10:20 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned benjamin buildbot cdumez cmarcelo commit-queue dbates sam webkit-bug-importer oldest_to_newest 1357166 0 koivisto 2017-10-05 12:23:40 -0700 Tweaks 1357167 1 322881 koivisto 2017-10-05 12:28:25 -0700 Created attachment 322881 patch 1357568 2 322881 commit-queue 2017-10-06 06:09:02 -0700 Comment on attachment 322881 patch Clearing flags on attachment: 322881 Committed r222977: <http://trac.webkit.org/changeset/222977> 1357569 3 commit-queue 2017-10-06 06:09:04 -0700 All reviewed patches have been landed. Closing bug. 1357571 4 webkit-bug-importer 2017-10-06 06:10:20 -0700 <rdar://problem/34854583> 322881 2017-10-05 12:28:25 -0700 2017-10-06 06:09:02 -0700 patch weakptr-tweaks.patch text/plain 5004 koivisto SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjI5MTEpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTA1ICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KKworICAgICAgICBNaW5vciBXZWFrUHRyIGltcHJvdmVtZW50cworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3OTU4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvV2Vha1B0 ci5oOgorICAgICAgICAoV1RGOjpXZWFrUHRyOjpvcGVyYXRvciBib29sIGNvbnN0KToKKworICAg ICAgICAgICAgTWFrZSBleHBsaWNpdC4KKworICAgICAgICAoV1RGOjpXZWFrUHRyRmFjdG9yeTo6 Y3JlYXRlV2Vha1B0ciBjb25zdCk6CisgICAgICAgIChXVEY6Om1ha2VXZWFrUHRyKToKKworICAg ICAgICAgICAgUmVtb3ZlIHRlbXBsYXRpbmcgZnJvbSBjcmVhdGVXZWFrUHRyLCBtYWtlV2Vha1B0 cigpIGlzIG5vdyB0aGUKKyAgICAgICAgICAgIGNhbm9uaWNhbCB3YXkgdG8gbWFrZSBkZXJpdmVk LXR5cGUgV2Vha1B0cnMuCisKIDIwMTctMTAtMDQgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBibWFsbG9jIG11dGV4IHNob3VsZCBiZSBhZGFwdGl2ZQpJbmRleDog U291cmNlL1dURi93dGYvV2Vha1B0ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1dl YWtQdHIuaAkocmV2aXNpb24gMjIyOTExKQorKysgU291cmNlL1dURi93dGYvV2Vha1B0ci5oCSh3 b3JraW5nIGNvcHkpCkBAIC02MSw5ICs2MSw2IEBAIHByaXZhdGU6CiAgICAgVCogbV9wdHI7CiB9 OwogCi10ZW1wbGF0ZTx0eXBlbmFtZSBULCB0eXBlbmFtZSBVPiBXZWFrUmVmZXJlbmNlPFQ+KiB3 ZWFrX3JlZmVyZW5jZV91cGNhc3QoV2Vha1JlZmVyZW5jZTxVPiopOwotdGVtcGxhdGU8dHlwZW5h bWUgVCwgdHlwZW5hbWUgVT4gV2Vha1JlZmVyZW5jZTxUPiogd2Vha19yZWZlcmVuY2VfZG93bmNh c3QoV2Vha1JlZmVyZW5jZTxVPiopOwotCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgogY2xhc3MgV2Vh a1B0ciB7CiAgICAgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQ7CkBAIC03NSw3ICs3Miw3IEBAIHB1 YmxpYzoKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBVPiBXZWFrUHRyKFdlYWtQdHI8VT4mJik7CiAK ICAgICBUKiBnZXQoKSBjb25zdCB7IHJldHVybiBtX3JlZiA/IG1fcmVmLT5nZXQoKSA6IG51bGxw dHI7IH0KLSAgICBvcGVyYXRvciBib29sKCkgY29uc3QgeyByZXR1cm4gbV9yZWYgJiYgbV9yZWYt PmdldCgpOyB9CisgICAgZXhwbGljaXQgb3BlcmF0b3IgYm9vbCgpIGNvbnN0IHsgcmV0dXJuIG1f cmVmICYmIG1fcmVmLT5nZXQoKTsgfQogCiAgICAgV2Vha1B0ciYgb3BlcmF0b3I9KHN0ZDo6bnVs bHB0cl90KSB7IG1fcmVmID0gbnVsbHB0cjsgcmV0dXJuICp0aGlzOyB9CiAgICAgdGVtcGxhdGU8 dHlwZW5hbWUgVT4gV2Vha1B0ciYgb3BlcmF0b3I9KGNvbnN0IFdlYWtQdHI8VT4mKTsKQEAgLTg4 LDYgKzg1LDcgQEAgcHVibGljOgogCiBwcml2YXRlOgogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+ IGZyaWVuZCBjbGFzcyBXZWFrUHRyOworICAgIHRlbXBsYXRlPHR5cGVuYW1lIFU+IGZyaWVuZCBX ZWFrUHRyPFU+IG1ha2VXZWFrUHRyKFUmKTsKIAogICAgIFJlZlB0cjxXZWFrUmVmZXJlbmNlPFQ+ PiBtX3JlZjsKIH07CkBAIC0xMDUsMTIgKzEwMywxMSBAQCBwdWJsaWM6CiAgICAgICAgIG1fcmVm LT5jbGVhcigpOwogICAgIH0KIAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFUgPSBUPgotICAgIFdl YWtQdHI8VT4gY3JlYXRlV2Vha1B0cihUJiBwdHIpIGNvbnN0CisgICAgV2Vha1B0cjxUPiBjcmVh dGVXZWFrUHRyKFQmIHB0cikgY29uc3QKICAgICB7CiAgICAgICAgIGlmICghbV9yZWYpCiAgICAg ICAgICAgICBtX3JlZiA9IFdlYWtSZWZlcmVuY2U8VD46OmNyZWF0ZSgmcHRyKTsKLSAgICAgICAg cmV0dXJuIHsgbWFrZVJlZigqd2Vha19yZWZlcmVuY2VfZG93bmNhc3Q8VT4obV9yZWYuZ2V0KCkp KSB9OworICAgICAgICByZXR1cm4geyBtYWtlUmVmKCptX3JlZikgfTsKICAgICB9CiAKICAgICB2 b2lkIHJldm9rZUFsbCgpCkBAIC0xNjIsNyArMTU5LDcgQEAgdGVtcGxhdGU8dHlwZW5hbWUgVD4g dGVtcGxhdGU8dHlwZW5hbWUgVQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgV2Vha1B0 cjxUPiBtYWtlV2Vha1B0cihUJiByZWYpCiB7Ci0gICAgcmV0dXJuIHJlZi53ZWFrUHRyRmFjdG9y eSgpLnRlbXBsYXRlIGNyZWF0ZVdlYWtQdHI8VD4ocmVmKTsKKyAgICByZXR1cm4geyBhZG9wdFJl Zigqd2Vha19yZWZlcmVuY2VfZG93bmNhc3Q8VD4ocmVmLndlYWtQdHJGYWN0b3J5KCkuY3JlYXRl V2Vha1B0cihyZWYpLm1fcmVmLmxlYWtSZWYoKSkpIH07CiB9CiAKIHRlbXBsYXRlPHR5cGVuYW1l IFQ+IGlubGluZSBXZWFrUHRyPFQ+IG1ha2VXZWFrUHRyKFQqIHB0cikKSW5kZXg6IFRvb2xzL0No YW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIyMjkyOCkK KysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3 LTEwLTA1ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBNaW5v ciBXZWFrUHRyIGltcHJvdmVtZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc3OTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9XZWFrUHRyLmNwcDoKKyAg ICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6QmFz ZTo6Y3JlYXRlV2Vha1B0cik6IERlbGV0ZWQuCisKIDIwMTctMTAtMDUgIENhcmxvcyBHYXJjaWEg Q2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIFJ1biBX ZWJLaXQyIEMgQVBJIHRlc3RzIGluIEdUSysgYm90cyBhZ2FpbiBhZnRlciB0aGUgbGFzdCBXZWJL aXQyIC0+IFdlYktpdCByZW5hbWUuCkluZGV4OiBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dU Ri9XZWFrUHRyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dU Ri9XZWFrUHRyLmNwcAkocmV2aXNpb24gMjIyOTExKQorKysgVG9vbHMvVGVzdFdlYktpdEFQSS9U ZXN0cy9XVEYvV2Vha1B0ci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQwLDkgKzQwLDkgQEAgVEVT VChXVEZfV2Vha1B0ciwgQmFzaWMpCiAgICAgRVhQRUNUX0VRKHdlYWtQdHIxLmdldCgpLCAmZHVt bXkpOwogICAgIEVYUEVDVF9FUSh3ZWFrUHRyMi5nZXQoKSwgJmR1bW15KTsKICAgICBFWFBFQ1Rf RVEod2Vha1B0cjMuZ2V0KCksICZkdW1teSk7Ci0gICAgRVhQRUNUX1RSVUUod2Vha1B0cjEpOwot ICAgIEVYUEVDVF9UUlVFKHdlYWtQdHIyKTsKLSAgICBFWFBFQ1RfVFJVRSh3ZWFrUHRyMyk7Cisg ICAgRVhQRUNUX1RSVUUoISF3ZWFrUHRyMSk7CisgICAgRVhQRUNUX1RSVUUoISF3ZWFrUHRyMik7 CisgICAgRVhQRUNUX1RSVUUoISF3ZWFrUHRyMyk7CiAgICAgRVhQRUNUX1RSVUUod2Vha1B0cjEg PT0gd2Vha1B0cjIpOwogICAgIEVYUEVDVF9UUlVFKHdlYWtQdHIxID09ICZkdW1teSk7CiAgICAg RVhQRUNUX1RSVUUoJmR1bW15ID09IHdlYWtQdHIyKTsKQEAgLTIwNiwxMiArMjA2LDYgQEAgcHVi bGljOgogICAgICAgICByZXR1cm4gMDsKICAgICB9CiAKLSAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBU PgotICAgIFdlYWtQdHI8VD4gY3JlYXRlV2Vha1B0cigpCi0gICAgewotICAgICAgICByZXR1cm4g bV93ZWFrUHRyRmFjdG9yeS5jcmVhdGVXZWFrUHRyPFQ+KCp0aGlzKTsKLSAgICB9Ci0KICAgICBh dXRvJiB3ZWFrUHRyRmFjdG9yeSgpIHsgcmV0dXJuIG1fd2Vha1B0ckZhY3Rvcnk7IH0KIAogcHJp dmF0ZToKQEAgLTIzOSwxMiArMjMzLDEyIEBAIFRFU1QoV1RGX1dlYWtQdHIsIERvd25jYXN0aW5n KQogICAgICAgICBEZXJpdmVkKiBkZXJpdmVkUHRyID0gJm9iamVjdDsKICAgICAgICAgQmFzZSog YmFzZVB0ciA9IHN0YXRpY19jYXN0PEJhc2UqPigmb2JqZWN0KTsKIAotICAgICAgICBiYXNlV2Vh a1B0ciA9IG9iamVjdC5jcmVhdGVXZWFrUHRyPEJhc2U+KCk7CisgICAgICAgIGJhc2VXZWFrUHRy ID0gb2JqZWN0LndlYWtQdHJGYWN0b3J5KCkuY3JlYXRlV2Vha1B0cihvYmplY3QpOwogICAgICAg ICBFWFBFQ1RfRVEoYmFzZVB0ci0+Zm9vKCksIGR1bW15MCk7CiAgICAgICAgIEVYUEVDVF9FUShi YXNlV2Vha1B0ci0+Zm9vKCksIGJhc2VQdHItPmZvbygpKTsKICAgICAgICAgRVhQRUNUX0VRKGJh c2VXZWFrUHRyLmdldCgpLT5mb28oKSwgYmFzZVB0ci0+Zm9vKCkpOwogCi0gICAgICAgIGRlcml2 ZWRXZWFrUHRyID0gb2JqZWN0LmNyZWF0ZVdlYWtQdHI8RGVyaXZlZD4oKTsKKyAgICAgICAgZGVy aXZlZFdlYWtQdHIgPSBtYWtlV2Vha1B0cihvYmplY3QpOwogICAgICAgICBFWFBFQ1RfRVEoZGVy aXZlZFdlYWtQdHItPmZvbygpLCBkdW1teTEpOwogICAgICAgICBFWFBFQ1RfRVEoZGVyaXZlZFdl YWtQdHItPmZvbygpLCBkZXJpdmVkUHRyLT5mb28oKSk7CiAgICAgICAgIEVYUEVDVF9FUShkZXJp dmVkV2Vha1B0ci5nZXQoKS0+Zm9vKCksIGRlcml2ZWRQdHItPmZvbygpKTsK