177931 2017-10-05 04:13:05 -0700 AX: [ATK] STATE_CHECKABLE should be removed from radio buttons in radiogroups with aria-readonly="true" 2017-10-10 01:55:24 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All Linux RESOLVED FIXED InRadar P2 Normal --- 1 jdiggs jdiggs aboxhall apinheiro buildbot cfleizach commit-queue dmazzoni jcraig samuel_white webkit-bug-importer oldest_to_newest 1356962 0 jdiggs 2017-10-05 04:13:05 -0700 Radio buttons in a readonly ARIA radiogroup should not claim to be settable/checkable, as per the Core AAM: https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#ariaReadonlyTrue 1356963 1 webkit-bug-importer 2017-10-05 04:13:25 -0700 <rdar://problem/34831213> 1356965 2 322820 jdiggs 2017-10-05 04:18:36 -0700 Created attachment 322820 Patch 1358247 3 322820 cfleizach 2017-10-09 09:34:38 -0700 Comment on attachment 322820 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322820&action=review > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:2107 > + return radioGroup ? radioGroup->ariaReadOnlyValue() != "true" : true; do we want to do equalIgnoringCase() for the != true 1358670 4 jdiggs 2017-10-10 01:26:13 -0700 (In reply to chris fleizach from comment #3) > Comment on attachment 322820 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322820&action=review > > > Source/WebCore/accessibility/AccessibilityNodeObject.cpp:2107 > > + return radioGroup ? radioGroup->ariaReadOnlyValue() != "true" : true; > > do we want to do equalIgnoringCase() for the != true In this case I don't believe it is necessary: ariaReadOnlyValue() applies convertToASCIILowercase() to the value being returned. 1358680 5 322820 commit-queue 2017-10-10 01:55:22 -0700 Comment on attachment 322820 Patch Clearing flags on attachment: 322820 Committed r223126: <http://trac.webkit.org/changeset/223126> 1358681 6 commit-queue 2017-10-10 01:55:24 -0700 All reviewed patches have been landed. Closing bug. 322820 2017-10-05 04:18:36 -0700 2017-10-10 01:55:22 -0700 Patch bug-177931-20171005131835.patch text/plain 6427 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyOTAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGExMmUxM2FhYTY2MDlk ZDM4NDQwZTI1ZTI5M2Q3NDgzODExYzFkNS4uMzU3Nzk3NmFiMWI0N2ExZmIzNWVlYTYwZTc4NDE5 MzBiYjA4ZDY3NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTA1ICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBBWDogW0FUS10gU1RB VEVfQ0hFQ0tBQkxFIHNob3VsZCBiZSByZW1vdmVkIGZyb20gcmFkaW8gYnV0dG9ucyBpbiByYWRp b2dyb3VwcyB3aXRoIGFyaWEtcmVhZG9ubHk9InRydWUiCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc5MzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBjaGVjayBpbiBjYW5TZXRWYWx1ZUF0dHJp YnV0ZSgpIGZvciByZWFkb25seSByYWRpb2dyb3VwIGFuY2VzdG9ycyBvZgorICAgICAgICByYWRp byBidXR0b25zLgorCisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvZ3RrL2FyaWEtcmVhZG9u bHktcmFkaW9ncm91cC5odG1sCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlOb2RlT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlOb2RlT2Jq ZWN0OjpjYW5TZXRWYWx1ZUF0dHJpYnV0ZSBjb25zdCk6CisgICAgICAgICogYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp dHlPYmplY3Q6OnJhZGlvR3JvdXBBbmNlc3RvciBjb25zdCk6CisgICAgICAgICogYWNjZXNzaWJp bGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CisKIDIwMTctMTAtMDQgIEFsZXggQ2hyaXN0ZW5z ZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZW1vdmUgV2ViQ29yZVN5 c3RlbUludGVyZmFjZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5Tm9kZU9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcAppbmRleCAxNjVkOTc1MDUzYTEwNTliZDQwZDc3 MDRkM2E2YTU1MWZjZTFhMWNjLi45MmUzMDRmMmQ2YzcwMzY3ODg3YzgyNDAzZTZlMWMyNDQxOTMy MTQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxp dHlOb2RlT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlOb2RlT2JqZWN0LmNwcApAQCAtMjA5OSw4ICsyMDk5LDEzIEBAIGJvb2wgQWNjZXNz aWJpbGl0eU5vZGVPYmplY3Q6OmNhblNldFZhbHVlQXR0cmlidXRlKCkgY29uc3QKICNpZiBQTEFU Rk9STShHVEspCiAgICAgLy8gSW4gQVRLLCBpbnB1dCB0eXBlcyB3aGljaCBzdXBwb3J0IGFyaWEt cmVhZG9ubHkgYXJlIHRyZWF0ZWQgYXMgaGF2aW5nIGEKICAgICAvLyBzZXR0YWJsZSB2YWx1ZSBp ZiB0aGUgdXNlciBjYW4gbW9kaWZ5IHRoZSB3aWRnZXQncyB2YWx1ZSBvciBpdHMgc3RhdGUuCi0g ICAgaWYgKHN1cHBvcnRzQVJJQVJlYWRPbmx5KCkgfHwgaXNSYWRpb0J1dHRvbigpKQorICAgIGlm IChzdXBwb3J0c0FSSUFSZWFkT25seSgpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKKworICAgIGlm IChpc1JhZGlvQnV0dG9uKCkpIHsKKyAgICAgICAgYXV0byByYWRpb0dyb3VwID0gcmFkaW9Hcm91 cEFuY2VzdG9yKCk7CisgICAgICAgIHJldHVybiByYWRpb0dyb3VwID8gcmFkaW9Hcm91cC0+YXJp YVJlYWRPbmx5VmFsdWUoKSAhPSAidHJ1ZSIgOiB0cnVlOworICAgIH0KICNlbmRpZgogCiAgICAg aWYgKGlzV2ViQXJlYSgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAppbmRleCA5OTgzZWMxZjQyYTI0OWNlZjRkOWYyNDE1 YmZjYjg3ODE4YzI2ZjBmLi5iOTcxMDBmYmEyMjNjOWUxZDIwZTMxMmY0ZTJiM2E1MDQ3NDczNjQy IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlP YmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eU9iamVjdC5jcHAKQEAgLTMzMTAsNiArMzMxMCwxMyBAQCBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBB Y2Nlc3NpYmlsaXR5T2JqZWN0OjpoaWdoZXN0RWRpdGFibGVBbmNlc3RvcigpCiAgICAgcmV0dXJu IHByZXZpb3VzRWRpdGFibGVBbmNlc3RvcjsKIH0KIAorQWNjZXNzaWJpbGl0eU9iamVjdCogQWNj ZXNzaWJpbGl0eU9iamVjdDo6cmFkaW9Hcm91cEFuY2VzdG9yKCkgY29uc3QKK3sKKyAgICByZXR1 cm4gY29uc3RfY2FzdDxBY2Nlc3NpYmlsaXR5T2JqZWN0Kj4oQWNjZXNzaWJpbGl0eU9iamVjdDo6 bWF0Y2hlZFBhcmVudCgqdGhpcywgZmFsc2UsIFtdIChjb25zdCBBY2Nlc3NpYmlsaXR5T2JqZWN0 JiBvYmplY3QpIHsKKyAgICAgICAgcmV0dXJuIG9iamVjdC5pc1JhZGlvR3JvdXAoKTsKKyAgICB9 KSk7Cit9CisKIGJvb2wgQWNjZXNzaWJpbGl0eU9iamVjdDo6aXNTdHlsZUZvcm1hdEdyb3VwKCkg Y29uc3QKIHsKICAgICBOb2RlKiBub2RlID0gdGhpcy0+bm9kZSgpOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmggYi9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaAppbmRleCAzNzFiYTky MDk2MjU0NjZlMjUzOWY0OTg4Y2Y1MDk3Mjk4MTNhZTU4Li4yMDdmNDhmZDhiMTZhNWEyZGQ1OWJk MGM5MDRkMWVlNjAyMjRkOTM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuaApAQCAtMTE2MSw2ICsxMTYxLDggQEAgcHJvdGVjdGVk OgogICAgIHZvaWQgYXJpYUVsZW1lbnRzRnJvbUF0dHJpYnV0ZShBY2Nlc3NpYmlsaXR5Q2hpbGRy ZW5WZWN0b3ImLCBjb25zdCBRdWFsaWZpZWROYW1lJikgY29uc3Q7CiAgICAgdm9pZCBhcmlhRWxl bWVudHNSZWZlcmVuY2VkQnlBdHRyaWJ1dGUoQWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVjdG9yJiwg Y29uc3QgUXVhbGlmaWVkTmFtZSYpIGNvbnN0OwogCisgICAgQWNjZXNzaWJpbGl0eU9iamVjdCog cmFkaW9Hcm91cEFuY2VzdG9yKCkgY29uc3Q7CisKICNpZiBQTEFURk9STShHVEspICYmIEhBVkUo QUNDRVNTSUJJTElUWSkKICAgICBib29sIGFsbG93c1RleHRSYW5nZXMoKSBjb25zdDsKICAgICB1 bnNpZ25lZCBnZXRMZW5ndGhGb3JUZXh0UmFuZ2UoKSBjb25zdDsKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4ZDMzYTBiZDNi NGI1Y2ViMzI2MjZmZjI0ZmMwYjk1OGYxOTRjM2Q5Li5jNDhjMWQzNWViOTg2ZmFmNGY2ZTAwZTE0 ODI1MTZmODYwZWM4ZWMxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTctMTAtMDUgIEpvYW5t YXJpZSBEaWdncyAgPGpkaWdnc0BpZ2FsaWEuY29tPgorCisgICAgICAgIEFYOiBbQVRLXSBTVEFU RV9DSEVDS0FCTEUgc2hvdWxkIGJlIHJlbW92ZWQgZnJvbSByYWRpbyBidXR0b25zIGluIHJhZGlv Z3JvdXBzIHdpdGggYXJpYS1yZWFkb25seT0idHJ1ZSIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzkzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9ndGsvYXJpYS1yZWFkb25s eS1yYWRpb2dyb3VwLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0 eS9ndGsvYXJpYS1yZWFkb25seS1yYWRpb2dyb3VwLmh0bWw6IEFkZGVkLgorCiAyMDE3LTEwLTA0 ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBJbXByb3ZlIENhbnZhc01hbmFnZXIgcmVjb3JkaW5nIGV2ZW50cwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9ndGsvYXJpYS1yZWFkb25seS1yYWRpb2dyb3VwLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvZ3RrL2FyaWEtcmVhZG9ubHkt cmFkaW9ncm91cC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMzhiYWY1MzZiYTY3NjM1M2VlYjgz OWVhZTA4ZjUyMmRiMjQ2MTNhMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2FjY2Vz c2liaWxpdHkvZ3RrL2FyaWEtcmVhZG9ubHktcmFkaW9ncm91cC1leHBlY3RlZC50eHQKQEAgLTAs MCArMSwxMiBAQAorVGhpcyB2ZXJpZmllcyBBUklBIHJhZGlvIGJ1dHRvbnMgYmFzZSB0aGVpciBy ZWFkb25seSB2YWx1ZSBvbiB0aGUgY29udGFpbmluZyByYWRpbyBncm91cC4KKworT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUiLgorCisKK3Rlc3QxIEFYVmFsdWUgaXMgc2V0dGFibGU6IDogdHJ1ZQor dGVzdDIgQVhWYWx1ZSBpcyBzZXR0YWJsZTogOiBmYWxzZQordGVzdDMgQVhWYWx1ZSBpcyBzZXR0 YWJsZTogOiB0cnVlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09N UExFVEUKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9ndGsvYXJpYS1y ZWFkb25seS1yYWRpb2dyb3VwLmh0bWwgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2d0ay9h cmlhLXJlYWRvbmx5LXJhZGlvZ3JvdXAuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wYzcyYTNjODhmYjU4OTk5 N2I0NWI3ZWFhN2Q2MDhjOTYxNzA2Mzg0Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv YWNjZXNzaWJpbGl0eS9ndGsvYXJpYS1yZWFkb25seS1yYWRpb2dyb3VwLmh0bWwKQEAgLTAsMCAr MSwyOCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4iPgor PGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvanMtdGVzdC1wcmUu anMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHkgaWQ9ImJvZHkiPgorICA8ZGl2IGlkPSJjb250 ZW50Ij4KKyAgICA8ZGl2IHJvbGU9InJhZGlvZ3JvdXAiPjxkaXYgcm9sZT0icmFkaW8iIGlkPSJ0 ZXN0MSI+PC9kaXY+PC9kaXY+CisgICAgPGRpdiByb2xlPSJyYWRpb2dyb3VwIiBhcmlhLXJlYWRv bmx5PSJ0cnVlIj48ZGl2IHJvbGU9InJhZGlvIiBpZD0idGVzdDIiPjwvZGl2PjwvZGl2PgorICAg IDxkaXYgcm9sZT0icmFkaW9ncm91cCIgYXJpYS1yZWFkb25seT0iZmFsc2UiPjxkaXYgcm9sZT0i cmFkaW8iIGlkPSJ0ZXN0MyI+PC9kaXY+PC9kaXY+CisgIDwvZGl2PgorPHAgaWQ9ImRlc2NyaXB0 aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CisgICAgZGVzY3Jp cHRpb24oIlRoaXMgdmVyaWZpZXMgQVJJQSByYWRpbyBidXR0b25zIGJhc2UgdGhlaXIgcmVhZG9u bHkgdmFsdWUgb24gdGhlIGNvbnRhaW5pbmcgcmFkaW8gZ3JvdXAuIik7CisgICAgaWYgKHdpbmRv dy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworICAgICAgICBmb3IgKHZhciBpID0gMTsgaSA8 PSAzOyBpKyspIHsKKyAgICAgICAgICAgIHZhciBheEVsZW1lbnQgPSBhY2Nlc3NpYmlsaXR5Q29u dHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoInRlc3QiICsgaSk7CisgICAgICAgICAgICBk ZWJ1ZygidGVzdCIgKyBpICsgIiBBWFZhbHVlIGlzIHNldHRhYmxlOiA6ICIgKyBheEVsZW1lbnQu aXNBdHRyaWJ1dGVTZXR0YWJsZSgiQVhWYWx1ZSIpKTsKKyAgICAgICAgfQorCisgICAgICAgIGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb250ZW50Iikuc3R5bGUudmlzaWJpbGl0eSA9ICJoaWRk ZW4iOworICAgIH0KKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgorCg==