177930 2017-10-05 04:03:50 -0700 Layout Test media/modern-media-controls/scrubber-support/scrubber-support-click.html is flaky 2017-10-05 11:52:49 -0700 1 1 1 Unclassified WebKit Media Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts commit-queue dino webkit-bug-importer oldest_to_newest 1356956 0 graouts 2017-10-05 04:03:50 -0700 The following layout test is flaky on Apple Sierra Debug WK1 media/modern-media-controls/scrubber-support/scrubber-support-click.html 1356960 1 322819 graouts 2017-10-05 04:05:56 -0700 Created attachment 322819 Patch 1357054 2 322819 dino 2017-10-05 09:49:16 -0700 Comment on attachment 322819 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322819&action=review > LayoutTests/ChangeLog:10 > + In cases where this test failed, it actually worked as expected but the "timeupdate" event would be fired > + twice, most likely because it was registered twice. We now use an asynchronous expectation to run the test > + which should only register the event listener once and make the test more reliable. You could probably just pass in a { once: true } to the event listener registration. Or are you saying it was actually registered twice? 1357120 3 graouts 2017-10-05 11:28:13 -0700 (In reply to Dean Jackson from comment #2) > Comment on attachment 322819 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322819&action=review > > > LayoutTests/ChangeLog:10 > > + In cases where this test failed, it actually worked as expected but the "timeupdate" event would be fired > > + twice, most likely because it was registered twice. We now use an asynchronous expectation to run the test > > + which should only register the event listener once and make the test more reliable. > > You could probably just pass in a { once: true } to the event listener > registration. Or are you saying it was actually registered twice? It was registered twice. 1357143 4 322819 commit-queue 2017-10-05 11:51:50 -0700 Comment on attachment 322819 Patch Clearing flags on attachment: 322819 Committed r222923: <http://trac.webkit.org/changeset/222923> 1357144 5 commit-queue 2017-10-05 11:51:51 -0700 All reviewed patches have been landed. Closing bug. 1357145 6 webkit-bug-importer 2017-10-05 11:52:49 -0700 <rdar://problem/34839329> 322819 2017-10-05 04:05:56 -0700 2017-10-05 11:51:50 -0700 Patch bug-177930-20171005130555.patch text/plain 3811 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyODk3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOGQzM2EwYmQzYjRiNWNlYjMyNjI2 ZmYyNGZjMGI5NThmMTk0YzNkOS4uYzA0OTM3NDNmY2QwOTYwNzQ1ZDIzODRkZTE4ZmQxM2ZhOWMx Mzg1MSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEwLTA1ICBBbnRvaW5lIFF1aW50ICA8 Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTGF5b3V0IFRlc3QgbWVkaWEvbW9kZXJuLW1l ZGlhLWNvbnRyb2xzL3NjcnViYmVyLXN1cHBvcnQvc2NydWJiZXItc3VwcG9ydC1jbGljay5odG1s IGlzIGZsYWt5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzc5MzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbiBjYXNlcyB3aGVyZSB0aGlzIHRlc3QgZmFpbGVkLCBpdCBhY3R1YWxseSB3b3JrZWQgYXMg ZXhwZWN0ZWQgYnV0IHRoZSAidGltZXVwZGF0ZSIgZXZlbnQgd291bGQgYmUgZmlyZWQKKyAgICAg ICAgdHdpY2UsIG1vc3QgbGlrZWx5IGJlY2F1c2UgaXQgd2FzIHJlZ2lzdGVyZWQgdHdpY2UuIFdl IG5vdyB1c2UgYW4gYXN5bmNocm9ub3VzIGV4cGVjdGF0aW9uIHRvIHJ1biB0aGUgdGVzdAorICAg ICAgICB3aGljaCBzaG91bGQgb25seSByZWdpc3RlciB0aGUgZXZlbnQgbGlzdGVuZXIgb25jZSBh bmQgbWFrZSB0aGUgdGVzdCBtb3JlIHJlbGlhYmxlLgorCisgICAgICAgICogbWVkaWEvbW9kZXJu LW1lZGlhLWNvbnRyb2xzL3NjcnViYmVyLXN1cHBvcnQvc2NydWJiZXItc3VwcG9ydC1jbGljay1l eHBlY3RlZC50eHQ6CisgICAgICAgICogbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3NjcnVi YmVyLXN1cHBvcnQvc2NydWJiZXItc3VwcG9ydC1jbGljay5odG1sOgorCiAyMDE3LTEwLTA0ICBN YXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBJbXByb3ZlIENhbnZhc01hbmFnZXIgcmVjb3JkaW5nIGV2ZW50cwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3NjcnViYmVyLXN1cHBvcnQvc2Ny dWJiZXItc3VwcG9ydC1jbGljay1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rl cm4tbWVkaWEtY29udHJvbHMvc2NydWJiZXItc3VwcG9ydC9zY3J1YmJlci1zdXBwb3J0LWNsaWNr LWV4cGVjdGVkLnR4dAppbmRleCAzNjVkOTk0NGExOGM3NDVmYTU0NDFlZTNjZTRjYmNlZDkxYzhl OGJjLi42NDUzNzE0ZmUxMjQ2MmYwZWIwMzIzMjk2MTE5YzI0OGE4MzUzOTA2IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvc2NydWJiZXItc3VwcG9y dC9zY3J1YmJlci1zdXBwb3J0LWNsaWNrLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9t ZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvc2NydWJiZXItc3VwcG9ydC9zY3J1YmJlci1zdXBw b3J0LWNsaWNrLWV4cGVjdGVkLnR4dApAQCAtMyw2ICszLDcgQEAgVGVzdGluZyB0aGUgU2NydWJi ZXJTdXBwb3J0IGJlaGF2aW9yIHdoZW4gY2xpY2tpbmcgdGhlIHNjcnViYmVyLgogT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUiLgogCiAKK1BBU1Mgc2NydWJiZXIuZ2V0Qm91bmRpbmdDbGllbnRSZWN0 KCkud2lkdGggYmVjYW1lIGRpZmZlcmVudCBmcm9tIDAKIFBBU1MgbWVkaWEuY3VycmVudFRpbWUg aXMgd2l0aGluIDAuMiBvZiAzLjE4NzIKIFBBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUK IApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3Nj cnViYmVyLXN1cHBvcnQvc2NydWJiZXItc3VwcG9ydC1jbGljay5odG1sIGIvTGF5b3V0VGVzdHMv bWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL3NjcnViYmVyLXN1cHBvcnQvc2NydWJiZXItc3Vw cG9ydC1jbGljay5odG1sCmluZGV4IDU5ZGM3OTFmY2Q4MDRkNTc0NThmMDUzMmQ5YTRkZTg1NTQz MmE3ZDkuLjFhYjYyMGI0ZTg2ZjBmNDUwYTczZWEzNTJjZjk3ZjE1YWVmOTQ5NjIgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9zY3J1YmJlci1zdXBw b3J0L3NjcnViYmVyLXN1cHBvcnQtY2xpY2suaHRtbAorKysgYi9MYXlvdXRUZXN0cy9tZWRpYS9t b2Rlcm4tbWVkaWEtY29udHJvbHMvc2NydWJiZXItc3VwcG9ydC9zY3J1YmJlci1zdXBwb3J0LWNs aWNrLmh0bWwKQEAgLTI0LDI5ICsyNCwyMiBAQCBkZXNjcmlwdGlvbigiVGVzdGluZyB0aGUgPGNv ZGU+U2NydWJiZXJTdXBwb3J0PC9jb2RlPiBiZWhhdmlvciB3aGVuIGNsaWNraW5nIHRoZQogY29u c3QgY29udGFpbmVyID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigiZGl2I2hvc3QiKTsKIGNvbnN0 IG1lZGlhID0gZG9jdW1lbnQucXVlcnlTZWxlY3RvcigidmlkZW8iKTsKIGNvbnN0IG1lZGlhQ29u dHJvbGxlciA9IGNyZWF0ZUNvbnRyb2xzKGNvbnRhaW5lciwgbWVkaWEsIG51bGwpOworY29uc3Qg c2NydWJiZXIgPSBtZWRpYUNvbnRyb2xsZXIuY29udHJvbHMudGltZUNvbnRyb2wuc2NydWJiZXIu Y2hpbGRyZW5bMV0uZWxlbWVudDsKIAogbWVkaWFDb250cm9sbGVyLmNvbnRyb2xzLnNob3dzU3Rh cnRCdXR0b24gPSBmYWxzZTsKIAotc2NoZWR1bGVyLmZyYW1lRGlkRmlyZSA9IGZ1bmN0aW9uKCkg ewotICAgIGlmIChtZWRpYS5wYXVzZWQpCi0gICAgICAgIHJldHVybjsKLQotICAgIGNvbnN0IHNj cnViYmVyID0gbWVkaWFDb250cm9sbGVyLmNvbnRyb2xzLnRpbWVDb250cm9sLnNjcnViYmVyLmNo aWxkcmVuWzFdLmVsZW1lbnQ7Ci0gICAgaWYgKHNjcnViYmVyLmdldEJvdW5kaW5nQ2xpZW50UmVj dCgpLndpZHRoID09PSAwKQotICAgICAgICByZXR1cm47Ci0KK21lZGlhLmFkZEV2ZW50TGlzdGVu ZXIoInBsYXkiLCAoKSA9PiB7CiAgICAgbWVkaWEucGF1c2UoKTsKLQotICAgIG1lZGlhLmFkZEV2 ZW50TGlzdGVuZXIoInRpbWV1cGRhdGUiLCAoKSA9PiB7Ci0gICAgICAgIHNob3VsZEJlQ2xvc2VU bygibWVkaWEuY3VycmVudFRpbWUiLCAzLjE4NzIsIDAuMik7Ci0gICAgICAgIGNvbnRhaW5lci5y ZW1vdmUoKTsKLSAgICAgICAgbWVkaWEucmVtb3ZlKCk7Ci0gICAgICAgIGZpbmlzaEpTVGVzdCgp OworICAgIHNob3VsZEJlY29tZURpZmZlcmVudCgic2NydWJiZXIuZ2V0Qm91bmRpbmdDbGllbnRS ZWN0KCkud2lkdGgiLCAiMCIsICgpID0+IHsKKyAgICAgICAgbWVkaWEuYWRkRXZlbnRMaXN0ZW5l cigidGltZXVwZGF0ZSIsICgpID0+IHsKKyAgICAgICAgICAgIHNob3VsZEJlQ2xvc2VUbygibWVk aWEuY3VycmVudFRpbWUiLCAzLjE4NzIsIDAuMik7CisgICAgICAgICAgICBjb250YWluZXIucmVt b3ZlKCk7CisgICAgICAgICAgICBtZWRpYS5yZW1vdmUoKTsKKyAgICAgICAgICAgIGZpbmlzaEpT VGVzdCgpOworICAgICAgICB9KTsKKyAgICAgICAgcHJlc3NPbkVsZW1lbnQoc2NydWJiZXIpOwog ICAgIH0pOwotICAgIAotICAgIHNjaGVkdWxlci5mcmFtZURpZEZpcmUgPSBudWxsOwotICAgIHBy ZXNzT25FbGVtZW50KHNjcnViYmVyKTsKLX07Cit9KTsKIAogPC9zY3JpcHQ+CiA8c2NyaXB0IHNy Yz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cg==