177914 2017-10-04 21:28:31 -0700 Web Inspector: When scrolled Network Table reduces the number of rows it may appear as blank 2017-10-05 11:04:04 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1356829 0 joepeck 2017-10-04 21:28:31 -0700 When scrolled Network Table reduces the number of rows it may appear as blank Steps to Reproduce: 1. Inspect apple.com 2. Show Network Tab 3. Reload 4. Scroll Network Tab Down 5. Select "Document" filter => expected to see 1 Document resource, instead see blank / broken table Notes: • The number of rows was reduced, but the Table's scrollTop was not reset to a reasonable value. This can happen any time the row count goes down so we should have a generic solution. 1356830 1 webkit-bug-importer 2017-10-04 21:28:54 -0700 <rdar://problem/34827613> 1356834 2 322777 joepeck 2017-10-04 21:34:25 -0700 Created attachment 322777 [PATCH] Proposed Fix 1356840 3 322777 mattbaker 2017-10-04 21:55:35 -0700 Comment on attachment 322777 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=322777&action=review r=me, with (optional) nits. > Source/WebInspectorUI/UserInterface/Views/Table.js:897 > + if (this._cachedScrollTop) { Might as well use scrollTop from above, since scrollableOffsetHeight is used. > Source/WebInspectorUI/UserInterface/Views/Table.js:901 > + if (this._cachedScrollTop > maximumScrollTop) { Ditto. > Source/WebInspectorUI/UserInterface/Views/Table.js:950 > + // of rows can fit on screen. Reset the scroll top. Should this say "Reset the scroll top to zero", so that it's obvious that we didn't mean to set it to NaN? 1356862 4 322787 joepeck 2017-10-04 23:06:38 -0700 Created attachment 322787 [PATCH] For Landing 1356868 5 322787 commit-queue 2017-10-04 23:33:59 -0700 Comment on attachment 322787 [PATCH] For Landing Clearing flags on attachment: 322787 Committed r222899: <http://trac.webkit.org/changeset/222899> 322777 2017-10-04 21:34:25 -0700 2017-10-04 23:06:51 -0700 [PATCH] Proposed Fix table-scroll-thing-1.patch text/plain 3542 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRjZGQyMTkzMTIyLi45ODBjZDExNmUzMCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQgQEAKIDIwMTctMTAtMDQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBXaGVuIHNjcm9sbGVkIE5ldHdvcmsgVGFibGUgcmVkdWNlcyB0aGUgbnVtYmVyIG9mIHJvd3Mg aXQgbWF5IGFwcGVhciBhcyBibGFuaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc3OTE0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNDgyNzYxMz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJ bnRlcmZhY2UvVmlld3MvVGFibGUuanM6CisgICAgICAgIChXSS5UYWJsZS5wcm90b3R5cGUuX3Vw ZGF0ZVZpc2libGVSb3dzKToKKyAgICAgICAgKFdJLlRhYmxlLnByb3RvdHlwZS5fdXBkYXRlRmls bGVyUm93V2l0aE5ld0hlaWdodCk6CisgICAgICAgIFJlZHVjZSB0aGUgc2Nyb2xsVG9wIHdoZW4g dGhlIHRhYmxlIHdhcyBzY3JvbGxlZCBhbmQgd2FzIHRoZW4gcmVsb2FkZWQgd2l0aCBhCisgICAg ICAgIHNtYWxsZXIgbnVtYmVyIG9mIHJvd3MuIFRoaXMgY2FuIGhhcHBlbiBpbiB0d28gd2F5cy4g RWl0aGVyIHRoZSBudW1iZXIgb2Ygcm93cworICAgICAgICB3YXMgcmVkdWNlZCBzbyBtdWNoIHRo YXQgd2UgZW50ZXIgbm9uLXNjcm9sbGFibGUgbW9kZSB3aXRoIGEgbm9uLXplcm8gZmlsbGVyCisg ICAgICAgIHJvdy4gVGhpcyBjYW4gYWx3YXlzIHJlc2V0IHRoZSBzY3JvbGxUb3AgdG8gMC4gT3Ig d2hlbiBhIGxhcmdlIG51bWJlciBvZiByb3dzCisgICAgICAgIGlzIHJlZHVjZWQgdG8gYSBzbWFs bGVyIG51bWJlciB0aGFuIG91ciBjdXJyZW50IHNjcm9sbFRvcCBidXQgc3RpbGwgbW9yZSB0aGFu CisgICAgICAgIGZpdCBvbiBvbmUgc2NyZWVuLiBJbiB0aGF0IGNhc2Ugd2UgY2FuIHJlZHVjZSB0 aGUgc2Nyb2xsVG9wIHRvIHdoYXRldmVyIHdvdWxkCisgICAgICAgIHNjcm9sbCB0aGUgdGFibGUg dG8gaXRzIG1heCBwb3NpdGlvbi4KKworMjAxNy0xMC0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IERldGFpbCBWaWV3cyBm b3IgcmVzb3VyY2VzIGluIE5ldHdvcmsgVGFiCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc1NTMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcwppbmRleCA0NjNiYzBiMGI4Zi4uYjNkYTE2 ZDI5M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RhYmxlLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1RhYmxlLmpzCkBAIC04OTAsNiArODkwLDIxIEBAIFdJLlRhYmxlID0gY2xhc3MgVGFibGUg ZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgIGxldCBudW1iZXJPZlJvd3MgPSB0aGlzLl9kYXRhU291 cmNlLnRhYmxlTnVtYmVyT2ZSb3dzKHRoaXMpOwogICAgICAgICB0aGlzLl9wcmV2aW91c1JldmVh bGVkUm93Q291bnQgPSBudW1iZXJPZlJvd3M7CiAKKyAgICAgICAgLy8gU2Nyb2xsIGJhY2sgdXAg aWYgdGhlIG51bWJlciBvZiByb3dzIHdhcyByZWR1Y2VkIHN1Y2ggdGhhdCB0aGUgZXhpc3RpbmcK KyAgICAgICAgLy8gc2Nyb2xsIHRvcCB2YWx1ZSBpcyBsYXJnZXIgdGhhbiBpdCBjb3VsZCBvdGhl cndpc2UgaGF2ZSBiZWVuLiBXZSBvbmx5CisgICAgICAgIC8vIG5lZWQgdG8gZG8gdGhpcyBhZGp1 c3RtZW50IGlmIHRoZXJlIGFyZSBtb3JlIHJvd3MgdGhhbiB3b3VsZCBmaXQgb24gc2NyZWVuLAor ICAgICAgICAvLyBiZWNhdXNlIHdoZW4gdGhlIGZpbGxlciByb3cgYWN0aXZhdGVzIGl0IHdpbGwg cmVzZXQgb3VyIHNjcm9sbC4KKyAgICAgICAgaWYgKHRoaXMuX2NhY2hlZFNjcm9sbFRvcCkgewor ICAgICAgICAgICAgbGV0IHJvd3NUaGF0Q2FuRml0T25TY3JlZW4gPSBNYXRoLmNlaWwoc2Nyb2xs YWJsZU9mZnNldEhlaWdodCAvIHJvd0hlaWdodCk7CisgICAgICAgICAgICBpZiAobnVtYmVyT2ZS b3dzID49IHJvd3NUaGF0Q2FuRml0T25TY3JlZW4pIHsKKyAgICAgICAgICAgICAgICBsZXQgbWF4 aW11bVNjcm9sbFRvcCA9IE1hdGgubWF4KDAsIChudW1iZXJPZlJvd3MgKiByb3dIZWlnaHQpIC0g c2Nyb2xsYWJsZU9mZnNldEhlaWdodCk7CisgICAgICAgICAgICAgICAgaWYgKHRoaXMuX2NhY2hl ZFNjcm9sbFRvcCA+IG1heGltdW1TY3JvbGxUb3ApIHsKKyAgICAgICAgICAgICAgICAgICAgdGhp cy5fc2Nyb2xsQ29udGFpbmVyRWxlbWVudC5zY3JvbGxUb3AgPSBtYXhpbXVtU2Nyb2xsVG9wOwor ICAgICAgICAgICAgICAgICAgICB0aGlzLl9jYWNoZWRTY3JvbGxUb3AgPSBtYXhpbXVtU2Nyb2xs VG9wOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgIH0KKyAgICAgICAgfQorCiAgICAg ICAgIGxldCB0b3BIaWRkZW5Sb3dDb3VudCA9IE1hdGgubWF4KDAsIE1hdGguZmxvb3IoKHNjcm9s bFRvcCAtIG92ZXJmbG93UGFkZGluZykgLyByb3dIZWlnaHQpKTsKICAgICAgICAgbGV0IGJvdHRv bUhpZGRlblJvd0NvdW50ID0gTWF0aC5tYXgoMCwgdGhpcy5fcHJldmlvdXNSZXZlYWxlZFJvd0Nv dW50IC0gdG9wSGlkZGVuUm93Q291bnQgLSB2aXNpYmxlUm93Q291bnQpOwogCkBAIC05MzEsNiAr OTQ2LDEzIEBAIFdJLlRhYmxlID0gY2xhc3MgVGFibGUgZXh0ZW5kcyBXSS5WaWV3CiAKICAgICAg ICAgdGhpcy5fc2Nyb2xsQ29udGFpbmVyRWxlbWVudC5jbGFzc0xpc3QuYWRkKCJub3Qtc2Nyb2xs YWJsZSIpOwogCisgICAgICAgIC8vIEluIHRoZSBldmVudCB0aGF0IHdlIGp1c3QgbWFkZSB0aGUg dGFibGUgbm90IHNjcm9sbGFibGUgdGhlbiB0aGUgbnVtYmVyCisgICAgICAgIC8vIG9mIHJvd3Mg Y2FuIGZpdCBvbiBzY3JlZW4uIFJlc2V0IHRoZSBzY3JvbGwgdG9wLgorICAgICAgICBpZiAodGhp cy5fY2FjaGVkU2Nyb2xsVG9wKSB7CisgICAgICAgICAgICB0aGlzLl9zY3JvbGxDb250YWluZXJF bGVtZW50LnNjcm9sbFRvcCA9IDA7CisgICAgICAgICAgICB0aGlzLl9jYWNoZWRTY3JvbGxUb3Ag PSAwOworICAgICAgICB9CisKICAgICAgICAgLy8gRXh0ZW5kIHBhc3QgZWRnZSBzb21lIHJlYXNv bmFibGUgYW1vdW50LiBBdCBsZWFzdCAyMDBweC4KICAgICAgICAgY29uc3QgcGFkZGluZ1Bhc3RU aGVFZGdlID0gMjAwOwogICAgICAgICB0aGlzLl9maWxsZXJIZWlnaHQgKz0gcGFkZGluZ1Bhc3RU aGVFZGdlOwo= 322787 2017-10-04 23:06:38 -0700 2017-10-04 23:33:59 -0700 [PATCH] For Landing for-landing-1.patch text/plain 3514 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGRjZGQyMTkzMTIyLi5hYWIzNmU2NjRmNCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjQgQEAKIDIwMTctMTAtMDQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBXaGVuIHNjcm9sbGVkIE5ldHdvcmsgVGFibGUgcmVkdWNlcyB0aGUgbnVtYmVyIG9mIHJvd3Mg aXQgbWF5IGFwcGVhciBhcyBibGFuaworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTc3OTE0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zNDgyNzYxMz4K KworICAgICAgICBSZXZpZXdlZCBieSBNYXR0IEJha2VyLgorCisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9UYWJsZS5qczoKKyAgICAgICAgKFdJLlRhYmxlLnByb3RvdHlwZS5fdXBkYXRl VmlzaWJsZVJvd3MpOgorICAgICAgICAoV0kuVGFibGUucHJvdG90eXBlLl91cGRhdGVGaWxsZXJS b3dXaXRoTmV3SGVpZ2h0KToKKyAgICAgICAgUmVkdWNlIHRoZSBzY3JvbGxUb3Agd2hlbiB0aGUg dGFibGUgd2FzIHNjcm9sbGVkIGFuZCB3YXMgdGhlbiByZWxvYWRlZCB3aXRoIGEKKyAgICAgICAg c21hbGxlciBudW1iZXIgb2Ygcm93cy4gVGhpcyBjYW4gaGFwcGVuIGluIHR3byB3YXlzLiBFaXRo ZXIgdGhlIG51bWJlciBvZiByb3dzCisgICAgICAgIHdhcyByZWR1Y2VkIHNvIG11Y2ggdGhhdCB3 ZSBlbnRlciBub24tc2Nyb2xsYWJsZSBtb2RlIHdpdGggYSBub24temVybyBmaWxsZXIKKyAgICAg ICAgcm93LiBUaGlzIGNhbiBhbHdheXMgcmVzZXQgdGhlIHNjcm9sbFRvcCB0byAwLiBPciB3aGVu IGEgbGFyZ2UgbnVtYmVyIG9mIHJvd3MKKyAgICAgICAgaXMgcmVkdWNlZCB0byBhIHNtYWxsZXIg bnVtYmVyIHRoYW4gb3VyIGN1cnJlbnQgc2Nyb2xsVG9wIGJ1dCBzdGlsbCBtb3JlIHRoYW4KKyAg ICAgICAgZml0IG9uIG9uZSBzY3JlZW4uIEluIHRoYXQgY2FzZSB3ZSBjYW4gcmVkdWNlIHRoZSBz Y3JvbGxUb3AgdG8gd2hhdGV2ZXIgd291bGQKKyAgICAgICAgc2Nyb2xsIHRoZSB0YWJsZSB0byBp dHMgbWF4IHBvc2l0aW9uLgorCisyMDE3LTEwLTA0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogRGV0YWlsIFZpZXdzIGZvciBy ZXNvdXJjZXMgaW4gTmV0d29yayBUYWIKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3NzU1MwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlLmpzCmluZGV4IDQ2M2JjMGIwYjhmLi5lMDkxMGJjNmM1 OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGFibGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv VGFibGUuanMKQEAgLTg5MCw2ICs4OTAsMjEgQEAgV0kuVGFibGUgPSBjbGFzcyBUYWJsZSBleHRl bmRzIFdJLlZpZXcKICAgICAgICAgbGV0IG51bWJlck9mUm93cyA9IHRoaXMuX2RhdGFTb3VyY2Uu dGFibGVOdW1iZXJPZlJvd3ModGhpcyk7CiAgICAgICAgIHRoaXMuX3ByZXZpb3VzUmV2ZWFsZWRS b3dDb3VudCA9IG51bWJlck9mUm93czsKIAorICAgICAgICAvLyBTY3JvbGwgYmFjayB1cCBpZiB0 aGUgbnVtYmVyIG9mIHJvd3Mgd2FzIHJlZHVjZWQgc3VjaCB0aGF0IHRoZSBleGlzdGluZworICAg ICAgICAvLyBzY3JvbGwgdG9wIHZhbHVlIGlzIGxhcmdlciB0aGFuIGl0IGNvdWxkIG90aGVyd2lz ZSBoYXZlIGJlZW4uIFdlIG9ubHkKKyAgICAgICAgLy8gbmVlZCB0byBkbyB0aGlzIGFkanVzdG1l bnQgaWYgdGhlcmUgYXJlIG1vcmUgcm93cyB0aGFuIHdvdWxkIGZpdCBvbiBzY3JlZW4sCisgICAg ICAgIC8vIGJlY2F1c2Ugd2hlbiB0aGUgZmlsbGVyIHJvdyBhY3RpdmF0ZXMgaXQgd2lsbCByZXNl dCBvdXIgc2Nyb2xsLgorICAgICAgICBpZiAoc2Nyb2xsVG9wKSB7CisgICAgICAgICAgICBsZXQg cm93c1RoYXRDYW5GaXRPblNjcmVlbiA9IE1hdGguY2VpbChzY3JvbGxhYmxlT2Zmc2V0SGVpZ2h0 IC8gcm93SGVpZ2h0KTsKKyAgICAgICAgICAgIGlmIChudW1iZXJPZlJvd3MgPj0gcm93c1RoYXRD YW5GaXRPblNjcmVlbikgeworICAgICAgICAgICAgICAgIGxldCBtYXhpbXVtU2Nyb2xsVG9wID0g TWF0aC5tYXgoMCwgKG51bWJlck9mUm93cyAqIHJvd0hlaWdodCkgLSBzY3JvbGxhYmxlT2Zmc2V0 SGVpZ2h0KTsKKyAgICAgICAgICAgICAgICBpZiAoc2Nyb2xsVG9wID4gbWF4aW11bVNjcm9sbFRv cCkgeworICAgICAgICAgICAgICAgICAgICB0aGlzLl9zY3JvbGxDb250YWluZXJFbGVtZW50LnNj cm9sbFRvcCA9IG1heGltdW1TY3JvbGxUb3A7CisgICAgICAgICAgICAgICAgICAgIHRoaXMuX2Nh Y2hlZFNjcm9sbFRvcCA9IG1heGltdW1TY3JvbGxUb3A7CisgICAgICAgICAgICAgICAgfQorICAg ICAgICAgICAgfQorICAgICAgICB9CisKICAgICAgICAgbGV0IHRvcEhpZGRlblJvd0NvdW50ID0g TWF0aC5tYXgoMCwgTWF0aC5mbG9vcigoc2Nyb2xsVG9wIC0gb3ZlcmZsb3dQYWRkaW5nKSAvIHJv d0hlaWdodCkpOwogICAgICAgICBsZXQgYm90dG9tSGlkZGVuUm93Q291bnQgPSBNYXRoLm1heCgw LCB0aGlzLl9wcmV2aW91c1JldmVhbGVkUm93Q291bnQgLSB0b3BIaWRkZW5Sb3dDb3VudCAtIHZp c2libGVSb3dDb3VudCk7CiAKQEAgLTkzMSw2ICs5NDYsMTMgQEAgV0kuVGFibGUgPSBjbGFzcyBU YWJsZSBleHRlbmRzIFdJLlZpZXcKIAogICAgICAgICB0aGlzLl9zY3JvbGxDb250YWluZXJFbGVt ZW50LmNsYXNzTGlzdC5hZGQoIm5vdC1zY3JvbGxhYmxlIik7CiAKKyAgICAgICAgLy8gSW4gdGhl IGV2ZW50IHRoYXQgd2UganVzdCBtYWRlIHRoZSB0YWJsZSBub3Qgc2Nyb2xsYWJsZSB0aGVuIHRo ZSBudW1iZXIKKyAgICAgICAgLy8gb2Ygcm93cyBjYW4gZml0IG9uIHNjcmVlbi4gUmVzZXQgdGhl IHNjcm9sbCB0b3AuCisgICAgICAgIGlmICh0aGlzLl9jYWNoZWRTY3JvbGxUb3ApIHsKKyAgICAg ICAgICAgIHRoaXMuX3Njcm9sbENvbnRhaW5lckVsZW1lbnQuc2Nyb2xsVG9wID0gMDsKKyAgICAg ICAgICAgIHRoaXMuX2NhY2hlZFNjcm9sbFRvcCA9IDA7CisgICAgICAgIH0KKwogICAgICAgICAv LyBFeHRlbmQgcGFzdCBlZGdlIHNvbWUgcmVhc29uYWJsZSBhbW91bnQuIEF0IGxlYXN0IDIwMHB4 LgogICAgICAgICBjb25zdCBwYWRkaW5nUGFzdFRoZUVkZ2UgPSAyMDA7CiAgICAgICAgIHRoaXMu X2ZpbGxlckhlaWdodCArPSBwYWRkaW5nUGFzdFRoZUVkZ2U7Cg==