177897 2017-10-04 14:00:01 -0700 check-webkit-style erroneously requires a space between the caret and brace in obj-c blocks. 2017-10-05 15:42:48 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner buildbot dbates glenn jbedard lforschler mitz simon.fraser thorton webkit-bug-importer oldest_to_newest 1356651 0 megan_gardner 2017-10-04 14:00:01 -0700 Check webkit style throws an error when you do not put a space between the ^ and the { for objective-c blocks. It was made so with the changes for this bug: https://bugs.webkit.org/show_bug.cgi?id=161247 But there is agreement that this should not be the case, and a space should not be required. A vast majority of the code in webkit already conforms to this style, with only a few outliers. 1356678 1 322730 megan_gardner 2017-10-04 14:57:52 -0700 Created attachment 322730 Patch 1356685 2 megan_gardner 2017-10-04 15:15:16 -0700 I need to expand this, new patch forthcoming 1356688 3 322732 megan_gardner 2017-10-04 15:22:09 -0700 Created attachment 322732 Patch 1356693 4 jbedard 2017-10-04 15:41:22 -0700 If you look at comment 5 in <https://bugs.webkit.org/show_bug.cgi?id=161247>, I specifically call out the problem Megan is addressing here... I'm not an Objective C programmer, and the WebKit style guide gives some conflicting advice on this. This seems like the right change, especially since you've seemed agreement with others more familiar than I with Objective C style. 1356715 5 322739 megan_gardner 2017-10-04 16:38:34 -0700 Created attachment 322739 Patch 1356720 6 322739 jbedard 2017-10-04 16:43:03 -0700 Comment on attachment 322739 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322739&action=review Unofficial R+, but please edit the ChangeLog to reflect the new behavior > Tools/ChangeLog:8 > + Remove the check for a space between ^ and {, To clarify, this change does the opposite of the original code, right? Now the style checker will enforce that there is NOT a space between ^ and { in an objective-C block. 1356877 7 322739 dbates 2017-10-04 23:52:31 -0700 Comment on attachment 322739 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322739&action=review > Tools/ChangeLog:3 > + check-webkit-style erroneously requires a space between the carrot and brace in obj-c blocks. Blocks are not specific to Objective-C. https://developer.apple.com/library/content/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/WorkingwithBlocks/WorkingwithBlocks.html > Tools/Scripts/webkitpy/style/checkers/cpp.py:1265 > + if search(r'\^\s\{', group): Would it make sense to check for one or more space characters, \s+? If so, please add additional tests. 1357290 8 megan_gardner 2017-10-05 15:41:42 -0700 https://trac.webkit.org/r222937 1357291 9 webkit-bug-importer 2017-10-05 15:42:48 -0700 <rdar://problem/34845080> 322730 2017-10-04 14:57:52 -0700 2017-10-04 15:22:08 -0700 Patch bug-177897-20171004145752.patch text/plain 1547 megan_gardner SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMjg4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTEwLTA0ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBs ZS5jb20+CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIGVycm9uZW91c2x5IHJlcXVpcmVz IGEgc3BhY2UgYmV0d2VlbiB0aGUgY2Fycm90IGFuZCBicmFjZSBpbiBvYmotYyBibG9ja3MuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc4OTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhl IGNoZWNrIGZvciBhIHNwYWNlIGJldHdlZW4gXiBhbmQgeywgCisgICAgICAgIGFzIHRoaXMgaXMg dmFsaWQgYW5kIGV4cGVjdGVkIE9iai1DCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKHJlZ2V4X2Zvcl9sYW1iZGFzX2FuZF9ibG9j a3MpOgorCiAyMDE3LTEwLTA0ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBXVEY6IFVwZGF0ZSBzdGQ6OmV4cGVjdGVkIHRvIG1hdGNoIGN1cnJlbnQgcHJvcG9z YWwKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 CShyZXZpc2lvbiAyMjI4ODEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weQkod29ya2luZyBjb3B5KQpAQCAtMTI2Miw5ICsxMjYyLDYgQEAgZGVmIHJlZ2V4 X2Zvcl9sYW1iZGFzX2FuZF9ibG9ja3MobGluZSwgbAogICAgICAgICBpZiBzZWFyY2gocicoXChc c3xcc1wpfFxzLCknLCBncm91cCk6CiAgICAgICAgICAgICB0YXJnX2Vycm9yID0gW2xpbmVfbnVt YmVyLCAnd2hpdGVzcGFjZS9icmFja2V0cycsIDQsCiAgICAgICAgICAgICAgICdFeHRyYSBzcGFj ZSBpbiBibG9jayBhcmd1bWVudHMuJ10KLSAgICAgICAgaWYgc2VhcmNoKHInXF5ceycsIGdyb3Vw KToKLSAgICAgICAgICAgIHRhcmdfZXJyb3IgPSBbbGluZV9udW1iZXIsICd3aGl0ZXNwYWNlL2Jy YWNrZXRzJywgNCwKLSAgICAgICAgICAgICAgJ05vIHNwYWNlIGJldHdlZW4gXiBhbmQgYmxvY2sg ZGVmaW5pdGlvbi4nXQogICAgICAgICBpZiBzZWFyY2gocidcXlxzXCgnLCBncm91cCk6CiAgICAg ICAgICAgICB0YXJnX2Vycm9yID0gW2xpbmVfbnVtYmVyLCAnd2hpdGVzcGFjZS9icmFja2V0cycs IDQsCiAgICAgICAgICAgICAgICdFeHRyYSBzcGFjZSBiZXR3ZWVuIF4gYW5kIGJsb2NrIGFyZ3Vt ZW50cy4nXQo= 322732 2017-10-04 15:22:09 -0700 2017-10-04 16:38:33 -0700 Patch bug-177897-20171004152209.patch text/plain 2912 megan_gardner SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMjg4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTEwLTA0ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBs ZS5jb20+CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIGVycm9uZW91c2x5IHJlcXVpcmVz IGEgc3BhY2UgYmV0d2VlbiB0aGUgY2Fycm90IGFuZCBicmFjZSBpbiBvYmotYyBibG9ja3MuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc4OTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhl IGNoZWNrIGZvciBhIHNwYWNlIGJldHdlZW4gXiBhbmQgeywgCisgICAgICAgIGFzIHRoaXMgaXMg dmFsaWQgYW5kIGV4cGVjdGVkIE9iai1DCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKHJlZ2V4X2Zvcl9sYW1iZGFzX2FuZF9ibG9j a3MpOgorCiAyMDE3LTEwLTA0ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBXVEY6IFVwZGF0ZSBzdGQ6OmV4cGVjdGVkIHRvIG1hdGNoIGN1cnJlbnQgcHJvcG9z YWwKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 CShyZXZpc2lvbiAyMjI4ODEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weQkod29ya2luZyBjb3B5KQpAQCAtMTI2Miw5ICsxMjYyLDkgQEAgZGVmIHJlZ2V4 X2Zvcl9sYW1iZGFzX2FuZF9ibG9ja3MobGluZSwgbAogICAgICAgICBpZiBzZWFyY2gocicoXChc c3xcc1wpfFxzLCknLCBncm91cCk6CiAgICAgICAgICAgICB0YXJnX2Vycm9yID0gW2xpbmVfbnVt YmVyLCAnd2hpdGVzcGFjZS9icmFja2V0cycsIDQsCiAgICAgICAgICAgICAgICdFeHRyYSBzcGFj ZSBpbiBibG9jayBhcmd1bWVudHMuJ10KLSAgICAgICAgaWYgc2VhcmNoKHInXF5ceycsIGdyb3Vw KToKKyAgICAgICAgaWYgc2VhcmNoKHInXF5cc1x7JywgZ3JvdXApOgogICAgICAgICAgICAgdGFy Z19lcnJvciA9IFtsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvYnJhY2tldHMnLCA0LAotICAgICAg ICAgICAgICAnTm8gc3BhY2UgYmV0d2VlbiBeIGFuZCBibG9jayBkZWZpbml0aW9uLiddCisgICAg ICAgICAgICAgICdFeHRyYSBzcGFjZSBiZXR3ZWVuIF4gYW5kIGJsb2NrIGRlZmluaXRpb24uJ10K ICAgICAgICAgaWYgc2VhcmNoKHInXF5cc1woJywgZ3JvdXApOgogICAgICAgICAgICAgdGFyZ19l cnJvciA9IFtsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvYnJhY2tldHMnLCA0LAogICAgICAgICAg ICAgICAnRXh0cmEgc3BhY2UgYmV0d2VlbiBeIGFuZCBibG9jayBhcmd1bWVudHMuJ10KSW5kZXg6 IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5CShyZXZpc2lvbiAyMjI4ODEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTk0Miw4ICsx OTQyLDggQEAgY2xhc3MgQ3BwU3R5bGVUZXN0KENwcFN0eWxlVGVzdEJhc2UpOgogICAgICAgICBz ZWxmLmFzc2VydF9saW50KCcgICAgICAgIF4odmFyICwgdmFyX3JlZikgeycsICdFeHRyYSBzcGFj ZSBpbiBibG9jayBhcmd1bWVudHMuICBbd2hpdGVzcGFjZS9icmFja2V0c10gWzRdJywgJ2Zvby5t JykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgICAgICBeKHZhcix2YXJfcmVmKSB7Jywg J01pc3Npbmcgc3BhY2UgYWZ0ZXIgLCAgW3doaXRlc3BhY2UvY29tbWFdIFszXScsICdmb28ubScp CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAgICAgICAgXih2YXIsIHZhcl9yZWYpIHsnLCAn UGxhY2UgYnJhY2Ugb24gaXRzIG93biBsaW5lIGZvciBmdW5jdGlvbiBkZWZpbml0aW9ucy4gIFt3 aGl0ZXNwYWNlL2JyYWNlc10gWzRdJywgJ2Zvby5jcHAnKQotICAgICAgICBzZWxmLmFzc2VydF9s aW50KCcgICAgICAgIF4geycsICcnLCAnZm9vLm0nKQotICAgICAgICBzZWxmLmFzc2VydF9saW50 KCcgICAgICAgIF57JywgJ05vIHNwYWNlIGJldHdlZW4gXiBhbmQgYmxvY2sgZGVmaW5pdGlvbi4g IFt3aGl0ZXNwYWNlL2JyYWNrZXRzXSBbNF0nLCAnZm9vLm0nKQorICAgICAgICBzZWxmLmFzc2Vy dF9saW50KCcgICAgICAgIF57JywgJycsICdmb28ubScpCisgICAgICAgIHNlbGYuYXNzZXJ0X2xp bnQoJyAgICAgICAgXiB7JywgJ0V4dHJhIHNwYWNlIGJldHdlZW4gXiBhbmQgYmxvY2sgZGVmaW5p dGlvbi4gIFt3aGl0ZXNwYWNlL2JyYWNrZXRzXSBbNF0nLCAnZm9vLm0nKQogICAgICAgICBzZWxm LmFzc2VydF9saW50KCcgICAgICAgIF4gKGFyZzEsIGFyZzIpIHsnLCAnRXh0cmEgc3BhY2UgYmV0 d2VlbiBeIGFuZCBibG9jayBhcmd1bWVudHMuICBbd2hpdGVzcGFjZS9icmFja2V0c10gWzRdJywg J2Zvby5tJykKIAogICAgIGRlZiB0ZXN0X29iamVjdGl2ZV9jX2Jsb2NrX2FzX2FyZ3VtZW50KHNl bGYpOgo= 322739 2017-10-04 16:38:34 -0700 2017-10-04 23:52:31 -0700 Patch bug-177897-20171004163833.patch text/plain 3497 megan_gardner SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIyMjg4MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE3LTEwLTA0ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBs ZS5jb20+CisKKyAgICAgICAgY2hlY2std2Via2l0LXN0eWxlIGVycm9uZW91c2x5IHJlcXVpcmVz IGEgc3BhY2UgYmV0d2VlbiB0aGUgY2Fycm90IGFuZCBicmFjZSBpbiBvYmotYyBibG9ja3MuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc4OTcKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGhl IGNoZWNrIGZvciBhIHNwYWNlIGJldHdlZW4gXiBhbmQgeywgCisgICAgICAgIGFzIHRoaXMgaXMg dmFsaWQgYW5kIGV4cGVjdGVkIE9iai1DCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcC5weToKKyAgICAgICAgKHJlZ2V4X2Zvcl9sYW1iZGFzX2FuZF9ibG9j a3MpOgorCiAyMDE3LTEwLTA0ICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KIAog ICAgICAgICBXVEY6IFVwZGF0ZSBzdGQ6OmV4cGVjdGVkIHRvIG1hdGNoIGN1cnJlbnQgcHJvcG9z YWwKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 CShyZXZpc2lvbiAyMjI4ODEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weQkod29ya2luZyBjb3B5KQpAQCAtMTI2Miw5ICsxMjYyLDkgQEAgZGVmIHJlZ2V4 X2Zvcl9sYW1iZGFzX2FuZF9ibG9ja3MobGluZSwgbAogICAgICAgICBpZiBzZWFyY2gocicoXChc c3xcc1wpfFxzLCknLCBncm91cCk6CiAgICAgICAgICAgICB0YXJnX2Vycm9yID0gW2xpbmVfbnVt YmVyLCAnd2hpdGVzcGFjZS9icmFja2V0cycsIDQsCiAgICAgICAgICAgICAgICdFeHRyYSBzcGFj ZSBpbiBibG9jayBhcmd1bWVudHMuJ10KLSAgICAgICAgaWYgc2VhcmNoKHInXF5ceycsIGdyb3Vw KToKKyAgICAgICAgaWYgc2VhcmNoKHInXF5cc1x7JywgZ3JvdXApOgogICAgICAgICAgICAgdGFy Z19lcnJvciA9IFtsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvYnJhY2tldHMnLCA0LAotICAgICAg ICAgICAgICAnTm8gc3BhY2UgYmV0d2VlbiBeIGFuZCBibG9jayBkZWZpbml0aW9uLiddCisgICAg ICAgICAgICAgICdFeHRyYSBzcGFjZSBiZXR3ZWVuIF4gYW5kIGJsb2NrIGRlZmluaXRpb24uJ10K ICAgICAgICAgaWYgc2VhcmNoKHInXF5cc1woJywgZ3JvdXApOgogICAgICAgICAgICAgdGFyZ19l cnJvciA9IFtsaW5lX251bWJlciwgJ3doaXRlc3BhY2UvYnJhY2tldHMnLCA0LAogICAgICAgICAg ICAgICAnRXh0cmEgc3BhY2UgYmV0d2VlbiBeIGFuZCBibG9jayBhcmd1bWVudHMuJ10KSW5kZXg6 IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5CShyZXZpc2lvbiAyMjI4ODEpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0 eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMTk0MiwxNCAr MTk0MiwxNCBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFzZSk6CiAgICAgICAg IHNlbGYuYXNzZXJ0X2xpbnQoJyAgICAgICAgXih2YXIgLCB2YXJfcmVmKSB7JywgJ0V4dHJhIHNw YWNlIGluIGJsb2NrIGFyZ3VtZW50cy4gIFt3aGl0ZXNwYWNlL2JyYWNrZXRzXSBbNF0nLCAnZm9v Lm0nKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KCcgICAgICAgIF4odmFyLHZhcl9yZWYpIHsn LCAnTWlzc2luZyBzcGFjZSBhZnRlciAsICBbd2hpdGVzcGFjZS9jb21tYV0gWzNdJywgJ2Zvby5t JykKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnICAgICAgICBeKHZhciwgdmFyX3JlZikgeycs ICdQbGFjZSBicmFjZSBvbiBpdHMgb3duIGxpbmUgZm9yIGZ1bmN0aW9uIGRlZmluaXRpb25zLiAg W3doaXRlc3BhY2UvYnJhY2VzXSBbNF0nLCAnZm9vLmNwcCcpCi0gICAgICAgIHNlbGYuYXNzZXJ0 X2xpbnQoJyAgICAgICAgXiB7JywgJycsICdmb28ubScpCi0gICAgICAgIHNlbGYuYXNzZXJ0X2xp bnQoJyAgICAgICAgXnsnLCAnTm8gc3BhY2UgYmV0d2VlbiBeIGFuZCBibG9jayBkZWZpbml0aW9u LiAgW3doaXRlc3BhY2UvYnJhY2tldHNdIFs0XScsICdmb28ubScpCisgICAgICAgIHNlbGYuYXNz ZXJ0X2xpbnQoJyAgICAgICAgXnsnLCAnJywgJ2Zvby5tJykKKyAgICAgICAgc2VsZi5hc3NlcnRf bGludCgnICAgICAgICBeIHsnLCAnRXh0cmEgc3BhY2UgYmV0d2VlbiBeIGFuZCBibG9jayBkZWZp bml0aW9uLiAgW3doaXRlc3BhY2UvYnJhY2tldHNdIFs0XScsICdmb28ubScpCiAgICAgICAgIHNl bGYuYXNzZXJ0X2xpbnQoJyAgICAgICAgXiAoYXJnMSwgYXJnMikgeycsICdFeHRyYSBzcGFjZSBi ZXR3ZWVuIF4gYW5kIGJsb2NrIGFyZ3VtZW50cy4gIFt3aGl0ZXNwYWNlL2JyYWNrZXRzXSBbNF0n LCAnZm9vLm0nKQogCiAgICAgZGVmIHRlc3Rfb2JqZWN0aXZlX2NfYmxvY2tfYXNfYXJndW1lbnQo c2VsZik6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAgICAgICAgd2l0aExhbWJkYTpeKHZh ciwgdmFyX3JlZikgeycsICcnLCAnZm9vLm1tJykKLSAgICAgICAgc2VsZi5hc3NlcnRfbGludCgn ICAgICAgICB3aXRoTGFtYmRhOl4geycsICcnLCAnZm9vLm0nKQotICAgICAgICBzZWxmLmFzc2Vy dF9saW50KCcgICAgICAgIHdpdGhMYW1iZGE6XnsnLCAnTm8gc3BhY2UgYmV0d2VlbiBeIGFuZCBi bG9jayBkZWZpbml0aW9uLiAgW3doaXRlc3BhY2UvYnJhY2tldHNdIFs0XScsICdmb28ubScpCisg ICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAgICAgICAgd2l0aExhbWJkYTpeeycsICcnLCAnZm9v Lm0nKQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcgICAgICAgIHdpdGhMYW1iZGE6XiB7Jywg J0V4dHJhIHNwYWNlIGJldHdlZW4gXiBhbmQgYmxvY2sgZGVmaW5pdGlvbi4gIFt3aGl0ZXNwYWNl L2JyYWNrZXRzXSBbNF0nLCAnZm9vLm0nKQogCiAgICAgZGVmIHRlc3Rfc3BhY2luZ19hcm91bmRf ZWxzZShzZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfbGludCgnfWVsc2UgeycsICdNaXNzaW5n IHNwYWNlIGJlZm9yZSBlbHNlJwo=