177894 2017-10-04 13:06:53 -0700 RenderMultiColumnFlow populate/evacuate should not disable layout state. 2017-10-04 14:29:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1356609 0 zalan 2017-10-04 13:06:53 -0700 They are not performed at layout time. 1356611 1 webkit-bug-importer 2017-10-04 13:07:31 -0700 <rdar://problem/34818696> 1356612 2 322709 zalan 2017-10-04 13:09:20 -0700 Created attachment 322709 Patch 1356635 3 322709 koivisto 2017-10-04 13:49:28 -0700 Comment on attachment 322709 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322709&action=review > Source/WebCore/ChangeLog:9 > + Populate/evacuate methods are not called at layout time. Maybe we could assert in LayoutStateDisabler that we do have a layout state? 1356636 4 zalan 2017-10-04 13:50:05 -0700 (In reply to Antti Koivisto from comment #3) > Comment on attachment 322709 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322709&action=review > > > Source/WebCore/ChangeLog:9 > > + Populate/evacuate methods are not called at layout time. > > Maybe we could assert in LayoutStateDisabler that we do have a layout state? Good idea! 1356665 5 322709 commit-queue 2017-10-04 14:29:54 -0700 Comment on attachment 322709 Patch Clearing flags on attachment: 322709 Committed r222881: <http://trac.webkit.org/changeset/222881> 1356666 6 commit-queue 2017-10-04 14:29:55 -0700 All reviewed patches have been landed. Closing bug. 322709 2017-10-04 13:09:20 -0700 2017-10-04 14:29:54 -0700 Patch bug-177894-20171004130919.patch text/plain 2188 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyODU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjJkZWI5MGQyNDg4ODg3 MzFlODgyZGJhODc2OTFkZTIxNzExMDBiNy4uYjk4YTg0YzI4Y2U0YTVkNDEwMDYwYmJlYmRmNGE5 MTgzOGY3NTQ2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTEwLTA0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuZGVyTXVsdGlDb2x1bW5G bG93IHBvcHVsYXRlL2V2YWN1YXRlIHNob3VsZCBub3QgZGlzYWJsZSBsYXlvdXQgc3RhdGUuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc4OTQKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzM0ODE4Njk2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFBvcHVsYXRlL2V2YWN1YXRlIG1ldGhvZHMgYXJlIG5v dCBjYWxsZWQgYXQgbGF5b3V0IHRpbWUuCisKKyAgICAgICAgQ292ZXJlZCBieSBleGlzdGluZyB0 ZXN0cy4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3cuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTXVsdGlDb2x1bW5GbG93Ojpwb3B1bGF0ZSk6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJNdWx0aUNvbHVtbkZsb3c6OmV2YWN1YXRlQW5kRGVzdHJveSk6 CisKIDIwMTctMTAtMDQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSBPcGVuV2ViUlRDIGJhY2tlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJNdWx0aUNvbHVtbkZsb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlck11bHRpQ29sdW1uRmxvdy5jcHAKaW5kZXggYWI1ZTRlZjY5YmNjZmUwOTE3 NmNmNzExOGQxMzJiMjI3ZDRmMmUxMS4uMmI1N2NkMTY3MzEzNjQ1N2Q1M2Q2NzJmYWM0ZjVjNWIz YzJkM2ZjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRp Q29sdW1uRmxvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlck11bHRp Q29sdW1uRmxvdy5jcHAKQEAgLTE1MCw3ICsxNTAsNiBAQCB2b2lkIFJlbmRlck11bHRpQ29sdW1u Rmxvdzo6cG9wdWxhdGUoKQogICAgIC8vIFJlcGFyZW50IGNoaWxkcmVuIHByZWNlZGluZyB0aGUg ZmxvdyB0aHJlYWQgaW50byB0aGUgZmxvdyB0aHJlYWQuIEl0J3MgbXVsdGljb2wgY29udGVudAog ICAgIC8vIG5vdy4gQXQgdGhpcyBwb2ludCB0aGVyZSdzIG9idmlvdXNseSBub3RoaW5nIGFmdGVy IHRoZSBmbG93IHRocmVhZCwgYnV0IHJlbmRlcmVycyAoY29sdW1uCiAgICAgLy8gc2V0cyBhbmQg c3Bhbm5lcnMpIHdpbGwgYmUgaW5zZXJ0ZWQgdGhlcmUgYXMgd2UgaW5zZXJ0IGVsZW1lbnRzIGlu dG8gdGhlIGZsb3cgdGhyZWFkLgotICAgIExheW91dFN0YXRlRGlzYWJsZXIgbGF5b3V0U3RhdGVE aXNhYmxlcih2aWV3KCkpOwogICAgIG11bHRpY29sQ29udGFpbmVyLT5tb3ZlQ2hpbGRyZW5Ubyh0 aGlzLCBtdWx0aWNvbENvbnRhaW5lci0+Zmlyc3RDaGlsZCgpLCB0aGlzLCB0cnVlKTsKICAgICAK ICAgICBpZiAobXVsdGljb2xDb250YWluZXItPmlzRmllbGRzZXQoKSkgewpAQCAtMTcwLDggKzE2 OSw2IEBAIHZvaWQgUmVuZGVyTXVsdGlDb2x1bW5GbG93OjpldmFjdWF0ZUFuZERlc3Ryb3koKQog ICAgIC8vIERlbGV0ZSB0aGUgbGluZSBib3ggdHJlZS4KICAgICBkZWxldGVMaW5lcygpOwogICAg IAotICAgIExheW91dFN0YXRlRGlzYWJsZXIgbGF5b3V0U3RhdGVEaXNhYmxlcih2aWV3KCkpOwot CiAgICAgLy8gRmlyc3QgcHJvbW90ZSBhbGwgY2hpbGRyZW4gb2YgdGhlIGZsb3cgdGhyZWFkLiBC ZWZvcmUgd2UgbW92ZSB0aGVtIHRvIHRoZSBmbG93IHRocmVhZCdzCiAgICAgLy8gY29udGFpbmVy LCB3ZSBuZWVkIHRvIHVucmVnaXN0ZXIgdGhlIGZsb3cgdGhyZWFkLCBzbyB0aGF0IHRoZXkgYXJl bid0IGp1c3QgcmUtYWRkZWQgYWdhaW4gdG8KICAgICAvLyB0aGUgZmxvdyB0aHJlYWQgdGhhdCB3 ZSdyZSB0cnlpbmcgdG8gZW1wdHkuCg==