177860 2017-10-04 03:06:52 -0700 [GTK] GtkUtilities.h should not be included in libs not linked to GTK 2017-10-04 07:07:24 -0700 1 1 1 Unclassified WebKit WebKitGTK Other PC Linux RESOLVED FIXED P2 Normal --- 1 mcatanzaro mcatanzaro bugs-noreply cgarcia commit-queue mcatanzaro oldest_to_newest 1356311 0 mcatanzaro 2017-10-04 03:06:52 -0700 HyphenationLibHyphen must not depend on GtkUtilities.h, since HyphenationLibHyphen is not built as part of the WebCorePlatformGTK static lib that is linked to GTK+, it's built as part of the WebCore static lib which is not. 1356340 1 mcatanzaro 2017-10-04 04:28:43 -0700 Also as of yesterday, we're using it in FontCacheFreeType.cpp, which is not good because that's not built as part of WebCorePlatformGTK. 1356342 2 322651 mcatanzaro 2017-10-04 04:30:36 -0700 Created attachment 322651 Patch 1356389 3 322651 commit-queue 2017-10-04 07:07:22 -0700 Comment on attachment 322651 Patch Clearing flags on attachment: 322651 Committed r222844: <http://trac.webkit.org/changeset/222844> 1356390 4 commit-queue 2017-10-04 07:07:24 -0700 All reviewed patches have been landed. Closing bug. 322651 2017-10-04 04:30:36 -0700 2017-10-04 07:07:22 -0700 Patch bug-177860-20171004133034.patch text/plain 7178 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyODM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjU0NjFlNWRhZjY2YjU4 N2NiNjU4MzAxNmNlZDg4YmFlNzhiOTJlZS4uODFlOTk0YjBjMjlkNmQ2NTM4YjRjMGU5YmJjMDRm ZDJhMTk4NWZiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDE3LTEwLTA0ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RLXSBH dGtVdGlsaXRpZXMuaCBzaG91bGQgbm90IGJlIGluY2x1ZGVkIGluIGxpYnMgbm90IGxpbmtlZCB0 byBHVEsKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 Nzg2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGxhdGZvcm0vRnJlZVR5cGUuY21ha2U6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL0d0a1V0aWxp dGllcy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b3BMZXZlbFBhdGgpOiBEZWxldGVkLgorICAg ICAgICAoV2ViQ29yZTo6d2Via2l0QnVpbGREaXJlY3RvcnkpOiBEZWxldGVkLgorICAgICAgICAq IHBsYXRmb3JtL2d0ay9HdGtVdGlsaXRpZXMuaDoKKyAgICAgICAgKFdlYkNvcmU6OndhbGxUaW1l Rm9yRXZlbnQpOgorICAgICAgICAqIHBsYXRmb3JtL3RleHQvaHlwaGVuL0h5cGhlbmF0aW9uTGli SHlwaGVuLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRvcExldmVsUGF0aCk6CisgICAgICAgIChX ZWJDb3JlOjp3ZWJraXRCdWlsZERpcmVjdG9yeSk6CisKKzIwMTctMTAtMDQgIE1pY2hhZWwgQ2F0 YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCiAgICAgICAgIFJFR1JFU1NJT04ocjIy MjM5Mik6IFtXUEVdW0dUS10gTWFueSBmb3JtcyB0ZXN0cyBhcmUgZmFpbGluZyBkdWUgdG8gYnJv a2VuIGV2ZW50IHRpbWVzdGFtcHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3NzQ0OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9GcmVlVHlwZS5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0ZyZWVUeXBlLmNtYWtl CmluZGV4IDRmMTdkYzFlN2IwYmZmYWE0ODg1OGZjZGNhYzA0NTk4NzhiZGQ2ZTUuLjEzYzY4ZDJl YzE2YWUwOTRhNWZiNjYwMmRhMDZhMGI3Mjk3M2Q1MTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL0ZyZWVUeXBlLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L0ZyZWVUeXBlLmNtYWtlCkBAIC03LDcgKzcsNiBAQCBsaXN0KEFQUEVORCBXZWJDb3JlX0lOQ0xV REVfRElSRUNUT1JJRVMKICkKIAogbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0gICAgcGxh dGZvcm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udENhY2hlRnJlZVR5cGUuY3BwCiAgICAgcGxhdGZv cm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udEN1c3RvbVBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcAog ICAgIHBsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5j cHAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9HbHlwaFBhZ2VUcmVlTm9kZUZyZWVU eXBlLmNwcApAQCAtMTgsNiArMTcsMTYgQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAg ICAgcGxhdGZvcm0vZ3JhcGhpY3MvaGFyZmJ1enovSGFyZkJ1enpTaGFwZXIuY3BwCiApCiAKK2lm IChQT1JUIFNUUkVRVUFMICJHVEsiKQorICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVQbGF0Zm9ybUdU S19TT1VSQ0VTCisgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRDYWNoZUZy ZWVUeXBlLmNwcAorKQorZWxzZSAoKQorICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwor ICAgICAgICBwbGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250Q2FjaGVGcmVlVHlwZS5jcHAK KykKK2VuZGlmICgpCisKIGlmIChVU0VfQ0FJUk8pCiAgICAgbGlzdChBUFBFTkQgV2ViQ29yZV9T T1VSQ0VTCiAgICAgICAgIHBsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRDYWlyb0hhcmZidXp6 TkcuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrVXRpbGl0 aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9HdGtVdGlsaXRpZXMuY3BwCmlu ZGV4IGZmZjE0MDQ3YzUwMGJiYThiNjAzZTk2NDU3MTc2MWY3ZGEwMzQxNTMuLmYzZWMzNDI4ZGMy NTYyYTRkOTNjYTRhNzBmZjEwNjg4NzkxNjUyMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9HdGtVdGlsaXRpZXMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9HdGtVdGlsaXRpZXMuY3BwCkBAIC0yMSw3ICsyMSw2IEBACiAKICNpbmNsdWRlICJJ bnRQb2ludC5oIgogI2luY2x1ZGUgPGd0ay9ndGsuaD4KLSNpbmNsdWRlIDx3dGYvZ2xpYi9HTGli VXRpbGl0aWVzLmg+CiAjaW5jbHVkZSA8d3RmL2dsaWIvR1VuaXF1ZVB0ci5oPgogCiBuYW1lc3Bh Y2UgV2ViQ29yZSB7CkBAIC03OCwzMCArNzcsNCBAQCBTdHJpbmcgZGVmYXVsdEd0a1N5c3RlbUZv bnQoKQogICAgIHJldHVybiBTdHJpbmc6OmZyb21VVEY4KGZvbnRTdHJpbmcuZ2V0KCkpOwogfQog Ci0jaWYgRU5BQkxFKERFVkVMT1BFUl9NT0RFKQotc3RhdGljIENTdHJpbmcgdG9wTGV2ZWxQYXRo KCkKLXsKLSAgICBpZiAoY29uc3QgY2hhciogdG9wTGV2ZWxEaXJlY3RvcnkgPSBnX2dldGVudigi V0VCS0lUX1RPUF9MRVZFTCIpKQotICAgICAgICByZXR1cm4gdG9wTGV2ZWxEaXJlY3Rvcnk7Ci0K LSAgICAvLyBJZiB0aGUgZW52aXJvbm1lbnQgdmFyaWFibGUgd2Fzbid0IHByb3ZpZGVkIHRoZW4g YXNzdW1lIHdlIHdlcmUgYnVpbHQgaW50bwotICAgIC8vIFdlYktpdEJ1aWxkL0RlYnVnIG9yIFdl YktpdEJ1aWxkL1JlbGVhc2UuIE9idmlvdXNseSB0aGlzIHdpbGwgZmFpbCBpZiB0aGUgYnVpbGQK LSAgICAvLyBkaXJlY3RvcnkgaXMgbm9uLXN0YW5kYXJkLCBidXQgd2UgY2FuJ3QgZG8gbXVjaCBt b3JlIGFib3V0IHRoaXMuCi0gICAgR1VuaXF1ZVB0cjxjaGFyPiBwYXJlbnRQYXRoKGdfcGF0aF9n ZXRfZGlybmFtZShnZXRDdXJyZW50RXhlY3V0YWJsZVBhdGgoKS5kYXRhKCkpKTsKLSAgICBHVW5p cXVlUHRyPGNoYXI+IGxheW91dFRlc3RzUGF0aChnX2J1aWxkX2ZpbGVuYW1lKHBhcmVudFBhdGgu Z2V0KCksICIuLiIsICIuLiIsICIuLiIsIG51bGxwdHIpKTsKLSAgICBHVW5pcXVlUHRyPGNoYXI+ IGFic29sdXRlVG9wTGV2ZWxQYXRoKHJlYWxwYXRoKGxheW91dFRlc3RzUGF0aC5nZXQoKSwgMCkp OwotICAgIHJldHVybiBhYnNvbHV0ZVRvcExldmVsUGF0aC5nZXQoKTsKLX0KLQotQ1N0cmluZyB3 ZWJraXRCdWlsZERpcmVjdG9yeSgpCi17Ci0gICAgY29uc3QgY2hhciogd2Via2l0T3V0cHV0RGly ID0gZ19nZXRlbnYoIldFQktJVF9PVVRQVVRESVIiKTsKLSAgICBpZiAod2Via2l0T3V0cHV0RGly KQotICAgICAgICByZXR1cm4gd2Via2l0T3V0cHV0RGlyOwotCi0gICAgR1VuaXF1ZVB0cjxjaGFy PiBvdXRwdXREaXIoZ19idWlsZF9maWxlbmFtZSh0b3BMZXZlbFBhdGgoKS5kYXRhKCksICJXZWJL aXRCdWlsZCIsIG51bGxwdHIpKTsKLSAgICByZXR1cm4gb3V0cHV0RGlyLmdldCgpOwotfQotI2Vu ZGlmCi0KIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9HdGtVdGlsaXRpZXMuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0 ay9HdGtVdGlsaXRpZXMuaAppbmRleCA0NTUzYjY3ZmNhZDEyYTQ0MjlmNGM4NTg1YzE4MDJmMjYy OGMzYmQwLi41M2Y5MDcwYTAzYmY0ZjE2MTY1OTdjMmEyZDRhYmI4NTA3OWJiNzA4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvR3RrVXRpbGl0aWVzLmgKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0d0a1V0aWxpdGllcy5oCkBAIC0xOSw2ICsxOSw3IEBA CiAjaWZuZGVmIEd0a1V0aWxpdGllc19oIAogI2RlZmluZSBHdGtVdGlsaXRpZXNfaCAKIAorI2lu Y2x1ZGUgPGd0ay9ndGsuaD4KICNpbmNsdWRlIDx3dGYvTW9ub3RvbmljVGltZS5oPgogI2luY2x1 ZGUgPHd0Zi9XYWxsVGltZS5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KQEAgLTM0 LDEwICszNSw3IEBAIGJvb2wgd2lkZ2V0SXNPbnNjcmVlblRvcGxldmVsV2luZG93KEd0a1dpZGdl dCopOwogdGVtcGxhdGU8dHlwZW5hbWUgR2RrRXZlbnRUeXBlPgogV2FsbFRpbWUgd2FsbFRpbWVG b3JFdmVudChjb25zdCBHZGtFdmVudFR5cGUqIGV2ZW50KQogewotICAgIC8vIEZJWE1FOiAwIGlz IEdES19DVVJSRU5UX1RJTUUuIFdlIHNob3VsZCBzdG9wIGluY2x1ZGluZyB0aGlzIGhlYWRlciBm cm9tCi0gICAgLy8gSHlwaGVuYXRpb25MaWJIeXBoZW4uY3BwIHNvIHRoYXQgd2UgY2FuIGluY2x1 ZGUgZ3RrL2d0ay5oIGhlcmUgYW5kIHVzZQotICAgIC8vIEdES19DVVJSRU5UX1RJTUUuCi0gICAg aWYgKGV2ZW50LT50aW1lID09IDApCisgICAgaWYgKGV2ZW50LT50aW1lID09IEdES19DVVJSRU5U X1RJTUUpCiAgICAgICAgIHJldHVybiBXYWxsVGltZTo6bm93KCk7CiAgICAgcmV0dXJuIE1vbm90 b25pY1RpbWU6OmZyb21SYXdTZWNvbmRzKGV2ZW50LT50aW1lIC8gMTAwMC4pLmFwcHJveGltYXRl V2FsbFRpbWUoKTsKIH0KQEAgLTQ3LDEwICs0NSw2IEBAIFdhbGxUaW1lIHdhbGxUaW1lRm9yRXZl bnQoY29uc3QgR2RrRXZlbnQqKTsKIAogU3RyaW5nIGRlZmF1bHRHdGtTeXN0ZW1Gb250KCk7CiAK LSNpZiBFTkFCTEUoREVWRUxPUEVSX01PREUpCi1DU3RyaW5nIHdlYmtpdEJ1aWxkRGlyZWN0b3J5 KCk7Ci0jZW5kaWYKLQogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQogCiAjZW5kaWYgLy8gR3RrVXRp bGl0aWVzX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvaHlwaGVu L0h5cGhlbmF0aW9uTGliSHlwaGVuLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQv aHlwaGVuL0h5cGhlbmF0aW9uTGliSHlwaGVuLmNwcAppbmRleCA2YzIwNmI4YWEwY2RjMWJhZDMx NjRkM2JmN2JmMTFhNTRhMTYxM2JmLi43OTFmNTIyMzRmODk2MDMyZjgwYWFkMzI1MWJmOTMzNmEw NTQ2YWQyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L2h5cGhlbi9I eXBoZW5hdGlvbkxpYkh5cGhlbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4 dC9oeXBoZW4vSHlwaGVuYXRpb25MaWJIeXBoZW4uY3BwCkBAIC0zNiwxNSArMzYsMTIgQEAKICNp bmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9OZXZlckRlc3Ryb3llZC5oPgog I2luY2x1ZGUgPHd0Zi9UaW55TFJVQ2FjaGUuaD4KKyNpbmNsdWRlIDx3dGYvZ2xpYi9HTGliVXRp bGl0aWVzLmg+CisjaW5jbHVkZSA8d3RmL2dsaWIvR1VuaXF1ZVB0ci5oPgogI2luY2x1ZGUgPHd0 Zi90ZXh0L0F0b21pY1N0cmluZ0hhc2guaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9DU3RyaW5nLmg+ CiAjaW5jbHVkZSA8d3RmL3RleHQvU3RyaW5nVmlldy5oPgogCi0jaWYgUExBVEZPUk0oR1RLKQot I2luY2x1ZGUgIkd0a1V0aWxpdGllcy5oIgotI2luY2x1ZGUgPHd0Zi9nbGliL0dVbmlxdWVQdHIu aD4KLSNlbmRpZgotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHN0YXRpYyBjb25zdCBjaGFyKiBj b25zdCBnRGljdGlvbmFyeURpcmVjdG9yaWVzW10gPSB7CkBAIC04OCw2ICs4NSwzMCBAQCBzdGF0 aWMgdm9pZCBzY2FuRGlyZWN0b3J5Rm9yRGljaW9uYXJpZXMoY29uc3QgY2hhciogZGlyZWN0b3J5 UGF0aCwgSGFzaE1hcDxBdG9taQogfQogCiAjaWYgRU5BQkxFKERFVkVMT1BFUl9NT0RFKQorc3Rh dGljIENTdHJpbmcgdG9wTGV2ZWxQYXRoKCkKK3sKKyAgICBpZiAoY29uc3QgY2hhciogdG9wTGV2 ZWxEaXJlY3RvcnkgPSBnX2dldGVudigiV0VCS0lUX1RPUF9MRVZFTCIpKQorICAgICAgICByZXR1 cm4gdG9wTGV2ZWxEaXJlY3Rvcnk7CisKKyAgICAvLyBJZiB0aGUgZW52aXJvbm1lbnQgdmFyaWFi bGUgd2Fzbid0IHByb3ZpZGVkIHRoZW4gYXNzdW1lIHdlIHdlcmUgYnVpbHQgaW50bworICAgIC8v IFdlYktpdEJ1aWxkL0RlYnVnIG9yIFdlYktpdEJ1aWxkL1JlbGVhc2UuIE9idmlvdXNseSB0aGlz IHdpbGwgZmFpbCBpZiB0aGUgYnVpbGQKKyAgICAvLyBkaXJlY3RvcnkgaXMgbm9uLXN0YW5kYXJk LCBidXQgd2UgY2FuJ3QgZG8gbXVjaCBtb3JlIGFib3V0IHRoaXMuCisgICAgR1VuaXF1ZVB0cjxj aGFyPiBwYXJlbnRQYXRoKGdfcGF0aF9nZXRfZGlybmFtZShnZXRDdXJyZW50RXhlY3V0YWJsZVBh dGgoKS5kYXRhKCkpKTsKKyAgICBHVW5pcXVlUHRyPGNoYXI+IGxheW91dFRlc3RzUGF0aChnX2J1 aWxkX2ZpbGVuYW1lKHBhcmVudFBhdGguZ2V0KCksICIuLiIsICIuLiIsICIuLiIsIG51bGxwdHIp KTsKKyAgICBHVW5pcXVlUHRyPGNoYXI+IGFic29sdXRlVG9wTGV2ZWxQYXRoKHJlYWxwYXRoKGxh eW91dFRlc3RzUGF0aC5nZXQoKSwgMCkpOworICAgIHJldHVybiBhYnNvbHV0ZVRvcExldmVsUGF0 aC5nZXQoKTsKK30KKworc3RhdGljIENTdHJpbmcgd2Via2l0QnVpbGREaXJlY3RvcnkoKQorewor ICAgIGNvbnN0IGNoYXIqIHdlYmtpdE91dHB1dERpciA9IGdfZ2V0ZW52KCJXRUJLSVRfT1VUUFVU RElSIik7CisgICAgaWYgKHdlYmtpdE91dHB1dERpcikKKyAgICAgICAgcmV0dXJuIHdlYmtpdE91 dHB1dERpcjsKKworICAgIEdVbmlxdWVQdHI8Y2hhcj4gb3V0cHV0RGlyKGdfYnVpbGRfZmlsZW5h bWUodG9wTGV2ZWxQYXRoKCkuZGF0YSgpLCAiV2ViS2l0QnVpbGQiLCBudWxscHRyKSk7CisgICAg cmV0dXJuIG91dHB1dERpci5nZXQoKTsKK30KKwogc3RhdGljIHZvaWQgc2NhblRlc3REaWN0aW9u YXJpZXNEaXJlY3RvcnlJZk5lY2Vzc2FyeShIYXNoTWFwPEF0b21pY1N0cmluZywgVmVjdG9yPFN0 cmluZz4+JiBhdmFpbGFibGVMb2NhbGVzKQogewogICAgIC8vIEl0J3MgdW5mb3J0dW5hdGUgdGhh dCB3ZSBuZWVkIHRvIGxvb2sgZm9yIHRoZSBkaWN0aW9uYXJpZXMgdGhpcyB3YXksIGJ1dAo=