177857 2017-10-04 02:11:25 -0700 [WPE] Expose ENABLE_XSLT option 2017-10-10 15:59:57 -0700 1 1 1 Unclassified WebKit WPE WebKit Other PC Linux RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177752 P2 Normal --- 1 mcatanzaro mcatanzaro aperez bugs-noreply clopez commit-queue mcatanzaro olivier.blin webkit-bug-importer oldest_to_newest 1356295 0 mcatanzaro 2017-10-04 02:11:25 -0700 Expose ENABLE_XSLT option 1356297 1 322640 mcatanzaro 2017-10-04 02:12:28 -0700 Created attachment 322640 Patch 1358828 2 clopez 2017-10-10 12:09:44 -0700 Why we want to expose this? 1358883 3 aperez 2017-10-10 13:49:27 -0700 (In reply to Carlos Alberto Lopez Perez from comment #2) > Why we want to expose this? Saving some MiB of disk space and some memory usage seems worth it, particularly for embedded usage. Example: The Arch Linux x86-64 libxml2+libxslt packages take ~11.5 MiB on disk, and take at least ~1.6 MiB of memory when loaded (according to Bloaty — https://github.com/google/bloaty), plus the reductions of size from the WebKit code that implements the XSLT functionality. 1358889 4 mcatanzaro 2017-10-10 13:56:56 -0700 I'm fine with requiring libxslt, but it seems useful for WPE to expose options for disabling features that add new dependencies if those dependencies are not useful on embedded devices. Anyway, if we don't expose it, we should revert r222727. 1358937 5 clopez 2017-10-10 15:29:42 -0700 (In reply to Adrian Perez from comment #3) > (In reply to Carlos Alberto Lopez Perez from comment #2) > > Why we want to expose this? > > Saving some MiB of disk space and some memory usage seems worth it, > particularly for embedded usage. > > Example: The Arch Linux x86-64 libxml2+libxslt packages take ~11.5 MiB > on disk, and take at least ~1.6 MiB of memory when loaded (according to > Bloaty — https://github.com/google/bloaty), plus the reductions of size > from the WebKit code that implements the XSLT functionality. Ok.. That's something someone might want to do in order to optimize space/memory requirements as much as possible. Let's do this then 1358938 6 322640 clopez 2017-10-10 15:29:50 -0700 Comment on attachment 322640 Patch Ok 1358953 7 322640 commit-queue 2017-10-10 15:59:11 -0700 Comment on attachment 322640 Patch Clearing flags on attachment: 322640 Committed r223152: <http://trac.webkit.org/changeset/223152> 1358954 8 commit-queue 2017-10-10 15:59:13 -0700 All reviewed patches have been landed. Closing bug. 322640 2017-10-04 02:12:28 -0700 2017-10-10 15:59:11 -0700 Patch bug-177857-20171004111226.patch text/plain 1240 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzc2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4IDUyOTc5 MTI0Y2I1NjI4M2Y4MzA2MTQ0MjNhNWQ0Yzk2MTU0NmM3MzEuLjkwMDM3OGYzNTA1YWQ5ZmFkN2Jm MWU1NzA1OWUyMjdmY2ZjMzcxYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BF LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC0zNCw2ICszNCw3 IEBAIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9VU0VSX01FU1NBR0Vf SEFORExFUlMgUFJJVkFURSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9XRUJfQU5JTUFUSU9OUyBQUklWQVRFIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BP UlRfVkFMVUUoRU5BQkxFX1dFQl9DUllQVE8gUFVCTElDIE9OKQogV0VCS0lUX09QVElPTl9ERUZB VUxUX1BPUlRfVkFMVUUoRU5BQkxFX1dFQkdMIFBVQkxJQyBPTikKK1dFQktJVF9PUFRJT05fREVG QVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9YU0xUIFBVQkxJQyBPTikKIAogaWYgKENNQUtFX1NZU1RF TV9OQU1FIE1BVENIRVMgIkxpbnV4IikKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfTUVNT1JZX1NBTVBMRVIgUFJJVkFURSBPTikKZGlmZiAtLWdpdCBhL0NoYW5n ZUxvZyBiL0NoYW5nZUxvZwppbmRleCAyZDJmYmY5ZTM4MDA1NDkyN2VhYjAyZjg3MzcwOTg1YWQ1 NmY3NjgwLi44YWFiNzlkMDlmOGM3OGI5ZDI0MWYxODQwOWRiMzNiZjFmNDBkMzMwIDEwMDY0NAot LS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMTAt MDQgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisgICAgICAg IFtXUEVdIEV4cG9zZSBFTkFCTEVfWFNMVCBvcHRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Nzg1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2U6 CisKIDIwMTctMTAtMDMgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAg ICAgIEJ1aWxkIGxpYndlYnJ0YyB1bml0IHRlc3RzIGV4ZWN1dGFibGVzCg==