177836 2017-10-03 14:00:46 -0700 RenderMenuList should not hold raw pointers 2017-10-03 15:40:35 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1356028 0 zalan 2017-10-03 14:00:46 -0700 m_innerBlock and m_buttonText 1356044 1 322581 zalan 2017-10-03 14:20:07 -0700 Created attachment 322581 Patch 1356049 2 322581 koivisto 2017-10-03 14:27:18 -0700 Comment on attachment 322581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322581&action=review > Source/WebCore/rendering/RenderMenuList.cpp:109 > + m_innerBlock = makeWeakPtr(*newInnerBlock.get()); No need for .get() 1356050 3 322581 koivisto 2017-10-03 14:27:59 -0700 Comment on attachment 322581 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322581&action=review > Source/WebCore/rendering/RenderMenuList.cpp:296 > + m_buttonText = makeWeakPtr(*newButtonText.get()); No need for .get() 1356052 4 322583 zalan 2017-10-03 14:29:19 -0700 Created attachment 322583 Patch 1356091 5 322583 commit-queue 2017-10-03 15:39:54 -0700 Comment on attachment 322583 Patch Clearing flags on attachment: 322583 Committed r222814: <http://trac.webkit.org/changeset/222814> 1356092 6 commit-queue 2017-10-03 15:39:57 -0700 All reviewed patches have been landed. Closing bug. 1356093 7 webkit-bug-importer 2017-10-03 15:40:35 -0700 <rdar://problem/34801095> 322581 2017-10-03 14:20:07 -0700 2017-10-03 14:29:18 -0700 Patch bug-177836-20171003142006.patch text/plain 3512 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRlMTY5OWFhNDZlMzQ1 NzAzMTM0Mjk5MjY5YWM1YzU0MThhNDU2ZC4uMWYwZGVmN2ZmMDg1NTIyZTRjYTBmNzk5M2Y5NWYy M2JkYWM5MjIwYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTEwLTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuZGVyTWVudUxpc3Qgc2hv dWxkIG5vdCBob2xkIHJhdyBwb2ludGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTc3ODM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgV2hpbGUgYm90aCBtX2J1dHRvblRleHQgYW5kIG1faW5uZXJCbG9j ayBhcmUgY2hpbGQgcmVuZGVyZXJzIG9mCisgICAgICAgIHRoZSBSZW5kZXJNZW51TGlzdCwgc28g dGhlIHRoZWlyIGxpZmVjeWNsZXMgYXJlIHN1cHBvc2VkIHRvIHRpZWQKKyAgICAgICAgdG8gdGhl IHBhcmVudCBvYmplY3QsIHRoaXMgcGF0Y2ggcmVtb3ZlcyBzb21lIG1hbnVhbCByYXcgcG9pbnRl ciBtYW5hZ2luZy4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlck1lbnVMaXN0OjpSZW5kZXJNZW51TGlzdCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJN ZW51TGlzdDo6Y3JlYXRlSW5uZXJCbG9jayk6CisgICAgICAgIChSZW5kZXJNZW51TGlzdDo6dGFr ZUNoaWxkKToKKyAgICAgICAgKFJlbmRlck1lbnVMaXN0OjpzZXRUZXh0KToKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyTWVudUxpc3QuaDoKKwogMjAxNy0xMC0wMiAgQW50dGkgS29pdmlzdG8g IDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IG1lbW9yeSBsZWFrcyBpbiBSZW5kZXJN dWx0aUNvbHVtbkZsb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJNZW51TGlzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVudUxpc3Qu Y3BwCmluZGV4IDA2YWMyMzQyYmI1MThkMzlmYmU0NTQzNzZlZDllYzFiMWVhNGFmNjEuLmExOWRm YzU5ODU4N2MyYWU2NDNlZGE5NGIzYjU1NGU3ZGE0M2U4NjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNwcApAQCAtNzEsOCArNzEsNiBAQCBzdGF0aWMgc2l6 ZV90IHNlbGVjdGVkT3B0aW9uQ291bnQoY29uc3QgUmVuZGVyTWVudUxpc3QmIHJlbmRlck1lbnVM aXN0KQogCiBSZW5kZXJNZW51TGlzdDo6UmVuZGVyTWVudUxpc3QoSFRNTFNlbGVjdEVsZW1lbnQm IGVsZW1lbnQsIFJlbmRlclN0eWxlJiYgc3R5bGUpCiAgICAgOiBSZW5kZXJGbGV4aWJsZUJveChl bGVtZW50LCBXVEZNb3ZlKHN0eWxlKSkKLSAgICAsIG1fYnV0dG9uVGV4dChudWxscHRyKQotICAg ICwgbV9pbm5lckJsb2NrKG51bGxwdHIpCiAgICAgLCBtX25lZWRzT3B0aW9uc1dpZHRoVXBkYXRl KHRydWUpCiAgICAgLCBtX29wdGlvbnNXaWR0aCgwKQogI2lmICFQTEFURk9STShJT1MpCkBAIC0x MDgsNyArMTA2LDcgQEAgdm9pZCBSZW5kZXJNZW51TGlzdDo6Y3JlYXRlSW5uZXJCbG9jaygpCiAg ICAgLy8gQ3JlYXRlIGFuIGFub255bW91cyBibG9jay4KICAgICBBU1NFUlQoIWZpcnN0Q2hpbGQo KSk7CiAgICAgYXV0byBuZXdJbm5lckJsb2NrID0gY3JlYXRlQW5vbnltb3VzQmxvY2soKTsKLSAg ICBtX2lubmVyQmxvY2sgPSBuZXdJbm5lckJsb2NrLmdldCgpOworICAgIG1faW5uZXJCbG9jayA9 IG1ha2VXZWFrUHRyKCpuZXdJbm5lckJsb2NrLmdldCgpKTsKICAgICBhZGp1c3RJbm5lclN0eWxl KCk7CiAgICAgUmVuZGVyRmxleGlibGVCb3g6OmFkZENoaWxkKFdURk1vdmUobmV3SW5uZXJCbG9j aykpOwogfQpAQCAtMTg1LDEwICsxODMsOCBAQCB2b2lkIFJlbmRlck1lbnVMaXN0OjphZGRDaGls ZChSZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBuZXdDaGlsZCwgUmVuZGVyT2JqZWN0KiBiZQogCiBS ZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBSZW5kZXJNZW51TGlzdDo6dGFrZUNoaWxkKFJlbmRlck9i amVjdCYgb2xkQ2hpbGQpCiB7Ci0gICAgaWYgKCZvbGRDaGlsZCA9PSBtX2lubmVyQmxvY2sgfHwg IW1faW5uZXJCbG9jaykgewotICAgICAgICBtX2lubmVyQmxvY2sgPSAwOworICAgIGlmICghbV9p bm5lckJsb2NrIHx8ICZvbGRDaGlsZCA9PSBtX2lubmVyQmxvY2spCiAgICAgICAgIHJldHVybiBS ZW5kZXJGbGV4aWJsZUJveDo6dGFrZUNoaWxkKG9sZENoaWxkKTsKLSAgICB9CiAgICAgcmV0dXJu IG1faW5uZXJCbG9jay0+dGFrZUNoaWxkKG9sZENoaWxkKTsKIH0KIApAQCAtMjk3LDcgKzI5Myw3 IEBAIHZvaWQgUmVuZGVyTWVudUxpc3Q6OnNldFRleHQoY29uc3QgU3RyaW5nJiBzKQogICAgICAg ICBtX2J1dHRvblRleHQtPnNldFRleHQodGV4dFRvVXNlLmltcGwoKSwgdHJ1ZSk7CiAgICAgZWxz ZSB7CiAgICAgICAgIGF1dG8gbmV3QnV0dG9uVGV4dCA9IGNyZWF0ZVJlbmRlcmVyPFJlbmRlclRl eHQ+KGRvY3VtZW50KCksIHRleHRUb1VzZSk7Ci0gICAgICAgIG1fYnV0dG9uVGV4dCA9IG5ld0J1 dHRvblRleHQuZ2V0KCk7CisgICAgICAgIG1fYnV0dG9uVGV4dCA9IG1ha2VXZWFrUHRyKCpuZXdC dXR0b25UZXh0LmdldCgpKTsKICAgICAgICAgYWRkQ2hpbGQoV1RGTW92ZShuZXdCdXR0b25UZXh0 KSk7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TWVudUxpc3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5oCmlu ZGV4IGZhNWE2MTgzNzk4MTllNjQxZDY3MTkzOGY0ZDdmOWZmNWY0OTc3OTcuLmVmNDMzM2Y0ZDAx NjlkYTNiYzcxNGFkMjJhODk3OTNhYmYzZWFlMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJNZW51TGlzdC5oCkBAIC0xMzcsOCArMTM3LDggQEAgcHJpdmF0ZToKIAogICAgIGJv b2wgaXNGbGV4aWJsZUJveEltcGwoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiB0cnVlOyB9CiAK LSAgICBSZW5kZXJUZXh0KiBtX2J1dHRvblRleHQ7Ci0gICAgUmVuZGVyQmxvY2sqIG1faW5uZXJC bG9jazsKKyAgICBXZWFrUHRyPFJlbmRlclRleHQ+IG1fYnV0dG9uVGV4dDsKKyAgICBXZWFrUHRy PFJlbmRlckJsb2NrPiBtX2lubmVyQmxvY2s7CiAKICAgICBib29sIG1fbmVlZHNPcHRpb25zV2lk dGhVcGRhdGU7CiAgICAgaW50IG1fb3B0aW9uc1dpZHRoOwo= 322583 2017-10-03 14:29:19 -0700 2017-10-03 15:39:54 -0700 Patch bug-177836-20171003142918.patch text/plain 3506 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRlMTY5OWFhNDZlMzQ1 NzAzMTM0Mjk5MjY5YWM1YzU0MThhNDU2ZC4uMjViYmJiNjlkMDBmMzhjYTRmYjgxYzBkOGYyNWRi MDVkNmJhN2RmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTEwLTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmVuZGVyTWVudUxpc3Qgc2hv dWxkIG5vdCBob2xkIHJhdyBwb2ludGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTc3ODM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29p dmlzdG8uCisKKyAgICAgICAgV2hpbGUgYm90aCBtX2J1dHRvblRleHQgYW5kIG1faW5uZXJCbG9j ayBhcmUgY2hpbGQgcmVuZGVyZXJzIG9mCisgICAgICAgIHRoZSBSZW5kZXJNZW51TGlzdCwgc28g dGhlIHRoZWlyIGxpZmVjeWNsZXMgYXJlIHN1cHBvc2VkIHRvIHRpZWQKKyAgICAgICAgdG8gdGhl IHBhcmVudCBvYmplY3QsIHRoaXMgcGF0Y2ggcmVtb3ZlcyBzb21lIG1hbnVhbCByYXcgcG9pbnRl ciBtYW5hZ2luZy4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAg ICAgICogcmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlck1lbnVMaXN0OjpSZW5kZXJNZW51TGlzdCk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJN ZW51TGlzdDo6Y3JlYXRlSW5uZXJCbG9jayk6CisgICAgICAgIChSZW5kZXJNZW51TGlzdDo6dGFr ZUNoaWxkKToKKyAgICAgICAgKFJlbmRlck1lbnVMaXN0OjpzZXRUZXh0KToKKyAgICAgICAgKiBy ZW5kZXJpbmcvUmVuZGVyTWVudUxpc3QuaDoKKwogMjAxNy0xMC0wMiAgQW50dGkgS29pdmlzdG8g IDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IG1lbW9yeSBsZWFrcyBpbiBSZW5kZXJN dWx0aUNvbHVtbkZsb3cKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJNZW51TGlzdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVudUxpc3Qu Y3BwCmluZGV4IDA2YWMyMzQyYmI1MThkMzlmYmU0NTQzNzZlZDllYzFiMWVhNGFmNjEuLjA0ZGMw ZmY0MjQzZjU0ZTQ1ZTFkOWU5ZDIxNTNkYzlkODBmYmJkZWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck1lbnVMaXN0LmNwcApAQCAtNzEsOCArNzEsNiBAQCBzdGF0aWMgc2l6 ZV90IHNlbGVjdGVkT3B0aW9uQ291bnQoY29uc3QgUmVuZGVyTWVudUxpc3QmIHJlbmRlck1lbnVM aXN0KQogCiBSZW5kZXJNZW51TGlzdDo6UmVuZGVyTWVudUxpc3QoSFRNTFNlbGVjdEVsZW1lbnQm IGVsZW1lbnQsIFJlbmRlclN0eWxlJiYgc3R5bGUpCiAgICAgOiBSZW5kZXJGbGV4aWJsZUJveChl bGVtZW50LCBXVEZNb3ZlKHN0eWxlKSkKLSAgICAsIG1fYnV0dG9uVGV4dChudWxscHRyKQotICAg ICwgbV9pbm5lckJsb2NrKG51bGxwdHIpCiAgICAgLCBtX25lZWRzT3B0aW9uc1dpZHRoVXBkYXRl KHRydWUpCiAgICAgLCBtX29wdGlvbnNXaWR0aCgwKQogI2lmICFQTEFURk9STShJT1MpCkBAIC0x MDgsNyArMTA2LDcgQEAgdm9pZCBSZW5kZXJNZW51TGlzdDo6Y3JlYXRlSW5uZXJCbG9jaygpCiAg ICAgLy8gQ3JlYXRlIGFuIGFub255bW91cyBibG9jay4KICAgICBBU1NFUlQoIWZpcnN0Q2hpbGQo KSk7CiAgICAgYXV0byBuZXdJbm5lckJsb2NrID0gY3JlYXRlQW5vbnltb3VzQmxvY2soKTsKLSAg ICBtX2lubmVyQmxvY2sgPSBuZXdJbm5lckJsb2NrLmdldCgpOworICAgIG1faW5uZXJCbG9jayA9 IG1ha2VXZWFrUHRyKCpuZXdJbm5lckJsb2NrLmdldCgpKTsKICAgICBhZGp1c3RJbm5lclN0eWxl KCk7CiAgICAgUmVuZGVyRmxleGlibGVCb3g6OmFkZENoaWxkKFdURk1vdmUobmV3SW5uZXJCbG9j aykpOwogfQpAQCAtMTg1LDEwICsxODMsOCBAQCB2b2lkIFJlbmRlck1lbnVMaXN0OjphZGRDaGls ZChSZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBuZXdDaGlsZCwgUmVuZGVyT2JqZWN0KiBiZQogCiBS ZW5kZXJQdHI8UmVuZGVyT2JqZWN0PiBSZW5kZXJNZW51TGlzdDo6dGFrZUNoaWxkKFJlbmRlck9i amVjdCYgb2xkQ2hpbGQpCiB7Ci0gICAgaWYgKCZvbGRDaGlsZCA9PSBtX2lubmVyQmxvY2sgfHwg IW1faW5uZXJCbG9jaykgewotICAgICAgICBtX2lubmVyQmxvY2sgPSAwOworICAgIGlmICghbV9p bm5lckJsb2NrIHx8ICZvbGRDaGlsZCA9PSBtX2lubmVyQmxvY2spCiAgICAgICAgIHJldHVybiBS ZW5kZXJGbGV4aWJsZUJveDo6dGFrZUNoaWxkKG9sZENoaWxkKTsKLSAgICB9CiAgICAgcmV0dXJu IG1faW5uZXJCbG9jay0+dGFrZUNoaWxkKG9sZENoaWxkKTsKIH0KIApAQCAtMjk3LDcgKzI5Myw3 IEBAIHZvaWQgUmVuZGVyTWVudUxpc3Q6OnNldFRleHQoY29uc3QgU3RyaW5nJiBzKQogICAgICAg ICBtX2J1dHRvblRleHQtPnNldFRleHQodGV4dFRvVXNlLmltcGwoKSwgdHJ1ZSk7CiAgICAgZWxz ZSB7CiAgICAgICAgIGF1dG8gbmV3QnV0dG9uVGV4dCA9IGNyZWF0ZVJlbmRlcmVyPFJlbmRlclRl eHQ+KGRvY3VtZW50KCksIHRleHRUb1VzZSk7Ci0gICAgICAgIG1fYnV0dG9uVGV4dCA9IG5ld0J1 dHRvblRleHQuZ2V0KCk7CisgICAgICAgIG1fYnV0dG9uVGV4dCA9IG1ha2VXZWFrUHRyKCpuZXdC dXR0b25UZXh0KTsKICAgICAgICAgYWRkQ2hpbGQoV1RGTW92ZShuZXdCdXR0b25UZXh0KSk7CiAg ICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWVudUxp c3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJNZW51TGlzdC5oCmluZGV4IGZh NWE2MTgzNzk4MTllNjQxZDY3MTkzOGY0ZDdmOWZmNWY0OTc3OTcuLmVmNDMzM2Y0ZDAxNjlkYTNi YzcxNGFkMjJhODk3OTNhYmYzZWFlMGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJNZW51TGlzdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJNZW51TGlzdC5oCkBAIC0xMzcsOCArMTM3LDggQEAgcHJpdmF0ZToKIAogICAgIGJvb2wgaXNG bGV4aWJsZUJveEltcGwoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiB0cnVlOyB9CiAKLSAgICBS ZW5kZXJUZXh0KiBtX2J1dHRvblRleHQ7Ci0gICAgUmVuZGVyQmxvY2sqIG1faW5uZXJCbG9jazsK KyAgICBXZWFrUHRyPFJlbmRlclRleHQ+IG1fYnV0dG9uVGV4dDsKKyAgICBXZWFrUHRyPFJlbmRl ckJsb2NrPiBtX2lubmVyQmxvY2s7CiAKICAgICBib29sIG1fbmVlZHNPcHRpb25zV2lkdGhVcGRh dGU7CiAgICAgaW50IG1fb3B0aW9uc1dpZHRoOwo=