177833 2017-10-03 13:02:30 -0700 Share code to determine a forbidden method 2017-10-03 15:41:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177837 InRadar P2 Normal --- 1 dbates dbates aestes webkit-bug-importer oldest_to_newest 1355993 0 dbates 2017-10-03 13:02:30 -0700 Currently we duplicate code in XMLHttpRequest and FetchRequest to determine if a method is forbidden. We should add a common helper function and update both classes to make use of it. 1355995 1 322569 dbates 2017-10-03 13:04:13 -0700 Created attachment 322569 Patch 1356094 2 322569 dbates 2017-10-03 15:40:39 -0700 Comment on attachment 322569 Patch Clearing flags on attachment: 322569 Committed r222815: <http://trac.webkit.org/changeset/222815> 1356095 3 dbates 2017-10-03 15:40:40 -0700 All reviewed patches have been landed. Closing bug. 1356096 4 webkit-bug-importer 2017-10-03 15:41:45 -0700 <rdar://problem/34801146> 322569 2017-10-03 13:04:13 -0700 2017-10-03 15:40:39 -0700 Patch bug-177833-20171003130412.patch text/plain 6617 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmZjZDExMjM5YjI0MjZk ZjFhMTQ0ZjIyYjhiNGFhY2E0NDI5MzhlMy4uNTc0ZWE5ZmE4YzJlZDllMjM5MDU4MmY0YmY3ZTRm MWExM2YzYmQxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE3LTEwLTAzICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KIAorICAgICAgICBTaGFyZSBjb2RlIHRvIGRl dGVybWluZSBhIGZvcmJpZGRlbiBtZXRob2QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3NzgzMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSB3ZSBkdXBsaWNhdGUgY29kZSBpbiBYTUxIdHRw UmVxdWVzdCBhbmQgRmV0Y2hSZXF1ZXN0IHRvIGRldGVybWluZSBpZiBhIG1ldGhvZCBpcworICAg ICAgICBmb3JiaWRkZW4uIFdlIHNob3VsZCBhZGQgYSBjb21tb24gaGVscGVyIGZ1bmN0aW9uIGFu ZCB1cGRhdGUgYm90aCBjbGFzc2VzIHRvIG1ha2UgdXNlIG9mIGl0LgorCisgICAgICAgIE5vIGZ1 bmN0aW9uYWxpdHkgY2hhbmdlZC4gU28sIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIE1vZHVs ZXMvZmV0Y2gvRmV0Y2hSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnNldE1ldGhvZCk6 IE1vZGlmaWVkIHRvIHVzZSBXZWJDb3JlOjppc0ZvcmJpZGRlbk1ldGhvZCgpLgorICAgICAgICAq IHBsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMuY3BwOgorICAgICAgICAoV2ViQ29yZTo6aXNG b3JiaWRkZW5NZXRob2QpOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL0hUVFBQ YXJzZXJzLmg6CisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlhNTEh0dHBSZXF1ZXN0OjpvcGVuKTogTW9kaWZpZWQgdG8gdXNlIFdlYkNvcmU6Omlz Rm9yYmlkZGVuTWV0aG9kKCkuCisgICAgICAgIChXZWJDb3JlOjpYTUxIdHRwUmVxdWVzdDo6aXNB bGxvd2VkSFRUUE1ldGhvZCk6IERlbGV0ZWQuCisgICAgICAgICogeG1sL1hNTEh0dHBSZXF1ZXN0 Lmg6CisKKzIwMTctMTAtMDMgIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCiAg ICAgICAgIFhNTEh0dHBSZXF1ZXN0LnNldFJlcXVlc3RIZWFkZXIoKSBzaG91bGQgYWxsb3cgQ29u dGVudC1UcmFuc2Zlci1FbmNvZGluZyBoZWFkZXI7IHJlbW92ZQogICAgICAgICBkdXBsaWNhdGUg bG9naWMgdG8gY2hlY2sgZm9yIGEgZm9yYmlkZGVuIFhIUiBoZWFkZXIgZmllbGQKICAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3NzgyOQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRjaFJlcXVlc3QuY3BwIGIvU291cmNl L1dlYkNvcmUvTW9kdWxlcy9mZXRjaC9GZXRjaFJlcXVlc3QuY3BwCmluZGV4IDFjMzM4OWJiNjE3 NTc5NzA3YjUwMjY1YmIyYmQyOTljYTUxMjFhNTYuLjQwODRiMWY4MTYxZDgxNzBhZThhMTkwNjQ5 MThiYzk5M2Y3MGQ1M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvZmV0Y2gv RmV0Y2hSZXF1ZXN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL2ZldGNoL0ZldGNo UmVxdWVzdC5jcHAKQEAgLTM5LDEzICszOSwxMCBAQCBzdGF0aWMgc3RkOjpvcHRpb25hbDxFeGNl cHRpb24+IHNldE1ldGhvZChSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIGNvbnN0IFN0cmluZwog ewogICAgIGlmICghaXNWYWxpZEhUVFBUb2tlbihpbml0TWV0aG9kKSkKICAgICAgICAgcmV0dXJu IEV4Y2VwdGlvbiB7IFR5cGVFcnJvciwgQVNDSUlMaXRlcmFsKCJNZXRob2QgaXMgbm90IGEgdmFs aWQgSFRUUCB0b2tlbi4iKSB9OwotCi0gICAgU3RyaW5nIG1ldGhvZCA9IGluaXRNZXRob2QuY29u dmVydFRvQVNDSUlVcHBlcmNhc2UoKTsKLSAgICBpZiAobWV0aG9kID09ICJDT05ORUNUIiB8fCBt ZXRob2QgPT0gIlRSQUNFIiB8fCBtZXRob2QgPT0gIlRSQUNLIikKKyAgICBpZiAoaXNGb3JiaWRk ZW5NZXRob2QoaW5pdE1ldGhvZCkpCiAgICAgICAgIHJldHVybiBFeGNlcHRpb24geyBUeXBlRXJy b3IsIEFTQ0lJTGl0ZXJhbCgiTWV0aG9kIGlzIGZvcmJpZGRlbi4iKSB9OwotCisgICAgU3RyaW5n IG1ldGhvZCA9IGluaXRNZXRob2QuY29udmVydFRvQVNDSUlVcHBlcmNhc2UoKTsKICAgICByZXF1 ZXN0LnNldEhUVFBNZXRob2QoKG1ldGhvZCA9PSAiREVMRVRFIiB8fCBtZXRob2QgPT0gIkdFVCIg fHwgbWV0aG9kID09ICJIRUFEIiB8fCBtZXRob2QgPT0gIk9QVElPTlMiIHx8IG1ldGhvZCA9PSAi UE9TVCIgfHwgbWV0aG9kID09ICJQVVQiKSA/IG1ldGhvZCA6IGluaXRNZXRob2QpOwotCiAgICAg cmV0dXJuIHN0ZDo6bnVsbG9wdDsKIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL0hUVFBQYXJzZXJzLmNwcAppbmRleCA5NWI1ZTg2NWUxMzNjNWVhZDUwMWJmMDI4MzAw OTY2OWE3OGJkYzZhLi40OGFjYzNjYTBjZjI1Mjc0NGYzNDFiY2UwYTNiYmM4ZTAyNDg0ZTRlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmNwcApA QCAtNzc4LDcgKzc3OCw3IEBAIHZvaWQgcGFyc2VBY2Nlc3NDb250cm9sRXhwb3NlSGVhZGVyc0Fs bG93TGlzdChjb25zdCBTdHJpbmcmIGhlYWRlclZhbHVlLCBIVFRQSGVhCiAgICAgfQogfQogCi0v LyBJbXBsZW1lbnRhdGlvbiBvZiBodHRwczovL2ZldGNoLnNwZWMud2hhdHdnLm9yZy8jY29ycy1z YWZlbGlzdGVkLXJlc3BvbnNlLWhlYWRlci1uYW1lCisvLyBJbXBsZW1lbnRzIDxodHRwczovL2Zl dGNoLnNwZWMud2hhdHdnLm9yZy8jZm9yYmlkZGVuLWhlYWRlci1uYW1lPi4KIGJvb2wgaXNGb3Ji aWRkZW5IZWFkZXJOYW1lKGNvbnN0IFN0cmluZyYgbmFtZSkKIHsKICAgICBIVFRQSGVhZGVyTmFt ZSBoZWFkZXJOYW1lOwpAQCAtODEyLDExICs4MTIsMTggQEAgYm9vbCBpc0ZvcmJpZGRlbkhlYWRl ck5hbWUoY29uc3QgU3RyaW5nJiBuYW1lKQogICAgIHJldHVybiBzdGFydHNXaXRoTGV0dGVyc0ln bm9yaW5nQVNDSUlDYXNlKG5hbWUsICJzZWMtIikgfHwgc3RhcnRzV2l0aExldHRlcnNJZ25vcmlu Z0FTQ0lJQ2FzZShuYW1lLCAicHJveHktIik7CiB9CiAKKy8vIEltcGxlbWVudHMgPGh0dHBzOi8v ZmV0Y2guc3BlYy53aGF0d2cub3JnLyNmb3JiaWRkZW4tcmVzcG9uc2UtaGVhZGVyLW5hbWU+Lgog Ym9vbCBpc0ZvcmJpZGRlblJlc3BvbnNlSGVhZGVyTmFtZShjb25zdCBTdHJpbmcmIG5hbWUpCiB7 CiAgICAgcmV0dXJuIGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKG5hbWUsICJzZXQtY29v a2llIikgfHwgZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UobmFtZSwgInNldC1jb29raWUy Iik7CiB9CiAKKy8vIEltcGxlbWVudHMgPGh0dHBzOi8vZmV0Y2guc3BlYy53aGF0d2cub3JnLyNm b3JiaWRkZW4tbWV0aG9kPi4KK2Jvb2wgaXNGb3JiaWRkZW5NZXRob2QoY29uc3QgU3RyaW5nJiBu YW1lKQoreworICAgIHJldHVybiBlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShuYW1lLCAi Y29ubmVjdCIpIHx8IGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKG5hbWUsICJ0cmFjZSIp IHx8IGVxdWFsTGV0dGVyc0lnbm9yaW5nQVNDSUlDYXNlKG5hbWUsICJ0cmFjayIpOworfQorCiBi b29sIGlzU2ltcGxlSGVhZGVyKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgU3RyaW5nJiB2YWx1 ZSkKIHsKICAgICBIVFRQSGVhZGVyTmFtZSBoZWFkZXJOYW1lOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5oIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5oCmluZGV4IDZhODJhZDI3YTU5NmE4MGMxNDE1 NGNmMTQwOTY4ZTFlYmM5MTg3NDUuLjQ5ODFkODA5ODJmY2U2YjM4MmI4M2JlNGViZmQyZDg5YjBj NTJmOTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUFBh cnNlcnMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJz LmgKQEAgLTk1LDYgKzk1LDcgQEAgdm9pZCBwYXJzZUFjY2Vzc0NvbnRyb2xFeHBvc2VIZWFkZXJz QWxsb3dMaXN0KGNvbnN0IFN0cmluZyYgaGVhZGVyVmFsdWUsIEhUVFBIZWEKIC8vIEhUVFAgSGVh ZGVyIHJvdXRpbmUgYXMgcGVyIGh0dHBzOi8vZmV0Y2guc3BlYy53aGF0d2cub3JnLyN0ZXJtaW5v bG9neS1oZWFkZXJzCiBib29sIGlzRm9yYmlkZGVuSGVhZGVyTmFtZShjb25zdCBTdHJpbmcmKTsK IGJvb2wgaXNGb3JiaWRkZW5SZXNwb25zZUhlYWRlck5hbWUoY29uc3QgU3RyaW5nJik7Citib29s IGlzRm9yYmlkZGVuTWV0aG9kKGNvbnN0IFN0cmluZyYpOwogYm9vbCBpc1NpbXBsZUhlYWRlcihj b25zdCBTdHJpbmcmIG5hbWUsIGNvbnN0IFN0cmluZyYgdmFsdWUpOwogYm9vbCBpc0Nyb3NzT3Jp Z2luU2FmZUhlYWRlcihIVFRQSGVhZGVyTmFtZSwgY29uc3QgSFRUUEhlYWRlclNldCYpOwogYm9v bCBpc0Nyb3NzT3JpZ2luU2FmZUhlYWRlcihjb25zdCBTdHJpbmcmLCBjb25zdCBIVFRQSGVhZGVy U2V0Jik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJlcXVlc3QuY3Bw IGIvU291cmNlL1dlYkNvcmUveG1sL1hNTEh0dHBSZXF1ZXN0LmNwcAppbmRleCA1NzVlNmZkZWU5 NTk2N2U0YzVlZWJlZTg3MzMxMzFlZDkwY2VmZmM0Li5lOTkwMmRiYTE3YWY4MTdhMzU3Y2JkOTNl MzRkYTZhNWRjZmRjODg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS94bWwvWE1MSHR0cFJl cXVlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5jcHAKQEAg LTMyNywxMyArMzI3LDYgQEAgRXhjZXB0aW9uT3I8dm9pZD4gWE1MSHR0cFJlcXVlc3Q6OnNldFdp dGhDcmVkZW50aWFscyhib29sIHZhbHVlKQogICAgIHJldHVybiB7IH07CiB9CiAKLWJvb2wgWE1M SHR0cFJlcXVlc3Q6OmlzQWxsb3dlZEhUVFBNZXRob2QoY29uc3QgU3RyaW5nJiBtZXRob2QpCi17 Ci0gICAgcmV0dXJuICFlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShtZXRob2QsICJ0cmFj ZSIpCi0gICAgICAgICYmICFlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShtZXRob2QsICJ0 cmFjayIpCi0gICAgICAgICYmICFlcXVhbExldHRlcnNJZ25vcmluZ0FTQ0lJQ2FzZShtZXRob2Qs ICJjb25uZWN0Iik7Ci19Ci0KIFN0cmluZyBYTUxIdHRwUmVxdWVzdDo6dXBwZXJjYXNlS25vd25I VFRQTWV0aG9kKGNvbnN0IFN0cmluZyYgbWV0aG9kKQogewogICAgIGNvbnN0IGNoYXIqIGNvbnN0 IG1ldGhvZHNbXSA9IHsgIkRFTEVURSIsICJHRVQiLCAiSEVBRCIsICJPUFRJT05TIiwgIlBPU1Qi LCAiUFVUIiB9OwpAQCAtMzc1LDcgKzM2OCw3IEBAIEV4Y2VwdGlvbk9yPHZvaWQ+IFhNTEh0dHBS ZXF1ZXN0OjpvcGVuKGNvbnN0IFN0cmluZyYgbWV0aG9kLCBjb25zdCBVUkwmIHVybCwgYm9vCiAg ICAgaWYgKCFpc1ZhbGlkSFRUUFRva2VuKG1ldGhvZCkpCiAgICAgICAgIHJldHVybiBFeGNlcHRp b24geyBTeW50YXhFcnJvciB9OwogCi0gICAgaWYgKCFpc0FsbG93ZWRIVFRQTWV0aG9kKG1ldGhv ZCkpCisgICAgaWYgKGlzRm9yYmlkZGVuTWV0aG9kKG1ldGhvZCkpCiAgICAgICAgIHJldHVybiBF eGNlcHRpb24geyBTZWN1cml0eUVycm9yIH07CiAKICAgICBpZiAoIWFzeW5jICYmIHNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQoKS0+aXNEb2N1bWVudCgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS94bWwvWE1MSHR0cFJlcXVlc3QuaCBiL1NvdXJjZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVx dWVzdC5oCmluZGV4IDI3ZmY4NzllNzJjYjg5NWI4NTIzNjUxOTgzMDU4N2E3MDEzMGMyN2UuLmRi ZGMwM2RkZjQxNGNlZjczN2YzYTg0YzI2ZGFlMDg0NWYwMmVmMzcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3htbC9YTUxIdHRwUmVxdWVzdC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3htbC9Y TUxIdHRwUmVxdWVzdC5oCkBAIC0xMDQsNyArMTA0LDYgQEAgcHVibGljOgogICAgIHZvaWQgZGlk Q2FjaGVSZXNwb25zZSgpOwogCiAgICAgLy8gRXhwb3NlIEhUVFAgdmFsaWRhdGlvbiBtZXRob2Rz IGZvciBvdGhlciB1bnRydXN0ZWQgcmVxdWVzdHMuCi0gICAgc3RhdGljIGJvb2wgaXNBbGxvd2Vk SFRUUE1ldGhvZChjb25zdCBTdHJpbmcmKTsKICAgICBzdGF0aWMgU3RyaW5nIHVwcGVyY2FzZUtu b3duSFRUUE1ldGhvZChjb25zdCBTdHJpbmcmKTsKIAogICAgIGVudW0gY2xhc3MgUmVzcG9uc2VU eXBlIHsgRW1wdHlTdHJpbmcsIEFycmF5YnVmZmVyLCBCbG9iLCBEb2N1bWVudCwgSnNvbiwgVGV4 dCB9Owo=