177789 2017-10-02 15:26:48 -0700 WeakPtr should have a move constructor 2017-10-02 17:43:18 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren benjamin buildbot cdumez cmarcelo commit-queue dbates koivisto webkit-bug-importer zalan oldest_to_newest 1355568 0 ggaren 2017-10-02 15:26:48 -0700 WeakPtr should have a move constructor 1355569 1 322457 ggaren 2017-10-02 15:27:37 -0700 Created attachment 322457 Patch 1355577 2 322457 zalan 2017-10-02 15:43:19 -0700 Comment on attachment 322457 Patch ofc 1355579 3 322457 cdumez 2017-10-02 15:52:39 -0700 Comment on attachment 322457 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322457&action=review > Source/WTF/wtf/WeakPtr.h:77 > + WeakPtr& operator=(const WeakPtr&) = default; No WeakPtr& operator=(const WeakPtr&&) = default; ? 1355581 4 322457 cdumez 2017-10-02 15:53:21 -0700 Comment on attachment 322457 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322457&action=review > Source/WTF/wtf/WeakPtr.h:70 > WeakPtr(const WeakPtr& o) : m_ref(o.m_ref) { } Can this one be = default; as well? 1355584 5 322464 ggaren 2017-10-02 15:59:42 -0700 Created attachment 322464 Patch 1355585 6 322464 cdumez 2017-10-02 16:02:25 -0700 Comment on attachment 322464 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322464&action=review I think that if we just drop the custom copy constructor / assignment operator then we'd get implicit move constructor / assignment operators, no? > Source/WTF/wtf/WeakPtr.h:77 > + WeakPtr& operator=(const WeakPtr&) = default; Why don't we want the WeakPtr& operator=(const WeakPtr&&) = default; too? 1355586 7 322464 cdumez 2017-10-02 16:03:27 -0700 Comment on attachment 322464 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322464&action=review > Source/WTF/ChangeLog:3 > + WeakPtr should have a move constructor It would be good to API-test this change. 1355612 8 322473 ggaren 2017-10-02 16:54:48 -0700 Created attachment 322473 Patch 1355617 9 322473 cdumez 2017-10-02 16:57:37 -0700 Comment on attachment 322473 Patch r=me 1355648 10 322473 commit-queue 2017-10-02 17:42:09 -0700 Comment on attachment 322473 Patch Clearing flags on attachment: 322473 Committed r222764: <http://trac.webkit.org/changeset/222764> 1355649 11 commit-queue 2017-10-02 17:42:10 -0700 All reviewed patches have been landed. Closing bug. 1355650 12 webkit-bug-importer 2017-10-02 17:43:18 -0700 <rdar://problem/34781637> 322457 2017-10-02 15:27:37 -0700 2017-10-02 15:59:21 -0700 Patch bug-177789-20171002152736.patch text/plain 1375 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjI3NTIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTEwLTAyICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2Vha1B0ciBzaG91bGQgaGF2ZSBhIG1vdmUgY29u c3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3Nzc4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFudHRpIHNhaWQgc28uCisKKyAgICAgICAgKiB3dGYvV2Vha1B0ci5oOgorCiAyMDE3LTEwLTAy ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgTlVMTCBXZWFr UHRyIHNob3VsZCBub3QgbWFsbG9jIQpJbmRleDogU291cmNlL1dURi93dGYvV2Vha1B0ci5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1dlYWtQdHIuaAkocmV2aXNpb24gMjIyNzUyKQor KysgU291cmNlL1dURi93dGYvV2Vha1B0ci5oCSh3b3JraW5nIGNvcHkpCkBAIC02OCwxMiArNjgs MTMgQEAgcHVibGljOgogICAgIFdlYWtQdHIoKSB7IH0KICAgICBXZWFrUHRyKHN0ZDo6bnVsbHB0 cl90KSB7IH0KICAgICBXZWFrUHRyKGNvbnN0IFdlYWtQdHImIG8pIDogbV9yZWYoby5tX3JlZikg eyB9CisgICAgV2Vha1B0cihXZWFrUHRyJiYpID0gZGVmYXVsdDsKICAgICBXZWFrUHRyKFJlZjxX ZWFrUmVmZXJlbmNlPFQ+PiYmIHJlZikgOiBtX3JlZihzdGQ6OmZvcndhcmQ8UmVmPFdlYWtSZWZl cmVuY2U8VD4+PihyZWYpKSB7IH0KIAogICAgIFQqIGdldCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVm ID8gbV9yZWYtPmdldCgpIDogbnVsbHB0cjsgfQogICAgIG9wZXJhdG9yIGJvb2woKSBjb25zdCB7 IHJldHVybiBtX3JlZiAmJiBtX3JlZi0+Z2V0KCk7IH0KIAotICAgIFdlYWtQdHImIG9wZXJhdG9y PShjb25zdCBXZWFrUHRyJiBvKSB7IG1fcmVmID0gby5tX3JlZjsgcmV0dXJuICp0aGlzOyB9Cisg ICAgV2Vha1B0ciYgb3BlcmF0b3I9KGNvbnN0IFdlYWtQdHImKSA9IGRlZmF1bHQ7CiAgICAgV2Vh a1B0ciYgb3BlcmF0b3I9KHN0ZDo6bnVsbHB0cl90KSB7IG1fcmVmID0gbnVsbHB0cjsgcmV0dXJu ICp0aGlzOyB9CiAKICAgICBUKiBvcGVyYXRvci0+KCkgY29uc3QgeyByZXR1cm4gbV9yZWYtPmdl dCgpOyB9Cg== 322464 2017-10-02 15:59:42 -0700 2017-10-02 16:54:46 -0700 Patch bug-177789-20171002155941.patch text/plain 1432 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjI3NTIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE3LTEwLTAyICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2Vha1B0ciBzaG91bGQgaGF2ZSBhIG1vdmUgY29u c3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3Nzc4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFudHRpIHNhaWQgc28uCisKKyAgICAgICAgKiB3dGYvV2Vha1B0ci5oOgorCiAyMDE3LTEwLTAy ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgTlVMTCBXZWFr UHRyIHNob3VsZCBub3QgbWFsbG9jIQpJbmRleDogU291cmNlL1dURi93dGYvV2Vha1B0ci5oCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1dlYWtQdHIuaAkocmV2aXNpb24gMjIyNzUyKQor KysgU291cmNlL1dURi93dGYvV2Vha1B0ci5oCSh3b3JraW5nIGNvcHkpCkBAIC02NywxMyArNjcs MTQgQEAgY2xhc3MgV2Vha1B0ciB7CiBwdWJsaWM6CiAgICAgV2Vha1B0cigpIHsgfQogICAgIFdl YWtQdHIoc3RkOjpudWxscHRyX3QpIHsgfQotICAgIFdlYWtQdHIoY29uc3QgV2Vha1B0ciYgbykg OiBtX3JlZihvLm1fcmVmKSB7IH0KKyAgICBXZWFrUHRyKGNvbnN0IFdlYWtQdHImKSA9IGRlZmF1 bHQ7CisgICAgV2Vha1B0cihXZWFrUHRyJiYpID0gZGVmYXVsdDsKICAgICBXZWFrUHRyKFJlZjxX ZWFrUmVmZXJlbmNlPFQ+PiYmIHJlZikgOiBtX3JlZihzdGQ6OmZvcndhcmQ8UmVmPFdlYWtSZWZl cmVuY2U8VD4+PihyZWYpKSB7IH0KIAogICAgIFQqIGdldCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVm ID8gbV9yZWYtPmdldCgpIDogbnVsbHB0cjsgfQogICAgIG9wZXJhdG9yIGJvb2woKSBjb25zdCB7 IHJldHVybiBtX3JlZiAmJiBtX3JlZi0+Z2V0KCk7IH0KIAotICAgIFdlYWtQdHImIG9wZXJhdG9y PShjb25zdCBXZWFrUHRyJiBvKSB7IG1fcmVmID0gby5tX3JlZjsgcmV0dXJuICp0aGlzOyB9Cisg ICAgV2Vha1B0ciYgb3BlcmF0b3I9KGNvbnN0IFdlYWtQdHImKSA9IGRlZmF1bHQ7CiAgICAgV2Vh a1B0ciYgb3BlcmF0b3I9KHN0ZDo6bnVsbHB0cl90KSB7IG1fcmVmID0gbnVsbHB0cjsgcmV0dXJu ICp0aGlzOyB9CiAKICAgICBUKiBvcGVyYXRvci0+KCkgY29uc3QgeyByZXR1cm4gbV9yZWYtPmdl dCgpOyB9Cg== 322473 2017-10-02 16:54:48 -0700 2017-10-02 17:42:09 -0700 Patch bug-177789-20171002165447.patch text/plain 2759 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjI3NTIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTEwLTAyICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2Vha1B0ciBzaG91bGQgaGF2ZSBhIG1vdmUgY29u c3RydWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTE3Nzc4OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogd3RmL1dlYWtQdHIuaDogTm93IHRoYXQgd2UganVzdCBoYXZlIGEgUmVmUHRyIGRhdGEgbWVt YmVyLAorICAgICAgICB0aGUgZGVmYXVsdCBvcGVyYXRvcnMgYXJlIHN1ZmZpY2llbnQuCisKIDIw MTctMTAtMDIgIEdlb2ZmcmV5IEdhcmVuICA8Z2dhcmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBO VUxMIFdlYWtQdHIgc2hvdWxkIG5vdCBtYWxsb2MhCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9XZWFr UHRyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvV2Vha1B0ci5oCShyZXZpc2lvbiAy MjI3NTIpCisrKyBTb3VyY2UvV1RGL3d0Zi9XZWFrUHRyLmgJKHdvcmtpbmcgY29weSkKQEAgLTY3 LDEzICs2NywxMSBAQCBjbGFzcyBXZWFrUHRyIHsKIHB1YmxpYzoKICAgICBXZWFrUHRyKCkgeyB9 CiAgICAgV2Vha1B0cihzdGQ6Om51bGxwdHJfdCkgeyB9Ci0gICAgV2Vha1B0cihjb25zdCBXZWFr UHRyJiBvKSA6IG1fcmVmKG8ubV9yZWYpIHsgfQogICAgIFdlYWtQdHIoUmVmPFdlYWtSZWZlcmVu Y2U8VD4+JiYgcmVmKSA6IG1fcmVmKHN0ZDo6Zm9yd2FyZDxSZWY8V2Vha1JlZmVyZW5jZTxUPj4+ KHJlZikpIHsgfQogCiAgICAgVCogZ2V0KCkgY29uc3QgeyByZXR1cm4gbV9yZWYgPyBtX3JlZi0+ Z2V0KCkgOiBudWxscHRyOyB9CiAgICAgb3BlcmF0b3IgYm9vbCgpIGNvbnN0IHsgcmV0dXJuIG1f cmVmICYmIG1fcmVmLT5nZXQoKTsgfQogCi0gICAgV2Vha1B0ciYgb3BlcmF0b3I9KGNvbnN0IFdl YWtQdHImIG8pIHsgbV9yZWYgPSBvLm1fcmVmOyByZXR1cm4gKnRoaXM7IH0KICAgICBXZWFrUHRy JiBvcGVyYXRvcj0oc3RkOjpudWxscHRyX3QpIHsgbV9yZWYgPSBudWxscHRyOyByZXR1cm4gKnRo aXM7IH0KIAogICAgIFQqIG9wZXJhdG9yLT4oKSBjb25zdCB7IHJldHVybiBtX3JlZi0+Z2V0KCk7 IH0KSW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJ KHJldmlzaW9uIDIyMjc1OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAt MSwzICsxLDE1IEBACisyMDE3LTEwLTAyICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5j b20+CisKKyAgICAgICAgV2Vha1B0ciBzaG91bGQgaGF2ZSBhIG1vdmUgY29uc3RydWN0b3IKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Nzc4OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocmlzIG1hZGUg bWUgd3JpdGUgYW4gQVBJIHRlc3QuIEl0IHdhc24ndCB0aGF0IHBhaW5mdWwuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9XZWFrUHRyLmNwcDoKKyAgICAgICAgKFRlc3RXZWJL aXRBUEk6OlRFU1QpOgorCiAyMDE3LTEwLTAyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5j b20+CiAKICAgICAgICAgV1NMIF4gc2hvdWxkIGJlICoKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV1RGL1dlYWtQdHIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRB UEkvVGVzdHMvV1RGL1dlYWtQdHIuY3BwCShyZXZpc2lvbiAyMjI3NTEpCisrKyBUb29scy9UZXN0 V2ViS2l0QVBJL1Rlc3RzL1dURi9XZWFrUHRyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE2LDYg KzExNiwyNCBAQCBURVNUKFdURl9XZWFrUHRyLCBEZXJlZmVyZW5jZSkKICAgICB3ZWFrUHRyLT5i YXIoKTsKIH0KIAorVEVTVChXVEZfV2Vha1B0ciwgT3BlcmF0b3JzKQoreworICAgIEZvbyBmOwor ICAgIFdlYWtQdHJGYWN0b3J5PEZvbz4gZmFjdG9yeTsKKyAgICBXZWFrUHRyPEZvbz4gd2Vha1B0 ciA9IGZhY3RvcnkuY3JlYXRlV2Vha1B0cihmKTsKKworICAgIFdlYWtQdHI8Rm9vPiB3ZWFrUHRy MiA9IHdlYWtQdHI7CisgICAgRVhQRUNUX0VRKHdlYWtQdHIyLmdldCgpLCAmZik7CisKKyAgICBX ZWFrUHRyPEZvbz4gd2Vha1B0cjM7CisgICAgd2Vha1B0cjMgPSB3ZWFrUHRyOworICAgIEVYUEVD VF9FUSh3ZWFrUHRyMy5nZXQoKSwgJmYpOworCisgICAgV2Vha1B0cjxGb28+IHdlYWtQdHI0ID0g V1RGTW92ZSh3ZWFrUHRyKTsKKyAgICBFWFBFQ1RfRVEod2Vha1B0cjQuZ2V0KCksICZmKTsKKyAg ICBFWFBFQ1RfRkFMU0Uod2Vha1B0cik7Cit9CisKIFRFU1QoV1RGX1dlYWtQdHIsIEZvcmdldCkK IHsKICAgICBpbnQgZHVtbXkgPSA1Owo=