177780 2017-10-02 14:39:35 -0700 VMTraps shouldn't crash if it sees an exception it doesn't understand. 2017-10-02 15:01:11 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller buildbot commit-queue mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1355509 0 keith_miller 2017-10-02 14:39:35 -0700 VMTraps shouldn't crash if it sees an exception it doesn't understand. 1355516 1 322444 keith_miller 2017-10-02 14:43:04 -0700 Created attachment 322444 Patch 1355526 2 322444 mark.lam 2017-10-02 14:47:24 -0700 Comment on attachment 322444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322444&action=review r=me with fixes. Would you happen to have a test for this already? > Source/JavaScriptCore/ChangeLog:11 > + noting that this means there's no way to know if, due a bug, we due *to* a bug. > Source/JavaScriptCore/runtime/VMTraps.cpp:216 > + return SignalAction::HotHandled; /HotHandled/NotHandled/. 1355527 3 322445 keith_miller 2017-10-02 14:48:00 -0700 Created attachment 322445 Patch for landing 1355528 4 322446 keith_miller 2017-10-02 14:48:36 -0700 Created attachment 322446 Patch for landing 1355530 5 322445 mark.lam 2017-10-02 14:48:45 -0700 Comment on attachment 322445 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=322445&action=review > Source/JavaScriptCore/ChangeLog:11 > + noting that this means there's no way to know if, due a bug, we typo still here. 1355532 6 keith_miller 2017-10-02 14:50:44 -0700 (In reply to Mark Lam from comment #2) > Comment on attachment 322444 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=322444&action=review > > r=me with fixes. Would you happen to have a test for this already? > I do but it's adding watchdog testing to JSTests/wasm.yaml. Unfortunately, that causes other crashes so I'll land that testing in a follow up. 1355533 7 keith_miller 2017-10-02 14:54:34 -0700 rdar://problem/33587513 1355534 8 keith_miller 2017-10-02 14:58:55 -0700 Committed r222748: <http://trac.webkit.org/changeset/222748> 322444 2017-10-02 14:43:04 -0700 2017-10-02 14:47:58 -0700 Patch bug-177780-20171002144303.patch text/plain 2113 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj OWViNDhkZWYxODBkNzVlODg0YWYwNDkzNzcyMjg1YWQ0MDFlNTVlLi5lZjc0ZGQxNGYxODM1MjI0 NjEzYmUwMjA4OTY1Nzk5MWZjMTg5YjQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0xMC0wMiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBWTVRyYXBzIHNob3VsZG4ndCBjcmFzaCBpZiBpdCBzZWVzIGFuIGV4 Y2VwdGlvbiBpdCBkb2Vzbid0IHVuZGVyc3RhbmQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc3ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBWTVRyYXBzIGNvdWxkIHNlZSBhIEpJVCBicmVha3BvaW50 IChTZWdWKSBmb3IgYW55IG51bWJlciBvZgorICAgICAgICByZWFzb25zIGl0IGRvZXNuJ3QgdW5k ZXJzdGFuZC4gZS5nLiAgYSBidWcgaW4gSklUIGNvZGUsIFdhc20gT09CLAorICAgICAgICBldGMu IFRoaXMgcGF0Y2ggbWFrZXMgaXQgaGFuZGxlIHRoYXQgY2FzZSBncmFjZWZ1bGx5LiBJdCdzIHdv cnRoCisgICAgICAgIG5vdGluZyB0aGF0IHRoaXMgbWVhbnMgdGhlcmUncyBubyB3YXkgdG8ga25v dyBpZiwgZHVlIGEgYnVnLCB3ZQorICAgICAgICBkaWRuJ3QgYWNjdXJhdGVseSB0cmFjayBhbGwg dGhlIFZNVHJhcHMgd2UgaW5zdGFsbGVkLiBJJ20gbm90IHN1cmUKKyAgICAgICAgaWYgdGhlcmUg aXMgYSBnb29kIHNvbHV0aW9uIHRvIHRoYXQgcHJvYmxlbSB0aG91Z2guCisKKyAgICAgICAgKiBy dW50aW1lL1ZNVHJhcHMuY3BwOgorCiAyMDE3LTEwLTAyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNv cmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5jbHVkZSBCZWFjb24g YW5kIFBpbmcgcmVxdWVzdHMgaW4gTmV0d29yayB0YWIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1ZNVHJhcHMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1 bnRpbWUvVk1UcmFwcy5jcHAKaW5kZXggZGVhYTQ0OWI2YmEyNmFjY2NlZGMxMjcyZTMyNTg5MmQ3 NWI4NzhkOC4uNTcyMThkYmU5NTlmZDUzMDA2NTc2NDZiNjNkMzBmN2ExZWI1YzFiZCAxMDA2NDQK LS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAKKysrIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAKQEAgLTIxMSw2ICsyMTEsMTAg QEAgcHVibGljOgogICAgICAgICAgICAgICAgICAgICByZXR1cm4gU2lnbmFsQWN0aW9uOjpOb3RI YW5kbGVkOwogCiAgICAgICAgICAgICAgICAgQ29kZUJsb2NrKiBjdXJyZW50Q29kZUJsb2NrID0g REZHOjpjb2RlQmxvY2tGb3JWTVRyYXBQQyhjb250ZXh0LnRyYXBQQyk7CisgICAgICAgICAgICAg ICAgaWYgKCFjdXJyZW50Q29kZUJsb2NrKSB7CisgICAgICAgICAgICAgICAgICAgIC8vIEVpdGhl ciB3ZSB0cmFwcGVkIGZvciBzb21lIG90aGVyIHJlYXNvbiwgZS5nLiBXYXNtIE9PQiwgb3Igd2Ug ZGlkbid0IHByb3Blcmx5IG1vbml0b3IgdGhlIFBDLiBSZWdhcmRsZXNzLCB3ZSBjYW4ndCBkbyBt dWNoIG5vdy4uLgorICAgICAgICAgICAgICAgICAgICByZXR1cm4gU2lnbmFsQWN0aW9uOjpIb3RI YW5kbGVkOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBBU1NFUlQoY3VycmVu dENvZGVCbG9jay0+aGFzSW5zdGFsbGVkVk1UcmFwQnJlYWtwb2ludHMoKSk7CiAgICAgICAgICAg ICAgICAgVk0mIHZtID0gKmN1cnJlbnRDb2RlQmxvY2stPnZtKCk7CiAgICAgICAgICAgICAgICAg QVNTRVJUKHZtLnRyYXBzKCkubmVlZFRyYXBIYW5kbGluZygpKTsgLy8gV2Ugc2hvdWxkIGhhdmUg YWxyZWFkeSBqZXR0aXNvbmVkIHRoaXMgY29kZSBibG9jayB3aGVuIHdlIGhhbmRsZWQgdGhlIHRy YXAuCg== 322445 2017-10-02 14:48:00 -0700 2017-10-02 14:49:28 -0700 Patch for landing bug-177780-20171002144759.patch text/plain 2107 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj OWViNDhkZWYxODBkNzVlODg0YWYwNDkzNzcyMjg1YWQ0MDFlNTVlLi4yNWI2MWY5MGNmYjA1OTZm MWUwNGUzYmM4NTRlNTkyM2I5YTBlZmY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0xMC0wMiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBWTVRyYXBzIHNob3VsZG4ndCBjcmFzaCBpZiBpdCBzZWVzIGFuIGV4 Y2VwdGlvbiBpdCBkb2Vzbid0IHVuZGVyc3RhbmQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc3ODAKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJr IExhbS4KKworICAgICAgICBWTVRyYXBzIGNvdWxkIHNlZSBhIEpJVCBicmVha3BvaW50IChTZWdW KSBmb3IgYW55IG51bWJlciBvZgorICAgICAgICByZWFzb25zIGl0IGRvZXNuJ3QgdW5kZXJzdGFu ZC4gZS5nLiAgYSBidWcgaW4gSklUIGNvZGUsIFdhc20gT09CLAorICAgICAgICBldGMuIFRoaXMg cGF0Y2ggbWFrZXMgaXQgaGFuZGxlIHRoYXQgY2FzZSBncmFjZWZ1bGx5LiBJdCdzIHdvcnRoCisg ICAgICAgIG5vdGluZyB0aGF0IHRoaXMgbWVhbnMgdGhlcmUncyBubyB3YXkgdG8ga25vdyBpZiwg ZHVlIGEgYnVnLCB3ZQorICAgICAgICBkaWRuJ3QgYWNjdXJhdGVseSB0cmFjayBhbGwgdGhlIFZN VHJhcHMgd2UgaW5zdGFsbGVkLiBJJ20gbm90IHN1cmUKKyAgICAgICAgaWYgdGhlcmUgaXMgYSBn b29kIHNvbHV0aW9uIHRvIHRoYXQgcHJvYmxlbSB0aG91Z2guCisKKyAgICAgICAgKiBydW50aW1l L1ZNVHJhcHMuY3BwOgorCiAyMDE3LTEwLTAyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5jbHVkZSBCZWFjb24gYW5kIFBp bmcgcmVxdWVzdHMgaW4gTmV0d29yayB0YWIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL1ZNVHJhcHMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUv Vk1UcmFwcy5jcHAKaW5kZXggZGVhYTQ0OWI2YmEyNmFjY2NlZGMxMjcyZTMyNTg5MmQ3NWI4Nzhk OC4uZTIzNmVkMzI1NDk5ZDcyODBlY2I5ODlkNzNiNWEyMTg2MTk0NjliOSAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAKKysrIGIvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAKQEAgLTIxMSw2ICsyMTEsMTAgQEAgcHVi bGljOgogICAgICAgICAgICAgICAgICAgICByZXR1cm4gU2lnbmFsQWN0aW9uOjpOb3RIYW5kbGVk OwogCiAgICAgICAgICAgICAgICAgQ29kZUJsb2NrKiBjdXJyZW50Q29kZUJsb2NrID0gREZHOjpj b2RlQmxvY2tGb3JWTVRyYXBQQyhjb250ZXh0LnRyYXBQQyk7CisgICAgICAgICAgICAgICAgaWYg KCFjdXJyZW50Q29kZUJsb2NrKSB7CisgICAgICAgICAgICAgICAgICAgIC8vIEVpdGhlciB3ZSB0 cmFwcGVkIGZvciBzb21lIG90aGVyIHJlYXNvbiwgZS5nLiBXYXNtIE9PQiwgb3Igd2UgZGlkbid0 IHByb3Blcmx5IG1vbml0b3IgdGhlIFBDLiBSZWdhcmRsZXNzLCB3ZSBjYW4ndCBkbyBtdWNoIG5v dy4uLgorICAgICAgICAgICAgICAgICAgICByZXR1cm4gU2lnbmFsQWN0aW9uOjpOb3RIYW5kbGVk OworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBBU1NFUlQoY3VycmVudENvZGVC bG9jay0+aGFzSW5zdGFsbGVkVk1UcmFwQnJlYWtwb2ludHMoKSk7CiAgICAgICAgICAgICAgICAg Vk0mIHZtID0gKmN1cnJlbnRDb2RlQmxvY2stPnZtKCk7CiAgICAgICAgICAgICAgICAgQVNTRVJU KHZtLnRyYXBzKCkubmVlZFRyYXBIYW5kbGluZygpKTsgLy8gV2Ugc2hvdWxkIGhhdmUgYWxyZWFk eSBqZXR0aXNvbmVkIHRoaXMgY29kZSBibG9jayB3aGVuIHdlIGhhbmRsZWQgdGhlIHRyYXAuCg== 322446 2017-10-02 14:48:36 -0700 2017-10-02 14:48:36 -0700 Patch for landing bug-177780-20171002144836.patch text/plain 2110 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBj OWViNDhkZWYxODBkNzVlODg0YWYwNDkzNzcyMjg1YWQ0MDFlNTVlLi5lZGQyOTdjOWRjM2E5NjMw ZDhlOTQ5OWQ4MjRlZTY4OTU1ZDIyMGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0xMC0wMiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBWTVRyYXBzIHNob3VsZG4ndCBjcmFzaCBpZiBpdCBzZWVzIGFuIGV4 Y2VwdGlvbiBpdCBkb2Vzbid0IHVuZGVyc3RhbmQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc3ODAKKworICAgICAgICBSZXZpZXdlZCBieSBNYXJr IExhbS4KKworICAgICAgICBWTVRyYXBzIGNvdWxkIHNlZSBhIEpJVCBicmVha3BvaW50IChTZWdW KSBmb3IgYW55IG51bWJlciBvZgorICAgICAgICByZWFzb25zIGl0IGRvZXNuJ3QgdW5kZXJzdGFu ZC4gZS5nLiAgYSBidWcgaW4gSklUIGNvZGUsIFdhc20gT09CLAorICAgICAgICBldGMuIFRoaXMg cGF0Y2ggbWFrZXMgaXQgaGFuZGxlIHRoYXQgY2FzZSBncmFjZWZ1bGx5LiBJdCdzIHdvcnRoCisg ICAgICAgIG5vdGluZyB0aGF0IHRoaXMgbWVhbnMgdGhlcmUncyBubyB3YXkgdG8ga25vdyBpZiwg ZHVlIHRvIGEgYnVnLCB3ZQorICAgICAgICBkaWRuJ3QgYWNjdXJhdGVseSB0cmFjayBhbGwgdGhl IFZNVHJhcHMgd2UgaW5zdGFsbGVkLiBJJ20gbm90IHN1cmUKKyAgICAgICAgaWYgdGhlcmUgaXMg YSBnb29kIHNvbHV0aW9uIHRvIHRoYXQgcHJvYmxlbSB0aG91Z2guCisKKyAgICAgICAgKiBydW50 aW1lL1ZNVHJhcHMuY3BwOgorCiAyMDE3LTEwLTAyICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFy b0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5jbHVkZSBCZWFjb24gYW5k IFBpbmcgcmVxdWVzdHMgaW4gTmV0d29yayB0YWIKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL1ZNVHJhcHMuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvVk1UcmFwcy5jcHAKaW5kZXggZGVhYTQ0OWI2YmEyNmFjY2NlZGMxMjcyZTMyNTg5MmQ3NWI4 NzhkOC4uZTIzNmVkMzI1NDk5ZDcyODBlY2I5ODlkNzNiNWEyMTg2MTk0NjliOSAxMDA2NDQKLS0t IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvVk1UcmFwcy5jcHAKQEAgLTIxMSw2ICsyMTEsMTAgQEAg cHVibGljOgogICAgICAgICAgICAgICAgICAgICByZXR1cm4gU2lnbmFsQWN0aW9uOjpOb3RIYW5k bGVkOwogCiAgICAgICAgICAgICAgICAgQ29kZUJsb2NrKiBjdXJyZW50Q29kZUJsb2NrID0gREZH Ojpjb2RlQmxvY2tGb3JWTVRyYXBQQyhjb250ZXh0LnRyYXBQQyk7CisgICAgICAgICAgICAgICAg aWYgKCFjdXJyZW50Q29kZUJsb2NrKSB7CisgICAgICAgICAgICAgICAgICAgIC8vIEVpdGhlciB3 ZSB0cmFwcGVkIGZvciBzb21lIG90aGVyIHJlYXNvbiwgZS5nLiBXYXNtIE9PQiwgb3Igd2UgZGlk bid0IHByb3Blcmx5IG1vbml0b3IgdGhlIFBDLiBSZWdhcmRsZXNzLCB3ZSBjYW4ndCBkbyBtdWNo IG5vdy4uLgorICAgICAgICAgICAgICAgICAgICByZXR1cm4gU2lnbmFsQWN0aW9uOjpOb3RIYW5k bGVkOworICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBBU1NFUlQoY3VycmVudENv ZGVCbG9jay0+aGFzSW5zdGFsbGVkVk1UcmFwQnJlYWtwb2ludHMoKSk7CiAgICAgICAgICAgICAg ICAgVk0mIHZtID0gKmN1cnJlbnRDb2RlQmxvY2stPnZtKCk7CiAgICAgICAgICAgICAgICAgQVNT RVJUKHZtLnRyYXBzKCkubmVlZFRyYXBIYW5kbGluZygpKTsgLy8gV2Ugc2hvdWxkIGhhdmUgYWxy ZWFkeSBqZXR0aXNvbmVkIHRoaXMgY29kZSBibG9jayB3aGVuIHdlIGhhbmRsZWQgdGhlIHRyYXAu Cg==