177774 2017-10-02 13:45:54 -0700 Web Inspector: After enabling the new Network Tab in experimental settings, the network tab disappears 2017-10-04 11:30:42 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue hi inspector-bugzilla-changes joepeck mjs webkit-bug-importer oldest_to_newest 1355463 0 joepeck 2017-10-02 13:45:54 -0700 After enabling the new Network Tab in experimental settings, the network tab disappears. Steps to reproduce: 1. Open Web Inspector 2. Click the gear for settings 3. Click Experimental 4. Check New Network Tab 5. Reload the inspector with the button that appears Result: Network Tab disappears. Expected: Network Tab to be there just different. Note: It is possible to add it back with New Tab however. 1355464 1 joepeck 2017-10-02 13:46:02 -0700 <rdar://problem/34771647> 1355465 2 322425 joepeck 2017-10-02 13:47:03 -0700 Created attachment 322425 [PATCH] Proposed Fix 1355619 3 322425 hi 2017-10-02 17:00:03 -0700 Comment on attachment 322425 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=322425&action=review > Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:259 > + if (!WI.settings.experimentalEnableNewNetworkTab.value) Shouldn't the reverse also be done (replace WI.NetworkTabContentView with WI.LEgacyNetworkTabContentView) if the setting changes to off? Also, doesn't a warning appear when you toggle this setting that you have to refresh to see the effects? Maybe a better solution would be to force a refresh if the user switches off the settings tab without clicking that button :| 1355646 4 322425 joepeck 2017-10-02 17:41:23 -0700 Comment on attachment 322425 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=322425&action=review >> Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js:259 >> + if (!WI.settings.experimentalEnableNewNetworkTab.value) > > Shouldn't the reverse also be done (replace WI.NetworkTabContentView with WI.LEgacyNetworkTabContentView) if the setting changes to off? Also, doesn't a warning appear when you toggle this setting that you have to refresh to see the effects? Maybe a better solution would be to force a refresh if the user switches off the settings tab without clicking that button :| Sure I can do this for the legacy direction. 1356191 5 322622 joepeck 2017-10-03 18:03:26 -0700 Created attachment 322622 [PATCH] Proposed Fix 1356197 6 322622 hi 2017-10-03 18:30:28 -0700 Comment on attachment 322622 [PATCH] Proposed Fix r=me 1356531 7 322622 commit-queue 2017-10-04 11:30:41 -0700 Comment on attachment 322622 [PATCH] Proposed Fix Clearing flags on attachment: 322622 Committed r222860: <http://trac.webkit.org/changeset/222860> 1356532 8 commit-queue 2017-10-04 11:30:42 -0700 All reviewed patches have been landed. Closing bug. 322425 2017-10-02 13:47:03 -0700 2017-10-03 18:03:26 -0700 [PATCH] Proposed Fix network-tab-placement-1.patch text/plain 2587 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI2MzRmZDczMWFiLi4xMmJkOTJlMjliNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTctMTAtMDIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBBZnRlciBlbmFibGluZyB0aGUgbmV3IE5ldHdvcmsgVGFiIGluIGV4cGVyaW1lbnRhbCBzZXR0 aW5ncywgdGhlIG5ldHdvcmsgdGFiIGRpc2FwcGVhcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Nzc3NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzQ3NzE2NDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanM6CisgICAg ICAgIFdoZW4gZW5hYmxpbmcgdGhlIG5ldyBuZXR3b3JrIHRhYiwgZW5zdXJlIGl0IGdldHMgYWRk ZWQgdG8gdGhlIGxpc3Qgb2Ygb3BlbiB0YWJzLgorICAgICAgICBQbGFjZSBpdCB3aGVyZSB0aGUg b2xkIG5ldHdvcmsgdGFiIHdhcyBzbyB0aGUgVUkgaXMgYXMgY29uc2lzdGVudCBhcyBwb3NzaWJs ZS4KKworMjAxNy0xMC0wMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgor CiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEluY2x1ZGUgQmVhY29uIGFuZCBQaW5nIHJlcXVlc3Rz IGluIE5ldHdvcmsgdGFiCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzc2NDEKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMzMDg2ODM5PgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NU YWJDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKaW5kZXggMzEwMDFiNjdlZjMuLjcxOTRhOGFl YzlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKQEAgLTI1Miw2ICsy NTIsMjQgQEAgV0kuU2V0dGluZ3NUYWJDb250ZW50VmlldyA9IGNsYXNzIFNldHRpbmdzVGFiQ29u dGVudFZpZXcgZXh0ZW5kcyBXSS5UYWJDb250ZW50VmkKICAgICAgICAgaWYgKHdpbmRvdy5OZXR3 b3JrQWdlbnQpIHsKICAgICAgICAgICAgIGV4cGVyaW1lbnRhbFNldHRpbmdzVmlldy5hZGRTZXR0 aW5nKFdJLlVJU3RyaW5nKCJOZXR3b3JrIFRhYjoiKSwgV0kuc2V0dGluZ3MuZXhwZXJpbWVudGFs RW5hYmxlTmV3TmV0d29ya1RhYiwgV0kuVUlTdHJpbmcoIk5ldyBOZXR3b3JrIFRhYiIpKTsKICAg ICAgICAgICAgIGV4cGVyaW1lbnRhbFNldHRpbmdzVmlldy5hZGRTZXBhcmF0b3IoKTsKKworICAg ICAgICAgICAgLy8gRW5zdXJlIHRoZSBuZXcgbmV0d29yayB0YWIgaXMgb3BlbiBhZnRlciByZWxv YWRpbmcgdGhlIGZyb250ZW5kLgorICAgICAgICAgICAgLy8gUHV0IGl0IGluIHRoZSBzYW1lIHBs YWNlIGFzIHRoZSBvcmlnaW5hbCBuZXR3b3JrIHRhYiBvciBqdXN0IGF0IHRoZSBlbmQuCisgICAg ICAgICAgICBXSS5zZXR0aW5ncy5leHBlcmltZW50YWxFbmFibGVOZXdOZXR3b3JrVGFiLmFkZEV2 ZW50TGlzdGVuZXIoV0kuU2V0dGluZy5FdmVudC5DaGFuZ2VkLCAoKSA9PiB7CisgICAgICAgICAg ICAgICAgaWYgKCFXSS5zZXR0aW5ncy5leHBlcmltZW50YWxFbmFibGVOZXdOZXR3b3JrVGFiLnZh bHVlKQorICAgICAgICAgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgICAgICAgICBsZXQg dGFicyA9IFdJLl9vcGVuVGFic1NldHRpbmcudmFsdWUuc2xpY2UoKTsKKyAgICAgICAgICAgICAg ICB0YWJzLnJlbW92ZShXSS5OZXR3b3JrVGFiQ29udGVudFZpZXcuVHlwZSk7CisKKyAgICAgICAg ICAgICAgICBsZXQgbmV0d29ya1RhYkluZGV4ID0gdGFicy5pbmRleE9mKFdJLkxlZ2FjeU5ldHdv cmtUYWJDb250ZW50Vmlldy5UeXBlKTsKKyAgICAgICAgICAgICAgICBpZiAobmV0d29ya1RhYklu ZGV4ICE9PSAtMSkKKyAgICAgICAgICAgICAgICAgICAgdGFicy5pbnNlcnRBdEluZGV4KFdJLk5l dHdvcmtUYWJDb250ZW50Vmlldy5UeXBlLCBuZXR3b3JrVGFiSW5kZXgpOworICAgICAgICAgICAg ICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgdGFicy5wdXNoKFdJLk5ldHdvcmtUYWJDb250 ZW50Vmlldy5UeXBlKTsKKworICAgICAgICAgICAgICAgIFdJLl9vcGVuVGFic1NldHRpbmcudmFs dWUgPSB0YWJzOworICAgICAgICAgICAgfSk7CiAgICAgICAgIH0KIAogICAgICAgICBpZiAod2lu ZG93LkxheWVyVHJlZUFnZW50KSB7Cg== 322622 2017-10-03 18:03:26 -0700 2017-10-04 11:30:41 -0700 [PATCH] Proposed Fix experimental-2.patch text/plain 2736 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDk1YzU5Y2Y4OGJhLi43YmNlNjgxMDlmZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMTAtMDIgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBBZnRlciBlbmFibGluZyB0aGUgbmV3IE5ldHdvcmsgVGFiIGluIGV4cGVyaW1lbnRhbCBzZXR0 aW5ncywgdGhlIG5ldHdvcmsgdGFiIGRpc2FwcGVhcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3Nzc3NAorICAgICAgICA8cmRhcjovL3Byb2JsZW0v MzQ3NzE2NDc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanM6CisgICAg ICAgIFdoZW4gZW5hYmxpbmcgdGhlIG5ldyBuZXR3b3JrIHRhYiwgZW5zdXJlIGl0IGdldHMgYWRk ZWQgdG8gdGhlIGxpc3Qgb2Ygb3BlbiB0YWJzLgorICAgICAgICBQbGFjZSBpdCB3aGVyZSB0aGUg b2xkIG5ldHdvcmsgdGFiIHdhcyBzbyB0aGUgVUkgaXMgYXMgY29uc2lzdGVudCBhcyBwb3NzaWJs ZS4KKwogMjAxNy0xMC0wMyAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogTGF5ZXJzIHRhYiBzaWRlYmFyJ3MgRE9NIGhpZ2hs aWdodCBzaG91bGQgYmUgYnkgcm93IGhvdmVyLCBub3Qgcm93IHNlbGVjdGlvbgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2V0dGluZ3NUYWJD b250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKaW5kZXggMzEwMDFiNjdlZjMuLmZhM2Y1MTdkZDI4 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9T ZXR0aW5nc1RhYkNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMKQEAgLTI1Miw2ICsyNTIs MjUgQEAgV0kuU2V0dGluZ3NUYWJDb250ZW50VmlldyA9IGNsYXNzIFNldHRpbmdzVGFiQ29udGVu dFZpZXcgZXh0ZW5kcyBXSS5UYWJDb250ZW50VmkKICAgICAgICAgaWYgKHdpbmRvdy5OZXR3b3Jr QWdlbnQpIHsKICAgICAgICAgICAgIGV4cGVyaW1lbnRhbFNldHRpbmdzVmlldy5hZGRTZXR0aW5n KFdJLlVJU3RyaW5nKCJOZXR3b3JrIFRhYjoiKSwgV0kuc2V0dGluZ3MuZXhwZXJpbWVudGFsRW5h YmxlTmV3TmV0d29ya1RhYiwgV0kuVUlTdHJpbmcoIk5ldyBOZXR3b3JrIFRhYiIpKTsKICAgICAg ICAgICAgIGV4cGVyaW1lbnRhbFNldHRpbmdzVmlldy5hZGRTZXBhcmF0b3IoKTsKKworICAgICAg ICAgICAgLy8gRW5zdXJlIHRoZSB0b2dnbGVkIG5ldHdvcmsgdGFiIGlzIG9wZW4gYWZ0ZXIgcmVs b2FkaW5nIHRoZSBmcm9udGVuZC4KKyAgICAgICAgICAgIC8vIFB1dCBpdCBpbiB0aGUgc2FtZSBw bGFjZSBhcyB0aGUgZXhpc3RpbmcgbmV0d29yayB0YWIgb3IganVzdCBhdCB0aGUgZW5kLgorICAg ICAgICAgICAgV0kuc2V0dGluZ3MuZXhwZXJpbWVudGFsRW5hYmxlTmV3TmV0d29ya1RhYi5hZGRF dmVudExpc3RlbmVyKFdJLlNldHRpbmcuRXZlbnQuQ2hhbmdlZCwgKCkgPT4geworICAgICAgICAg ICAgICAgIGxldCBuZXdOZXR3b3JrVGFibGVFbmFibGVkID0gV0kuc2V0dGluZ3MuZXhwZXJpbWVu dGFsRW5hYmxlTmV3TmV0d29ya1RhYi52YWx1ZTsKKyAgICAgICAgICAgICAgICBsZXQgaW5jb21p bmdUYWJJZGVudGlmaWVyID0gbmV3TmV0d29ya1RhYmxlRW5hYmxlZCA/IFdJLk5ldHdvcmtUYWJD b250ZW50Vmlldy5UeXBlIDogV0kuTGVnYWN5TmV0d29ya1RhYkNvbnRlbnRWaWV3LlR5cGU7Cisg ICAgICAgICAgICAgICAgbGV0IG91dGdvaW5nVGFiSWRlbnRpZmllciA9IG5ld05ldHdvcmtUYWJs ZUVuYWJsZWQgPyBXSS5MZWdhY3lOZXR3b3JrVGFiQ29udGVudFZpZXcuVHlwZSA6IFdJLk5ldHdv cmtUYWJDb250ZW50Vmlldy5UeXBlOworCisgICAgICAgICAgICAgICAgbGV0IHRhYnMgPSBXSS5f b3BlblRhYnNTZXR0aW5nLnZhbHVlLnNsaWNlKCk7CisgICAgICAgICAgICAgICAgdGFicy5yZW1v dmUoaW5jb21pbmdUYWJJZGVudGlmaWVyKTsKKworICAgICAgICAgICAgICAgIGxldCBpbmRleCA9 IHRhYnMuaW5kZXhPZihvdXRnb2luZ1RhYklkZW50aWZpZXIpOworICAgICAgICAgICAgICAgIGlm IChpbmRleCAhPT0gLTEpCisgICAgICAgICAgICAgICAgICAgIHRhYnMuaW5zZXJ0QXRJbmRleChp bmNvbWluZ1RhYklkZW50aWZpZXIsIGluZGV4KTsKKyAgICAgICAgICAgICAgICBlbHNlCisgICAg ICAgICAgICAgICAgICAgIHRhYnMucHVzaChpbmNvbWluZ1RhYklkZW50aWZpZXIpOworCisgICAg ICAgICAgICAgICAgV0kuX29wZW5UYWJzU2V0dGluZy52YWx1ZSA9IHRhYnM7CisgICAgICAgICAg ICB9KTsKICAgICAgICAgfQogCiAgICAgICAgIGlmICh3aW5kb3cuTGF5ZXJUcmVlQWdlbnQpIHsK