177773 2017-10-02 13:42:54 -0700 NULL WeakPtr should not malloc! 2017-10-02 15:21:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ggaren ggaren benjamin buildbot cdumez cmarcelo dbates koivisto webkit-bug-importer zalan oldest_to_newest 1355459 0 ggaren 2017-10-02 13:42:54 -0700 NULL WeakPtr should not malloc! 1355472 1 322429 ggaren 2017-10-02 13:54:22 -0700 Created attachment 322429 Patch 1355477 2 buildbot 2017-10-02 13:57:27 -0700 Attachment 322429 did not pass style-queue: ERROR: Source/WTF/wtf/WeakPtr.h:70: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1355489 3 322429 koivisto 2017-10-02 14:17:17 -0700 Comment on attachment 322429 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=322429&action=review lol yes r=me > Source/WTF/wtf/WeakPtr.h:70 > + WeakPtr() { } > + WeakPtr(std::nullptr_t) { } > + WeakPtr(const WeakPtr& o) : m_ref(o.m_ref) { } Should also add WeakPtr(WeakPtr&&) = default at some point (and operator= too). 1355562 4 ggaren 2017-10-02 15:21:14 -0700 Committed r222752: <http://trac.webkit.org/changeset/222752> 1355563 5 webkit-bug-importer 2017-10-02 15:21:48 -0700 <rdar://problem/34778205> 322429 2017-10-02 13:54:22 -0700 2017-10-02 14:17:17 -0700 Patch bug-177773-20171002135421.patch text/plain 2651 ggaren SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjI3MzkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTEwLTAyICBHZW9mZnJleSBHYXJlbiAgPGdn YXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgTlVMTCBXZWFrUHRyIHNob3VsZCBub3QgbWFsbG9j IQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc3Nzcz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHJhbnNs YXRpbmcgTlVMTCBpbnRvIG1hbGxvYyBpcy4uLiBpbmVmZmljaWVudC4KKworICAgICAgICAqIHd0 Zi9XZWFrUHRyLmg6CisgICAgICAgIChXVEY6OldlYWtQdHI6OldlYWtQdHIpOgorICAgICAgICAo V1RGOjpXZWFrUHRyOjpvcGVyYXRvcj0pOgorICAgICAgICAoV1RGOjpXZWFrUHRyOjpjbGVhcik6 IE1ha2UgbV9yZWYgbGF6eSBzbyB0aGF0IGEgTlVMTCBtX3JlZiBjYW4gcmVwcmVzZW50CisgICAg ICAgIGEgTlVMTCBwb2ludGVyLiBOb3JtYWwgZGVyZWZlcmVuY2UgaXMgbm8gc2xvd2VyIGJlY2F1 c2Ugd2UgY2FuIHJlbHkgb24KKyAgICAgICAgdGhlIGZhY3QgdGhhdCBkZXJlZmVyZW5jZSBvZiBO VUxMIHNob3VsZCBjcmFzaC4gb3BlcmF0b3IgYm9vbCgpIGFuZCBnZXQoKQorICAgICAgICBpbmN1 ciBhbiBleHRyYSBicmFuY2guIFRoYXQncyBwcm9iYWJseSB3b3J0aCBpdCB0byBhdm9pZCBtYWxs b2MKKyAgICAgICAgZm9yIE5VTEwuCisKIDIwMTctMDktMzAgIEFudHRpIEtvaXZpc3RvICA8YW50 dGlAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBtYWtlV2Vha1B0ciBmb3IgZWFzaWVyIFdlYWtQ dHIgY29uc3RydWN0aW9uCkluZGV4OiBTb3VyY2UvV1RGL3d0Zi9XZWFrUHRyLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dURi93dGYvV2Vha1B0ci5oCShyZXZpc2lvbiAyMjI3MzkpCisrKyBTb3Vy Y2UvV1RGL3d0Zi9XZWFrUHRyLmgJKHdvcmtpbmcgY29weSkKQEAgLTY1LDI0ICs2NSwyNCBAQCB0 ZW1wbGF0ZTx0eXBlbmFtZSBUPgogY2xhc3MgV2Vha1B0ciB7CiAgICAgV1RGX01BS0VfRkFTVF9B TExPQ0FURUQ7CiBwdWJsaWM6Ci0gICAgV2Vha1B0cigpIDogbV9yZWYoV2Vha1JlZmVyZW5jZTxU Pjo6Y3JlYXRlKG51bGxwdHIpKSB7IH0KLSAgICBXZWFrUHRyKHN0ZDo6bnVsbHB0cl90KSA6IG1f cmVmKFdlYWtSZWZlcmVuY2U8VD46OmNyZWF0ZShudWxscHRyKSkgeyB9Ci0gICAgV2Vha1B0cihj b25zdCBXZWFrUHRyJiBvKSA6IG1fcmVmKG8ubV9yZWYuY29weVJlZigpKSB7IH0KKyAgICBXZWFr UHRyKCkgeyB9CisgICAgV2Vha1B0cihzdGQ6Om51bGxwdHJfdCkgeyB9CisgICAgV2Vha1B0cihj b25zdCBXZWFrUHRyJiBvKSA6IG1fcmVmKG8ubV9yZWYpIHsgfQogICAgIFdlYWtQdHIoUmVmPFdl YWtSZWZlcmVuY2U8VD4+JiYgcmVmKSA6IG1fcmVmKHN0ZDo6Zm9yd2FyZDxSZWY8V2Vha1JlZmVy ZW5jZTxUPj4+KHJlZikpIHsgfQogCi0gICAgVCogZ2V0KCkgY29uc3QgeyByZXR1cm4gbV9yZWYt PmdldCgpOyB9Ci0gICAgb3BlcmF0b3IgYm9vbCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVmLT5nZXQo KTsgfQorICAgIFQqIGdldCgpIGNvbnN0IHsgcmV0dXJuIG1fcmVmID8gbV9yZWYtPmdldCgpIDog bnVsbHB0cjsgfQorICAgIG9wZXJhdG9yIGJvb2woKSBjb25zdCB7IHJldHVybiBtX3JlZiAmJiBt X3JlZi0+Z2V0KCk7IH0KIAotICAgIFdlYWtQdHImIG9wZXJhdG9yPShjb25zdCBXZWFrUHRyJiBv KSB7IG1fcmVmID0gby5tX3JlZi5jb3B5UmVmKCk7IHJldHVybiAqdGhpczsgfQotICAgIFdlYWtQ dHImIG9wZXJhdG9yPShzdGQ6Om51bGxwdHJfdCkgeyBtX3JlZiA9IFdlYWtSZWZlcmVuY2U8VD46 OmNyZWF0ZShudWxscHRyKTsgcmV0dXJuICp0aGlzOyB9CisgICAgV2Vha1B0ciYgb3BlcmF0b3I9 KGNvbnN0IFdlYWtQdHImIG8pIHsgbV9yZWYgPSBvLm1fcmVmOyByZXR1cm4gKnRoaXM7IH0KKyAg ICBXZWFrUHRyJiBvcGVyYXRvcj0oc3RkOjpudWxscHRyX3QpIHsgbV9yZWYgPSBudWxscHRyOyBy ZXR1cm4gKnRoaXM7IH0KIAotICAgIFQqIG9wZXJhdG9yLT4oKSBjb25zdCB7IHJldHVybiBnZXQo KTsgfQotICAgIFQmIG9wZXJhdG9yKigpIGNvbnN0IHsgcmV0dXJuICpnZXQoKTsgfQorICAgIFQq IG9wZXJhdG9yLT4oKSBjb25zdCB7IHJldHVybiBtX3JlZi0+Z2V0KCk7IH0KKyAgICBUJiBvcGVy YXRvciooKSBjb25zdCB7IHJldHVybiAqbV9yZWYtPmdldCgpOyB9CiAKLSAgICB2b2lkIGNsZWFy KCkgeyBtX3JlZiA9IFdlYWtSZWZlcmVuY2U8VD46OmNyZWF0ZShudWxscHRyKTsgfQorICAgIHZv aWQgY2xlYXIoKSB7IG1fcmVmID0gbnVsbHB0cjsgfQogCiBwcml2YXRlOgotICAgIFJlZjxXZWFr UmVmZXJlbmNlPFQ+PiBtX3JlZjsKKyAgICBSZWZQdHI8V2Vha1JlZmVyZW5jZTxUPj4gbV9yZWY7 CiB9OwogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBUPgo=