177767 2017-10-02 13:11:41 -0700 Add makeWeakPtr variant that takes pointer 2017-10-02 14:32:18 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned commit-queue webkit-bug-importer zalan oldest_to_newest 1355431 0 koivisto 2017-10-02 13:11:41 -0700 Instead of a reference. 1355435 1 322416 koivisto 2017-10-02 13:15:02 -0700 Created attachment 322416 patch 1355437 2 322416 zalan 2017-10-02 13:16:13 -0700 Comment on attachment 322416 patch Lovely! 1355498 3 322416 commit-queue 2017-10-02 14:31:19 -0700 Comment on attachment 322416 patch Clearing flags on attachment: 322416 Committed r222741: <http://trac.webkit.org/changeset/222741> 1355499 4 commit-queue 2017-10-02 14:31:21 -0700 All reviewed patches have been landed. Closing bug. 1355502 5 webkit-bug-importer 2017-10-02 14:32:18 -0700 <rdar://problem/34776677> 322416 2017-10-02 13:15:02 -0700 2017-10-02 14:31:19 -0700 patch makeweak-ptr.patch text/plain 2560 koivisto SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAyMjI3MzgpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTEwLTAyICBBbnR0aSBLb2l2aXN0byAgPGFu dHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgbWFrZVdlYWtQdHIgdmFyaWFudCB0aGF0IHRh a2VzIHBvaW50ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3Nzc2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogd3RmL1dlYWtQdHIuaDoKKyAgICAgICAgKFdURjo6bWFrZVdlYWtQdHIpOgorCisgICAg ICAgIFRoaXMgdmVyc2lvbiBkZWFscyB3aXRoIHRoZSBudWxscHRyLgorCiAyMDE3LTA5LTMwICBB bnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgbWFrZVdlYWtQ dHIgZm9yIGVhc2llciBXZWFrUHRyIGNvbnN0cnVjdGlvbgpJbmRleDogU291cmNlL1dURi93dGYv V2Vha1B0ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL1dlYWtQdHIuaAkocmV2aXNp b24gMjIyNzM4KQorKysgU291cmNlL1dURi93dGYvV2Vha1B0ci5oCSh3b3JraW5nIGNvcHkpCkBA IC0xMjYsNiArMTI2LDEzIEBAIHRlbXBsYXRlIDx0eXBlbmFtZSBUPiBpbmxpbmUgV2Vha1B0cjxU PiAKICAgICByZXR1cm4gcmVmLndlYWtQdHJGYWN0b3J5KCkudGVtcGxhdGUgY3JlYXRlV2Vha1B0 cjxUPihyZWYpOwogfQogCit0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gaW5saW5lIFdlYWtQdHI8VD4g bWFrZVdlYWtQdHIoVCogcHRyKQoreworICAgIGlmICghcHRyKQorICAgICAgICByZXR1cm4geyB9 OworICAgIHJldHVybiBtYWtlV2Vha1B0cigqcHRyKTsKK30KKwogdGVtcGxhdGU8dHlwZW5hbWUg VCwgdHlwZW5hbWUgVT4gaW5saW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBXZWFrUHRyPFQ+JiBh LCBjb25zdCBXZWFrUHRyPFU+JiBiKQogewogICAgIHJldHVybiBhLmdldCgpID09IGIuZ2V0KCk7 CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMjI3MzgpCisrKyBTb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0xMC0wMiAgQW50dGkg S29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIG1ha2VXZWFrUHRyIHZh cmlhbnQgdGhhdCB0YWtlcyBwb2ludGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzc3NjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBVc2UgaXQuCisKKyAgICAgICAgKiByZW5kZXJpbmcvU2VsZWN0aW9u UmFuZ2VEYXRhLmg6CisgICAgICAgIChXZWJDb3JlOjpTZWxlY3Rpb25SYW5nZURhdGE6OkNvbnRl eHQ6OkNvbnRleHQpOgorCiAyMDE3LTEwLTAyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5j b20+CiAKICAgICAgICAgU2VsZWN0aW9uUmFuZ2VEYXRhIHNob3VsZCBub3QgaG9sZCByYXcgUmVu ZGVyT2JqZWN0IHBvaW50ZXJzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvU2VsZWN0 aW9uUmFuZ2VEYXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Nl bGVjdGlvblJhbmdlRGF0YS5oCShyZXZpc2lvbiAyMjI3MzgpCisrKyBTb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvU2VsZWN0aW9uUmFuZ2VEYXRhLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ4LDggKzQ4 LDggQEAgcHVibGljOgogICAgIHB1YmxpYzoKICAgICAgICAgQ29udGV4dCgpID0gZGVmYXVsdDsK ICAgICAgICAgQ29udGV4dChSZW5kZXJPYmplY3QqIHN0YXJ0LCBSZW5kZXJPYmplY3QqIGVuZCwg dW5zaWduZWQgc3RhcnRPZmZzZXQsIHVuc2lnbmVkIGVuZE9mZnNldCkKLSAgICAgICAgICAgIDog bV9zdGFydChzdGFydCA/IG1ha2VXZWFrUHRyKCpzdGFydCkgOiBudWxscHRyKQotICAgICAgICAg ICAgLCBtX2VuZChlbmQgPyBtYWtlV2Vha1B0cigqZW5kKSA6IG51bGxwdHIpCisgICAgICAgICAg ICA6IG1fc3RhcnQobWFrZVdlYWtQdHIoc3RhcnQpKQorICAgICAgICAgICAgLCBtX2VuZChtYWtl V2Vha1B0cihlbmQpKQogICAgICAgICAgICAgLCBtX3N0YXJ0UG9zaXRpb24oc3RhcnRPZmZzZXQp CiAgICAgICAgICAgICAsIG1fZW5kUG9zaXRpb24oZW5kT2Zmc2V0KQogICAgICAgICB7Cg==