177752 2017-10-02 10:28:09 -0700 [WPE] Do not require XSLT if disabled 2017-10-10 15:27:23 -0700 1 1 1 Unclassified WebKit WPE WebKit Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177857 P2 Normal --- 1 olivier.blin webkit-unassigned aperez bugs-noreply commit-queue cturner don.olmstead mcatanzaro webkit-bug-importer zan oldest_to_newest 1355288 0 olivier.blin 2017-10-02 10:28:09 -0700 libxslt is not a hard dep. 1355289 1 322387 olivier.blin 2017-10-02 10:29:46 -0700 Created attachment 322387 Patch 1355370 2 322387 commit-queue 2017-10-02 11:58:10 -0700 Comment on attachment 322387 Patch Clearing flags on attachment: 322387 Committed r222727: <http://trac.webkit.org/changeset/222727> 1355371 3 commit-queue 2017-10-02 11:58:12 -0700 All reviewed patches have been landed. Closing bug. 1355748 4 mcatanzaro 2017-10-03 02:07:21 -0700 I suppose we should expose ENABLE_XSLT as a public option, since it allows avoiding a dependency that's not needed on embedded devices. 1355755 5 zan 2017-10-03 02:41:29 -0700 (In reply to Michael Catanzaro from comment #4) > I suppose we should expose ENABLE_XSLT as a public option, since it allows > avoiding a dependency that's not needed on embedded devices. Yes, I think that makes sense. 1355761 6 aperez 2017-10-03 02:49:39 -0700 (In reply to Zan Dobersek from comment #5) > (In reply to Michael Catanzaro from comment #4) > > I suppose we should expose ENABLE_XSLT as a public option, since it allows > > avoiding a dependency that's not needed on embedded devices. > > Yes, I think that makes sense. +1 1355902 7 don.olmstead 2017-10-03 11:05:35 -0700 (In reply to Adrian Perez from comment #6) > (In reply to Zan Dobersek from comment #5) > > (In reply to Michael Catanzaro from comment #4) > > > I suppose we should expose ENABLE_XSLT as a public option, since it allows > > > avoiding a dependency that's not needed on embedded devices. > > > > Yes, I think that makes sense. > > +1 Please do. We want to remove libxslt from WinCairo by default 1356293 8 mcatanzaro 2017-10-04 02:09:37 -0700 This doesn't affect WinCairo at all since the choice of which options to expose for WPE is WPE-specific. 1356296 9 mcatanzaro 2017-10-04 02:11:51 -0700 Bug #177857 1356298 10 mcatanzaro 2017-10-04 02:12:47 -0700 In the future: please no patches to allow disabling dependencies unless the corresponding feature flag also made public. 322387 2017-10-02 10:29:46 -0700 2017-10-02 11:58:10 -0700 Patch bug-177752-20171002192944.patch text/plain 1317 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dQRS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCmluZGV4IDdkN2M2 YWIzYzFjZTA0MjlhN2NjZTcyZjY5Y2YyYmJhNGRkMDg4Y2UuLmE3OTQ3ZjQxMzU5MDNhOTM5Mjk2 NTI3NTZiMjRjMTk3ZDA4ODMzZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BF LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC02OSwxMyArNjks MTYgQEAgZmluZF9wYWNrYWdlKExpYkVwb3h5IDEuNC4wIFJFUVVJUkVEKQogZmluZF9wYWNrYWdl KExpYkdjcnlwdCAxLjYuMCBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShMaWJTb3VwIDIuNDIuMCBS RVFVSVJFRCkKIGZpbmRfcGFja2FnZShMaWJYbWwyIDIuOC4wIFJFUVVJUkVEKQotZmluZF9wYWNr YWdlKExpYlhzbHQgMS4xLjcgUkVRVUlSRUQpCiBmaW5kX3BhY2thZ2UoUE5HIFJFUVVJUkVEKQog ZmluZF9wYWNrYWdlKFNxbGl0ZSBSRVFVSVJFRCkKIGZpbmRfcGFja2FnZShXZWJQIFJFUVVJUkVE KQogCiBmaW5kX3BhY2thZ2UoV1BFQmFja2VuZCBSRVFVSVJFRCkKIAoraWYgKEVOQUJMRV9YU0xU KQorICAgIGZpbmRfcGFja2FnZShMaWJYc2x0IDEuMS43IFJFUVVJUkVEKQorZW5kaWYgKCkKKwog c2V0KFVTRV9DQUlSTyBPTikKIHNldChVU0VfWERHTUlNRSBPTikKIFNFVF9BTkRfRVhQT1NFX1RP X0JVSUxEKFVTRV9HQ1JZUFQgVFJVRSkKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxv ZwppbmRleCBmMDgwZWJkMDYwZTM0ZTQ1ZGJhMWE3ZGNjNWM2MTIzMGVkMGE1MTJjLi5jYmYyZGZj ODAxNjI0NjY0NGE1YTc4Njk5ZDQ3NjUzOWUzZTkwZjYxIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cK KysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMTAtMDIgIE9saXZpZXIgQmxp biAgPG9saXZpZXIuYmxpbkBzb2Z0YXRob21lLmNvbT4KKworICAgICAgICBbV1BFXSBEbyBub3Qg cmVxdWlyZSBYU0xUIGlmIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzc3NTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOiBsaWJ4c2x0 IGlzIG5vdCBhIGhhcmQgZGVwCisKIDIwMTctMTAtMDIgIE9saXZpZXIgQmxpbiAgPG9saXZpZXIu YmxpbkBzb2Z0YXRob21lLmNvbT4KIAogICAgICAgICBbV1BFXSBSZW1vdmUgR251VExTIGRlcGVu ZGVuY3kK