177744 2017-10-02 07:29:48 -0700 Fix build with MathML disabled 2017-10-02 11:36:00 -0700 1 1 1 Unclassified WebKit MathML Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 olivier.blin webkit-unassigned commit-queue fred.wang kling koivisto mcatanzaro rego webkit-bug-importer zalan oldest_to_newest 1355225 0 olivier.blin 2017-10-02 07:29:48 -0700 These are regressions from r217549 (StyleResolver) and r221379 (RenderBlockFlow), which do not guard MathML usage. 1355228 1 322375 olivier.blin 2017-10-02 07:38:34 -0700 Created attachment 322375 Patch 1355273 2 322375 mcatanzaro 2017-10-02 10:12:24 -0700 Comment on attachment 322375 Patch OK, but I think we should remove this build flag. 1355292 3 olivier.blin 2017-10-02 10:32:54 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 322375 [details] > Patch > > OK, but I think we should remove this build flag. What about embedded devices that will probably not need MathML? 1355319 4 322375 commit-queue 2017-10-02 10:59:40 -0700 Comment on attachment 322375 Patch Clearing flags on attachment: 322375 Committed r222721: <http://trac.webkit.org/changeset/222721> 1355320 5 commit-queue 2017-10-02 10:59:41 -0700 All reviewed patches have been landed. Closing bug. 1355325 6 webkit-bug-importer 2017-10-02 11:00:15 -0700 <rdar://problem/34770850> 1355355 7 mcatanzaro 2017-10-02 11:36:00 -0700 We usually make features optional for the benefit of embedded devices only if it would entail a significant code size savings (especially when they require extra dependencies). That seems unlikely for MathML, right? How much space is it actually saving you to turn it off? WebKit is moving towards using mainly runtime flags to guard features, and MathML just doesn't seem to fit as something that deserves a build flag anymore. 322375 2017-10-02 07:38:34 -0700 2017-10-02 10:59:40 -0700 Patch bug-177744-20171002163832.patch text/plain 2551 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNjg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWRmZmNmYjBlY2QyZTRm ZmJlNmEwYjIzN2QwNDMyYzI2YWIzOWExNy4uYzU4OTJhZDQ2YTc1MTYxZDlmN2RkNGVhNTAzMGZj NGU2MDNiYmRlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTEwLTAyICBPbGl2 aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgRml4IGJ1 aWxkIHdpdGggTWF0aE1MIGRpc2FibGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzc3NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGVzZSBhcmUgcmVncmVzc2lvbnMgZnJvbSByMjE3NTQ5IChTdHls ZVJlc29sdmVyKSBhbmQgcjIyMTM3OSAoUmVuZGVyQmxvY2tGbG93KSwgd2hpY2ggZG8gbm90IGd1 YXJkIE1hdGhNTCB1c2FnZS4KKworICAgICAgICAqIGNzcy9TdHlsZVJlc29sdmVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Omhhc0VmZmVjdGl2ZURpc3BsYXlOb25lRm9yRGlzcGxheUNvbnRlbnRz KToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckJsb2NrRmxvdzo6d2lsbENyZWF0ZUNvbHVtbnMgY29uc3QpOgorCiAyMDE3 LTA5LTMwICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIERvbid0 IHJldmVhbCBmaWxlIFVSTCB3aGVuIHBhc3RpbmcgYW4gaW1hZ2UKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2Nzcy9TdHlsZVJlc29sdmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHls ZVJlc29sdmVyLmNwcAppbmRleCAxOTYzNjIyMzI3YzQ3NWQzYzA0Yzg2NjAzYjY3NWE1MGQ1YTli YzY4Li41OTkwMDIwYzBhM2Q5MDU0NjNmYjc1MDRlZGRjMTAyNTE0NDA0MjgzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvY3NzL1N0eWxlUmVzb2x2ZXIuY3BwCkBAIC03NzksOSArNzc5LDExIEBAIHN0YXRpYyBib29s IGhhc0VmZmVjdGl2ZURpc3BsYXlOb25lRm9yRGlzcGxheUNvbnRlbnRzKGNvbnN0IEVsZW1lbnQm IGVsZW1lbnQpCiAgICAgLy8gRklYTUU6IDxnPiwgPHVzZT4gYW5kIDx0c3Bhbj4gaGF2ZSBzcGVj aWFsICg/KSBiZWhhdmlvciBmb3IgZGlzcGxheTpjb250ZW50cyBpbiB0aGUgY3VycmVudCBkcmFm dCBzcGVjLgogICAgIGlmIChpczxTVkdFbGVtZW50PihlbGVtZW50KSkKICAgICAgICAgcmV0dXJu IHRydWU7CisjaWYgRU5BQkxFKE1BVEhNTCkKICAgICAvLyBOb3Qgc3VyZSBNYXRoTUwgY29kZSBj YW4gaGFuZGxlIGl0LgogICAgIGlmIChpczxNYXRoTUxFbGVtZW50PihlbGVtZW50KSkKICAgICAg ICAgcmV0dXJuIHRydWU7CisjZW5kaWYgLy8gRU5BQkxFKE1BVEhNTCkKICAgICBpZiAoIWlzPEhU TUxFbGVtZW50PihlbGVtZW50KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIHJldHVybiB0 YWdOYW1lcy5nZXQoKS5jb250YWlucyhlbGVtZW50LmxvY2FsTmFtZSgpKTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHAKaW5kZXggZGUxNGVmNmI1MTJiMTVm ZGM2ZmM2OGZlZDg3MTNhN2IyZWJhYjM0Yi4uMmUyNmE4ZjBjNmRhODRiY2M3MTY2N2YwYmQ5YTA3 NzY1M2M2MjBmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJs b2NrRmxvdy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxv dy5jcHAKQEAgLTQzMCw4ICs0MzAsMTIgQEAgYm9vbCBSZW5kZXJCbG9ja0Zsb3c6OndpbGxDcmVh dGVDb2x1bW5zKHN0ZDo6b3B0aW9uYWw8dW5zaWduZWQ+IGRlc2lyZWRDb2x1bW5Db3UKICAgICAv LyBUaGUgZm9sbG93aW5nIHR5cGVzIGFyZSBub3Qgc3VwcG9zZWQgdG8gY3JlYXRlIG11bHRpY29s IGNvbnRleHQuCiAgICAgaWYgKGlzRmlsZVVwbG9hZENvbnRyb2woKSB8fCBpc1RleHRDb250cm9s KCkgfHwgaXNMaXN0Qm94KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBpZiAoaXNSZW5k ZXJTVkdCbG9jaygpIHx8IGlzUmVuZGVyTWF0aE1MQmxvY2soKSB8fCBpc1J1YnlSdW4oKSkKKyAg ICBpZiAoaXNSZW5kZXJTVkdCbG9jaygpIHx8IGlzUnVieVJ1bigpKQogICAgICAgICByZXR1cm4g ZmFsc2U7CisjaWYgRU5BQkxFKE1BVEhNTCkKKyAgICBpZiAoaXNSZW5kZXJNYXRoTUxCbG9jaygp KQorICAgICAgICByZXR1cm4gZmFsc2U7CisjZW5kaWYgLy8gRU5BQkxFKE1BVEhNTCkKIAogICAg IGlmICghZmlyc3RDaGlsZCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7Cg==