177742 2017-10-02 06:44:04 -0700 [GTK] Do not hardcode font family in served remote inspector HTML snippets 2017-10-02 15:01:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez berto buildbot cgarcia commit-queue darin gustavo mcatanzaro webkit-bug-importer oldest_to_newest 1355212 0 aperez 2017-10-02 06:44:04 -0700 There's a string with a HTML+CSS snippet in Source/WebKit/UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp which contains a hardcoded font. It seems like it would be a good idea to not hardcode this. 1355213 1 aperez 2017-10-02 06:45:55 -0700 This could be done in a similar way as this patch in Epiphany: https://bugzilla.gnome.org/show_bug.cgi?id=783489 It uses “font:menu” to obtain the system font, which is supported since CSS 2. I'll be sending a patch. 1355214 2 322373 aperez 2017-10-02 06:49:01 -0700 Created attachment 322373 Patch 1355215 3 buildbot 2017-10-02 06:51:47 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1355507 4 322441 aperez 2017-10-02 14:38:24 -0700 Created attachment 322441 Patch for landing 1355535 5 322441 commit-queue 2017-10-02 15:01:01 -0700 Comment on attachment 322441 Patch for landing Clearing flags on attachment: 322441 Committed r222749: <http://trac.webkit.org/changeset/222749> 1355536 6 commit-queue 2017-10-02 15:01:03 -0700 All reviewed patches have been landed. Closing bug. 1355538 7 webkit-bug-importer 2017-10-02 15:01:50 -0700 <rdar://problem/34777611> 322373 2017-10-02 06:49:01 -0700 2017-10-02 14:37:56 -0700 Patch bug-177742-20171002154900.patch text/plain 2337 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGVkMDgzYzdmOGM1NjgwOTIz ODcxY2RiNTYwNGNkMTljODU2YTlhNzAuLjQyYzE4YTIyOGQwMGQ2NDAwMjIwMWZjYWY4YjE1NDdj NGY2NzBmMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMTAtMDIgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtHVEtd IERvIG5vdCBoYXJkY29kZSBmb250IGZhbWlseSBpbiBzZXJ2ZWQgcmVtb3RlIGluc3BlY3RvciBI VE1MIHNuaXBwZXRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzc3NDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbnN0ZWFkIG9mIGhhcmRjb2RpbmcgQ2FudGFyZWxsIGFzIHRoZSBmb250IHVzZWQgZm9y IHRoZSBIVE1MIHNuaXBwZXRzIHNlcnZlZAorICAgICAgICBieSB0aGUgcmVtb3RlIGluc3BlY3Rv ciBoYW5kbGVyLCB1c2UgImZvbnQ6IG1lbnUiIHRvIG9idGFpbiB0aGUgc3lzdGVtIFVJCisgICAg ICAgIGZvbnQsIHBsdXMgYSAiZm9udC1zaXplIiBydWxlIGZvciBhZGp1c3RpbmcgdGhlIHNpemUu CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRSZW1vdGVJbnNwZWN0b3JQcm90 b2NvbEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpSZW1vdGVJbnNwZWN0b3JQcm90b2Nv bEhhbmRsZXI6OmhhbmRsZVJlcXVlc3QpOiBDaGFuZ2UgdGhlCisgICAgICAgIENTUyBydWxlcyBp biB0aGUgc2VydmVkIHNuaXBwZXQuCisKIDIwMTctMDktMzAgIERhcmluIEFkbGVyICA8ZGFyaW5A YXBwbGUuY29tPgogCiAgICAgICAgIEhhdmUgSVBDOjpDb25uZWN0aW9uOjpDbGllbnQgb2JqZWN0 cyBjb25zaXN0ZW50bHkgaW52YWxpZGF0ZSB0aGUgY29ubmVjdGlvbiB3aGVuIGRlc3Ryb3llZApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRSZW1vdGVJ bnNwZWN0b3JQcm90b2NvbEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRSZW1vdGVJbnNwZWN0b3JQcm90b2NvbEhhbmRsZXIuY3BwCmluZGV4IDAwYjRm NmYxZDZhNWI2NDgyMzNlZjI3MDAyNWRlMjM0NWM3ZDAyYTIuLjBkOWU5ZTFlOGMxNGM2MGY3ZTU4 Y2QwYmY4OTYzZjYzODM0YzhjNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0UmVtb3RlSW5zcGVjdG9yUHJvdG9jb2xIYW5kbGVyLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFJlbW90ZUluc3BlY3RvclByb3Rv Y29sSGFuZGxlci5jcHAKQEAgLTExOSw3ICsxMTksNyBAQCB2b2lkIFJlbW90ZUluc3BlY3RvclBy b3RvY29sSGFuZGxlcjo6aGFuZGxlUmVxdWVzdChXZWJLaXRVUklTY2hlbWVSZXF1ZXN0KiByZXF1 ZQogICAgICAgICAiPG1ldGEgaHR0cC1lcXVpdj1cIkNvbnRlbnQtVHlwZVwiIGNvbnRlbnQ9XCJ0 ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLThcIiAvPiIKICAgICAgICAgIjxzdHlsZT4iCiAgICAgICAg ICIgIGgxIHsgY29sb3I6ICNiYWJkYjY7IHRleHQtc2hhZG93OiAwIDFweCAwIHdoaXRlOyBtYXJn aW4tYm90dG9tOiAwOyB9IgotICAgICAgICAiICBodG1sIHsgZm9udC1mYW1pbHk6IENhbnRhcmVs bCwgc2Fucy1zZXJpZjsgZm9udDogMTFwdCBjYW50YXJlbGw7IGNvbG9yOiAjMmUzNDM2OyBwYWRk aW5nOiAyMHB4IDIwcHggMCAyMHB4OyBiYWNrZ3JvdW5kLWNvbG9yOiAjZjZmNmY0OyAiCisgICAg ICAgICIgIGh0bWwgeyBmb250LWZhbWlseTogbWVudTsgZm9udC1zaXplOiAxMXB0OyBjb2xvcjog IzJlMzQzNjsgcGFkZGluZzogMjBweCAyMHB4IDAgMjBweDsgYmFja2dyb3VuZC1jb2xvcjogI2Y2 ZjZmNDsgIgogICAgICAgICAiICAgICAgICAgYmFja2dyb3VuZC1pbWFnZTogLXdlYmtpdC1ncmFk aWVudChsaW5lYXIsIGxlZnQgdG9wLCBsZWZ0IGJvdHRvbSwgY29sb3Itc3RvcCgwLCAjZWVlZWVj KSwgY29sb3Itc3RvcCgxLCAjZjZmNmY0KSk7IgogICAgICAgICAiICAgICAgICAgYmFja2dyb3Vu ZC1zaXplOiAxMDAlIDVlbTsgYmFja2dyb3VuZC1yZXBlYXQ6IG5vLXJlcGVhdDsgfSIKICAgICAg ICAgIiAgdGFibGUgeyB3aWR0aDogMTAwJTsgYm9yZGVyLWNvbGxhcHNlOiBjb2xsYXBzZTsgfSIK 322441 2017-10-02 14:38:24 -0700 2017-10-02 15:01:01 -0700 Patch for landing bug-177742-20171002233815.patch text/plain 2317 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDczNDc3NmRlMDAwZDIzY2M4 MTAwYzkwMjhlNGVlMDVkOGE5MGU3N2UuLmYyNjYyMTNhZGEwY2EzYWI5YjZiOTZmZDFiOWY0NjM1 NmVmNDkzOWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMTAtMDIgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBEbyBu b3QgaGFyZGNvZGUgZm9udCBmYW1pbHkgaW4gc2VydmVkIHJlbW90ZSBpbnNwZWN0b3IgSFRNTCBz bmlwcGV0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTc3NzQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ2FybG9zIEdhcmNpYSBDYW1wb3MuCisKKyAg ICAgICAgSW5zdGVhZCBvZiBoYXJkY29kaW5nIENhbnRhcmVsbCBhcyB0aGUgZm9udCB1c2VkIGZv ciB0aGUgSFRNTCBzbmlwcGV0cyBzZXJ2ZWQKKyAgICAgICAgYnkgdGhlIHJlbW90ZSBpbnNwZWN0 b3IgaGFuZGxlciwgdXNlICJmb250OiBtZW51IiB0byBvYnRhaW4gdGhlIHN5c3RlbSBVSQorICAg ICAgICBmb250LCBwbHVzIGEgImZvbnQtc2l6ZSIgcnVsZSBmb3IgYWRqdXN0aW5nIHRoZSBzaXpl LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UmVtb3RlSW5zcGVjdG9yUHJv dG9jb2xIYW5kbGVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlSW5zcGVjdG9yUHJvdG9j b2xIYW5kbGVyOjpoYW5kbGVSZXF1ZXN0KTogQ2hhbmdlIHRoZQorICAgICAgICBDU1MgcnVsZXMg aW4gdGhlIHNlcnZlZCBzbmlwcGV0LgorCiAyMDE3LTEwLTAyICBKb3NlcGggUGVjb3Jhcm8gIDxw ZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogSW5jbHVkZSBCZWFj b24gYW5kIFBpbmcgcmVxdWVzdHMgaW4gTmV0d29yayB0YWIKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UmVtb3RlSW5zcGVjdG9yUHJvdG9jb2xIYW5k bGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0UmVtb3RlSW5z cGVjdG9yUHJvdG9jb2xIYW5kbGVyLmNwcAppbmRleCAwMGI0ZjZmMWQ2YTViNjQ4MjMzZWYyNzAw MjVkZTIzNDVjN2QwMmEyLi4wZDllOWUxZThjMTRjNjBmN2U1OGNkMGJmODk2M2Y2MzgzNGM4YzU5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFJlbW90 ZUluc3BlY3RvclByb3RvY29sSGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRSZW1vdGVJbnNwZWN0b3JQcm90b2NvbEhhbmRsZXIuY3BwCkBAIC0x MTksNyArMTE5LDcgQEAgdm9pZCBSZW1vdGVJbnNwZWN0b3JQcm90b2NvbEhhbmRsZXI6OmhhbmRs ZVJlcXVlc3QoV2ViS2l0VVJJU2NoZW1lUmVxdWVzdCogcmVxdWUKICAgICAgICAgIjxtZXRhIGh0 dHAtZXF1aXY9XCJDb250ZW50LVR5cGVcIiBjb250ZW50PVwidGV4dC9odG1sOyBjaGFyc2V0PXV0 Zi04XCIgLz4iCiAgICAgICAgICI8c3R5bGU+IgogICAgICAgICAiICBoMSB7IGNvbG9yOiAjYmFi ZGI2OyB0ZXh0LXNoYWRvdzogMCAxcHggMCB3aGl0ZTsgbWFyZ2luLWJvdHRvbTogMDsgfSIKLSAg ICAgICAgIiAgaHRtbCB7IGZvbnQtZmFtaWx5OiBDYW50YXJlbGwsIHNhbnMtc2VyaWY7IGZvbnQ6 IDExcHQgY2FudGFyZWxsOyBjb2xvcjogIzJlMzQzNjsgcGFkZGluZzogMjBweCAyMHB4IDAgMjBw eDsgYmFja2dyb3VuZC1jb2xvcjogI2Y2ZjZmNDsgIgorICAgICAgICAiICBodG1sIHsgZm9udC1m YW1pbHk6IG1lbnU7IGZvbnQtc2l6ZTogMTFwdDsgY29sb3I6ICMyZTM0MzY7IHBhZGRpbmc6IDIw cHggMjBweCAwIDIwcHg7IGJhY2tncm91bmQtY29sb3I6ICNmNmY2ZjQ7ICIKICAgICAgICAgIiAg ICAgICAgIGJhY2tncm91bmQtaW1hZ2U6IC13ZWJraXQtZ3JhZGllbnQobGluZWFyLCBsZWZ0IHRv cCwgbGVmdCBib3R0b20sIGNvbG9yLXN0b3AoMCwgI2VlZWVlYyksIGNvbG9yLXN0b3AoMSwgI2Y2 ZjZmNCkpOyIKICAgICAgICAgIiAgICAgICAgIGJhY2tncm91bmQtc2l6ZTogMTAwJSA1ZW07IGJh Y2tncm91bmQtcmVwZWF0OiBuby1yZXBlYXQ7IH0iCiAgICAgICAgICIgIHRhYmxlIHsgd2lkdGg6 IDEwMCU7IGJvcmRlci1jb2xsYXBzZTogY29sbGFwc2U7IH0iCg==