<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>177741</bug_id>
          
          <creation_ts>2017-10-02 06:22:59 -0700</creation_ts>
          <short_desc>[GLib] NetworkStateNotifier implementation missing</short_desc>
          <delta_ts>2017-10-02 11:08:11 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Gustavo Noronha (kov)">gustavo</reporter>
          <assigned_to name="Gustavo Noronha (kov)">gustavo</assigned_to>
          <cc>bugs-noreply</cc>
    
    <cc>cgarcia</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1355209</commentid>
    <comment_count>0</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2017-10-02 06:22:59 -0700</bug_when>
    <thetext>[GLib] NetworkStateNotifier implementation missing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1355210</commentid>
    <comment_count>1</comment_count>
      <attachid>322372</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2017-10-02 06:26:56 -0700</bug_when>
    <thetext>Created attachment 322372
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1355211</commentid>
    <comment_count>2</comment_count>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2017-10-02 06:29:55 -0700</bug_when>
    <thetext>I used this to test: http://html5-demos.appspot.com/static/navigator.onLine.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1355218</commentid>
    <comment_count>3</comment_count>
      <attachid>322372</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2017-10-02 06:59:31 -0700</bug_when>
    <thetext>Comment on attachment 322372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322372&amp;action=review

&gt; Source/WebCore/platform/network/NetworkStateNotifier.cpp:78
&gt;  
&gt; -#if !PLATFORM(IOS) &amp;&amp; !PLATFORM(MAC) &amp;&amp; !PLATFORM(WIN)
&gt; +#if !PLATFORM(IOS) &amp;&amp; !PLATFORM(MAC) &amp;&amp; !PLATFORM(WIN) &amp;&amp; !PLATFORM(GTK) &amp;&amp; !PLATFORM(WPE)

So, can we remove the stubs now then?

&gt; Source/WebCore/platform/network/glib/NetworkStateNotifierGLib.cpp:29
&gt; +    GNetworkMonitor* monitor = g_network_monitor_get_default();
&gt; +    m_isOnLine = g_network_monitor_get_network_available(monitor);

This can be one line, we don&apos;t need the local variable.

&gt; Source/WebCore/platform/network/glib/NetworkStateNotifierGLib.cpp:40
&gt; +    GNetworkMonitor* monitor = g_network_monitor_get_default();
&gt; +    g_signal_connect(monitor, &quot;network-changed&quot;, G_CALLBACK(networkChangedCallback), this);

Ditto. Since we don&apos;t really use the monitor in the callback we could use connect swapped and the callbck would only receive the NetworkStateNotifier and we don&apos;t need the forward declaration in the header either.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1355224</commentid>
    <comment_count>4</comment_count>
      <attachid>322372</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2017-10-02 07:09:19 -0700</bug_when>
    <thetext>Comment on attachment 322372
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=322372&amp;action=review

&gt;&gt; Source/WebCore/platform/network/NetworkStateNotifier.cpp:78
&gt;&gt; +#if !PLATFORM(IOS) &amp;&amp; !PLATFORM(MAC) &amp;&amp; !PLATFORM(WIN) &amp;&amp; !PLATFORM(GTK) &amp;&amp; !PLATFORM(WPE)
&gt; 
&gt; So, can we remove the stubs now then?

Yeah, looks like it&apos;s #if !EVERYTHING now!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1355263</commentid>
    <comment_count>5</comment_count>
      <attachid>322383</attachid>
    <who name="Gustavo Noronha (kov)">gustavo</who>
    <bug_when>2017-10-02 10:02:39 -0700</bug_when>
    <thetext>Created attachment 322383
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1355329</commentid>
    <comment_count>6</comment_count>
      <attachid>322383</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-10-02 11:08:10 -0700</bug_when>
    <thetext>Comment on attachment 322383
Patch for landing

Clearing flags on attachment: 322383

Committed r222723: &lt;http://trac.webkit.org/changeset/222723&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1355330</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-10-02 11:08:11 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>322372</attachid>
            <date>2017-10-02 06:26:56 -0700</date>
            <delta_ts>2017-10-02 10:02:35 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-177741-20171002152654.patch</filename>
            <type>text/plain</type>
            <size>6178</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjEyYmMzYTIxNjcyMmY2
ZWU2YzU1MDVkNzRlY2ZmOTcwODdiNWUzMy4uMmQwNGJkZDJlYTUyNTFmYTJiNjNkNWYyZTVlY2Fj
MWE3NjY3YjQ4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTEwLTAyICBHdXN0
YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgorCisg
ICAgICAgIFtHTGliXSBOZXR3b3JrU3RhdGVOb3RpZmllciBpbXBsZW1lbnRhdGlvbiBtaXNzaW5n
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc3NDEK
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcg
dGVzdHMuIFRoZSBET00gc3VwcG9ydCBpcyBhbHJlYWR5IGJlaW5nIHRlc3RlZCwgYnV0IHdlIHdv
dWxkIG5lZWQgYSB3YXkKKyAgICAgICAgb2Ygc2ltdWxhdGluZyBhIG5ldHdvcmsgb3V0YWdlIHRv
IHRlc3QgR05ldHdvcmtNb25pdG9yLgorCisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6IGFk
ZCBuZXcgZmlsZS4KKyAgICAgICAgKiBQbGF0Zm9ybVdQRS5jbWFrZTogYWRkIG5ldyBmaWxlLgor
ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuY3BwOiBubyBs
b25nZXIgdXNlIHRoZSBlbXB0eSBpbXBsZW1lbnRhdGlvbnMgZm9yIEdUSyBhbmQgV1BFLgorICAg
ICAgICAqIHBsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuaDoKKyAgICAgICAg
KiBwbGF0Zm9ybS9uZXR3b3JrL2dsaWIvTmV0d29ya1N0YXRlTm90aWZpZXJHTGliLmNwcDogQWRk
ZWQuCisgICAgICAgIChXZWJDb3JlOjpOZXR3b3JrU3RhdGVOb3RpZmllcjo6dXBkYXRlU3RhdGVX
aXRob3V0Tm90aWZ5aW5nKTogdXBkYXRlIHRoZSBuZXR3b3JrIHN0YXRlIHVzaW5nIEdOZXR3b3Jr
TW9uaXRvcidzIGF2YWlsYWJpbGl0eS4KKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtTdGF0ZU5v
dGlmaWVyOjpuZXR3b3JrQ2hhbmdlZENhbGxiYWNrKTogd2hlbiBuZXR3b3JrLWNoYW5nZWQgaXMg
ZW1pdHRlZCwgdHJpZ2dlciBhIHN0YXRlIHVwZGF0ZS4KKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdv
cmtTdGF0ZU5vdGlmaWVyOjpzdGFydE9ic2VydmluZyk6IHdhdGNoIEdOZXR3b3JrTW9uaXRvcidz
IG5ldHdvcmstY2hhbmdlZCBzaWduYWwuCisKIDIwMTctMTAtMDIgIFJ5b3N1a2UgTml3YSAgPHJu
aXdhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgV2luZG93cyBidWlsZCBmaXggYXR0ZW1wdCBhZnRl
ciByMjIyNjk3LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21ha2Ug
Yi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCAzZGE4N2Q4OGIzNjdkODhm
OTc4NDYwOTExOTRlNGNiNjUyYWQ4OGQ5Li4wZjViNzAwYzU5ZjI0ZDgwNjZkNDYwNGZkNWNlZjVh
MjIzNzU5YzJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQor
KysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtMTA3LDYgKzEwNyw4IEBA
IGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogICAgIHBsYXRmb3JtL2d0ay9TY3JvbGxBbmlt
YXRvckd0ay5jcHAKICAgICBwbGF0Zm9ybS9ndGsvU2VsZWN0aW9uRGF0YS5jcHAKIAorICAgIHBs
YXRmb3JtL25ldHdvcmsvZ2xpYi9OZXR3b3JrU3RhdGVOb3RpZmllckdMaWIuY3BwCisKICAgICBw
bGF0Zm9ybS9uZXR3b3JrL3NvdXAvQXV0aGVudGljYXRpb25DaGFsbGVuZ2VTb3VwLmNwcAogICAg
IHBsYXRmb3JtL25ldHdvcmsvc291cC9DZXJ0aWZpY2F0ZUluZm8uY3BwCiAgICAgcGxhdGZvcm0v
bmV0d29yay9zb3VwL0Nvb2tpZUphclNvdXAuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y
ZS9QbGF0Zm9ybVdQRS5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtV1BFLmNtYWtlCmlu
ZGV4IDk2NjI0NDllNWM2YjU4ZjQ2ZGNlOTBlYzIzYzRmN2ZhOWViZTA5NjAuLmU1NThkNjlkMzc5
MmRjMDE1ZjZmNzY5ZDBlMDhjMjkzYTIzODZlNjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl
L1BsYXRmb3JtV1BFLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtV1BFLmNtYWtl
CkBAIC05Nyw2ICs5Nyw4IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogCiAgICAgcGxh
dGZvcm0vZ3JhcGhpY3Mvd3BlL1BsYXRmb3JtRGlzcGxheVdQRS5jcHAKIAorICAgIHBsYXRmb3Jt
L25ldHdvcmsvZ2xpYi9OZXR3b3JrU3RhdGVOb3RpZmllckdMaWIuY3BwCisKICAgICBwbGF0Zm9y
bS9uZXR3b3JrL3NvdXAvQXV0aGVudGljYXRpb25DaGFsbGVuZ2VTb3VwLmNwcAogICAgIHBsYXRm
b3JtL25ldHdvcmsvc291cC9DZXJ0aWZpY2F0ZUluZm8uY3BwCiAgICAgcGxhdGZvcm0vbmV0d29y
ay9zb3VwL0Nvb2tpZUphclNvdXAuY3BwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0ZU5vdGlmaWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs
YXRmb3JtL25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuY3BwCmluZGV4IGFhMjViYjBjYmZk
ZjI5MzRkM2NhMzVlNzFkNDI4Y2MxMzcwYzQyNTMuLjRiM2EwOTkwMDA4NTA2NDc1NTQ0ZWIyOWYw
MTRkYjFjY2RhNGI1OWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv
cmsvTmV0d29ya1N0YXRlTm90aWZpZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt
L25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuY3BwCkBAIC03NSw3ICs3NSw3IEBAIHZvaWQg
TmV0d29ya1N0YXRlTm90aWZpZXI6OnVwZGF0ZVN0YXRlU29vbigpCiAgICAgbV91cGRhdGVTdGF0
ZVRpbWVyLnN0YXJ0T25lU2hvdCh1cGRhdGVTdGF0ZVNvb25JbnRlcnZhbCk7CiB9CiAKLSNpZiAh
UExBVEZPUk0oSU9TKSAmJiAhUExBVEZPUk0oTUFDKSAmJiAhUExBVEZPUk0oV0lOKQorI2lmICFQ
TEFURk9STShJT1MpICYmICFQTEFURk9STShNQUMpICYmICFQTEFURk9STShXSU4pICYmICFQTEFU
Rk9STShHVEspICYmICFQTEFURk9STShXUEUpCiAKIC8vIEVtcHR5IHN0dWJzIGZvciBwbGF0Zm9y
bXMgd2hlcmUgbW9uaXRvcmluZyBvZiBuZXR3b3JrIHN0YXRlIGlzIG5vdCB5ZXQgaW1wbGVtZW50
ZWQuCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29y
a1N0YXRlTm90aWZpZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29y
a1N0YXRlTm90aWZpZXIuaAppbmRleCBmNWU3OWI0NDUxMmNjNTgyYjA0NTAyY2RhZTQyZTFkYjdm
OTBmYThiLi4zZWM5OGEyODhmMDYxNWY4NWNjYjhiNTkzMjdiNzI1NDgwNGNmZDc3IDEwMDY0NAot
LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0ZU5vdGlmaWVy
LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3Rp
Zmllci5oCkBAIC00MSw2ICs0MSwxMCBAQCB0eXBlZGVmIGNvbnN0IHN0cnVjdCBfX1NDRHluYW1p
Y1N0b3JlICogU0NEeW5hbWljU3RvcmVSZWY7CiAjaW5jbHVkZSA8d2luZG93cy5oPgogI2VuZGlm
CiAKKyNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkKK3R5cGVkZWYgc3RydWN0IF9H
TmV0d29ya01vbml0b3IgR05ldHdvcmtNb25pdG9yOworI2VuZGlmCisKIG5hbWVzcGFjZSBXZWJD
b3JlIHsKIAogY2xhc3MgTmV0d29ya1N0YXRlTm90aWZpZXIgewpAQCAtNjcsNiArNzEsMTAgQEAg
cHJpdmF0ZToKICAgICBzdGF0aWMgdm9pZCBDQUxMQkFDSyBhZGRyZXNzQ2hhbmdlQ2FsbGJhY2so
dm9pZCosIEJPT0xFQU4gdGltZWRPdXQpOwogI2VuZGlmCiAKKyNpZiBQTEFURk9STShHVEspIHx8
IFBMQVRGT1JNKFdQRSkKKyAgICBzdGF0aWMgdm9pZCBuZXR3b3JrQ2hhbmdlZENhbGxiYWNrKEdO
ZXR3b3JrTW9uaXRvciosIGdib29sZWFuIGF2YWlsYWJsZSwgTmV0d29ya1N0YXRlTm90aWZpZXIq
KTsKKyNlbmRpZgorCiAgICAgc3RkOjpvcHRpb25hbDxib29sPiBtX2lzT25MaW5lOwogICAgIFZl
Y3RvcjxXVEY6OkZ1bmN0aW9uPHZvaWQoYm9vbCk+PiBtX2xpc3RlbmVyczsKICAgICBUaW1lciBt
X3VwZGF0ZVN0YXRlVGltZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u
ZXR3b3JrL2dsaWIvTmV0d29ya1N0YXRlTm90aWZpZXJHTGliLmNwcCBiL1NvdXJjZS9XZWJDb3Jl
L3BsYXRmb3JtL25ldHdvcmsvZ2xpYi9OZXR3b3JrU3RhdGVOb3RpZmllckdMaWIuY3BwCm5ldyBm
aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAuLmNlNjU1YWFjNWRlMDE4ZGVmYTExNDBkMjNkMjQzNTQ5MTc5MDg2OTIKLS0tIC9kZXYv
bnVsbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2dsaWIvTmV0d29ya1N0
YXRlTm90aWZpZXJHTGliLmNwcApAQCAtMCwwICsxLDQzIEBACisvKgorICogIENvcHlyaWdodCAo
QykgMjAxNyBDb2xsYWJvcmEgTHRkLgorICoKKyAqICBUaGlzIGxpYnJhcnkgaXMgZnJlZSBzb2Z0
d2FyZTsgeW91IGNhbiByZWRpc3RyaWJ1dGUgaXQgYW5kL29yCisgKiAgbW9kaWZ5IGl0IHVuZGVy
IHRoZSB0ZXJtcyBvZiB0aGUgR05VIExlc3NlciBHZW5lcmFsIFB1YmxpYworICogIExpY2Vuc2Ug
YXMgcHVibGlzaGVkIGJ5IHRoZSBGcmVlIFNvZnR3YXJlIEZvdW5kYXRpb247IGVpdGhlcgorICog
IHZlcnNpb24gMiBvZiB0aGUgTGljZW5zZSwgb3IgKGF0IHlvdXIgb3B0aW9uKSBhbnkgbGF0ZXIg
dmVyc2lvbi4KKyAqCisgKiAgVGhpcyBsaWJyYXJ5IGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3Bl
IHRoYXQgaXQgd2lsbCBiZSB1c2VmdWwsCisgKiAgYnV0IFdJVEhPVVQgQU5ZIFdBUlJBTlRZOyB3
aXRob3V0IGV2ZW4gdGhlIGltcGxpZWQgd2FycmFudHkgb2YKKyAqICBNRVJDSEFOVEFCSUxJVFkg
b3IgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UuICBTZWUgdGhlIEdOVQorICogIExl
c3NlciBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlIGZvciBtb3JlIGRldGFpbHMuCisgKgorICogIFlv
dSBzaG91bGQgaGF2ZSByZWNlaXZlZCBhIGNvcHkgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQ
dWJsaWMKKyAqICBMaWNlbnNlIGFsb25nIHdpdGggdGhpcyBsaWJyYXJ5OyBpZiBub3QsIHdyaXRl
IHRvIHRoZSBGcmVlIFNvZnR3YXJlCisgKiAgRm91bmRhdGlvbiwgSW5jLiwgNTEgRnJhbmtsaW4g
U3RyZWV0LCBGaWZ0aCBGbG9vciwgQm9zdG9uLCBNQSAgMDIxMTAtMTMwMSAgVVNBCisgKi8KKwor
I2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIk5ldHdvcmtTdGF0ZU5vdGlmaWVyLmgiCisK
KyNpbmNsdWRlIDxnaW8vZ2lvLmg+CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKwordm9pZCBOZXR3
b3JrU3RhdGVOb3RpZmllcjo6dXBkYXRlU3RhdGVXaXRob3V0Tm90aWZ5aW5nKCkKK3sKKyAgICBH
TmV0d29ya01vbml0b3IqIG1vbml0b3IgPSBnX25ldHdvcmtfbW9uaXRvcl9nZXRfZGVmYXVsdCgp
OworICAgIG1faXNPbkxpbmUgPSBnX25ldHdvcmtfbW9uaXRvcl9nZXRfbmV0d29ya19hdmFpbGFi
bGUobW9uaXRvcik7Cit9CisKK3ZvaWQgTmV0d29ya1N0YXRlTm90aWZpZXI6Om5ldHdvcmtDaGFu
Z2VkQ2FsbGJhY2soR05ldHdvcmtNb25pdG9yKiwgZ2Jvb2xlYW4sIE5ldHdvcmtTdGF0ZU5vdGlm
aWVyKiBuZXR3b3JrU3RhdGVOb3RpZmllcikKK3sKKyAgICBuZXR3b3JrU3RhdGVOb3RpZmllci0+
c2luZ2xldG9uKCkudXBkYXRlU3RhdGVTb29uKCk7Cit9CisKK3ZvaWQgTmV0d29ya1N0YXRlTm90
aWZpZXI6OnN0YXJ0T2JzZXJ2aW5nKCkKK3sKKyAgICBHTmV0d29ya01vbml0b3IqIG1vbml0b3Ig
PSBnX25ldHdvcmtfbW9uaXRvcl9nZXRfZGVmYXVsdCgpOworICAgIGdfc2lnbmFsX2Nvbm5lY3Qo
bW9uaXRvciwgIm5ldHdvcmstY2hhbmdlZCIsIEdfQ0FMTEJBQ0sobmV0d29ya0NoYW5nZWRDYWxs
YmFjayksIHRoaXMpOworfQorCit9Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>322383</attachid>
            <date>2017-10-02 10:02:39 -0700</date>
            <delta_ts>2017-10-02 11:08:10 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-177741-20171002190238.patch</filename>
            <type>text/plain</type>
            <size>5855</size>
            <attacher name="Gustavo Noronha (kov)">gustavo</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjIyNzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjEyYmMzYTIxNjcyMmY2
ZWU2YzU1MDVkNzRlY2ZmOTcwODdiNWUzMy4uZjdmMDkzOTRmOThmNjIxNDE1ZmQ4YjFmMDY4NmI1
YWZhOTJjYjY2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTEwLTAyICBHdXN0
YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFAY29sbGFib3JhLmNvLnVrPgorCisg
ICAgICAgIFtHTGliXSBOZXR3b3JrU3RhdGVOb3RpZmllciBpbXBsZW1lbnRhdGlvbiBtaXNzaW5n
CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzc3NDEK
KworICAgICAgICBSZXZpZXdlZCBieSBDYXJsb3MgR2FyY2lhIENhbXBvcy4KKworICAgICAgICBO
byBuZXcgdGVzdHMuIFRoZSBET00gc3VwcG9ydCBpcyBhbHJlYWR5IGJlaW5nIHRlc3RlZCwgYnV0
IHdlIHdvdWxkIG5lZWQgYSB3YXkKKyAgICAgICAgb2Ygc2ltdWxhdGluZyBhIG5ldHdvcmsgb3V0
YWdlIHRvIHRlc3QgR05ldHdvcmtNb25pdG9yLgorCisgICAgICAgICogUGxhdGZvcm1HVEsuY21h
a2U6IGFkZCBuZXcgZmlsZS4KKyAgICAgICAgKiBQbGF0Zm9ybVdQRS5jbWFrZTogYWRkIG5ldyBm
aWxlLgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuY3Bw
OiBubyBsb25nZXIgbmVlZCB0aGUgZW1wdHkgaW1wbGVtZW50YXRpb25zLCBhbGwgcGxhdGZvcm1z
IGNvdmVyZWQuCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmll
ci5oOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvZ2xpYi9OZXR3b3JrU3RhdGVOb3RpZmll
ckdMaWIuY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtTdGF0ZU5vdGlmaWVy
Ojp1cGRhdGVTdGF0ZVdpdGhvdXROb3RpZnlpbmcpOiB1cGRhdGUgdGhlIG5ldHdvcmsgc3RhdGUg
dXNpbmcgR05ldHdvcmtNb25pdG9yJ3MgYXZhaWxhYmlsaXR5LgorICAgICAgICAoV2ViQ29yZTo6
TmV0d29ya1N0YXRlTm90aWZpZXI6Om5ldHdvcmtDaGFuZ2VkQ2FsbGJhY2spOiB3aGVuIG5ldHdv
cmstY2hhbmdlZCBpcyBlbWl0dGVkLCB0cmlnZ2VyIGEgc3RhdGUgdXBkYXRlLgorICAgICAgICAo
V2ViQ29yZTo6TmV0d29ya1N0YXRlTm90aWZpZXI6OnN0YXJ0T2JzZXJ2aW5nKTogd2F0Y2ggR05l
dHdvcmtNb25pdG9yJ3MgbmV0d29yay1jaGFuZ2VkIHNpZ25hbC4KKwogMjAxNy0xMC0wMiAgUnlv
c3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBXaW5kb3dzIGJ1aWxkIGZp
eCBhdHRlbXB0IGFmdGVyIHIyMjI2OTcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QbGF0
Zm9ybUdUSy5jbWFrZSBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCmluZGV4IDNk
YTg3ZDg4YjM2N2Q4OGY5Nzg0NjA5MTE5NGU0Y2I2NTJhZDg4ZDkuLjBmNWI3MDBjNTlmMjRkODA2
NmQ0NjA0ZmQ1Y2VmNWEyMjM3NTljMmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL1BsYXRm
b3JtR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtR1RLLmNtYWtlCkBAIC0x
MDcsNiArMTA3LDggQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCiAgICAgcGxhdGZvcm0v
Z3RrL1Njcm9sbEFuaW1hdG9yR3RrLmNwcAogICAgIHBsYXRmb3JtL2d0ay9TZWxlY3Rpb25EYXRh
LmNwcAogCisgICAgcGxhdGZvcm0vbmV0d29yay9nbGliL05ldHdvcmtTdGF0ZU5vdGlmaWVyR0xp
Yi5jcHAKKwogICAgIHBsYXRmb3JtL25ldHdvcmsvc291cC9BdXRoZW50aWNhdGlvbkNoYWxsZW5n
ZVNvdXAuY3BwCiAgICAgcGxhdGZvcm0vbmV0d29yay9zb3VwL0NlcnRpZmljYXRlSW5mby5jcHAK
ICAgICBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5jcHAKZGlmZiAtLWdpdCBh
L1NvdXJjZS9XZWJDb3JlL1BsYXRmb3JtV1BFLmNtYWtlIGIvU291cmNlL1dlYkNvcmUvUGxhdGZv
cm1XUEUuY21ha2UKaW5kZXggOTY2MjQ0OWU1YzZiNThmNDZkY2U5MGVjMjNjNGY3ZmE5ZWJlMDk2
MC4uZTU1OGQ2OWQzNzkyZGMwMTVmNmY3NjlkMGUwOGMyOTNhMjM4NmU2NCAxMDA2NDQKLS0tIGEv
U291cmNlL1dlYkNvcmUvUGxhdGZvcm1XUEUuY21ha2UKKysrIGIvU291cmNlL1dlYkNvcmUvUGxh
dGZvcm1XUEUuY21ha2UKQEAgLTk3LDYgKzk3LDggQEAgbGlzdChBUFBFTkQgV2ViQ29yZV9TT1VS
Q0VTCiAKICAgICBwbGF0Zm9ybS9ncmFwaGljcy93cGUvUGxhdGZvcm1EaXNwbGF5V1BFLmNwcAog
CisgICAgcGxhdGZvcm0vbmV0d29yay9nbGliL05ldHdvcmtTdGF0ZU5vdGlmaWVyR0xpYi5jcHAK
KwogICAgIHBsYXRmb3JtL25ldHdvcmsvc291cC9BdXRoZW50aWNhdGlvbkNoYWxsZW5nZVNvdXAu
Y3BwCiAgICAgcGxhdGZvcm0vbmV0d29yay9zb3VwL0NlcnRpZmljYXRlSW5mby5jcHAKICAgICBw
bGF0Zm9ybS9uZXR3b3JrL3NvdXAvQ29va2llSmFyU291cC5jcHAKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuY3BwIGIvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmllci5jcHAKaW5k
ZXggYWEyNWJiMGNiZmRmMjkzNGQzY2EzNWU3MWQ0MjhjYzEzNzBjNDI1My4uYmFiZDBjYzE5NzU2
ZGJmOWVmYzFhZTlkN2IzNTBlMTMwOGVmN2JmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmllci5jcHAKKysrIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmllci5jcHAKQEAgLTc1LDE4
ICs3NSw0IEBAIHZvaWQgTmV0d29ya1N0YXRlTm90aWZpZXI6OnVwZGF0ZVN0YXRlU29vbigpCiAg
ICAgbV91cGRhdGVTdGF0ZVRpbWVyLnN0YXJ0T25lU2hvdCh1cGRhdGVTdGF0ZVNvb25JbnRlcnZh
bCk7CiB9CiAKLSNpZiAhUExBVEZPUk0oSU9TKSAmJiAhUExBVEZPUk0oTUFDKSAmJiAhUExBVEZP
Uk0oV0lOKQotCi0vLyBFbXB0eSBzdHVicyBmb3IgcGxhdGZvcm1zIHdoZXJlIG1vbml0b3Jpbmcg
b2YgbmV0d29yayBzdGF0ZSBpcyBub3QgeWV0IGltcGxlbWVudGVkLgotCi12b2lkIE5ldHdvcmtT
dGF0ZU5vdGlmaWVyOjp1cGRhdGVTdGF0ZVdpdGhvdXROb3RpZnlpbmcoKQotewotfQotCi12b2lk
IE5ldHdvcmtTdGF0ZU5vdGlmaWVyOjpzdGFydE9ic2VydmluZygpCi17Ci19Ci0KLSNlbmRpZgot
CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0ZU5vdGlmaWVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9uZXR3b3JrL05ldHdvcmtTdGF0ZU5vdGlmaWVyLmgKaW5kZXggZjVlNzliNDQ1MTJjYzU4
MmIwNDUwMmNkYWU0MmUxZGI3ZjkwZmE4Yi4uZjk4OTkxZGZjODRjM2M4NDEzNzgyMGUxMzQxNDIw
ZTU1ZmQ4MGViMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9O
ZXR3b3JrU3RhdGVOb3RpZmllci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv
cmsvTmV0d29ya1N0YXRlTm90aWZpZXIuaApAQCAtNjcsNiArNjcsMTAgQEAgcHJpdmF0ZToKICAg
ICBzdGF0aWMgdm9pZCBDQUxMQkFDSyBhZGRyZXNzQ2hhbmdlQ2FsbGJhY2sodm9pZCosIEJPT0xF
QU4gdGltZWRPdXQpOwogI2VuZGlmCiAKKyNpZiBQTEFURk9STShHVEspIHx8IFBMQVRGT1JNKFdQ
RSkKKyAgICBzdGF0aWMgdm9pZCBuZXR3b3JrQ2hhbmdlZENhbGxiYWNrKE5ldHdvcmtTdGF0ZU5v
dGlmaWVyKik7CisjZW5kaWYKKwogICAgIHN0ZDo6b3B0aW9uYWw8Ym9vbD4gbV9pc09uTGluZTsK
ICAgICBWZWN0b3I8V1RGOjpGdW5jdGlvbjx2b2lkKGJvb2wpPj4gbV9saXN0ZW5lcnM7CiAgICAg
VGltZXIgbV91cGRhdGVTdGF0ZVRpbWVyOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh
dGZvcm0vbmV0d29yay9nbGliL05ldHdvcmtTdGF0ZU5vdGlmaWVyR0xpYi5jcHAgYi9Tb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2dsaWIvTmV0d29ya1N0YXRlTm90aWZpZXJHTGliLmNw
cApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwLi5kNGZlNjcyZWEyNDJhNzE0YTdkYTdjMzVhZDdkYTRkODI2ZTY5MzE5Ci0t
LSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9nbGliL05l
dHdvcmtTdGF0ZU5vdGlmaWVyR0xpYi5jcHAKQEAgLTAsMCArMSw0MSBAQAorLyoKKyAqICBDb3B5
cmlnaHQgKEMpIDIwMTcgQ29sbGFib3JhIEx0ZC4KKyAqCisgKiAgVGhpcyBsaWJyYXJ5IGlzIGZy
ZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgorICogIG1vZGlmeSBp
dCB1bmRlciB0aGUgdGVybXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKKyAqICBM
aWNlbnNlIGFzIHB1Ymxpc2hlZCBieSB0aGUgRnJlZSBTb2Z0d2FyZSBGb3VuZGF0aW9uOyBlaXRo
ZXIKKyAqICB2ZXJzaW9uIDIgb2YgdGhlIExpY2Vuc2UsIG9yIChhdCB5b3VyIG9wdGlvbikgYW55
IGxhdGVyIHZlcnNpb24uCisgKgorICogIFRoaXMgbGlicmFyeSBpcyBkaXN0cmlidXRlZCBpbiB0
aGUgaG9wZSB0aGF0IGl0IHdpbGwgYmUgdXNlZnVsLAorICogIGJ1dCBXSVRIT1VUIEFOWSBXQVJS
QU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVkIHdhcnJhbnR5IG9mCisgKiAgTUVSQ0hBTlRB
QklMSVRZIG9yIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFLiAgU2VlIHRoZSBHTlUK
KyAqICBMZXNzZXIgR2VuZXJhbCBQdWJsaWMgTGljZW5zZSBmb3IgbW9yZSBkZXRhaWxzLgorICoK
KyAqICBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5IG9mIHRoZSBHTlUgTGVzc2VyIEdl
bmVyYWwgUHVibGljCisgKiAgTGljZW5zZSBhbG9uZyB3aXRoIHRoaXMgbGlicmFyeTsgaWYgbm90
LCB3cml0ZSB0byB0aGUgRnJlZSBTb2Z0d2FyZQorICogIEZvdW5kYXRpb24sIEluYy4sIDUxIEZy
YW5rbGluIFN0cmVldCwgRmlmdGggRmxvb3IsIEJvc3RvbiwgTUEgIDAyMTEwLTEzMDEgIFVTQQor
ICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJOZXR3b3JrU3RhdGVOb3RpZmll
ci5oIgorCisjaW5jbHVkZSA8Z2lvL2dpby5oPgorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK3Zv
aWQgTmV0d29ya1N0YXRlTm90aWZpZXI6OnVwZGF0ZVN0YXRlV2l0aG91dE5vdGlmeWluZygpCit7
CisgICAgbV9pc09uTGluZSA9IGdfbmV0d29ya19tb25pdG9yX2dldF9uZXR3b3JrX2F2YWlsYWJs
ZShnX25ldHdvcmtfbW9uaXRvcl9nZXRfZGVmYXVsdCgpKTsKK30KKwordm9pZCBOZXR3b3JrU3Rh
dGVOb3RpZmllcjo6bmV0d29ya0NoYW5nZWRDYWxsYmFjayhOZXR3b3JrU3RhdGVOb3RpZmllciog
bmV0d29ya1N0YXRlTm90aWZpZXIpCit7CisgICAgbmV0d29ya1N0YXRlTm90aWZpZXItPnNpbmds
ZXRvbigpLnVwZGF0ZVN0YXRlU29vbigpOworfQorCit2b2lkIE5ldHdvcmtTdGF0ZU5vdGlmaWVy
OjpzdGFydE9ic2VydmluZygpCit7CisgICAgZ19zaWduYWxfY29ubmVjdF9zd2FwcGVkKGdfbmV0
d29ya19tb25pdG9yX2dldF9kZWZhdWx0KCksICJuZXR3b3JrLWNoYW5nZWQiLCBHX0NBTExCQUNL
KG5ldHdvcmtDaGFuZ2VkQ2FsbGJhY2spLCB0aGlzKTsKK30KKworfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>